polishgeeks-dev-tools 1.3.2 → 1.4.0

data/spec/lib/polish_geeks/dev_tools/commands/examples_comparator_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
-  subject { described_class.new }
+  subject(:examples_comparator) { described_class.new }
 
   let(:example_file) { rand.to_s }
   let(:dedicated_file) { example_file }
@@ -11,7 +11,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     let(:config_path) { rand.to_s }
 
     before do
-      expect(subject)
+      expect(examples_comparator)
         .to receive(:config_path)
         .and_return(config_path)
 
@@ -30,15 +30,15 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
       let(:compare_result) { true }
 
       before do
-        expect(subject)
+        expect(examples_comparator)
           .to receive(:same_key_structure?)
           .and_return(compare_result)
       end
 
       it 'puts a successful message into output' do
-        subject.execute
+        examples_comparator.execute
 
-        expect(subject.output).to include 'success'
+        expect(examples_comparator.output).to include 'success'
       end
     end
 
@@ -46,14 +46,14 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
       let(:compare_result) { false }
 
       before do
-        expect(subject)
+        expect(examples_comparator)
           .to receive(:same_key_structure?)
           .and_return(compare_result)
       end
 
       it 'puts a failed message into output' do
-        subject.execute
-        expect(subject.output).to include 'failed'
+        examples_comparator.execute
+        expect(examples_comparator.output).to include 'failed'
       end
     end
 
@@ -61,8 +61,8 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
       let(:dedicated_file_present) { false }
 
       it 'puts a failed message into output' do
-        subject.execute
-        expect(subject.output).to include 'file is missing'
+        examples_comparator.execute
+        expect(examples_comparator.output).to include 'file is missing'
       end
     end
   end
@@ -73,7 +73,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     end
 
     it 'is equal to expected message' do
-      expect(subject.send(:config_path)).to eq expected
+      expect(examples_comparator.send(:config_path)).to eq expected
     end
   end
 
@@ -82,7 +82,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     let(:expected) { "\e[32m success\e[0m - #{compare_header}\n" }
 
     it 'is equal to expected message' do
-      expect(subject.send(:successful_compare, compare_header)).to eq expected
+      expect(examples_comparator.send(:successful_compare, compare_header)).to eq expected
     end
   end
 
@@ -91,7 +91,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     let(:expected) { "\e[31m failed\e[0m - #{compare_header} - structure not equal\n" }
 
     it 'is equal to expected message' do
-      expect(subject.send(:failed_compare, compare_header)).to eq expected
+      expect(examples_comparator.send(:failed_compare, compare_header)).to eq expected
     end
   end
 
@@ -99,7 +99,9 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
     let(:expected) { "#{File.basename(example_file)} and #{File.basename(dedicated_file)}" }
 
     it 'is equal to expected message' do
-      expect(subject.send(:compare_header, example_file, dedicated_file)).to eq expected
+      expect(
+        examples_comparator.send(:compare_header, example_file, dedicated_file)
+      ).to eq expected
     end
   end
 
@@ -138,7 +140,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
 
       it do
         expect(
-          subject.send(
+          examples_comparator.send(
             :same_key_structure?,
             example_file,
             dedicated_file
@@ -152,7 +154,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
 
       it do
         expect(
-          subject.send(
+          examples_comparator.send(
             :same_key_structure?,
             example_file,
             dedicated_file
@@ -165,22 +167,18 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExamplesComparator do
   describe '#valid?' do
     context 'when example files have the same structure' do
       before do
-        subject.instance_variable_set(:@output, 'OK')
+        examples_comparator.instance_variable_set(:@output, 'OK')
       end
 
-      it 'returns true' do
-        expect(subject.valid?).to eq true
-      end
+      it { expect(examples_comparator.valid?).to eq true }
     end
 
     context 'when example files do not have the same structure' do
       before do
-        subject.instance_variable_set(:@output, 'failed')
+        examples_comparator.instance_variable_set(:@output, 'failed')
       end
 
-      it 'returns false' do
-        expect(subject.valid?).to eq false
-      end
+      it { expect(examples_comparator.valid?).to eq false }
     end
   end
 

data/spec/lib/polish_geeks/dev_tools/commands/expires_in_spec.rb

@@ -1,18 +1,16 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::ExpiresIn do
-  subject { described_class.new }
+  subject(:expires_in) { described_class.new }
 
   let(:config) { double }
 
   describe '#execute' do
-    it 'executes the command' do
-      subject.execute
-    end
+    it { expires_in.execute }
   end
 
   describe '#label' do
-    it { expect(subject.label).to eq 'Expires in' }
+    it { expect(expires_in.label).to eq 'Expires in' }
   end
 
   describe '#error_message' do
@@ -21,18 +19,18 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExpiresIn do
       let(:output) { [file_name] }
       let(:expected) { "Following files use expire_in instead of expires_in:\n\n#{file_name}\n" }
 
-      before { subject.instance_variable_set('@output', output) }
+      before { expires_in.instance_variable_set('@output', output) }
 
-      it { expect(subject.error_message).to eq expected }
+      it { expect(expires_in.error_message).to eq expected }
     end
   end
 
   describe '#valid?' do
     context 'when output is empty' do
       before do
-        subject.instance_variable_set('@output', '')
+        expires_in.instance_variable_set('@output', '')
       end
-      it { expect(subject.valid?).to eq true }
+      it { expect(expires_in.valid?).to eq true }
     end
   end
 
@@ -49,7 +47,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExpiresIn do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:excludes)).to eq [] }
+      it { expect(expires_in.send(:excludes)).to eq [] }
     end
 
     context 'when expire_files_ignored is set' do
@@ -65,7 +63,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::ExpiresIn do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:excludes)).to eq expires_in_files_ignored }
+      it { expect(expires_in.send(:excludes)).to eq expires_in_files_ignored }
     end
   end
 end

data/spec/lib/polish_geeks/dev_tools/commands/final_blank_line_spec.rb

@@ -1,68 +1,64 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
-  subject { described_class.new }
+  subject(:final_blank_line) { described_class.new }
 
   describe '#execute' do
     let(:files) { [rand.to_s, rand.to_s] }
 
     before do
-      expect(subject)
+      expect(final_blank_line)
         .to receive(:files_to_analyze)
         .and_return(files)
     end
 
     context 'when all files are valid' do
       before do
-        expect(subject)
+        expect(final_blank_line)
           .to receive(:file_valid?)
           .exactly(files.count).times
           .and_return true
-        subject.execute
+        final_blank_line.execute
       end
 
-      it 'sets appropriate variables' do
-        expect(subject.output).to eq []
-        expect(subject.counter).to eq(files.count)
-      end
+      it { expect(final_blank_line.output).to eq [] }
+      it { expect(final_blank_line.counter).to eq(files.count) }
     end
 
     context 'when exist not valid file' do
       before do
-        expect(subject)
+        expect(final_blank_line)
           .to receive(:file_valid?)
           .exactly(files.count).times
           .and_return false
 
         files.each do |file|
-          expect(subject)
+          expect(final_blank_line)
             .to receive(:sanitize)
             .with(file)
             .and_return(file)
         end
-        subject.execute
+        final_blank_line.execute
       end
 
-      it 'sets appropriate variables' do
-        expect(subject.output).to eq files
-        expect(subject.counter).to eq(files.count)
-      end
+      it { expect(final_blank_line.output).to eq files }
+      it { expect(final_blank_line.counter).to eq(files.count) }
     end
   end
 
   describe '#valid?' do
     before do
-      subject.instance_variable_set('@output', output)
+      final_blank_line.instance_variable_set('@output', output)
     end
 
     context 'when output is empty' do
       let(:output) { [] }
-      it { expect(subject.valid?).to eq true }
+      it { expect(final_blank_line.valid?).to eq true }
     end
 
     context 'when output have some files' do
       let(:output) { ['file_name'] }
-      it { expect(subject.valid?).to eq false }
+      it { expect(final_blank_line.valid?).to eq false }
     end
   end
 
@@ -71,10 +67,10 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
     let(:expected) { "Final blank line: #{counter} files checked" }
 
     before do
-      subject.instance_variable_set('@counter', counter)
+      final_blank_line.instance_variable_set('@counter', counter)
     end
 
-    it { expect(subject.label).to eq expected }
+    it { expect(final_blank_line.label).to eq expected }
   end
 
   describe '#error_message' do
@@ -82,28 +78,28 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
     let(:expected) { "Following files don't have final blank line: \n#{output.join("\n")}\n" }
 
     before do
-      subject.instance_variable_set('@output', output)
+      final_blank_line.instance_variable_set('@output', output)
     end
 
-    it { expect(subject.error_message).to eq expected }
+    it { expect(final_blank_line.error_message).to eq expected }
   end
 
   describe '#files_to_analyze' do
     let(:files) { [rand.to_s, rand.to_s] }
 
     before do
-      expect(subject)
+      expect(final_blank_line)
         .to receive(:files_from_path)
         .with('**/{*,.*}')
         .and_return(files)
 
-      expect(subject)
+      expect(final_blank_line)
         .to receive(:remove_excludes)
         .with(files)
         .and_return(files)
     end
 
-    it { expect(subject.send(:files_to_analyze)).to eq files }
+    it { expect(final_blank_line.send(:files_to_analyze)).to eq files }
   end
 
   describe '#remove_excludes' do
@@ -111,12 +107,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
     let(:excludes) { %w(lib exclude.txt) }
 
     before do
-      expect(subject)
+      expect(final_blank_line)
         .to receive(:excludes)
         .and_return(excludes)
     end
 
-    it { expect(subject.send(:remove_excludes, files)).to eq ['file.rb'] }
+    it { expect(final_blank_line.send(:remove_excludes, files)).to eq ['file.rb'] }
   end
 
   describe '#excludes' do
@@ -124,12 +120,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
     let(:expected) { configs + described_class::DEFAULT_PATHS_TO_EXCLUDE }
 
     before do
-      expect(subject)
+      expect(final_blank_line)
         .to receive(:config_excludes)
         .and_return(configs)
     end
 
-    it { expect(subject.send(:excludes)).to eq expected }
+    it { expect(final_blank_line.send(:excludes)).to eq expected }
   end
 
   describe '#config_excludes' do
@@ -146,7 +142,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:config_excludes)).to eq paths }
+      it { expect(final_blank_line.send(:config_excludes)).to eq paths }
     end
 
     context 'final_blank_line_ignored is not set' do
@@ -161,7 +157,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:config_excludes)).to eq [] }
+      it { expect(final_blank_line.send(:config_excludes)).to eq [] }
     end
   end
 
@@ -170,7 +166,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
     let(:app_root) { PolishGeeks::DevTools.app_root }
     let(:path) { "#{app_root}/#{file}" }
 
-    it { expect(subject.send(:sanitize, "#{app_root}/#{path}")).to eq file }
+    it { expect(final_blank_line.send(:sanitize, "#{app_root}/#{path}")).to eq file }
   end
 
   describe '#file_valid?' do
@@ -192,7 +188,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
             .and_return([rand.to_s + "\n"])
         end
 
-        it { expect(subject.send(:file_valid?, file)).to eq true }
+        it { expect(final_blank_line.send(:file_valid?, file)).to eq true }
       end
 
       context 'file does not have final blank line' do
@@ -203,7 +199,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
             .and_return([rand.to_s + 'end'])
         end
 
-        it { expect(subject.send(:file_valid?, file)).to eq false }
+        it { expect(final_blank_line.send(:file_valid?, file)).to eq false }
       end
     end
 
@@ -214,7 +210,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::FinalBlankLine do
           .with(file)
           .and_return(0)
 
-        it { expect(subject.send(:file_valid?, file)).to eq true }
+        it { expect(final_blank_line.send(:file_valid?, file)).to eq true }
       end
     end
   end

data/spec/lib/polish_geeks/dev_tools/commands/gemfile_spec.rb

@@ -1,30 +1,30 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::Gemfile do
-  subject { described_class.new }
+  subject(:gemfile) { described_class.new }
 
   describe '#execute' do
     let(:wrong_gem) { rand.to_s }
-    let(:gemfile) { double }
+    let(:gemfile_file) { double }
     let(:output) { [rand.to_s] }
 
     before do
       expect(File)
         .to receive(:join)
         .with(::PolishGeeks::DevTools.app_root, 'Gemfile')
-        .and_return(gemfile)
+        .and_return(gemfile_file)
     end
 
     context 'gemfile file exists' do
       before do
         expect(File)
           .to receive(:exist?)
-          .with(gemfile)
+          .with(gemfile_file)
           .and_return(true)
 
         expect(IO)
           .to receive(:readlines)
-          .with(gemfile)
+          .with(gemfile_file)
           .and_return([wrong_gem])
 
         expect(wrong_gem)
@@ -34,8 +34,8 @@ RSpec.describe PolishGeeks::DevTools::Commands::Gemfile do
       end
 
       it 'set wrong gems to output' do
-        subject.execute
-        expect(subject.output).to eq [wrong_gem]
+        gemfile.execute
+        expect(gemfile.output).to eq [wrong_gem]
       end
     end
 
@@ -43,30 +43,30 @@ RSpec.describe PolishGeeks::DevTools::Commands::Gemfile do
       before do
         expect(File)
           .to receive(:exist?)
-          .with(gemfile)
+          .with(gemfile_file)
           .and_return(false)
       end
 
       it 'set empty array to output' do
-        subject.execute
-        expect(subject.output).to eq []
+        gemfile.execute
+        expect(gemfile.output).to eq []
       end
     end
   end
 
   describe '#label' do
-    it { expect(subject.label).to eq 'Gemfile checking' }
+    it { expect(gemfile.label).to eq 'Gemfile checking' }
   end
 
   describe '#error_message' do
     let(:output) { [rand.to_s, rand.to_s] }
 
     before do
-      subject.instance_variable_set('@output', output)
+      gemfile.instance_variable_set('@output', output)
     end
 
     it 'contains output with wrong gems' do
-      expect(subject.error_message)
+      expect(gemfile.error_message)
         .to eq "Gemfile contains gems from local path: \n#{output.join('')}"
     end
   end
@@ -74,18 +74,18 @@ RSpec.describe PolishGeeks::DevTools::Commands::Gemfile do
   describe '#valid?' do
     context 'when output is empty' do
       before do
-        subject.instance_variable_set('@output', [])
+        gemfile.instance_variable_set('@output', [])
       end
 
-      it { expect(subject.valid?).to be true }
+      it { expect(gemfile.valid?).to be true }
     end
 
     context 'when output is not empty' do
       before do
-        subject.instance_variable_set('@output', [rand.to_s])
+        gemfile.instance_variable_set('@output', [rand.to_s])
       end
 
-      it { expect(subject.valid?).to be false }
+      it { expect(gemfile.valid?).to be false }
     end
   end
 end