moose-inventory 1.0.8 → 2.0

data/lib/moose_inventory/cli/host_add.rb

@@ -1,10 +1,14 @@
+# frozen_string_literal: true
+
 require 'thor'
 require 'json'
 require 'indentation'
 
-require_relative './formatter.rb'
-require_relative '../db/exceptions.rb'
- 
+require_relative 'formatter'
+require_relative '../db/exceptions'
+require_relative '../inventory_context'
+require_relative '../operations/add_hosts'
+
 module Moose
   module Inventory
     module Cli
@@ -15,78 +19,59 @@ module Moose
         desc 'add HOSTNAME_1 [HOSTNAME_2 ...]',
              'Add a hosts HOSTNAME_n to the inventory'
         option :groups
-        # rubocop:disable Metrics/LineLength
-        def add(*argv) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-          # rubocop:enable Metrics/LineLength
-          if argv.length < 1
-            abort('ERROR: Wrong number of arguments, '\
-              "#{argv.length} for 1 or more.")
-          end
+        def add(*argv)
+          abort_if_missing_args(argv, 1, '1 or more')
 
-          # Convenience
-          db = Moose::Inventory::DB
-          fmt = Moose::Inventory::Cli::Formatter
-          
           # Arguments
-          names = argv.uniq.map(&:downcase)
+          names = normalize_names(argv)
 
           # split(/\W+/) splits on hyphens too, which is not what we want
-          #groups = options[:groups].downcase.split(/\W+/).uniq
-          options[:groups].nil? && options[:groups] = ''  
-          groups = options[:groups].downcase.split(',').uniq
+          # groups = options[:groups].downcase.split(/\W+/).uniq
+          groups = csv_option_names(options[:groups])
 
           # Sanity
-          if groups.include?('ungrouped')
-            abort("ERROR: Cannot manually manipulate "\
-              "the automatic group 'ungrouped'.")
-          end
+          abort_if_automatic_group(groups)
 
-          # Process
-          db.transaction do # Transaction start
-            fmt.reset_indent
-              
-            names.each do |name|
-              puts "Add host '#{name}':"
-              fmt.puts 2, "- Creating host '#{name}'..."
-              host = db.models[:host].find(name: name)
-              groups_ds = nil
-              if host.nil?
-                host = db.models[:host].create(name: name)
-              else
-                fmt.warn "The host '#{name}' already exists, skipping creation.\n"
-                groups_ds = host.groups_dataset
-              end
-              fmt.puts 4, "- OK"
-              
-              groups.each do |g|
-                next if g.nil? || g.empty?
-                fmt.puts 2, "- Adding association {host:#{name} <-> group:#{g}}..."
-                group = db.models[:group].find(name: g)
-                if group.nil?
-                  fmt.warn "The group '#{g}' doesn't exist, but will be created.\n"
-                  group = db.models[:group].create(name: g)
-                end
-                if !groups_ds.nil? && groups_ds[name: g].nil?
-                  fmt.warn "Association {host:#{name} <-> group:#{ g }} already exists, skipping creation.\n"
-                else
-                  host.add_group(group)
-                end
-                fmt.puts 4, '- OK'
-              end
-              
-              # Handle the automatic 'ungrouped' group
-              groups_ds = host.groups_dataset
-              if !groups_ds.nil?  && groups_ds.count == 0
-                  fmt.puts 2, "- Adding automatic association {host:#{name} <-> group:ungrouped}..."
-                  ungrouped = db.models[:group].find_or_create(name: 'ungrouped')
-                  host.add_group(ungrouped)
-                  fmt.puts 4, "- OK"
-              end
-              fmt.puts 2, "- All OK"
-            end
-          end # Transaction end
+          result = Moose::Inventory::Operations::AddHosts
+                   .new(context: Moose::Inventory::InventoryContext.new(db: db))
+                   .call(names: names, groups: groups)
+          render_add_hosts_events(result.events)
           puts 'Succeeded'
         end
+
+        private
+
+        def render_add_hosts_events(events)
+          fmt.reset_indent
+          events.each { |event| render_add_hosts_event(event) }
+        end
+
+        def render_add_hosts_event(event) # rubocop:disable Metrics/CyclomaticComplexity
+          payload = event.payload
+          case event.type
+          when :host_started
+            puts "Add host '#{payload[:name]}':"
+          when :creating_host
+            fmt.puts 2, "- Creating host '#{payload[:name]}'..."
+          when :host_exists
+            fmt.warn "The host '#{payload[:name]}' already exists, skipping creation.\n"
+          when :ok
+            fmt.puts payload[:indent], '- OK'
+          when :adding_association
+            fmt.puts 2, "- Adding association {host:#{payload[:host]} <-> group:#{payload[:group]}}..."
+          when :group_missing_created
+            fmt.warn "The group '#{payload[:name]}' doesn't exist, but will be created.\n"
+          when :association_exists
+            fmt.warn(
+              "Association {host:#{payload[:host]} <-> group:#{payload[:group]}} " \
+              "already exists, skipping creation.\n"
+            )
+          when :adding_automatic_group
+            fmt.puts 2, "- Adding automatic association {host:#{payload[:host]} <-> group:#{payload[:group]}}..."
+          when :host_complete
+            fmt.puts 2, '- All OK'
+          end
+        end
       end
     end
   end

data/lib/moose_inventory/cli/host_addgroup.rb

@@ -1,8 +1,12 @@
+# frozen_string_literal: true
+
 require 'thor'
 require 'json'
 
-require_relative './formatter.rb'
-require_relative '../db/exceptions.rb'
+require_relative 'formatter'
+require_relative '../db/exceptions'
+require_relative '../inventory_context'
+require_relative '../operations/add_associations'
 
 module Moose
   module Inventory
@@ -12,76 +16,81 @@ module Moose
       class Host
         desc 'addgroup HOSTNAME GROUPNAME [GROUPNAME ...]',
              'Associate the host with a group'
-        # rubocop:disable Metrics/LineLength
-        def addgroup(*args) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
-          # rubocop:enable Metrics/LineLength
-          # Sanity
-          if args.length < 2
-            abort('ERROR: Wrong number of arguments, '\
-              "#{args.length} for 2 or more.")
-          end
+        def addgroup(*args)
+          abort_if_missing_args(args, 2, '2 or more')
+
+          name = args[0].downcase
+          groups = normalize_names(args.slice(1, args.length - 1))
+
+          abort_if_automatic_group(groups)
 
-          # Convenience
-          db = Moose::Inventory::DB
-          fmt = Moose::Inventory::Cli::Formatter
-
-          # Arguments
-          name   = args[0].downcase
-          groups = args.slice(1, args.length - 1).uniq.map(&:downcase)
-
-          # Sanity
-          if groups.include?('ungrouped')
-            abort 'ERROR: Cannot manually manipulate the automatic '\
-              'group \'ungrouped\'.'
-          end 
-          
-          # Transaction
-          db.transaction do # Transaction start
-            puts "Associate host '#{name}' with groups '#{groups.join(',')}':" 
-            # Get the target host
-            fmt.puts 2, "- Retrieve host '#{name}'..."
-            host = db.models[:host].find(name: name)
-            if host.nil?
-              fail db.exceptions[:moose], "The host '#{name}' "\
-                'was not found in the database.'
-            end
-            fmt.puts 4, '- OK'
-
-            # Associate host with the groups
-            groups_ds = host.groups_dataset
-            groups.each do |g|
-              fmt.puts 2,  "- Add association {host:#{name} <-> group:#{ g }}..."
-
-              # Check against existing associations
-              if !groups_ds[name: g].nil?
-                fmt.warn "Association {host:#{name} <-> group:#{g}} already exists, skipping."
-                fmt.puts 4,  "- Already exists, skipping."
-              else
-                # Add new association
-                group = db.models[:group].find(name: g)
-                if group.nil?
-                  fmt.warn "Group '#{g}' does not exist and will be created."
-                  fmt.puts 4,  "- Group does not exist, creating now..."
-                  group = db.models[:group].create(name: g)
-                  fmt.puts 6,  "- OK"
-                end
-                host.add_group(group)
-              end
-              fmt.puts 4, '- OK'
-            end
-
-            # Handle 'ungrouped' group automation
-            unless groups_ds[name: 'ungrouped'].nil?
-              fmt.puts 2,  '- Remove automatic association '\
-                "{host:#{name} <-> group:ungrouped}..."
-              ungrouped  = db.models[:group].find(name: 'ungrouped')
-              host.remove_group(ungrouped) unless ungrouped.nil?
-              fmt.puts 4, '- OK'
-            end
+          context = Moose::Inventory::InventoryContext.new(db: db)
+          operation = Moose::Inventory::Operations::AddAssociations.new(context: context)
+
+          db.transaction do
+            puts "Associate host '#{name}' with groups '#{groups.join(',')}':"
+            host = fetch_existing_host_for_addgroup(context, name)
+            render_host_addgroup_events(
+              operation.host_to_groups(host: host, host_name: name, group_names: groups).events
+            )
             fmt.puts 2, '- All OK'
-          end # Transaction end
+          end
+
           puts 'Succeeded'
         end
+
+        private
+
+        def fetch_existing_host_for_addgroup(context, name)
+          fmt.puts 2, "- Retrieve host '#{name}'..."
+          host = context.find_host(name)
+          raise db.exceptions[:moose], "The host '#{name}' was not found in the database." if host.nil?
+
+          fmt.puts 4, '- OK'
+          host
+        end
+
+        def render_host_addgroup_events(events)
+          events.each { |event| render_host_addgroup_event(event) }
+        end
+
+        def render_host_addgroup_event(event)
+          payload = event.payload
+
+          return render_host_addgroup_warning(event.type, payload) if host_addgroup_warning?(event.type)
+          return render_host_addgroup_status(payload) if event.type == :already_exists_skipping
+
+          render_host_addgroup_output(event.type, payload)
+        end
+
+        def host_addgroup_warning?(type)
+          %i[host_group_association_exists group_missing_created].include?(type)
+        end
+
+        def render_host_addgroup_warning(type, payload)
+          if type == :host_group_association_exists
+            fmt.warn "Association {host:#{payload[:host]} <-> group:#{payload[:group]}} already exists, skipping."
+          else
+            fmt.warn "Group '#{payload[:name]}' does not exist and will be created."
+          end
+        end
+
+        def render_host_addgroup_status(payload)
+          fmt.puts payload[:indent], '- Already exists, skipping.'
+        end
+
+        def render_host_addgroup_output(type, payload)
+          case type
+          when :adding_host_group_association
+            fmt.puts 2, "- Add association {host:#{payload[:host]} <-> group:#{payload[:group]}}..."
+          when :group_creating_now
+            fmt.puts 4, '- Group does not exist, creating now...'
+          when :removing_automatic_group
+            fmt.puts 2, "- Remove automatic association {host:#{payload[:host]} <-> group:ungrouped}..."
+          when :ok
+            fmt.puts payload[:indent], '- OK'
+          end
+        end
       end
     end
   end

data/lib/moose_inventory/cli/host_addvar.rb

@@ -30,9 +30,9 @@ module Moose
 
           # Transaction
           db.transaction do # Transaction start
-            puts "Add variables '#{vars.join(",")}' to host '#{name}':"
-            
-            fmt.puts 2,"- retrieve host '#{name}'..."
+            puts "Add variables '#{vars.join(',')}' to host '#{name}':"
+
+            fmt.puts 2, "- retrieve host '#{name}'..."
             host = db.models[:host].find(name: name)
             if host.nil?
               fail db.exceptions[:moose],
@@ -44,11 +44,11 @@ module Moose
             vars.each do |v|
               fmt.puts 2, "- add variable '#{v}'..."
               vararray = v.split('=')
-              if v.start_with?('=') ||  v.end_with?('=') || vararray.length != 2
+              if v.start_with?('=') || v.end_with?('=') || vararray.length != 2
                 fail db.exceptions[:moose],
                      "Incorrect format in '{#{v}}'. Expected 'key=value'."
               end
-                
+
               # Check against existing associations
               hostvar = hostvars_ds[name: vararray[0]]
               if !hostvar.nil?
@@ -61,7 +61,7 @@ module Moose
               else
                 # hostvar doesn't exist, so create and associate
                 hostvar = db.models[:hostvar].create(name: vararray[0],
-                                                      value: vararray[1])
+                                                     value: vararray[1])
                 host.add_hostvar(hostvar)
               end
               fmt.puts 4, '- OK'

data/lib/moose_inventory/cli/host_get.rb

@@ -16,7 +16,7 @@ module Moose
         desc 'get HOST_1 [HOST_2 ...]',
              'Get hosts HOST_n from the inventory'
         def get(*argv) # rubocop:disable Metrics/AbcSize
-          if argv.length < 1
+          if argv.empty?
             abort('ERROR: Wrong number of arguments, '\
               "#{argv.length} for 1 or more")
           end
@@ -24,30 +24,27 @@ module Moose
           # Convenience
           db = Moose::Inventory::DB
           fmt = Moose::Inventory::Cli::Formatter
-          
+
           # Arguments
           names = argv.uniq.map(&:downcase)
 
           # Process
           results = {}
-          names.each do |name| # rubocop:disable Style/Next
+          names.each do |name|
             host = db.models[:host].find(name: name)
 
-            unless host.nil?
-              groups = host.groups_dataset.map(:name)
-
-              hostvars = {}
-              host.hostvars_dataset.each do |hv|
-                hostvars[hv[:name].to_sym] = hv[:value]
-              end
-
-              results[host[:name].to_sym] = {}
-              unless groups.length == 0
-                results[host[:name].to_sym][:groups] = groups
-              end
-              unless hostvars.length == 0
-                results[host[:name].to_sym][:hostvars] = hostvars
-              end
+            next if host.nil?
+            groups = host.groups_dataset.map(:name)
+
+            hostvars = {}
+            host.hostvars_dataset.each do |hv|
+              hostvars[hv[:name].to_sym] = hv[:value]
+            end
+
+            results[host[:name].to_sym] = {}
+            results[host[:name].to_sym][:groups] = groups unless groups.empty?
+            unless hostvars.empty?
+              results[host[:name].to_sym][:hostvars] = hostvars
             end
           end
 

data/lib/moose_inventory/cli/host_list.rb

@@ -24,11 +24,11 @@ module Moose
             results[host[:name].to_sym][:groups] = groups
 
             hostvars = {}
-            host.hostvars_dataset.each do |hv| 
-              hostvars[hv[:name].to_sym] = hv[:value] 
+            host.hostvars_dataset.each do |hv|
+              hostvars[hv[:name].to_sym] = hv[:value]
             end
 
-            unless hostvars.length == 0
+            unless hostvars.empty?
               results[host[:name].to_sym][:hostvars] = hostvars
             end
           end

data/lib/moose_inventory/cli/host_listvars.rb

@@ -15,32 +15,31 @@ module Moose
         def listvars(*argv)
           # Convenience
           confopts = Moose::Inventory::Config._confopts
-          
+
           # sanity
           if confopts[:ansible] == true
             if argv.length != 1
-            abort('ERROR: Wrong number of arguments for Ansible mode, '\
-                  "#{args.length} for 1.")
+              abort('ERROR: Wrong number of arguments for Ansible mode, '\
+                    "#{args.length} for 1.")
             end
           else
-            if argv.length < 1
+            if argv.empty?
               abort('ERROR: Wrong number of arguments, '\
                     "#{args.length} for 1 or more.")
             end
           end
 
-
           # Convenience
           db = Moose::Inventory::DB
-          fmt = Moose::Inventory::Cli::Formatter 
+          fmt = Moose::Inventory::Cli::Formatter
 
           # Arguments
           names = argv.uniq.map(&:downcase)
 
-          #process
+          # process
           results = {}
-            
-          if confopts[:ansible] == true 
+
+          if confopts[:ansible] == true
             # This is the implementation per Ansible specs
             name = names.first
             host = db.models[:host].find(name: name)
@@ -51,28 +50,27 @@ module Moose
                 results[hv[:name].to_sym] = hv[:value]
               end
             end
-            
-            # Add the Ansible 1.3 '_meta' tag 
+
+            # Add the Ansible 1.3 '_meta' tag
             # see http://docs.ansible.com/ansible/developing_inventory.html#tuning-the-external-inventory-script
-            results['_meta'.to_sym] = {} 
+            results['_meta'.to_sym] = {}
             results['_meta'.to_sym]['hostvars'.to_sym] = {}
-            db.models[:host].each do |host| 
-              results['_meta'.to_sym]['hostvars'.to_sym][host.name().to_sym] = {}
+            db.models[:host].each do |host|
+              results['_meta'.to_sym]['hostvars'.to_sym][host.name.to_sym] = {}
               host.hostvars_dataset.each do |hv|
-                results['_meta'.to_sym]['hostvars'.to_sym][host.name().to_sym][hv[:name].to_sym] = hv[:value]
+                results['_meta'.to_sym]['hostvars'.to_sym][host.name.to_sym][hv[:name].to_sym] = hv[:value]
               end
             end
-            
+
           else
-            # This our more flexible implementation, which is not compatible 
-            # with the Ansible specs 
+            # This our more flexible implementation, which is not compatible
+            # with the Ansible specs
             names.each do |name|
               host = db.models[:host].find(name: name)
-              unless host.nil?
-                results[name.to_sym] = {}
-                host.hostvars_dataset.each do |hv|
-                  results[name.to_sym][hv[:name].to_sym] = hv[:value]
-                end
+              next if host.nil?
+              results[name.to_sym] = {}
+              host.hostvars_dataset.each do |hv|
+                results[name.to_sym][hv[:name].to_sym] = hv[:value]
               end
             end
           end

data/lib/moose_inventory/cli/host_rm.rb

@@ -16,7 +16,7 @@ module Moose
         def rm(*argv) # rubocop:disable Metrics/AbcSize
           #
           # Sanity
-          if argv.length < 1
+          if argv.empty?
             abort('ERROR: Wrong number of arguments, '\
               "#{argv.length} for 1 or more.")
           end
@@ -24,7 +24,7 @@ module Moose
           # Convenience
           db = Moose::Inventory::DB
           fmt = Moose::Inventory::Cli::Formatter
-          
+
           # Arguments
           names = argv.uniq.map(&:downcase)
 
@@ -38,22 +38,22 @@ module Moose
               if host.nil?
                 warn_count += 1
                 fmt.warn "Host '#{name}' does not exist, skipping.\n"
-                fmt.puts 4, "- No such host, skipping."
+                fmt.puts 4, '- No such host, skipping.'
               end
-              fmt.puts 4, "- OK" 
+              fmt.puts 4, '- OK'
               unless host.nil?
                 fmt.puts 2, "- Destroy host '#{name}'..."
                 host.remove_all_groups
                 host.destroy
-                fmt.puts 4, "- OK"
+                fmt.puts 4, '- OK'
               end
-              fmt.puts 2, "- All OK"
+              fmt.puts 2, '- All OK'
             end
           end # Transaction end
-          if warn_count == 0 
-            puts "Succeeded."
+          if warn_count == 0
+            puts 'Succeeded.'
           else
-            puts "Succeeded, with warnings."
+            puts 'Succeeded, with warnings.'
           end
         end
       end