moose-inventory 1.0.8 → 2.0

data/spec/lib/moose_inventory/cli/group_addhost_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -19,7 +19,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
 
     @console = Moose::Inventory::Cli::Formatter
-    
+
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
 
@@ -45,35 +45,34 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
     #------------------------
     it 'addhost <missing args> ... should abort with an error' do
-      actual = runner  do
+      actual = runner do
         @app.start(%w(group addhost)) # <- no group given
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
 
     #------------------------
     it 'GROUP HOST ... should abort if the group does not exist' do
-      
       host_name = 'example'
       group_name = 'not-a-group'
-      
+
       actual = runner do
         @app.start(%W(group addhost #{group_name} #{host_name}))
       end
 
-      #@console.out(actual, 'y')
+      # @console.out(actual, 'y')
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "ERROR: The group '#{group_name}' does not exist.\n"\
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
@@ -83,18 +82,18 @@ RSpec.describe Moose::Inventory::Cli::Group do
     it 'GROUP HOST... should add the host to an existing group' do
       # 1. Should add the host to the group
       # 2. Should remove the host from the 'ungrouped' automatic group
-      
+
       host_name = 'test1'
       group_name = 'testgroup1'
 
       runner { @app.start(%W(host add #{host_name})) }
       @db.models[:group].create(name: group_name)
 
-      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
 
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -109,28 +108,27 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       # We should have the correct group associations
       host = @db.models[:host].find(name: host_name)
-      groups = host.groups_dataset 
+      groups = host.groups_dataset
       expect(groups.count).to eq(1)
       expect(groups[name: group_name]).not_to be_nil
-      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!      
+      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!
     end
 
     #------------------------
     it '\'ungrouped\' HOST... should abort with an error' do
-      
       host_name = 'test1'
       group_name = 'ungrouped'
-    
+
       runner { @app.start(%W(host add #{host_name})) }
-    
-      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
-    
-      desired = { aborted: true}
-      desired[:STDERR] = 
+
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+
+      desired = { aborted: true }
+      desired[:STDERR] =
         "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-    end 
-    
+    end
+
     #------------------------
     it 'GROUP HOST ... should add the host to an group, creating the host if necessary' do
       host_name = 'test1'
@@ -140,11 +138,11 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       # DON'T CREATE THE HOST! That's the point of the test. ;o)
 
-      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
 
       # Check output
       desired = {}
-      desired[:STDOUT] = 
+      desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -155,54 +153,54 @@ RSpec.describe Moose::Inventory::Cli::Group do
         "  - all OK\n"\
         "Succeeded, with warnings.\n"
       desired[:STDERR] =
-        "WARNING: Host '#{host_name}' does not exist and will be created.\n" 
+        "WARNING: Host '#{host_name}' does not exist and will be created.\n"
       expected(actual, desired)
 
-      # Check db          
+      # Check db
       group = @db.models[:group].find(name: group_name)
       hosts = group.hosts_dataset
       expect(hosts.count).to eq(1)
       expect(hosts[name: host_name]).not_to be_nil
     end
-    
+
     #------------------------
     it 'GROUP HOST... should skip associations that already '\
        ' exist, but raise a warning.' do
-       host_name = 'test1'
-       group_name = 'testgroup1'
-    
-       runner { @app.start(%W(group add #{group_name})) }
-       runner { @app.start(%W(host add #{host_name})) }
-    
-       # Run once to make the initial association
-       runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
-         
-       # Run again, to prove expected result
-       actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
-
-       #@console.out(actual,'y')
-           
-       # Check output
-       desired = {}
-       desired[:STDOUT] = 
-         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
-         "  - retrieve group \'#{group_name}\'...\n"\
-         "    - OK\n"\
-         "  - add association {group:#{group_name} <-> host:#{host_name}}...\n"\
-         "    - already exists, skipping.\n"\
-         "    - OK\n"\
-         "  - all OK\n"\
-         "Succeeded, with warnings.\n"
-       desired[:STDERR] = 
-         "WARNING: Association {group:#{group_name} <-> host:#{host_name}} already exists, skipping.\n"
-       expected(actual, desired)
-    
-       # Check db          
-       group = @db.models[:group].find(name: group_name)
-       hosts = group.hosts_dataset
-       expect(hosts.count).to eq(1)
-       expect(hosts[name: host_name]).not_to be_nil
-     end    
+      host_name = 'test1'
+      group_name = 'testgroup1'
+
+      runner { @app.start(%W(group add #{group_name})) }
+      runner { @app.start(%W(host add #{host_name})) }
+
+      # Run once to make the initial association
+      runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+
+      # Run again, to prove expected result
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+
+      # @console.out(actual,'y')
+
+      # Check output
+      desired = {}
+      desired[:STDOUT] =
+        "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
+        "  - retrieve group \'#{group_name}\'...\n"\
+        "    - OK\n"\
+        "  - add association {group:#{group_name} <-> host:#{host_name}}...\n"\
+        "    - already exists, skipping.\n"\
+        "    - OK\n"\
+        "  - all OK\n"\
+        "Succeeded, with warnings.\n"
+      desired[:STDERR] =
+        "WARNING: Association {group:#{group_name} <-> host:#{host_name}} already exists, skipping.\n"
+      expected(actual, desired)
+
+      # Check db
+      group = @db.models[:group].find(name: group_name)
+      hosts = group.hosts_dataset
+      expect(hosts.count).to eq(1)
+      expect(hosts[name: host_name]).not_to be_nil
+    end
 
     #------------------------
     it 'GROUP HOST1 HOST2 ... should associate the group with '\
@@ -214,32 +212,31 @@ RSpec.describe Moose::Inventory::Cli::Group do
       host_names.each do |host|
         runner { @app.start(%W(host add #{host})) }
       end
-      
+
       actual = runner { @app.start(%W(group addhost #{group_name}) + host_names) }
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: false, STDERR: ''}
+      desired = { aborted: false, STDERR: '' }
       desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_names.join(',')}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"
       host_names.each do |host|
-        desired[:STDOUT] = desired[:STDOUT] + 
-          "  - add association {group:#{group_name} <-> host:#{host}}...\n"\
-          "    - OK\n"\
-          "  - remove automatic association {group:ungrouped <-> host:#{host}}...\n"\
-          "    - OK\n"\
-
-        #desired[:STDERR] = desired[:STDERR] +  
-        #  "WARNING: Host '#{host}' does not exist and will be created.\n" 
+        desired[:STDOUT] = desired[:STDOUT] +
+                           "  - add association {group:#{group_name} <-> host:#{host}}...\n"\
+                           "    - OK\n"\
+                           "  - remove automatic association {group:ungrouped <-> host:#{host}}...\n"\
+                           "    - OK\n"\
+
+        # desired[:STDERR] = desired[:STDERR] +
+        #  "WARNING: Host '#{host}' does not exist and will be created.\n"
       end
-      desired[:STDOUT]  = desired[:STDOUT]  + 
-        "  - all OK\n"\
-        "Succeeded.\n"
+      desired[:STDOUT] = desired[:STDOUT] +
+                         "  - all OK\n"\
+                         "Succeeded.\n"
       expected(actual, desired)
-      
 
       # We should have group associations
       group = @db.models[:group].find(name: group_name)

data/spec/lib/moose_inventory/cli/group_addvar_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -40,96 +40,96 @@ RSpec.describe Moose::Inventory::Cli::Group do
       result = @group.instance_methods(false).include?(:addvar)
       expect(result).to eq(true)
     end
-    
+
     #-----------------
     it '<missing args> ... should abort with an error' do
       actual = runner  do
         @app.start(%w(group addvar)) # <- no group given
       end
       # @console.out(actual, 'y')
-      
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
 
     #------------------------
     it 'GROUP key=value ... should abort if the group does not exist' do
-      group_name ='not-a-group'
-      group_var = "foo=bar"
-      
+      group_name = 'not-a-group'
+      group_var = 'foo=bar'
+
       actual = runner do
         @app.start(%W(group addvar #{group_name} #{group_var}))
       end
 
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] =  
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Add variables '#{group_var}' to group '#{group_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "An error occurred during a transaction, any changes have been rolled back.\n"\
         "ERROR: The group '#{group_name}' does not exist.\n"
       expected(actual, desired)
     end
 
     #------------------------
-     it 'GROUP <malformed> ... should abort with an error' do
-       # 1. Should add the var to the db
-       # 2. Should associate the host with the var
-       
-       group_name = 'test_group'
-       @db.models[:group].create(name: group_name)
- 
-       var  = {name: 'var1', value: "testval"}
-       cases = %W(
-         testvar 
-         testvar= 
-         =testval 
-         testvar=testval= 
-         =testvar=testval 
-         testvar=testval=extra
-       )      
-     
-       cases.each do |args| 
-         actual = runner do
-           @app.start(%W(group addvar #{group_name} #{args} ))
-         end
-         #@console.out(actual,'p')
-   
-         desired = { aborted: true}
-         desired[:STDOUT] = 
-         "Add variables '#{args}' to group '#{group_name}':\n"\
-         "  - retrieve group '#{group_name}'...\n"\
-         "    - OK\n"\
-         "  - add variable '#{args}'...\n"
-         
-         desired[:STDERR] = 
-           "An error occurred during a transaction, any changes have been rolled back.\n"\
-           "ERROR: Incorrect format in '{#{args}}'. Expected 'key=value'.\n"
-           
-         expected(actual, desired)
-       end
-     end
-    
+    it 'GROUP <malformed> ... should abort with an error' do
+      # 1. Should add the var to the db
+      # 2. Should associate the host with the var
+
+      group_name = 'test_group'
+      @db.models[:group].create(name: group_name)
+
+      var = { name: 'var1', value: 'testval' }
+      cases = %w(
+        testvar
+        testvar=
+        =testval
+        testvar=testval=
+        =testvar=testval
+        testvar=testval=extra
+      )
+
+      cases.each do |args|
+        actual = runner do
+          @app.start(%W(group addvar #{group_name} #{args}))
+        end
+        # @console.out(actual,'p')
+
+        desired = { aborted: true }
+        desired[:STDOUT] =
+          "Add variables '#{args}' to group '#{group_name}':\n"\
+          "  - retrieve group '#{group_name}'...\n"\
+          "    - OK\n"\
+          "  - add variable '#{args}'...\n"
+
+        desired[:STDERR] =
+          "An error occurred during a transaction, any changes have been rolled back.\n"\
+          "ERROR: Incorrect format in '{#{args}}'. Expected 'key=value'.\n"
+
+        expected(actual, desired)
+      end
+    end
+
     #------------------------
     it 'GROUP key=value ... should associate the group with the key/value pair' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
-      
+
       group_name = 'test1'
-      var  = {name: 'var1', value: "testval"}
+      var = { name: 'var1', value: 'testval' }
 
       @db.models[:group].create(name: group_name)
-      
+
       actual = runner do
-        @app.start(%W(group addvar #{group_name} #{var[:name]}=#{var[:value]} ))
+        @app.start(%W(group addvar #{group_name} #{var[:name]}=#{var[:value]}))
       end
-      #@console.out(actual,'p')
-      
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      # @console.out(actual,'p')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Add variables '#{var[:name]}=#{var[:value]}' to group '#{group_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -146,71 +146,71 @@ RSpec.describe Moose::Inventory::Cli::Group do
       expect(groupvars[name: var[:name]]).not_to be_nil
       expect(groupvars[name: var[:name]][:value]).to eq(var[:value])
     end
-     
+
     #------------------------
     it 'GROUP key1=value1 key2=value2 ... should associate the group with multiple key/value pairs' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
-      
+
       group_name = 'test1'
       varsarray  = [
-        {name: 'var1', value: "val1"},
-        {name: 'var2', value: "val2"}
+        { name: 'var1', value: 'val1' },
+        { name: 'var2', value: 'val2' },
       ]
-    
+
       vars = []
       varsarray.each do |var|
         vars << "#{var[:name]}=#{var[:value]}"
       end
-        
+
       @db.models[:group].create(name: group_name)
-      
+
       actual = runner do
-        @app.start(%W(group addvar #{group_name}) + vars )
+        @app.start(%W(group addvar #{group_name}) + vars)
       end
-      
-      #@console.out(actual,'y')
-      
-      desired = { aborted: false} 
-      desired[:STDOUT] = 
+
+      # @console.out(actual,'y')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Add variables '#{vars.join(',')}' to group '#{group_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"
       vars.each do |var|
-        desired[:STDOUT] =  desired[:STDOUT] + 
-          "  - add variable '#{var}'...\n"\
-          "    - OK\n"
+        desired[:STDOUT] =  desired[:STDOUT] +
+                            "  - add variable '#{var}'...\n"\
+                            "    - OK\n"
       end
-      desired[:STDOUT] =  desired[:STDOUT] + 
-        "  - all OK\n"\
-        "Succeeded.\n"
+      desired[:STDOUT] = desired[:STDOUT] +
+                         "  - all OK\n"\
+                         "Succeeded.\n"
       expected(actual, desired)
-    
+
       # We should have the correct hostvar associations
       group = @db.models[:group].find(name: group_name)
       groupvars = group.groupvars_dataset
       expect(vars.count).to eq(vars.length)
-    end    
+    end
 
     #------------------------
     it 'GROUP key=value ... should update an already existing association' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
-      
+
       group_name = 'test1'
-      var  = {name: 'var1', value: "testval"}
-    
+      var = { name: 'var1', value: 'testval' }
+
       @db.models[:group].create(name: group_name)
-      runner { @app.start(%W(group addvar #{group_name} #{var[:name]}=#{var[:value]} )) }
-    
-      var[:value]  = "newtestval"
+      runner { @app.start(%W(group addvar #{group_name} #{var[:name]}=#{var[:value]})) }
+
+      var[:value] = 'newtestval'
       actual = runner do
-        @app.start(%W(group addvar #{group_name} #{var[:name]}=#{var[:value]} ))
+        @app.start(%W(group addvar #{group_name} #{var[:name]}=#{var[:value]}))
       end
-      #@console.out(actual,'y')
-      
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      # @console.out(actual,'y')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Add variables '#{var[:name]}=#{var[:value]}' to group '#{group_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -220,16 +220,16 @@ RSpec.describe Moose::Inventory::Cli::Group do
         "  - all OK\n"\
         "Succeeded.\n"
       expected(actual, desired)
-    
+
       # We should have the correct hostvar associations
       group = @db.models[:group].find(name: group_name)
       groupvars = group.groupvars_dataset
       expect(groupvars.count).to eq(1)
       expect(groupvars[name: var[:name]]).not_to be_nil
       expect(groupvars[name: var[:name]][:value]).to eq(var[:value])
-        
+
       groupvars = @db.models[:groupvar].all
-      expect(groupvars.count).to eq(1)   
+      expect(groupvars.count).to eq(1)
     end
   end
 end

data/spec/lib/moose_inventory/cli/group_get_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test' 
+      env:     'test',
     }
 
     @mockargs = []
@@ -21,7 +21,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
     @console = Moose::Inventory::Cli::Formatter
-    
+
     @db = Moose::Inventory::DB
     @db.init if @db.db.nil?
 
@@ -43,23 +43,23 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
     #---------------------
     it '<missing args> ... should abort with an error' do
-      actual = runner { @app.start(%W(group get)) }
+      actual = runner { @app.start(%w(group get)) }
+
+      # @console.out(actual,'y')
 
-      #@console.out(actual,'y')
-      
-      desired = {aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 1 or more\n"
 
       expected(actual, desired)
     end
-    
+
     #---------------------
     it "GROUP ... should return an empty set when GROUP doesn't exist" do
       group_name = 'does-not-exist'
-      actual = runner { @app.start(%W(group get #{ group_name })) }
+      actual = runner { @app.start(%W(group get #{group_name})) }
+
+      # @console.out(actual, 'y')
 
-      #@console.out(actual, 'y')
-      
       desired = {}
       desired[:STDOUT] = {}.to_yaml
 
@@ -69,14 +69,14 @@ RSpec.describe Moose::Inventory::Cli::Group do
     #---------------------
     it 'GROUP ... should get a group from the db' do
       name = 'test_group'
-      runner { @app.start(%W(group add #{ name })) }
+      runner { @app.start(%W(group add #{name})) }
 
-      actual = runner { @app.start(%W(group get #{ name })) }
+      actual = runner { @app.start(%W(group get #{name})) }
 
       mock = {}
       mock[name.to_sym] = {}
-      # mock[name.to_sym][:hosts] = [] # TODO: Should this be present or not? 
-        
+      # mock[name.to_sym][:hosts] = [] # TODO: Should this be present or not?
+
       desired = { aborted: false, STDOUT: '', STDERR: '' }
       desired[:STDOUT] = mock.to_yaml
 
@@ -87,21 +87,20 @@ RSpec.describe Moose::Inventory::Cli::Group do
     it 'GROUP ... should display groupvars, if any are set' do
       name = 'test_group'
       var = 'foo=bar'
-      tmp = runner { @app.start(%W(group add #{ name })) }
-      tmp = runner { @app.start(%W(group addvar #{ name } #{ var })) }
+      tmp = runner { @app.start(%W(group add #{name})) }
+      tmp = runner { @app.start(%W(group addvar #{name} #{var})) }
+
+      actual = runner { @app.start(%W(group get #{name})) }
+      # @console.out(actual, 'y')
 
-      actual = runner { @app.start(%W(group get #{ name })) }
-      #@console.out(actual, 'y')
-      
       mock = {}
       mock[name.to_sym] = {}
-      mock[name.to_sym][:groupvars] = {foo: 'bar'}
-        
+      mock[name.to_sym][:groupvars] = { foo: 'bar' }
+
       desired = {}
       desired[:STDOUT] = mock.to_yaml
-       
+
       expected(actual, desired)
     end
-        
   end
 end