moose-inventory 1.0.8 → 2.0

data/spec/lib/moose_inventory/cli/host_get_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -21,7 +21,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
     @console = Moose::Inventory::Cli::Formatter
-    
+
     @db = Moose::Inventory::DB
     @db.init if @db.db.nil?
 
@@ -45,19 +45,19 @@ RSpec.describe Moose::Inventory::Cli::Host do
     it 'host get <missing args> ... should abort with an error' do
       # no items in the db
       name = 'not-in-db'
-      actual = runner { @app.start(%W(host get)) }
+      actual = runner { @app.start(%w(host get)) }
 
-      desired = {aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 1 or more\n"
 
       expected(actual, desired)
     end
-    
+
     #---------------------
     it 'host get HOST ... should return an empty set when HOST doesn\'t exist' do
       # no items in the db
       name = 'not-in-db'
-      actual = runner { @app.start(%W(host get #{ name })) }
+      actual = runner { @app.start(%W(host get #{name})) }
 
       desired = {}
       desired[:STDOUT] = {}.to_yaml
@@ -68,14 +68,14 @@ RSpec.describe Moose::Inventory::Cli::Host do
     #---------------------
     it 'host get HOST ... should get a host from the db' do
       name = 'test-host-add'
-      runner { @app.start(%W(host add #{ name })) }
+      runner { @app.start(%W(host add #{name})) }
 
-      actual = runner { @app.start(%W(host get #{ name })) }
+      actual = runner { @app.start(%W(host get #{name})) }
 
       mock = {}
       mock[name.to_sym] = {}
       mock[name.to_sym][:groups] = ['ungrouped']
-        
+
       desired = { aborted: false, STDOUT: '', STDERR: '' }
       desired[:STDOUT] = mock.to_yaml
 
@@ -86,19 +86,19 @@ RSpec.describe Moose::Inventory::Cli::Host do
     it 'host get HOST ... should display hostvars, if any are set' do
       name = 'test-host-add'
       var = 'foo=bar'
-      runner { @app.start(%W(host add #{ name })) }
-      runner { @app.start(%W(host addvar #{ name } #{ var })) }
+      runner { @app.start(%W(host add #{name})) }
+      runner { @app.start(%W(host addvar #{name} #{var})) }
+
+      actual = runner { @app.start(%W(host get #{name})) }
 
-      actual = runner { @app.start(%W(host get #{ name })) }
-        
       mock = {}
       mock[name.to_sym] = {}
       mock[name.to_sym][:groups] = ['ungrouped']
-      mock[name.to_sym][:hostvars] = {foo: 'bar'}
-        
+      mock[name.to_sym][:hostvars] = { foo: 'bar' }
+
       desired = {}
       desired[:STDOUT] = mock.to_yaml
-       
+
       expected(actual, desired)
     end
   end

data/spec/lib/moose_inventory/cli/host_list_spec.rb

@@ -9,14 +9,14 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
     @mockarg_parts.each do |key, val|
       @mockargs << "--#{key}"
       @mockargs << val
-    end 
+    end
 
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
@@ -45,7 +45,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     it 'should return an empty set when no results' do
       # no items in the db
       name = 'not-in-db'
-      actual = runner { @app.start(%W(host list)) }
+      actual = runner { @app.start(%w(host list)) }
 
       desired = { aborted: false, STDOUT: '', STDERR: '' }
       desired[:STDOUT] = {}.to_yaml
@@ -56,20 +56,20 @@ RSpec.describe Moose::Inventory::Cli::Host do
     #---------------------
     it 'should get a list of hosts from the db' do
       var = 'foo=bar'
-      
+
       mock = {}
       hosts = %w(host1 host2 host3)
       hosts.each do |name|
         runner { @app.start(%W(host add #{name})) }
-        runner { @app.start(%W(host addvar #{ name } foo=bar)) }
+        runner { @app.start(%W(host addvar #{name} foo=bar)) }
         mock[name.to_sym] = {}
         mock[name.to_sym][:groups] = ['ungrouped']
-        mock[name.to_sym][:hostvars] = {foo: 'bar'}
+        mock[name.to_sym][:hostvars] = { foo: 'bar' }
       end
 
       # items should now be in the db
-      actual = runner{ @app.start(%w(host list)) }
-        
+      actual = runner { @app.start(%w(host list)) }
+
       desired = { aborted: false, STDOUT: '', STDERR: '' }
       desired[:STDOUT] = mock.to_yaml
 

data/spec/lib/moose_inventory/cli/host_listvar_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -18,7 +18,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
       @mockargs << val
     end
 
-    @config = Moose::Inventory::Config 
+    @config = Moose::Inventory::Config
     @config.init(@mockargs)
 
     @db = Moose::Inventory::DB
@@ -26,12 +26,12 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
     @console = Moose::Inventory::Cli::Formatter
     @host = Moose::Inventory::Cli::Host
-    @cli = Moose::Inventory::Cli 
+    @cli = Moose::Inventory::Cli
     @app = Moose::Inventory::Cli::Application
   end
 
   before(:each) do
-    # We make some @cli calls, which changes config, 
+    # We make some @cli calls, which changes config,
     # so we must reset config on each pass
     @config.init(@mockargs)
     @db.reset
@@ -44,72 +44,71 @@ RSpec.describe Moose::Inventory::Cli::Host do
       result = @host.instance_methods(false).include?(:listvars)
       expect(result).to eq(true)
     end
-    
+
     #-----------------
     it '<missing args> ... should abort with an error' do
-      actual = runner  {  @app.start(%w(host listvars))  }
+      actual = runner  { @app.start(%w(host listvars)) }
 
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 1 or more.\n"
       expected(actual, desired)
     end
-    
+
     #-----------------
     it '--ansible <missing args> ... should abort with an error' do
-      
       args = @mockargs.clone
-      args.concat( %w(--ansible host listvars) ).flatten
-    
-      actual = runner{ @cli.start(args) }
- 
+      args.concat(%w(--ansible host listvars)).flatten
+
+      actual = runner { @cli.start(args) }
+
       # Check output
-      desired = { aborted: true} 
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments for Ansible mode, 0 for 1.\n"
       expected(actual, desired)
     end
-    
+
     #------------------------
     it 'HOST ... should return a list of host variables grouped by host' do
-      host_name ='test_host'
+      host_name = 'test_host'
       host_vars = %w(foo=bar cow=chicken)
-      
-      tmp = runner {  @app.start(%W(host add #{host_name} )) }
+
+      tmp = runner {  @app.start(%W(host add #{host_name})) }
       tmp = runner {  @app.start(%W(host addvar #{host_name} #{host_vars[0]} #{host_vars[1]})) }
-      
+
       actual = runner do
         @app.start(%W(host listvars #{host_name}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
       mock = {}
-      mock[host_name.to_sym] = {} 
+      mock[host_name.to_sym] = {}
       host_vars.each do |hv|
-        hv_array = hv.split('=')  
-        mock[host_name.to_sym][hv_array[0].to_sym] = hv_array[1] 
+        hv_array = hv.split('=')
+        mock[host_name.to_sym][hv_array[0].to_sym] = hv_array[1]
       end
-      
+
       desired = {}
       desired[:STDOUT] = mock.to_yaml
       expected(actual, desired)
     end
-    
+
     #------------------------
     it '--ansible HOST ... should return a list of host variables per Ansible specs' do
-      host_name ='test_host'
+      host_name = 'test_host'
       host_vars = %w(foo=bar cow=chicken)
-      
-      tmp = runner {  @app.start(%W(host add #{host_name} )) }
+
+      tmp = runner {  @app.start(%W(host add #{host_name})) }
       tmp = runner {  @app.start(%W(host addvar #{host_name} #{host_vars[0]} #{host_vars[1]})) }
-      
+
       actual = runner do
-        @cli.start(%W(--ansible host listvars #{host_name}))
+        @cli.start(%W(--config #{@mockarg_parts[:config]} --ansible host listvars #{host_name}))
       end
-    
-      #@console.out(actual, 'y')
-      
+
+      # @console.out(actual, 'y')
+
       # Check output
       meta = {}
       meta['hostvars'.to_sym] = {}
@@ -117,48 +116,47 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
       mock = {}
       host_vars.each do |hv|
-        hv_array = hv.split('=')  
+        hv_array = hv.split('=')
         mock[hv_array[0].to_sym] = hv_array[1]
-        meta['hostvars'.to_sym][host_name.to_sym][hv_array[0].to_sym] = hv_array[1]  
+        meta['hostvars'.to_sym][host_name.to_sym][hv_array[0].to_sym] = hv_array[1]
       end
       mock['_meta'.to_sym] = meta
-        
+
       desired = {}
       desired[:STDOUT] = mock.to_json + "\n"
       expected(actual, desired)
     end
-    
+
     #------------------------
     it '--ansible HOST ... should be an alias for Ansible\'s --host HOST' do
-      host_name ='test_host'
+      host_name = 'test_host'
       host_vars = %w(foo=bar cow=chicken)
-      
-      tmp = runner {  @app.start(%W(host add #{host_name} )) }
+
+      tmp = runner {  @app.start(%W(host add #{host_name})) }
       tmp = runner {  @app.start(%W(host addvar #{host_name} #{host_vars[0]} #{host_vars[1]})) }
-      
+
       actual = runner do
-        @cli.start(%W(--host #{host_name}))
+        @cli.start(%W(--config #{@mockarg_parts[:config]} --host #{host_name}))
       end
-    
-      #@console.out(actual, 'y')
-      
+
+      # @console.out(actual, 'y')
+
       # Check output
-      meta = {} 
+      meta = {}
       meta['hostvars'.to_sym] = {}
       meta['hostvars'.to_sym][host_name.to_sym] = {}
 
       mock = {}
       host_vars.each do |hv|
-        hv_array = hv.split('=')  
-        mock[hv_array[0].to_sym] = hv_array[1] 
-        meta['hostvars'.to_sym][host_name.to_sym][hv_array[0].to_sym] = hv_array[1]  
+        hv_array = hv.split('=')
+        mock[hv_array[0].to_sym] = hv_array[1]
+        meta['hostvars'.to_sym][host_name.to_sym][hv_array[0].to_sym] = hv_array[1]
       end
       mock['_meta'.to_sym] = meta
-      
+
       desired = {}
       desired[:STDOUT] = mock.to_json + "\n"
       expected(actual, desired)
     end
-    
   end
 end

data/spec/lib/moose_inventory/cli/host_rm_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -58,8 +58,8 @@ RSpec.describe Moose::Inventory::Cli::Host do
       # already exists.
 
       # no items in the db
-      name = "fake"
-      actual = runner {  @app.start(%W(host rm #{name})) }
+      name = 'fake'
+      actual = runner { @app.start(%W(host rm #{name})) }
 
       desired = {}
       desired[:STDOUT] =
@@ -92,7 +92,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
         "    - OK\n"\
         "  - All OK\n"\
         "Succeeded.\n"
-        
+
       expected(actual, desired)
 
       # Check db
@@ -113,15 +113,15 @@ RSpec.describe Moose::Inventory::Cli::Host do
       desired = { aborted: false, STDERR: '', STDOUT: '' }
       names.each do |name|
         desired[:STDOUT] = desired[:STDOUT] +
-          "Remove host '#{name}':\n"\
-          "  - Retrieve host '#{name}'...\n"\
-          "    - OK\n"\
-          "  - Destroy host '#{name}'...\n"\
-          "    - OK\n"\
-          "  - All OK\n"
+                           "Remove host '#{name}':\n"\
+                           "  - Retrieve host '#{name}'...\n"\
+                           "    - OK\n"\
+                           "  - Destroy host '#{name}'...\n"\
+                           "    - OK\n"\
+                           "  - All OK\n"
       end
-      desired[:STDOUT] = desired[:STDOUT] + 
-        "Succeeded.\n"
+      desired[:STDOUT] = desired[:STDOUT] +
+                         "Succeeded.\n"
       expected(actual, desired)
 
       # Check db

data/spec/lib/moose_inventory/cli/host_rmgroup_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -40,17 +40,17 @@ RSpec.describe Moose::Inventory::Cli::Host do
       result = @host.instance_methods(false).include?(:rmgroup)
       expect(result).to eq(true)
     end
-    
+
     #----------------
 
     #------------------------
     it 'host rmgroup <missing args> ... should abort with an error' do
-      actual = runner  do
+      actual = runner do
         @app.start(%w(host rmgroup)) # <- no group given
       end
 
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
@@ -64,41 +64,41 @@ RSpec.describe Moose::Inventory::Cli::Host do
       end
 
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Dissociate host '#{host_name}' from groups '#{group_name}':\n"\
         "  - Retrieve host '#{host_name}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "An error occurred during a transaction, any changes have been rolled back.\n"\
         "ERROR: The host '#{host_name}' was not found in the database.\n"
       expected(actual, desired)
     end
- 
+
     #------------------------
     it 'host rmgroup HOST GROUP ... should dissociate the host from an existing group' do
       # 1. Should rm the host to the group
       # 2. Should add the host from the 'ungrouped' automatic group
-      #    if it has no other groups. 
-       
+      #    if it has no other groups.
+
       host_name = 'test1'
       runner { @app.start(%W(host add #{host_name})) }
 
       group_names = %w(group1 group2)
-      tmp = runner { @app.start(%W(host addgroup #{host_name} #{group_names[0]} #{group_names[1]} )) }
+      tmp = runner { @app.start(%W(host addgroup #{host_name} #{group_names[0]} #{group_names[1]})) }
 
       #
       # Dissociate from the first group
       # 1. expect that the group association is removed
       # 2. expect that no association with ungrouped is made.
-      
+
       actual = runner do
-        @app.start(%W(host rmgroup #{host_name} #{group_names[0]} )) 
+        @app.start(%W(host rmgroup #{host_name} #{group_names[0]}))
       end
-      #@console.dump(actual, 'y')
-      
+      # @console.dump(actual, 'y')
+
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Dissociate host '#{host_name}' from groups '#{group_names[0]}':\n"\
         "  - Retrieve host '#{host_name}'...\n"\
         "    - OK\n"\
@@ -115,19 +115,19 @@ RSpec.describe Moose::Inventory::Cli::Host do
       expect(groups.count).to eq(1)
       expect(groups[name: group_names[0]]).to be_nil
       expect(groups[name: group_names[1]]).not_to be_nil
-      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!      
+      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!
 
       #
       # Remove the second group
       # 1. expect that the group association is removed
       # 2. expect that an association will be made with 'ungrouped'.
       actual = runner do
-        @app.start(args = %W(host rmgroup #{host_name} #{group_names[1]} )) 
+        @app.start(args = %W(host rmgroup #{host_name} #{group_names[1]}))
       end
-      
+
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Dissociate host '#{host_name}' from groups '#{group_names[1]}':\n"\
         "  - Retrieve host '#{host_name}'...\n"\
         "    - OK\n"\
@@ -139,61 +139,60 @@ RSpec.describe Moose::Inventory::Cli::Host do
         "Succeeded\n"
       expected(actual, desired)
       # rubocop:enable Metrics/LineLength
-     
+
       # We should have the correct group associations
       host = @db.models[:host].find(name: host_name)
       groups = host.groups_dataset
       expect(groups.count).to eq(1)
       expect(groups[name: group_names[0]]).to be_nil
       expect(groups[name: group_names[1]]).to be_nil
-      expect(groups[name: 'ungrouped']).not_to be_nil       
+      expect(groups[name: 'ungrouped']).not_to be_nil
     end
-    
+
     #------------------------
     it 'host rmgroup HOST GROUP ... should warn about non-existing associations' do
       # 1. Should warn that the group doesn't exist.
-      # 2. Should complete with success. (desired state == actual state) 
-      
+      # 2. Should complete with success. (desired state == actual state)
+
       host_name = 'test1'
       group_name = 'no-group'
       runner { @app.start(%W(host add #{host_name})) }
-    
+
       actual = runner do
-        @app.start(%W(host rmgroup #{host_name} #{group_name} )) 
+        @app.start(%W(host rmgroup #{host_name} #{group_name}))
       end
-    
+
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Dissociate host '#{host_name}' from groups '#{group_name}':\n"\
         "  - Retrieve host \'#{host_name}\'...\n"\
         "    - OK\n"\
-        "  - Remove association {host:#{host_name} <-> group:#{group_name }}...\n"\
+        "  - Remove association {host:#{host_name} <-> group:#{group_name}}...\n"\
         "    - Doesn't exist, skipping.\n"\
         "    - OK\n"\
         "  - All OK\n"\
         "Succeeded\n"
-      desired[:STDERR] = "WARNING: Association {host:#{host_name} <-> group:#{group_name }} doesn't exist, skipping.\n" 
+      desired[:STDERR] = "WARNING: Association {host:#{host_name} <-> group:#{group_name}} doesn't exist, skipping.\n"
 
       expected(actual, desired)
-    end    
+    end
 
     #------------------------
     it 'host rmgroup HOST \'ungrouped\' ... should abort with an error' do
-
       name = 'test1'
       groupname = 'ungrouped'
 
       runner { @app.start(%W(host add #{name})) }
 
-      actual = runner { @app.start(%W(host rmgroup #{name} #{groupname} )) }
+      actual = runner { @app.start(%W(host rmgroup #{name} #{groupname})) }
 
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] =
-      "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
+        "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
     end
-    
+
     #------------------------
     it 'host rmgroup GROUP1 GROUP1 ... should dissociate the host from'\
       ' multiple groups at once' do
@@ -206,29 +205,27 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
       group_names = %w(group1 group2)
       group_names.each do |group|
-        runner { @app.start(%W(host addgroup #{host_name} #{group} )) }
+        runner { @app.start(%W(host addgroup #{host_name} #{group})) }
       end
 
       actual = runner do
         @app.start(%W(host rmgroup #{host_name}) + group_names)
       end
-
-      # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
+      desired = { aborted: false }
       desired[:STDOUT] =
         "Dissociate host '#{host_name}' from groups '#{group_names.join(',')}':\n"\
         "  - Retrieve host \'#{host_name}\'...\n"\
         "    - OK\n"
       group_names.each do |group|
         desired[:STDOUT] = desired[:STDOUT] +
-        "  - Remove association {host:#{host_name} <-> group:#{group}}...\n"\
-        "    - OK\n"\
+                           "  - Remove association {host:#{host_name} <-> group:#{group}}...\n"\
+                           "    - OK\n"\
       end
       desired[:STDOUT] = desired[:STDOUT] +
-        "  - Add automatic association {host:#{host_name} <-> group:ungrouped}...\n"\
-        "    - OK\n"\
-        "  - All OK\n"\
-        "Succeeded\n"
+                         "  - Add automatic association {host:#{host_name} <-> group:ungrouped}...\n"\
+                         "    - OK\n"\
+                         "  - All OK\n"\
+                         "Succeeded\n"
       expected(actual, desired)
       # rubocop:enable Metrics/LineLength
 
@@ -240,6 +237,6 @@ RSpec.describe Moose::Inventory::Cli::Host do
         expect(groups[name: group]).to be_nil
       end
       expect(groups[name: 'ungrouped']).not_to be_nil # redundant, but for clarity!
-    end         
+    end
   end
 end