moose-inventory 1.0.8 → 2.0

data/spec/lib/moose_inventory/operations/group_child_relations_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'inventory_context'
+require 'operations/group_child_relations'
+
+RSpec.describe Moose::Inventory::Operations::GroupChildRelations do
+  before(:all) do
+    @mockargs = [
+      '--config', File.join(spec_root, 'config/config.yml'),
+      '--format', 'yaml',
+      '--env', 'test'
+    ]
+
+    Moose::Inventory::Config.init(@mockargs)
+    @db = Moose::Inventory::DB
+    @db.init if @db.db.nil?
+  end
+
+  before(:each) do
+    @db.reset
+  end
+
+  def operation
+    described_class.new(
+      context: Moose::Inventory::InventoryContext.new(db: @db)
+    )
+  end
+
+  it 'adds child groups and reports duplicate and auto-create events' do
+    parent = @db.models[:group].create(name: 'parent')
+    existing = @db.models[:group].create(name: 'existing')
+    parent.add_child(existing)
+
+    result = operation.add_children(
+      parent_group: parent,
+      parent_name: 'parent',
+      child_names: %w[existing created]
+    )
+
+    expect(result.warning_count).to eq(2)
+    expect(result.events.map(&:type)).to include(
+      :child_association_exists,
+      :child_group_missing
+    )
+    expect(parent.children_dataset[name: 'created']).not_to be_nil
+  end
+
+  it 'removes child groups and recursively deletes orphan groups when requested' do
+    parent = @db.models[:group].create(name: 'parent')
+    child = @db.models[:group].create(name: 'child')
+    grandchild = @db.models[:group].create(name: 'grandchild')
+    host = @db.models[:host].create(name: 'child-host')
+    child.add_host(host)
+    parent.add_child(child)
+    child.add_child(grandchild)
+
+    result = operation.remove_children(
+      parent_group: parent,
+      parent_name: 'parent',
+      child_names: %w[missing child],
+      delete_orphans: true
+    )
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(
+      :child_association_missing,
+      :recursively_delete_orphaned_group,
+      :destroying_group,
+      :adding_automatic_group_to_host
+    )
+    expect(@db.models[:group].find(name: 'child')).to be_nil
+    expect(@db.models[:group].find(name: 'grandchild')).to be_nil
+    expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+  end
+end

data/spec/lib/moose_inventory/operations/remove_associations_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'inventory_context'
+require 'operations/remove_associations'
+
+RSpec.describe Moose::Inventory::Operations::RemoveAssociations do
+  before(:all) do
+    @mockargs = [
+      '--config', File.join(spec_root, 'config/config.yml'),
+      '--format', 'yaml',
+      '--env', 'test'
+    ]
+
+    Moose::Inventory::Config.init(@mockargs)
+    @db = Moose::Inventory::DB
+    @db.init if @db.db.nil?
+  end
+
+  before(:each) do
+    @db.reset
+  end
+
+  def operation
+    described_class.new(
+      context: Moose::Inventory::InventoryContext.new(db: @db)
+    )
+  end
+
+  it 'removes groups from a host and reports missing associations and ungrouped reattachment' do
+    host = @db.models[:host].create(name: 'host1')
+    group = @db.models[:group].create(name: 'group1')
+    other = @db.models[:group].create(name: 'group2')
+    host.add_group(group)
+    host.add_group(other)
+
+    result = operation.host_from_groups(
+      host: host,
+      host_name: 'host1',
+      group_names: %w[group1 missing group2]
+    )
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(
+      :host_group_association_missing,
+      :adding_automatic_group
+    )
+    expect(host.groups_dataset[name: 'group1']).to be_nil
+    expect(host.groups_dataset[name: 'group2']).to be_nil
+    expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+  end
+
+  it 'removes hosts from a group and reports missing associations and ungrouped reattachment' do
+    group = @db.models[:group].create(name: 'group1')
+    host1 = @db.models[:host].create(name: 'host1')
+    host2 = @db.models[:host].create(name: 'host2')
+    extra = @db.models[:group].create(name: 'extra')
+    host2.add_group(extra)
+    group.add_host(host1)
+    group.add_host(host2)
+
+    result = operation.group_from_hosts(
+      group: group,
+      group_name: 'group1',
+      host_names: %w[host1 missing host2]
+    )
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(
+      :group_host_association_missing,
+      :adding_automatic_group
+    )
+    expect(group.hosts_dataset[name: 'host1']).to be_nil
+    expect(group.hosts_dataset[name: 'host2']).to be_nil
+    expect(host1.groups_dataset[name: 'ungrouped']).not_to be_nil
+    expect(host2.groups_dataset[name: 'ungrouped']).to be_nil
+  end
+end

data/spec/lib/moose_inventory/operations/remove_groups_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'inventory_context'
+require 'operations/remove_groups'
+
+RSpec.describe Moose::Inventory::Operations::RemoveGroups do
+  before(:all) do
+    @mockargs = [
+      '--config', File.join(spec_root, 'config/config.yml'),
+      '--format', 'yaml',
+      '--env', 'test'
+    ]
+
+    Moose::Inventory::Config.init(@mockargs)
+    @db = Moose::Inventory::DB
+    @db.init if @db.db.nil?
+  end
+
+  before(:each) do
+    @db.reset
+  end
+
+  def operation
+    described_class.new(
+      context: Moose::Inventory::InventoryContext.new(db: @db)
+    )
+  end
+
+  it 'reports missing groups as warnings' do
+    result = operation.call(names: ['missing'], recursive: false)
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(:group_missing)
+  end
+
+  it 'removes groups and recursively cleans orphaned children when requested' do
+    parent = @db.models[:group].create(name: 'parent')
+    child = @db.models[:group].create(name: 'child')
+    host = @db.models[:host].create(name: 'child-host')
+    child.add_host(host)
+    parent.add_child(child)
+
+    result = operation.call(names: ['parent'], recursive: true)
+
+    expect(result.warning_count).to eq(0)
+    expect(result.events.map(&:type)).to include(
+      :removing_child_association,
+      :recursively_delete_orphaned_group,
+      :adding_automatic_group_to_host,
+      :destroying_group
+    )
+    expect(@db.models[:group].find(name: 'parent')).to be_nil
+    expect(@db.models[:group].find(name: 'child')).to be_nil
+    expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+  end
+end

data/spec/shared/shared_config_setup.rb

@@ -4,7 +4,7 @@ RSpec.shared_context 'shared config init', a: :b do
     @mockarg_parts = {
       config:  File.join(spec_dir, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -16,6 +16,6 @@ RSpec.shared_context 'shared config init', a: :b do
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
 
-    @db      = Moose::Inventory::DB
+    @db = Moose::Inventory::DB
   end
 end

data/spec/spec_helper.rb

@@ -1,10 +1,7 @@
 if RUBY_VERSION >= '1.9'
   require 'simplecov'
-  require 'coveralls'
-
   SimpleCov.formatters = [
-    SimpleCov::Formatter::HTMLFormatter # ,
-    # Coveralls::SimpleCov::Formatter
+    SimpleCov::Formatter::HTMLFormatter
   ]
 
   SimpleCov.start do
@@ -31,11 +28,12 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__),
 require 'rspec'
 require 'json'
 require 'yaml'
+require 'fileutils'
 require 'find'
 require 'moose_inventory'
 
 RSpec.configure do |config|
-  #config.filter_run focus: true # <- enable to allow test focus
+  # config.filter_run focus: true # <- enable to allow test focus
   config.color = true
   config.tty = true
   config.formatter = :progress #:documentation # :progress, :html, :textmate
@@ -87,7 +85,7 @@ RSpec.configure do |config|
   def expected(actual, desired)
     desired[:aborted].nil? && desired[:aborted] = false
     desired[:STDOUT].nil? && desired[:STDOUT] = ''
-    desired[:STDERR].nil? && desired[:STDERR] = '' 
+    desired[:STDERR].nil? && desired[:STDERR] = ''
 
     expect(actual[:unexpected]).to eq(false)
     expect(actual[:aborted]).to eq(desired[:aborted])
@@ -96,9 +94,10 @@ RSpec.configure do |config|
   end
 
   def clobber_db_files
+    FileUtils.mkdir_p('tmp')
     paths = []
-    Find.find('tmp/') { |path|  paths << path if path =~ /.*\.db$/ }
-    paths.each { |file|  File.delete(file) }
+    Find.find('tmp') { |path| paths << path if path =~ /.*\.db$/ }
+    paths.each { |file| File.delete(file) }
   end
 
   def spec_root