moose-inventory 1.0.8 → 2.0

data/spec/lib/moose_inventory/cli/group_rmchild_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -19,7 +19,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
 
     @console = Moose::Inventory::Cli::Formatter
-    
+
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
 
@@ -49,65 +49,63 @@ RSpec.describe Moose::Inventory::Cli::Group do
         @app.start(%w(group addchild))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
-    
+
     #------------------------
     it 'ungrouped ... should abort with an error' do
-      parent_name = "ungrouped"
-      child_name = "fake"
-      
-      actual = runner  do
+      parent_name = 'ungrouped'
+      child_name = 'fake'
+
+      actual = runner do
         @app.start(%W(group addchild #{parent_name} #{child_name}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-      
+
       ############################
-      # Should work the other way round too, when the child in the ungrouped item      
-      parent_name = "fake"
-      child_name = "ungrouped"
-      
-      actual = runner  do
+      # Should work the other way round too, when the child in the ungrouped item
+      parent_name = 'fake'
+      child_name = 'ungrouped'
+
+      actual = runner do
         @app.start(%W(group rmchild #{parent_name} #{child_name}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-      
-    end    
+    end
 
     #------------------------
     it 'GROUP CHILDGROUP  ... should abort if GROUP does not exist' do
-      
       pname = 'parent_group'
       cname = 'child group'
-      
+
       actual = runner do
         @app.start(%W(group rmchild #{pname} #{cname}))
       end
 
-      #@console.out(actual, 'y')
+      # @console.out(actual, 'y')
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n"\
         "  - retrieve group '#{pname}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "ERROR: The group '#{pname}' does not exist.\n"\
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
@@ -115,21 +113,20 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
     #------------------------
     it 'GROUP CHILDGROUP  ... should succeed with warnings if CHILDGROUP is not associated' do
-      
       pname = 'parent_group'
       cname = 'child group'
 
       runner { @app.start(%W(group add #{pname} #{cname})) }
-            
+
       actual = runner do
         @app.start(%W(group rmchild #{pname} #{cname}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
       desired = {}
-      desired[:STDOUT] = 
+      desired[:STDOUT] =
         "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n"\
         "  - retrieve group '#{pname}'...\n"\
         "    - OK\n"\
@@ -137,9 +134,9 @@ RSpec.describe Moose::Inventory::Cli::Group do
         "    - doesn't exist, skipping.\n"\
         "    - OK\n"\
         "  - all OK\n"\
-        "Succeeded, with warnings.\n"  
-        
-      desired[:STDERR] = 
+        "Succeeded, with warnings.\n"
+
+      desired[:STDERR] =
         "WARNING: Association {group:#{pname} <-> group:#{cname}} does not exist, skipping.\n"
 
       expected(actual, desired)
@@ -147,31 +144,75 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
     #------------------------
     it 'GROUP CHILDGROUP  ... should succeed without warnings if CHILDGROUP is associated' do
-      
       pname = 'parent_group'
       cname = 'child group'
 
       runner { @app.start(%W(group add #{pname} #{cname})) }
       runner { @app.start(%W(group addchild #{pname} #{cname})) }
-            
+
       actual = runner do
         @app.start(%W(group rmchild #{pname} #{cname}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
       desired = {}
-      desired[:STDOUT] = 
+      desired[:STDOUT] =
         "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n"\
         "  - retrieve group '#{pname}'...\n"\
         "    - OK\n"\
         "  - remove association {group:#{pname} <-> group:#{cname}}...\n"\
         "    - OK\n"\
         "  - all OK\n"\
-        "Succeeded.\n"  
-        
+        "Succeeded.\n"
+
       expected(actual, desired)
     end
+
+    #------------------------
+    it 'GROUP CHILDGROUP --delete-orphans ... should delete orphaned child groups recursively' do
+      runner { @app.start(%w(group add parent)) }
+      runner { @app.start(%w(group add child --hosts child-host)) }
+      runner { @app.start(%w(group add grandchild)) }
+      runner { @app.start(%w(group addchild parent child)) }
+      runner { @app.start(%w(group addchild child grandchild)) }
+
+      actual = runner do
+        @app.start(%w(group rmchild --delete-orphans parent child))
+      end
+
+      expect(actual[:unexpected]).to eq(false)
+      expect(actual[:aborted]).to eq(false)
+      expect(actual[:STDOUT]).to include("- Recursively delete orphaned group 'child'...\n")
+      expect(actual[:STDOUT]).to include("- Recursively delete orphaned group 'grandchild'...\n")
+
+      expect(@db.models[:group].find(name: 'parent')).not_to be_nil
+      %w(child grandchild).each do |name|
+        expect(@db.models[:group].find(name: name)).to be_nil
+      end
+
+      host = @db.models[:host].find(name: 'child-host')
+      expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+    end
+
+    #------------------------
+    it 'GROUP CHILDGROUP --delete-orphans ... should preserve child groups with another parent' do
+      runner { @app.start(%w(group add parent other-parent)) }
+      runner { @app.start(%w(group addchild parent child)) }
+      runner { @app.start(%w(group addchild other-parent child)) }
+
+      actual = runner do
+        @app.start(%w(group rmchild --delete-orphans parent child))
+      end
+
+      expect(actual[:unexpected]).to eq(false)
+      expect(actual[:aborted]).to eq(false)
+
+      child = @db.models[:group].find(name: 'child')
+      expect(child).not_to be_nil
+      expect(child.parents_dataset[name: 'parent']).to be_nil
+      expect(child.parents_dataset[name: 'other-parent']).not_to be_nil
+    end
   end
 end

data/spec/lib/moose_inventory/cli/group_rmhost_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -41,7 +41,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
       result = @group.instance_methods(false).include?(:rmhost)
       expect(result).to eq(true)
     end
-    
+
     #----------------
 
     #------------------------
@@ -51,7 +51,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
       end
 
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
@@ -65,16 +65,16 @@ RSpec.describe Moose::Inventory::Cli::Group do
       end
 
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "ERROR: The group '#{group_name}' does not exist.\n"\
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
     end
- 
+
     #------------------------
     it 'GROUP HOST ... should dissociate the group from an existing group' do
       host_name = 'test1'
@@ -82,22 +82,22 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       runner { @app.start(%W(host add #{host_name})) }
       runner { @app.start(%W(group add #{group_name})) }
-      runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
+      runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
 
       #
       # Dissociate the host
       # 1. expect that the group association is removed
       # 2. expect that no association with ungrouped is made.
-      
+
       actual = runner do
-        @app.start(%W(group rmhost #{group_name} #{host_name} )) 
+        @app.start(%W(group rmhost #{group_name} #{host_name}))
       end
-      
-      #@console.dump(actual, 'y')
-      
+
+      # @console.dump(actual, 'y')
+
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -115,56 +115,55 @@ RSpec.describe Moose::Inventory::Cli::Group do
       hosts = group.hosts_dataset
       expect(hosts.count).to eq(0)
     end
-    
+
     #------------------------
     it 'GROUP HOST ... should warn about non-existing associations' do
       # 1. Should warn that the association doesn't exist.
-      # 2. Should complete with success. (desired state == actual state) 
-      
+      # 2. Should complete with success. (desired state == actual state)
+
       host_name = 'test_host'
       group_name = 'test_group'
       runner { @app.start(%W(host add #{host_name})) }
       runner { @app.start(%W(group add #{group_name})) }
       runner { @app.start(%W(group addhost #{host_name})) }
-    
+
       actual = runner do
-        @app.start(%W(group rmhost #{group_name} #{host_name})) 
+        @app.start(%W(group rmhost #{group_name} #{host_name}))
       end
-     
+
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n"\
         "  - retrieve group \'#{group_name}\'...\n"\
         "    - OK\n"\
-        "  - remove association {group:#{group_name } <-> host:#{host_name}}...\n"\
+        "  - remove association {group:#{group_name} <-> host:#{host_name}}...\n"\
         "    - doesn't exist, skipping.\n"\
         "    - OK\n"\
         "  - all OK\n"\
         "Succeeded, with warnings.\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "WARNING: Association {group:#{group_name} <-> host:#{host_name}} "\
-          "doesn't exist, skipping.\n" 
+          "doesn't exist, skipping.\n"
 
       expected(actual, desired)
-    end    
+    end
 
     #------------------------
     it '\'ungrouped\' HOST ... should abort with an error' do
-
       host_name = 'test_host'
       group_name = 'ungrouped'
 
       runner { @app.start(%W(host add #{name})) } # <- auto creates the association with ungrouped
 
-      actual = runner { @app.start(%W(group rmhost #{group_name} #{host_name} )) }
+      actual = runner { @app.start(%W(group rmhost #{group_name} #{host_name})) }
 
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] =
         "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
     end
-    
+
     #------------------------
     it 'GROUP HOST1 HOST2 ... should dissociate the group from'\
       ' multiple hosts at once' do
@@ -173,33 +172,31 @@ RSpec.describe Moose::Inventory::Cli::Group do
       #    if it has no other groups.
 
       group_name = 'test_group'
-      host_names = %W( test_host1 test_host2 test_host3 )
+      host_names = %w(test_host1 test_host2 test_host3)
+
+      runner { @app.start(%W(group add #{group_name})) }
+      runner { @app.start(%W(group addhost #{group_name}) + host_names) }
 
-      runner { @app.start(%W(group add #{group_name} )) }
-      runner {  @app.start(%W(group addhost #{group_name}) + host_names)  }
-      
       actual = runner do
         @app.start(%W(group rmhost #{group_name}) + host_names)
       end
 
-      #@console.out(actual, 'y')
-
-      # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
+      # @console.out(actual, 'y')
+      desired = { aborted: false }
       desired[:STDOUT] =
         "Dissociate group '#{group_name}' from host(s) '#{host_names.join(',')}':\n"\
         "  - retrieve group \'#{group_name}\'...\n"\
         "    - OK\n"
       host_names.each do |host|
         desired[:STDOUT] = desired[:STDOUT] +
-        "  - remove association {group:#{group_name} <-> host:#{host}}...\n"\
-        "    - OK\n"\
-        "  - add automatic association {group:ungrouped <-> host:#{host}}...\n"\
-        "    - OK\n"\
+                           "  - remove association {group:#{group_name} <-> host:#{host}}...\n"\
+                           "    - OK\n"\
+                           "  - add automatic association {group:ungrouped <-> host:#{host}}...\n"\
+                           "    - OK\n"\
       end
       desired[:STDOUT] = desired[:STDOUT] +
-        "  - all OK\n"\
-        "Succeeded.\n"
+                         "  - all OK\n"\
+                         "Succeeded.\n"
       expected(actual, desired)
       # rubocop:enable Metrics/LineLength
 
@@ -210,6 +207,6 @@ RSpec.describe Moose::Inventory::Cli::Group do
       host_names.each do |host|
         expect(hosts[name: host]).to be_nil
       end
-    end         
+    end
   end
 end