mongoid 7.3.2 → 7.4.0

data/spec/mongoid/reloadable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -11,7 +10,7 @@ describe Mongoid::Reloadable do
 
       let(:person) do
         Person.with(collection: 'other') do |person_class|
-          person_class.create
+          person_class.create!
         end
       end
 
@@ -29,13 +28,13 @@ describe Mongoid::Reloadable do
     context "when using bson ids" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:from_db) do
         Person.find(person.id).tap do |peep|
           peep.age = 35
-          peep.save
+          peep.save!
         end
       end
 
@@ -52,13 +51,13 @@ describe Mongoid::Reloadable do
     context "when using string ids" do
 
       let(:account) do
-        Account.create(name: "bank", number: "1000")
+        Account.create!(name: "bank", number: "1000")
       end
 
       let!(:from_db) do
         Account.find(account.id).tap do |acc|
           acc.number = "1001"
-          acc.save
+          acc.save!
         end
       end
 
@@ -75,7 +74,7 @@ describe Mongoid::Reloadable do
     context "when an after initialize callback is defined" do
 
       let!(:book) do
-        Book.create(title: "Snow Crash")
+        Book.create!(title: "Snow Crash")
       end
 
       before do
@@ -91,7 +90,7 @@ describe Mongoid::Reloadable do
     context "when the document was dirty" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       before do
@@ -140,7 +139,7 @@ describe Mongoid::Reloadable do
     context "when the document is embedded" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when embedded a single level" do
@@ -149,13 +148,13 @@ describe Mongoid::Reloadable do
 
           let(:person) do
             Person.with(collection: 'other') do |person_class|
-              person_class.create
+              person_class.create!
             end
           end
 
           let!(:address) do
             person.with(collection: 'other') do |person_object|
-              person_object.addresses.create(street: "Abbey Road", number: 4)
+              person_object.addresses.create!(street: "Abbey Road", number: 4)
             end
           end
 
@@ -180,7 +179,7 @@ describe Mongoid::Reloadable do
         context "when the relation is an embeds many" do
 
           let!(:address) do
-            person.addresses.create(street: "Abbey Road", number: 4)
+            person.addresses.create!(street: "Abbey Road", number: 4)
           end
 
           before do
@@ -238,11 +237,11 @@ describe Mongoid::Reloadable do
       context "when the relation is embedded multiple levels" do
 
         let!(:address) do
-          person.addresses.create(street: "Abbey Road", number: 3)
+          person.addresses.create!(street: "Abbey Road", number: 3)
         end
 
         let!(:location) do
-          address.locations.create(name: "home")
+          address.locations.create!(name: "home")
         end
 
         before do
@@ -271,11 +270,11 @@ describe Mongoid::Reloadable do
     context "when embedded documents change" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(number: 27, street: "Maiden Lane")
+        person.addresses.create!(number: 27, street: "Maiden Lane")
       end
 
       before do
@@ -289,10 +288,137 @@ describe Mongoid::Reloadable do
       end
     end
 
+    context "when embedded documents are unasssigned and reassigned" do
+
+      context "when broken_updates feature flag is not set" do
+        config_override :broken_updates, false
+
+        let(:palette) do
+          Palette.new
+        end
+
+        let(:canvas) do
+          Canvas.create!
+        end
+
+        before do
+          canvas.palette = palette
+          canvas.palette = nil
+          canvas.palette = palette
+          canvas.save!
+          canvas.reload
+        end
+
+        it "reloads the embedded document correctly" do
+          expect(canvas.palette).to eq(palette)
+        end
+      end
+
+      context "when broken_updates feature flag is set" do
+        config_override :broken_updates, true
+
+        let(:palette) do
+          Palette.new
+        end
+
+        let(:canvas) do
+          Canvas.create!
+        end
+
+        before do
+          canvas.palette = palette
+          canvas.palette = nil
+          canvas.palette = palette
+          canvas.save!
+          canvas.reload
+        end
+
+        it "does not reload the embedded document correctly" do
+          expect(canvas.palette).to be_nil
+        end
+      end
+    end
+
+    context "when embeds_many documents are cleared and reassigned" do
+
+      context "when broken_updates feature flag is not set" do
+        config_override :broken_updates, false
+
+        let(:contractor) do
+          Contractor.new(name: 'contractor')
+        end
+
+        let(:building) do
+          Building.create!
+        end
+
+        it "persists an embedded document correctly the second time" do
+          building.contractors << contractor
+          expect(building.contractors).to eq([contractor])
+
+          building.contractors.clear
+          expect(building.contractors).to eq([])
+
+          building.contractors << contractor
+          building.reload
+          expect(building.contractors).to eq([contractor])
+        end
+      end
+
+      context "when broken_updates feature flag is set" do
+        config_override :broken_updates, true
+
+        let(:contractor) do
+          Contractor.new(name: 'contractor')
+        end
+
+        let(:building) do
+          Building.create!
+        end
+
+        it "doesn't persist the embedded document correctly the second time" do
+          building.contractors << contractor
+          expect(building.contractors).to eq([contractor])
+
+          building.contractors.clear
+          expect(building.contractors).to eq([])
+
+          building.contractors << contractor
+          building.reload
+          expect(building.contractors).to eq([])
+        end
+      end
+    end
+
+    context "when embedded document is nil" do
+
+      let(:palette) do
+        Palette.new
+      end
+
+      let(:canvas) do
+        Canvas.create!(palette: palette)
+      end
+
+      before do
+        canvas.palette = nil
+      end
+
+      let(:reload) do
+        palette.reload
+      end
+
+      it "raises a document not found error" do
+        expect do
+          reload
+        end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Palette with id\(s\)/)
+      end
+    end
+
     context "with relational associations" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "for a has_one" do
@@ -336,13 +462,13 @@ describe Mongoid::Reloadable do
     context "when overriding #id alias" do
 
       let!(:object) do
-        IdKey.create(key: 'foo')
+        IdKey.create!(key: 'foo')
       end
 
       let!(:from_db) do
         IdKey.find(object._id).tap do |object|
           object.key = 'bar'
-          object.save
+          object.save!
         end
       end
 
@@ -359,7 +485,7 @@ describe Mongoid::Reloadable do
     context 'when the document is readonly' do
 
       before do
-        Person.create
+        Person.create!
       end
 
       let(:reloaded) do
@@ -401,7 +527,7 @@ describe Mongoid::Reloadable do
       context 'without embedded document' do
         let(:profile) do
           Profile.with(client: :other) do |klass|
-            klass.create
+            klass.create!
           end
         end
 
@@ -423,8 +549,8 @@ describe Mongoid::Reloadable do
       context 'with embedded document' do
         let(:profile_image) do
           Profile.with(client: :other) do |klass|
-            profile = klass.create
-            ProfileImage.create(profile: profile)
+            profile = klass.create!
+            ProfileImage.create!(profile: profile)
           end
         end
 
@@ -442,5 +568,65 @@ describe Mongoid::Reloadable do
         end
       end
     end
+
+    context 'when raise_not_found_error is false' do
+      config_override :raise_not_found_error, false
+
+      let!(:band) { Band.create!(name: 'Sun Project') }
+
+      context 'when document exists in the database' do
+        before do
+          band.name = 'test'
+        end
+
+        it 'reloads the document' do
+          band.name.should == 'test'
+
+          band.reload
+
+          band.name.should == 'Sun Project'
+        end
+      end
+
+      context 'when document does not exist in the database' do
+        before do
+          band.name = 'test'
+
+          band.destroy
+        end
+
+        it 'creates a new document with default values' do
+          original_id = band.id
+          band.name.should == 'test'
+
+          band.reload
+
+          band.name.should be nil
+          band.id.should_not be nil
+          # _id changes
+          band.id.should_not == original_id
+        end
+      end
+    end
+
+    context 'when document has referenced associations' do
+      let!(:church) do
+        Church.create!(name: 'Test', acolytes: [Acolyte.new(name: 'Borg')])
+      end
+
+      before do
+        church.acolytes.first.name = 'test'
+      end
+
+      it 'resets the associations' do
+        church.acolytes.first.name.should == 'test'
+
+        church.reload
+
+        church.acolytes._loaded?.should be false
+
+        church.acolytes.first.name.should == 'Borg'
+      end
+    end
   end
 end

data/spec/mongoid/scopable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -111,6 +110,17 @@ describe Mongoid::Scopable do
         expect(Band).to be_default_scoping
       end
     end
+
+    context "when parent class has default scope" do
+
+      let (:selector) do
+        AudibleSound.all.selector
+      end
+
+      it "the subclass doesn't duplicate the default scope in the selector" do
+        expect(selector).to eq({'active' => true})
+      end
+    end
   end
 
   describe ".default_scopable?" do
@@ -178,7 +188,7 @@ describe Mongoid::Scopable do
         context "when scopes are chained" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           it "constructs a criteria for an embedded relation" do
@@ -235,7 +245,7 @@ describe Mongoid::Scopable do
 
         before do
           Band.scope(:tests, ->{ Band.where(name: 'TESTING').collation(locale: 'en_US', strength: 2) })
-          Band.create(name: 'testing')
+          Band.create!(name: 'testing')
         end
 
         it 'applies the collation' do
@@ -432,13 +442,9 @@ describe Mongoid::Scopable do
       context "when the name conflict with an existing method" do
 
         context "when raising an error" do
-
-          before do
-            Mongoid.scope_overwrite_exception = true
-          end
+          config_override :scope_overwrite_exception, true
 
           after do
-            Mongoid.scope_overwrite_exception = false
             class << Band
               undef_method :active
             end
@@ -454,9 +460,9 @@ describe Mongoid::Scopable do
         end
 
         context "when not raising an error" do
+          config_override :scope_overwrite_exception, false
 
           after do
-            Mongoid.scope_overwrite_exception = false
             class << Band
               undef_method :active
             end
@@ -660,12 +666,12 @@ describe Mongoid::Scopable do
                 where(:author_id.in => author_ids)
               })
 
-              Author.create(author: true, id: 1)
-              Author.create(author: true, id: 2)
-              Author.create(author: true, id: 3)
-              Article.create(author_id: 1, public: true)
-              Article.create(author_id: 2, public: true)
-              Article.create(author_id: 3, public: false)
+              Author.create!(author: true, id: 1)
+              Author.create!(author: true, id: 2)
+              Author.create!(author: true, id: 3)
+              Article.create!(author_id: 1, public: true)
+              Article.create!(author_id: 2, public: true)
+              Article.create!(author_id: 3, public: false)
             end
 
             after do
@@ -707,13 +713,9 @@ describe Mongoid::Scopable do
       context "when the name conflict with an existing method" do
 
         context "when raising an error" do
-
-          before do
-            Mongoid.scope_overwrite_exception = true
-          end
+          config_override :scope_overwrite_exception, true
 
           after do
-            Mongoid.scope_overwrite_exception = false
             class << Band
               undef_method :active
             end
@@ -729,9 +731,9 @@ describe Mongoid::Scopable do
         end
 
         context "when not raising an error" do
+          config_override :scope_overwrite_exception, false
 
           after do
-            Mongoid.scope_overwrite_exception = false
             class << Band
               undef_method :active
             end
@@ -858,7 +860,7 @@ describe Mongoid::Scopable do
         Circle._declared_scopes.clear
       end
 
-      it "uses sublcass context for all the other used scopes" do
+      it "uses subclass context for all the other used scopes" do
         expect(Circle.visible.selector).to eq("radius" => 5)
       end
     end
@@ -1127,6 +1129,47 @@ describe Mongoid::Scopable do
         expect(Mongoid::Threaded.current_scope(Band)).to be_nil
       end
     end
+
+    context 'when nesting with_scope calls' do
+      let(:c1) { Band.where(active: true) }
+      let(:c2) { Band.where(active: false) }
+
+      context "when the broken_scoping is not set" do
+        config_override :broken_scoping, false
+
+        it 'restores previous scope' do
+          Band.with_scope(c1) do |crit|
+            Band.with_scope(c2) do |crit2|
+              Mongoid::Threaded.current_scope(Band).selector.should == {
+                'active' => true,
+                '$and' => ['active' => false],
+              }
+            end
+
+            Mongoid::Threaded.current_scope(Band).selector.should == {
+              'active' => true,
+            }
+          end
+        end
+      end
+
+      context "when the broken_scoping is set" do
+        config_override :broken_scoping, true
+
+        it 'does not restore previous scope' do
+          Band.with_scope(c1) do |crit|
+            Band.with_scope(c2) do |crit2|
+              Mongoid::Threaded.current_scope(Band).selector.should == {
+                'active' => true,
+                '$and' => ['active' => false],
+              }
+            end
+
+            Mongoid::Threaded.current_scope(Band).should be_nil
+          end
+        end
+      end
+    end
   end
 
   describe ".without_default_scope" do

data/spec/mongoid/selectable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -12,7 +11,7 @@ describe Mongoid::Selectable do
       context "when the document has a shard key" do
 
         let(:profile) do
-          Profile.create(name: "google")
+          Profile.create!(name: "google")
         end
 
         let!(:selector) do
@@ -29,7 +28,7 @@ describe Mongoid::Selectable do
         context "when using object ids" do
 
           let(:band) do
-            Band.create
+            Band.create!
           end
 
           let(:selector) do
@@ -44,7 +43,7 @@ describe Mongoid::Selectable do
         context "when using a custom id" do
 
           let(:account) do
-            Account.create(name: "savings")
+            Account.create!(name: "savings")
           end
 
           let(:selector) do
@@ -76,7 +75,7 @@ describe Mongoid::Selectable do
     context "when the document is embedded" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the document is an embeds one" do
@@ -95,7 +94,7 @@ describe Mongoid::Selectable do
       context "when the document is an embeds many" do
 
         let(:address) do
-          person.addresses.create(street: "kreuzbergstr")
+          person.addresses.create!(street: "kreuzbergstr")
         end
 
         it "returns the hash with the selector" do
@@ -118,7 +117,7 @@ describe Mongoid::Selectable do
         context "when the document is embedded multiple levels" do
 
           let(:location) do
-            address.locations.create
+            address.locations.create!
           end
 
           it "returns a hash with the selector" do

data/spec/mongoid/serializable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -341,7 +340,7 @@ describe Mongoid::Serializable do
 
       context "when only two attributes are loaded" do
         before do
-          person.save
+          person.save!
         end
 
         let(:from_db) do
@@ -408,7 +407,7 @@ describe Mongoid::Serializable do
       context "when the model is saved before the relation is added" do
 
         before do
-          person.save
+          person.save!
         end
 
         context "when a model has an embeds many" do
@@ -418,7 +417,7 @@ describe Mongoid::Serializable do
           end
 
           before do
-            person.save
+            person.save!
           end
 
           it "includes the relation" do
@@ -432,7 +431,7 @@ describe Mongoid::Serializable do
           end
 
           before do
-            person.save
+            person.save!
           end
 
           it "includes the relation" do
@@ -450,7 +449,7 @@ describe Mongoid::Serializable do
           end
 
           before do
-            person.save
+            person.save!
           end
 
           it "includes the relation" do
@@ -464,7 +463,7 @@ describe Mongoid::Serializable do
           end
 
           before do
-            person.save
+            person.save!
           end
 
           it "includes the relation" do
@@ -504,7 +503,7 @@ describe Mongoid::Serializable do
           context "when the ids were not loaded" do
 
             before do
-              person.save
+              person.save!
             end
 
             let(:from_db) do
@@ -612,10 +611,10 @@ describe Mongoid::Serializable do
                 end
 
                 before do
-                  person.save
+                  person.save!
                 end
 
-                it "includes the specific ralations" do
+                it "includes the specific relations" do
                   expect(relation_hash[0]["locations"].map do |location|
                     location["name"]
                   end).to include "Home"

data/spec/mongoid/shardable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 require_relative './shardable_models'
@@ -129,7 +128,7 @@ describe Mongoid::Shardable do
     end
 
     context 'when record is persisted' do
-      let(:instance) { klass.create(name: value) }
+      let(:instance) { klass.create!(name: value) }
 
       it { is_expected.to eq({ 'name' => value }) }
 
@@ -173,7 +172,7 @@ describe Mongoid::Shardable do
     end
 
     context 'when record is persisted' do
-      let(:instance) { klass.create(name: value) }
+      let(:instance) { klass.create!(name: value) }
 
       it { is_expected.to eq({ 'name' => value }) }
 

data/spec/mongoid/stateful_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -53,7 +52,7 @@ describe Mongoid::Stateful do
 
     context "when the object has been destroyed" do
       before do
-        person.save
+        person.save!
         person.destroy
       end