mongoid 7.3.2 → 7.4.0

data/spec/mongoid/attributes_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -21,7 +20,7 @@ describe Mongoid::Attributes do
     context "when the attribute was excluded in a criteria" do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when the attribute is localized" do
@@ -56,7 +55,7 @@ describe Mongoid::Attributes do
               let!(:agent) do
                 agent = Agent.new(:title => title)
                 agent.build_address(:city => city)
-                agent.save()
+                agent.save!()
                 agent
               end
               let(:from_db) do
@@ -199,7 +198,7 @@ describe Mongoid::Attributes do
     context 'when the document has a custom attribute type' do
 
       let(:bar) do
-        Bar.create(lat_lng: LatLng.new(52.30, 13.25))
+        Bar.create!(lat_lng: LatLng.new(52.30, 13.25))
       end
 
       it 'returns the demongoized version of the attribute' do
@@ -256,7 +255,7 @@ describe Mongoid::Attributes do
     context "when the document is an existing record" do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when the attribute was excluded in a criteria" do
@@ -330,7 +329,7 @@ describe Mongoid::Attributes do
 
       context 'when projecting with #only' do
         let!(:person) do
-          Person.create(title: 'sir', name: { first_name: 'Jose', language: { name: 'es' } })
+          Person.create!(title: 'sir', name: { first_name: 'Jose', language: { name: 'es' } })
         end
 
         context 'when projecting an embedded association' do
@@ -415,7 +414,7 @@ describe Mongoid::Attributes do
       let(:bar) do
         Bar.new.tap do |b|
           b[:lat_lng] = LatLng.new(52.30, 13.25)
-          b.save
+          b.save!
         end
       end
 
@@ -476,7 +475,7 @@ describe Mongoid::Attributes do
       context 'when writing fields on a document with projection' do
 
         let!(:person) do
-          Person.create(title: "sir")
+          Person.create!(title: "sir")
         end
 
         context "when excluding with only and the field was not excluded" do
@@ -988,7 +987,7 @@ describe Mongoid::Attributes do
     context 'when the document has a custom attribute type' do
 
       let(:bar) do
-        Bar.create(lat_lng: LatLng.new(52.30, 13.25))
+        Bar.create!(lat_lng: LatLng.new(52.30, 13.25))
       end
 
       it 'returns the demongoized version of the attribute' do
@@ -1026,7 +1025,7 @@ describe Mongoid::Attributes do
     context "when the document is an existing record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the attribute does not exist" do
@@ -1065,7 +1064,7 @@ describe Mongoid::Attributes do
   describe "#read_attribute_before_type_cast" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the attribute has not yet been assigned" do
@@ -1086,7 +1085,7 @@ describe Mongoid::Attributes do
     context 'when reading fields on a document with projection' do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when excluding with only and the field was not excluded" do
@@ -1157,7 +1156,7 @@ describe Mongoid::Attributes do
     context "when the document is an existing record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the attribute does not exist" do
@@ -1216,7 +1215,7 @@ describe Mongoid::Attributes do
 
     context "when the attribute is not on only list" do
 
-      before { Person.create }
+      before { Person.create! }
       let(:person) do
         Person.only(:id).first
       end
@@ -1285,7 +1284,7 @@ describe Mongoid::Attributes do
     context "when the attribute exists" do
 
       let(:person) do
-        Person.create(title: "Sir")
+        Person.create!(title: "Sir")
       end
 
       before do
@@ -1303,7 +1302,7 @@ describe Mongoid::Attributes do
       context "when saving after the removal" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the removal" do
@@ -1323,7 +1322,7 @@ describe Mongoid::Attributes do
      end
 
      before do
-       person.save
+       person.save!
        person.pet.remove_attribute(:name)
      end
 
@@ -1338,7 +1337,7 @@ describe Mongoid::Attributes do
      context "when saving after the removal" do
 
        before do
-         person.save
+         person.save!
        end
 
        it "persists the removal" do
@@ -1383,7 +1382,7 @@ describe Mongoid::Attributes do
       context 'when the database name is used' do
 
         let(:person) do
-          Person.create(at: Time.now)
+          Person.create!(at: Time.now)
         end
 
         before do
@@ -1401,7 +1400,7 @@ describe Mongoid::Attributes do
         context "when saving after the removal" do
 
           before do
-            person.save
+            person.save!
           end
 
           it "persists the removal" do
@@ -1413,7 +1412,7 @@ describe Mongoid::Attributes do
       context 'when the alias is used' do
 
         let(:person) do
-          Person.create(aliased_timestamp: Time.now)
+          Person.create!(aliased_timestamp: Time.now)
         end
 
         before do
@@ -1431,7 +1430,7 @@ describe Mongoid::Attributes do
         context "when saving after the removal" do
 
           before do
-            person.save
+            person.save!
           end
 
           it "persists the removal" do
@@ -1574,7 +1573,7 @@ describe Mongoid::Attributes do
         person.write_attribute(:test, "aliased field to test")
       end
 
-      it "allows the field name to be udpated" do
+      it "allows the field name to be updated" do
         expect(person.t).to eq("aliased field to test")
       end
     end
@@ -1635,7 +1634,7 @@ describe Mongoid::Attributes do
     context 'when writing fields on a document with projection' do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when excluding with only and the field was not excluded" do
@@ -2075,7 +2074,7 @@ describe Mongoid::Attributes do
   context "when persisting nil attributes" do
 
     let!(:person) do
-      Person.create(score: nil)
+      Person.create!(score: nil)
     end
 
     it "has an entry in the attributes" do
@@ -2090,7 +2089,7 @@ describe Mongoid::Attributes do
     end
 
     it "saves the default" do
-      expect { person.save }.to_not raise_error
+      expect { person.save! }.to_not raise_error
       expect(person.last_drink_taken_at).to eq(1.day.ago.in_time_zone("Alaska").to_date)
     end
   end
@@ -2100,7 +2099,7 @@ describe Mongoid::Attributes do
     context "when no value exists in the database" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "applies the default value" do
@@ -2113,7 +2112,7 @@ describe Mongoid::Attributes do
       context "when the value is not nil" do
 
         let!(:person) do
-          Person.create(age: 50)
+          Person.create!(age: 50)
         end
 
         let(:from_db) do
@@ -2128,7 +2127,7 @@ describe Mongoid::Attributes do
       context "when the value is explicitly nil" do
 
         let!(:person) do
-          Person.create(age: nil)
+          Person.create!(age: nil)
         end
 
         let(:from_db) do
@@ -2143,7 +2142,7 @@ describe Mongoid::Attributes do
       context "when the default is a proc" do
 
         let!(:account) do
-          Account.create(name: "savings", balance: "100")
+          Account.create!(name: "savings", balance: 100)
         end
 
         let(:from_db) do
@@ -2161,7 +2160,7 @@ describe Mongoid::Attributes do
 
     context 'when the attribute is blank' do
       let(:person) do
-        Person.create(title: '')
+        Person.create!(title: '')
       end
 
       it 'returns false' do
@@ -2171,7 +2170,7 @@ describe Mongoid::Attributes do
 
     context 'when the attribute is localized' do
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context 'after initialization when the field is nil' do
@@ -2203,7 +2202,7 @@ describe Mongoid::Attributes do
 
     context 'when the attribute is not localized' do
       let(:person) do
-        Person.create(username: 'localized')
+        Person.create!(username: 'localized')
       end
 
       before do

data/spec/mongoid/cacheable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -38,7 +37,7 @@ describe Mongoid::Cacheable do
     context "when persisted" do
 
       before do
-        document.save
+        document.save!
       end
 
       context "with updated_at" do

data/spec/mongoid/changeable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -698,7 +697,7 @@ describe Mongoid::Changeable do
     context "when the document is embedded" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:name) do
@@ -740,7 +739,7 @@ describe Mongoid::Changeable do
       context "when the field has not changed" do
 
         let(:person) do
-          Person.create(map: { name: "value" })
+          Person.create!(map: { name: "value" })
         end
 
         before do
@@ -755,7 +754,7 @@ describe Mongoid::Changeable do
       context "when the field is changed" do
 
         let(:person) do
-          Person.create(map: { name: "value" })
+          Person.create!(map: { name: "value" })
         end
 
         before do
@@ -770,7 +769,7 @@ describe Mongoid::Changeable do
       context "when a dynamic field is changed in place" do
 
         let(:person) do
-          Person.create(other_name: { full: {first: 'first', last: 'last'} })
+          Person.create!(other_name: { full: {first: 'first', last: 'last'} })
         end
 
         before do
@@ -798,11 +797,11 @@ describe Mongoid::Changeable do
     context "when a child has changed" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "hobrecht")
+        person.addresses.create!(street: "hobrecht")
       end
 
       before do
@@ -817,15 +816,15 @@ describe Mongoid::Changeable do
     context "when changed? has been called before child elements size change" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "hobrecht")
+        person.addresses.create!(street: "hobrecht")
       end
 
       let!(:location) do
-        address.locations.create(name: "home")
+        address.locations.create!(name: "home")
       end
 
       before do
@@ -857,7 +856,7 @@ describe Mongoid::Changeable do
       context "when adding via create" do
 
         before do
-          address.locations.create
+          address.locations.create!
         end
 
         it "returns false" do
@@ -869,15 +868,15 @@ describe Mongoid::Changeable do
     context "when a deeply embedded child has changed" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "hobrecht")
+        person.addresses.create!(street: "hobrecht")
       end
 
       let!(:location) do
-        address.locations.create(name: "home")
+        address.locations.create!(name: "home")
       end
 
       before do
@@ -892,7 +891,7 @@ describe Mongoid::Changeable do
     context "when a child is new" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
@@ -907,11 +906,11 @@ describe Mongoid::Changeable do
     context "when a deeply embedded child is new" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "hobrecht")
+        person.addresses.create!(street: "hobrecht")
       end
 
       let!(:location) do
@@ -1260,7 +1259,7 @@ describe Mongoid::Changeable do
       context "when the document is persisted" do
 
         let(:person) do
-          Person.create(pets: true)
+          Person.create!(pets: true)
         end
 
         before do
@@ -1297,7 +1296,7 @@ describe Mongoid::Changeable do
       context "when the document is persisted" do
 
         let(:person) do
-          Person.create(title: "test")
+          Person.create!(title: "test")
         end
 
         before do
@@ -1395,7 +1394,7 @@ describe Mongoid::Changeable do
   context "when only embedded documents change" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the child is an embeds one" do
@@ -1454,7 +1453,7 @@ describe Mongoid::Changeable do
       context "when a child is modified" do
 
         let!(:address) do
-          person.addresses.create(street: "jakobstr.")
+          person.addresses.create!(street: "jakobstr.")
         end
 
         before do
@@ -1469,7 +1468,7 @@ describe Mongoid::Changeable do
       context "when no child is modified" do
 
         let!(:address) do
-          person.addresses.create(street: "skalitzerstr.")
+          person.addresses.create!(street: "skalitzerstr.")
         end
 
         it "does not flag the parent as changed" do
@@ -1482,7 +1481,7 @@ describe Mongoid::Changeable do
   context "when changing a hash of hashes" do
 
     let!(:person) do
-      Person.create(map: { "test" => {}})
+      Person.create!(map: { "test" => {}})
     end
 
     before do
@@ -1499,15 +1498,15 @@ describe Mongoid::Changeable do
   context "when modifying a many to many key" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:preference) do
-      Preference.create(name: "dirty")
+      Preference.create!(name: "dirty")
     end
 
     before do
-      person.update_attributes(preference_ids: [ preference.id ])
+      person.update_attributes!(preference_ids: [ preference.id ])
     end
 
     it "records the foreign key dirty changes" do
@@ -1520,7 +1519,7 @@ describe Mongoid::Changeable do
   context "when accessing an array field" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:from_db) do
@@ -1546,7 +1545,7 @@ describe Mongoid::Changeable do
   context "when reloading an unchanged document" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:from_db) do
@@ -1565,7 +1564,7 @@ describe Mongoid::Changeable do
   context "when fields are getting changed" do
 
     let(:person) do
-      Person.create(
+      Person.create!(
         title: "MC",
         some_dynamic_field: 'blah'
       )
@@ -1645,7 +1644,7 @@ describe Mongoid::Changeable do
     context "when the document is persisted" do
 
       let!(:acolyte) do
-        Acolyte.create(name: "callback-test")
+        Acolyte.create!(name: "callback-test")
       end
 
       before do
@@ -1689,7 +1688,7 @@ describe Mongoid::Changeable do
       end
 
       it "retains the changes until after all callbacks" do
-        acolyte.save
+        acolyte.save!
         expect(acolyte.changed_in_callback["name"]).to eq([ nil, "callback-test" ])
       end
     end
@@ -1698,7 +1697,7 @@ describe Mongoid::Changeable do
   context "when associations are getting changed" do
 
     let(:person) do
-      Person.create(addresses: [ Address.new ])
+      Person.create!(addresses: [ Address.new ])
     end
 
     before do
@@ -1715,7 +1714,7 @@ describe Mongoid::Changeable do
     context 'when persisting the root document' do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       it 'is not marked as changed' do
@@ -1739,7 +1738,7 @@ describe Mongoid::Changeable do
         context 'when building the lowest level document' do
 
           before do
-            person.save
+            person.save!
           end
 
           let!(:code) do
@@ -1761,7 +1760,7 @@ describe Mongoid::Changeable do
           context 'when saving the hierarchy' do
 
             before do
-              person.save
+              person.save!
             end
 
             let(:reloaded) do
@@ -1783,7 +1782,7 @@ describe Mongoid::Changeable do
               end
 
               before do
-                reloaded.save
+                reloaded.save!
               end
 
               it 'saves the deepest embedded document' do

data/spec/mongoid/clients/factory_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -66,9 +65,15 @@ describe Mongoid::Clients::Factory do
             expect(client).to be_a(Mongo::Client)
           end
 
-          it 'does not produce driver warnings' do
-            Mongo::Logger.logger.should_not receive(:warn)
-            client
+          context 'not JRuby' do
+            # Run this test on JRuby when driver 2.16.0 is released -
+            # see RUBY-2771.
+            fails_on_jruby
+
+            it 'does not produce driver warnings' do
+              Mongo::Logger.logger.should_not receive(:warn)
+              client
+            end
           end
 
           let(:cluster_addresses) do

data/spec/mongoid/clients/options_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -83,9 +82,11 @@ describe Mongoid::Clients::Options, retry: 3 do
 
         let!(:connections_and_cluster_during) do
           connections = nil
-          cluster = Minim.with(options) do |klass|
+          cluster = nil
+          Minim.with(options) do |klass|
             klass.where(name: 'emily').to_a
             connections = Minim.mongo_client.database.command(serverStatus: 1).first['connections']['current']
+            cluster = Minim.collection.cluster
           end
           [ connections, cluster ]
         end
@@ -124,7 +125,10 @@ describe Mongoid::Clients::Options, retry: 3 do
           end
 
           it 'disconnects the new cluster when the block exits' do
-            expect(connections_before).to eq(connections_after)
+            expect(cluster_after).not_to be(cluster_during)
+
+            cluster_during.connected?.should be false
+            cluster_before.connected?.should be true
           end
         end
 
@@ -138,13 +142,14 @@ describe Mongoid::Clients::Options, retry: 3 do
 
           it 'does not create a new cluster' do
             expect(connections_during).to eq(connections_before)
+
+            cluster_during.should be cluster_before
           end
 
           it 'does not disconnect the original cluster' do
-            skip 'https://jira.mongodb.org/browse/MONGOID-5130'
-
-            expect(connections_after).to eq(connections_before)
             expect(cluster_before).to be(cluster_after)
+
+            cluster_before.connected?.should be true
           end
         end
 
@@ -240,11 +245,11 @@ describe Mongoid::Clients::Options, retry: 3 do
             threads << Thread.new do
               if i % 2 == 0
                 NameOnly.with(collection: 'British') do |klass|
-                  klass.create(name: 'realised')
+                  klass.create!(name: 'realised')
                 end
               else
                 NameOnly.with(collection: 'American') do |klass|
-                  klass.create(name: 'realized')
+                  klass.create!(name: 'realized')
                 end
               end
             end
@@ -302,7 +307,7 @@ describe Mongoid::Clients::Options, retry: 3 do
       end
 
       let(:test_model) do
-        Minim.create
+        Minim.create!
       end
 
       let(:persistence_context) do
@@ -458,7 +463,7 @@ describe Mongoid::Clients::Options, retry: 3 do
         before do
           threads = []
           100.times do |i|
-            test_model = NameOnly.create
+            test_model = NameOnly.create!
             threads << Thread.new do
               if i % 2 == 0
                 test_model.with(collection: 'British') do |b|