mongoid 7.3.2 → 7.4.0

data/spec/integration/criteria/range_spec.rb

@@ -0,0 +1,265 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Queries with Range criteria' do
+  let(:now_utc) { Time.utc(2020, 1, 1, 16, 0, 0, 0) }
+  let(:now_in_zone) { now_utc.in_time_zone('Asia/Tokyo') }
+  let(:today) { Date.new(2020, 1, 1) }
+
+  let!(:band1) { Band.create!(likes: 0, rating: 0.9, founded: today, updated_at: now_utc) }
+  let!(:band2) { Band.create!(likes: 1, rating: 1.0, founded: today + 1.day, updated_at: now_utc + 1.days) }
+  let!(:band3) { Band.create!(likes: 2, rating: 2.9, founded: today + 2.days, updated_at: now_utc + 2.days) }
+  let!(:band4) { Band.create!(likes: 3, rating: 3.0, founded: today + 3.days, updated_at: now_utc + 3.days) }
+  let!(:band5) { Band.create!(likes: 4, rating: 3.1, founded: today + 4.days, updated_at: now_utc + 4.days) }
+
+  context 'Range<Integer> criteria vs Integer field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(likes: 1..3).to_a).to eq [band2, band3, band4]
+      expect(Band.where(likes: 1...3).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(likes: eval('1..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(likes: eval('..3')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(likes: eval('...3')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Integer> criteria vs Float field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(rating: 1..3).to_a).to eq [band2, band3, band4]
+      expect(Band.where(rating: 1...3).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(rating: eval('1..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(rating: eval('..3')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(rating: eval('...3')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Float> criteria vs Integer field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(likes: 0.95..3.05).to_a).to eq [band2, band3, band4]
+      expect(Band.where(likes: 0.95...3.0).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(likes: eval('0.95..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(likes: eval('..3.05')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(likes: eval('...3.0')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Float> criteria vs Float field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(rating: 0.95..3.05).to_a).to eq [band2, band3, band4]
+      expect(Band.where(rating: 0.95...3.0).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(rating: eval('0.95..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(rating: eval('..3.05')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(rating: eval('...3.0')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Time> criteria vs Time field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(updated_at: (now_utc + 1.day)..(now_utc + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(updated_at: (now_utc + 1.day)...(now_utc + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(updated_at: eval('(now_utc + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(updated_at: eval('..(now_utc + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(updated_at: eval('...(now_utc + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Time> criteria vs Date field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(founded: (now_utc + 1.day)..(now_utc + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(founded: (now_utc + 1.day)...(now_utc + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(founded: eval('(now_utc + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(founded: eval('..(now_utc + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(founded: eval('...(now_utc + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<ActiveSupport::TimeWithZone> criteria vs Time field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(updated_at: (now_in_zone + 1.day)..(now_in_zone + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(updated_at: (now_in_zone + 1.day)...(now_in_zone + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(updated_at: eval('(now_in_zone + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(updated_at: eval('..(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(updated_at: eval('...(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<ActiveSupport::TimeWithZone> criteria vs Date field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(founded: (now_in_zone + 1.day)..(now_in_zone + 3.days)).to_a).to eq [band3, band4, band5]
+      expect(Band.where(founded: (now_in_zone + 1.day)...(now_in_zone + 3.days)).to_a).to eq [band3, band4]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(founded: eval('(now_in_zone + 1.day)..')).to_a).to eq [band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(founded: eval('..(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3, band4, band5]
+        expect(Band.where(founded: eval('...(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+      end
+    end
+  end
+
+  context 'Range<Date> criteria vs Date field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(founded: (today + 1.day)..(today + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(founded: (today + 1.day)...(today + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(founded: eval('(today + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(founded: eval('..(today + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(founded: eval('...(today + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Date> criteria vs Time field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(updated_at: (today + 1.day)..(today + 3.days)).to_a).to eq [band2, band3]
+      expect(Band.where(updated_at: (today + 1.day)...(today + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(updated_at: eval('(today + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(updated_at: eval('..(today + 3.days)')).to_a).to eq [band1, band2, band3]
+        expect(Band.where(updated_at: eval('...(today + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+end

data/spec/integration/criteria/time_with_zone_spec.rb

@@ -1,32 +1,142 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
 describe 'TimeWithZone in queries' do
-  context 'in a non-UTC time zone' do
-    let(:time_zone_name) { 'Pacific Time (US & Canada)' }
+  let(:now_utc) { Time.now.utc }
+  let(:now_in_zone) { now_utc.in_time_zone(time_zone) }
 
-    before do
-      time = Time.now
-      expect(time.utc_offset).not_to eq(time.in_time_zone(time_zone_name).utc_offset)
+  shared_examples_for 'time zone queries' do
+    let!(:book_earlier) { Book.create!(updated_at: now_utc - 20.minutes, dynamic_time: now_utc - 20.minutes).reload }
+    let!(:book_now)     { Book.create!(dynamic_time: now_in_zone).reload }
+    let!(:book_later)   { Book.create!(updated_at: now_in_zone + 20.minutes, dynamic_time: now_in_zone + 20.minutes).reload }
+
+    context 'Mongo driver static field' do
+
+      let(:view_lt) do
+        Book.collection.find(updated_at: {'$lt' => query_time + 10.minutes})
+      end
+
+      let(:view_gt) do
+        Book.collection.find(updated_at: {'$gt' => query_time - 10.minutes})
+      end
+
+      let(:view_range) do
+        Book.collection.find(updated_at: {'$gt' => query_time - 10.minutes, '$lt' => query_time + 10.minutes})
+      end
+
+      it 'finds the document' do
+        expect(view_lt.to_a).to eq([book_earlier.attributes, book_now.attributes])
+        expect(view_gt.to_a).to eq([book_now.attributes, book_later.attributes])
+        expect(view_range.to_a).to eq([book_now.attributes])
+      end
     end
 
-    let(:time_in_zone) { Time.now.in_time_zone(time_zone_name) }
+    context 'Mongo driver dynamic field' do
+
+      let(:view_lt) do
+        Book.collection.find(dynamic_time: {'$lt' => query_time + 10.minutes})
+      end
+
+      let(:view_gt) do
+        Book.collection.find(dynamic_time: {'$gt' => query_time - 10.minutes})
+      end
+
+      let(:view_range) do
+        Book.collection.find(dynamic_time: {'$gt' => query_time - 10.minutes, '$lt' => query_time + 10.minutes})
+      end
 
-    let(:view_lt) do
-      Agency.collection.find(updated_at: {'$lt' => time_in_zone + 10.minutes})
+      it 'finds the document' do
+        expect(view_lt.to_a).to eq([book_earlier.attributes, book_now.attributes])
+        expect(view_gt.to_a).to eq([book_now.attributes, book_later.attributes])
+        expect(view_range.to_a).to eq([book_now.attributes])
+      end
     end
 
-    let(:view_gt) do
-      Agency.collection.find(updated_at: {'$gt' => time_in_zone - 10.minutes})
+    context 'Mongoid static field' do
+
+      let(:view_lt) do
+        Book.all.lt(updated_at: query_time + 10.minutes)
+      end
+
+      let(:view_gt) do
+        Book.all.gt(updated_at: query_time - 10.minutes)
+      end
+
+      let(:view_range) do
+        Book.all.where(updated_at: (query_time - 10.minutes)..(query_time + 10.minutes))
+      end
+
+      it 'finds the document' do
+        expect(view_lt.pluck(:_id).sort).to eq([book_earlier, book_now].pluck(:_id).sort)
+        expect(view_gt.pluck(:_id).sort).to eq([book_now, book_later].pluck(:_id).sort)
+        expect(view_range.pluck(:_id).sort).to eq([book_now].pluck(:_id).sort)
+      end
     end
 
-    let!(:agency) { Agency.create!.reload }
+    context 'Mongoid dynamic field' do
+
+      let(:view_lt) do
+        Book.all.lt(dynamic_time: query_time + 10.minutes)
+      end
+
+      let(:view_gt) do
+        Book.all.gt(dynamic_time: query_time - 10.minutes)
+      end
+
+      let(:view_range) do
+        Book.all.where(dynamic_time: (query_time - 10.minutes)..(query_time + 10.minutes))
+      end
+
+      it 'finds the document' do
+        expect(view_lt.pluck(:_id).sort).to eq([book_earlier, book_now].pluck(:_id).sort)
+        expect(view_gt.pluck(:_id).sort).to eq([book_now, book_later].pluck(:_id).sort)
+        expect(view_range.pluck(:_id).sort).to eq([book_now].pluck(:_id).sort)
+      end
+    end
+  end
+
+  context 'query with Time' do
+    let(:query_time) { now_utc }
+
+    context 'when zone of queried time is UTC' do
+      let(:time_zone) { 'UTC' }
+      it { expect(now_in_zone.utc_offset).to eq 0 }
+      it_behaves_like 'time zone queries'
+    end
+
+    context 'when zone of queried time is JST' do
+      let(:time_zone) { 'Asia/Tokyo' }
+      it { expect(now_in_zone.utc_offset).to be > 0 }
+      it_behaves_like 'time zone queries'
+    end
+
+    context 'when zone of queried time is PST' do
+      let(:time_zone) { 'Pacific Time (US & Canada)' }
+      it { expect(now_in_zone.utc_offset).to be < 0 }
+      it_behaves_like 'time zone queries'
+    end
+  end
+
+  context 'query with ActiveSupport::TimeWithZone' do
+    let(:query_time) { now_in_zone }
+
+    context 'when zone of queried time is UTC' do
+      let(:time_zone) { 'UTC' }
+      it { expect(now_in_zone.utc_offset).to eq 0 }
+      it_behaves_like 'time zone queries'
+    end
+
+    context 'when zone of queried time is JST' do
+      let(:time_zone) { 'Asia/Tokyo' }
+      it { expect(now_in_zone.utc_offset).to be > 0 }
+      it_behaves_like 'time zone queries'
+    end
 
-    it 'finds the document' do
-      view_lt.to_a.should == [agency.attributes]
-      view_gt.to_a.should == [agency.attributes]
+    context 'when zone of queried time is PST' do
+      let(:time_zone) { 'Pacific Time (US & Canada)' }
+      it { expect(now_in_zone.utc_offset).to be < 0 }
+      it_behaves_like 'time zone queries'
     end
   end
 end

data/spec/integration/discriminator_key_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/discriminator_value_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/document_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/i18n_fallbacks_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/matcher_examples_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/matcher_operator_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
@@ -15,7 +14,32 @@ end
 describe 'Matcher operators' do
   Dir[File.join(File.dirname(__FILE__), 'matcher_operator_data', '*.yml')].sort.each do |path|
     context File.basename(path) do
-      specs = YAML.load(File.read(path))
+      permitted_classes = [ BigDecimal,
+                            Date,
+                            Time,
+                            Range,
+                            Regexp,
+                            Symbol,
+                            BSON::Binary,
+                            BSON::Code,
+                            BSON::CodeWithScope,
+                            BSON::DbPointer,
+                            BSON::Decimal128,
+                            BSON::Int32,
+                            BSON::Int64,
+                            BSON::MaxKey,
+                            BSON::MinKey,
+                            BSON::ObjectId,
+                            BSON::Regexp::Raw,
+                            BSON::Symbol::Raw,
+                            BSON::Timestamp,
+                            BSON::Undefined ]
+
+      specs = if RUBY_VERSION.start_with?("2.5")
+                YAML.safe_load(File.read(path), permitted_classes, [], true)
+              else
+                YAML.safe_load(File.read(path), permitted_classes: permitted_classes, aliases: true)
+              end
 
       specs.each do |spec|
         context spec['name'] do
@@ -52,7 +76,7 @@ describe 'Matcher operators' do
           end
 
           context 'server query' do
-            let!(:document) { Mop.create(spec.fetch('document')) }
+            let!(:document) { Mop.create!(spec.fetch('document')) }
 
             context 'via driver' do
               if mop_error?(spec, 'driver')

data/spec/integration/matcher_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
@@ -20,6 +19,101 @@ describe 'Matcher operators' do
     end
   end
 
+  context 'when comparing Time objects' do
+    let(:time) {Time.utc(2021, 10, 25, 10, 30, 30, 581345)}
+    let(:document) do
+      ConsumptionPeriod.new(:started_at => time)
+    end
+
+    context 'comparing millisecond precision' do
+      let(:time_millis) {Time.utc(2021, 10, 25, 10, 30, 30, 581774)}
+
+      context "when compare_time_by_ms feature flag is set" do
+        config_override :compare_time_by_ms, true
+
+        context 'with exact match' do
+          let(:query) do
+            {'started_at' => time_millis}
+          end
+
+          it_behaves_like 'is true'
+
+          context 'and query has different timezone' do
+            let(:time_millis) do
+              Time.utc(2021, 10, 25, 10, 30, 30, 581345).in_time_zone("Stockholm")
+            end
+
+            it_behaves_like 'is true'
+          end
+        end
+
+        context 'with $in' do
+          let(:query) do
+            {'started_at' => {:$in => [time_millis]}}
+          end
+
+          it_behaves_like 'is true'
+        end
+
+        context 'when matching an element in an array' do
+          let(:document) do
+            Mop.new(:array_field => [time])
+          end
+
+          context 'with equals match' do
+            let(:query) do
+              {'array_field' => time_millis}
+            end
+
+            it_behaves_like 'is true'
+          end
+        end
+      end
+
+      context "when compare_time_by_ms feature flag is not set" do
+        config_override :compare_time_by_ms, false
+
+        context 'with exact match' do
+          let(:query) do
+            {'started_at' => time_millis}
+          end
+
+          it_behaves_like 'is false'
+
+          context 'and query has different timezone' do
+            let(:time_millis) do
+              Time.utc(2021, 10, 25, 10, 30, 30, 581345).in_time_zone("Stockholm")
+            end
+
+            it_behaves_like 'is true'
+          end
+        end
+
+        context 'with $in' do
+          let(:query) do
+            {'started_at' => {:$in => [time_millis]}}
+          end
+
+          it_behaves_like 'is false'
+        end
+
+        context 'when matching an element in an array' do
+          let(:document) do
+            Mop.new(:array_field => [time])
+          end
+
+          context 'with equals match' do
+            let(:query) do
+              {'array_field' => time_millis}
+            end
+
+            it_behaves_like 'is false'
+          end
+        end
+      end
+    end
+  end
+
   context 'when querying nested document' do
     context 'embeds_one' do
       let(:document) do

data/spec/integration/server_query_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/shardable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 require_relative '../mongoid/shardable_models'

data/spec/integration/stringified_symbol_field_spec.rb

@@ -31,8 +31,8 @@ describe "StringifiedSymbol fields" do
     end
   end
 
-# Using command monitoring to test that StringifiedSymbol sends a string and returns a symbol
-let(:client) { Order.collection.client }
+  # Using command monitoring to test that StringifiedSymbol sends a string and returns a symbol
+  let(:client) { Order.collection.client }
 
   before do
     client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
@@ -91,7 +91,7 @@ let(:client) { Order.collection.client }
     end
 
     it "sends the value as a string" do
-      Order.create(saved_status: [0, 1, 2])
+      Order.create!(saved_status: [0, 1, 2])
       event = insert_events.second
       doc = event.command["documents"].first
       expect(doc["saved_status"]).to eq("[0, 1, 2]")
@@ -187,4 +187,17 @@ let(:client) { Order.collection.client }
       expect(event.command["updates"].first["u"]["$set"]["saved_status"]).to eq("[3, 4, 5]")
     end
   end
+  
+  context "when StringifiedSymbol is embedded" do 
+    
+    describe "When the embedded field is not unique" do
+      
+      it "should be invalid" do
+        order = Order.new
+        order.purchased_items.build(item_id: :foo)
+        order.purchased_items.build(item_id: :foo)
+        expect(order.invalid?).to be true
+      end
+    end
+  end
 end

data/spec/lite_spec_helper.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
@@ -19,7 +18,14 @@ autoload :Timecop, 'timecop'
 
 require 'support/spec_config'
 require 'mrss/lite_constraints'
-require "support/session_registry"
+
+if Gem::Version.new(Mongo::VERSION) < Gem::Version.new('2.18.0.alpha')
+  require "mrss/session_registry_legacy"
+else
+  require "mrss/session_registry"
+end
+
+Mrss.patch_mongo_for_session_registry
 
 unless SpecConfig.instance.ci?
   begin