mongoid 7.3.2 → 7.4.0

data/spec/mongoid/association/accessors_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -8,7 +7,7 @@ describe Mongoid::Association::Accessors do
   describe "\#{getter}?" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the association is a has one" do
@@ -89,7 +88,7 @@ describe Mongoid::Association::Accessors do
       context "when the association is named next" do
 
         let(:user) do
-          User.create
+          User.create!
         end
 
         it "allows the existence check" do
@@ -167,6 +166,36 @@ describe Mongoid::Association::Accessors do
           end
         end
       end
+
+      context "when the association is set to nil first" do
+        context "when broken_updates feature flag is not set" do
+          config_override :broken_updates, false
+
+          let!(:name) do
+            person.build_name
+          end
+
+          it "returns true" do
+            person.name = nil
+            person.name = name
+            expect(person).to have_name
+          end
+        end
+
+        context "when broken_updates feature flag is set" do
+          config_override :broken_updates, true
+
+          let!(:name) do
+            person.build_name
+          end
+
+          it "returns true" do
+            person.name = nil
+            person.name = name
+            expect(person).to have_name
+          end
+        end
+      end
     end
 
     context "when the association is an embeds many" do
@@ -355,13 +384,13 @@ describe Mongoid::Association::Accessors do
     context "when the association is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the association is a many to many" do
 
         let!(:preference) do
-          Preference.create(name: "Setting")
+          Preference.create!(name: "Setting")
         end
 
         before do
@@ -413,7 +442,7 @@ describe Mongoid::Association::Accessors do
       context "when the association is a many to one" do
 
         let!(:post) do
-          Post.create(title: "First!")
+          Post.create!(title: "First!")
         end
 
         before do
@@ -465,7 +494,7 @@ describe Mongoid::Association::Accessors do
       context "when the association is a references one" do
 
         let!(:game) do
-          Game.create(name: "Centipeded")
+          Game.create!(name: "Centipeded")
         end
 
         before do
@@ -520,15 +549,15 @@ describe Mongoid::Association::Accessors do
       context "when there's a single references many/one" do
 
         let!(:movie) do
-          Movie.create(title: "Inception")
+          Movie.create!(title: "Inception")
         end
 
         let!(:book) do
-          Book.create(title: "Jurassic Park")
+          Book.create!(title: "Jurassic Park")
         end
 
         let!(:movie_rating) do
-          movie.ratings.create(value: 10)
+          movie.ratings.create!(value: 10)
         end
 
         let!(:book_rating) do
@@ -833,7 +862,7 @@ describe Mongoid::Association::Accessors do
       context "when setting the _ids accessor" do
 
         let(:post) do
-          Post.create
+          Post.create!
         end
 
         before do
@@ -911,7 +940,7 @@ describe Mongoid::Association::Accessors do
     end
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when value is an empty string" do
@@ -970,13 +999,13 @@ describe Mongoid::Association::Accessors do
   context 'when setting the association more than once' do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context 'when the association is a references one' do
 
       let(:game) do
-        Game.create
+        Game.create!
       end
 
       before do
@@ -992,7 +1021,7 @@ describe Mongoid::Association::Accessors do
     context 'when the association is a references many' do
 
       let!(:preference) do
-        Preference.create(name: "Setting")
+        Preference.create!(name: "Setting")
       end
 
       before do

data/spec/mongoid/association/auto_save_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
+require_relative './referenced/has_many_models'
+require_relative './referenced/has_one_models'
 
 describe Mongoid::Association::Referenced::AutoSave do
 
@@ -22,22 +23,59 @@ describe Mongoid::Association::Referenced::AutoSave do
 
     context "when the option is not provided" do
 
-      let(:game) do
-        Game.new(name: "Tekken")
-      end
+      context 'has_many' do
+
+        let(:parent) do
+          HmmSchool.new
+        end
+
+        let(:child) do
+          HmmStudent.new(name: "Panda")
+        end
+
+        before do
+          parent.students = [child]
+        end
+
+        context "when saving the parent document" do
+
+          before do
+            parent.associations[:students].options[:autosave].should be_falsy
+
+            parent.save!
+          end
 
-      before do
-        person.game = game
+          it "does not save the child" do
+            expect(child).to_not be_persisted
+          end
+        end
       end
 
-      context "when saving the parent document" do
+      context 'has_one' do
+
+        let(:parent) do
+          HomCollege.new
+        end
+
+        let(:child) do
+          HomAccreditation.new
+        end
 
         before do
-          person.save
+          parent.accreditation = child
         end
 
-        it "does not save the relation" do
-          expect(game).to_not be_persisted
+        context "when saving the parent document" do
+
+          before do
+            parent.associations[:accreditation].options[:autosave].should be_falsy
+
+            parent.save!
+          end
+
+          it "does not save the child" do
+            expect(child).to_not be_persisted
+          end
         end
       end
     end
@@ -57,7 +95,7 @@ describe Mongoid::Association::Referenced::AutoSave do
         it "does not add the autosave callback twice" do
           expect(drug).to receive(:save).once
           person.drugs.push(drug)
-          person.save
+          person.save!
         end
       end
 
@@ -77,7 +115,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
             before do
               person.drugs << drug
-              person.save
+              person.save!
             end
 
             it "saves the relation" do
@@ -103,7 +141,7 @@ describe Mongoid::Association::Referenced::AutoSave do
             before do
               person.with(database: other_database) do |per|
                 per.drugs << drug
-                per.save
+                per.save!
               end
             end
 
@@ -118,9 +156,9 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when saving an existing parent document" do
 
           before do
-            person.save
+            person.save!
             person.drugs << drug
-            person.save
+            person.save!
           end
 
           it "saves the relation" do
@@ -136,11 +174,11 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.drugs << drug
-            person.save
+            person.save!
           end
 
           it 'does not load the association' do
-            from_db.save
+            from_db.save!
             expect(from_db.ivar(:drugs)).to be false
           end
         end
@@ -156,7 +194,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.account = account
-            person.save
+            person.save!
           end
 
           it "saves the relation" do
@@ -171,9 +209,9 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when saving an existing parent document" do
 
           before do
-            person.save
+            person.save!
             person.account = account
-            person.save
+            person.save!
           end
 
           it "saves the relation" do
@@ -189,14 +227,14 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.account = account
-            person.save
+            person.save!
           end
 
           it "sends one insert" do
             account.name = "account"
             expect_query(1) do
               person.with(write: {w:0}) do |_person|
-                _person.save
+                _person.save!
               end
             end
           end
@@ -210,11 +248,11 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.account = account
-            person.save
+            person.save!
           end
 
           it 'does not load the association' do
-            from_db.save
+            from_db.save!
             expect(from_db.ivar(:account)).to be false
           end
         end
@@ -234,7 +272,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             ghost.movie = movie
-            ghost.save
+            ghost.save!
           end
 
           it "saves the relation" do
@@ -245,9 +283,9 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when saving an existing parent document" do
 
           before do
-            ghost.save
+            ghost.save!
             ghost.movie = movie
-            ghost.save
+            ghost.save!
           end
 
           it "saves the relation" do
@@ -259,7 +297,7 @@ describe Mongoid::Association::Referenced::AutoSave do
       context "when it has two relations with autosaves" do
 
         let!(:person) do
-          Person.create(drugs: [percocet], account: account)
+          Person.create!(drugs: [percocet], account: account)
         end
 
         let(:from_db) do
@@ -282,7 +320,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             from_db.drugs = [placebo]
-            from_db.save
+            from_db.save!
           end
 
           it 'loads the updated association' do
@@ -297,7 +335,7 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when updating none document" do
 
           before do
-            from_db.save
+            from_db.save!
           end
 
           it 'doest not load drugs association' do
@@ -338,22 +376,22 @@ describe Mongoid::Association::Referenced::AutoSave do
         end
 
         let(:king) do
-          King.create
+          King.create!
         end
 
         let(:peasant) do
-          Peasant.create
+          Peasant.create!
         end
 
         let(:harvest) do
-          Harvest.create(season: 'Summer')
+          Harvest.create!(season: 'Summer')
         end
 
         before do
           peasant.harvest = harvest
           king.peasant = peasant
           harvest.season = 'Fall'
-          king.save
+          king.save!
         end
 
         it 'cascades the save' do

data/spec/mongoid/association/builders_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -177,7 +176,7 @@ describe Mongoid::Association::Builders do
     context "when the parent is persisted" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the relation is a has one" do

data/spec/mongoid/association/constrainable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 

data/spec/mongoid/association/counter_cache_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -10,7 +9,7 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when counter is reset" do
 
       let(:person) do
-        Person.create do |person|
+        Person.create! do |person|
           person[:drugs_count] = 3
         end
       end
@@ -31,7 +30,7 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when reset with invalid name" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "expect to raise an error" do
@@ -44,11 +43,11 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when counter gets messy" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:post) do
-        person.posts.create(title: "my first post")
+        person.posts.create!(title: "my first post")
       end
 
       before do
@@ -69,11 +68,11 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when the counter is on a subclass" do
 
       let(:subscription) do
-        Subscription.create
+        Subscription.create!
       end
 
       let!(:pack) do
-        subscription.packs.create
+        subscription.packs.create!
       end
 
       before do
@@ -97,8 +96,8 @@ describe Mongoid::Association::Referenced::CounterCache do
 
       before do
         subscription.with(collection: 'other') do |sub|
-          sub.save
-          sub.packs.create
+          sub.save!
+          sub.packs.create!
         end
       end
 
@@ -115,7 +114,7 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when counter is reset" do
 
       let(:person) do
-        Person.create do |person|
+        Person.create! do |person|
           person[:drugs_count] = 3
         end
       end
@@ -141,7 +140,7 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when reset with invalid name" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "expect to raise an error" do
@@ -154,11 +153,11 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when counter gets messy" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:post) do
-        person.posts.create(title: "my first post")
+        person.posts.create!(title: "my first post")
       end
 
       before do
@@ -174,11 +173,11 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when the counter is on a subclass" do
 
       let(:subscription) do
-        Subscription.create
+        Subscription.create!
       end
 
       let!(:pack) do
-        subscription.packs.create
+        subscription.packs.create!
       end
 
       before do
@@ -196,7 +195,7 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when was 3 " do
 
       let(:person) do
-        Person.create do |person|
+        Person.create! do |person|
           person[:drugs_count] = 3
         end
       end
@@ -225,7 +224,7 @@ describe Mongoid::Association::Referenced::CounterCache do
     end
     context "when update with 2 and use a string argument" do
 
-      let(:person) { Person.create }
+      let(:person) { Person.create! }
 
       before do
         Person.update_counters person.id, "drugs_count" => 2
@@ -238,7 +237,7 @@ describe Mongoid::Association::Referenced::CounterCache do
 
     context "when update more multiple counters" do
 
-      let(:person) { Person.create }
+      let(:person) { Person.create! }
 
       before do
         Person.update_counters(person.id, :drugs_count => 2, :second_counter => 5)
@@ -256,7 +255,7 @@ describe Mongoid::Association::Referenced::CounterCache do
 
   describe "#increment_counter" do
 
-    let(:person) { Person.create }
+    let(:person) { Person.create! }
 
     context "when increment 3 times" do
 
@@ -288,8 +287,8 @@ describe Mongoid::Association::Referenced::CounterCache do
 
       before do
         person.with(collection: 'other') do |per|
-          per.save
-          per.drugs.create
+          per.save!
+          per.drugs.create!
         end
       end
 
@@ -304,7 +303,7 @@ describe Mongoid::Association::Referenced::CounterCache do
   describe "#decrement_counter" do
 
     let(:person) do
-      Person.create do |p|
+      Person.create! do |p|
         p[:drugs_count] = 3
       end
     end
@@ -338,8 +337,8 @@ describe Mongoid::Association::Referenced::CounterCache do
 
       before do
         person.with(collection: 'other') do |per|
-          per.save
-          drug = per.drugs.create
+          per.save!
+          drug = per.drugs.create!
           drug.destroy
         end
       end
@@ -359,11 +358,11 @@ describe Mongoid::Association::Referenced::CounterCache do
       context 'when #destroy is called on the object' do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:drug) do
-          person.drugs.create
+          person.drugs.create!
         end
 
         before do
@@ -378,7 +377,7 @@ describe Mongoid::Association::Referenced::CounterCache do
       context 'when #create is called on the object' do
 
         let(:person) do
-          Person.create { |p| p.drugs += [Drug.create, Drug.create] }
+          Person.create! { |p| p.drugs += [Drug.create!, Drug.create!] }
         end
 
         it "updates the counter cache" do
@@ -389,7 +388,7 @@ describe Mongoid::Association::Referenced::CounterCache do
       context 'when #update is called on the object' do
 
         let(:person1) do
-          Person.create { |p| p.drugs += [Drug.create, Drug.create] }
+          Person.create! { |p| p.drugs += [Drug.create!, Drug.create!] }
         end
 
         let(:drug) do
@@ -397,7 +396,7 @@ describe Mongoid::Association::Referenced::CounterCache do
         end
 
         let(:person2) do
-          Person.create
+          Person.create!
         end
 
         before do
@@ -418,9 +417,9 @@ describe Mongoid::Association::Referenced::CounterCache do
 
         context 'when foreign_key differs from model name' do
 
-          let(:genre) { PostGenre.create }
+          let(:genre) { PostGenre.create! }
 
-          let(:post) { Post.create }
+          let(:post) { Post.create! }
 
           it 'updates correct counter cache' do
             post.update post_genre: genre
@@ -433,11 +432,11 @@ describe Mongoid::Association::Referenced::CounterCache do
     context "when parent is frozen" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:drug) do
-        person.drugs.create
+        person.drugs.create!
       end
 
       before do