mongoid 7.3.2 → 7.4.0

data/spec/mongoid/loggable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 

data/spec/mongoid/matcher/extract_attribute_spec.rb

@@ -1,12 +1,15 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
 describe 'Matcher.extract_attribute' do
   Dir[File.join(File.dirname(__FILE__), 'extract_attribute_data', '*.yml')].sort.each do |path|
     context File.basename(path) do
-      specs = YAML.load(File.read(path))
+      specs = if RUBY_VERSION.start_with?("2.5")
+                YAML.safe_load(File.read(path), [], [], true)
+              else
+                YAML.safe_load(File.read(path), aliases: true)
+              end
 
       specs.each do |spec|
         context spec['name'] do

data/spec/mongoid/persistable/creatable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -352,8 +351,8 @@ describe Mongoid::Persistable::Creatable do
       context "when building related documents" do
 
         before do
-          container.vehicles.build({}, Car).save
-          container.vehicles.build({}, Truck).save
+          container.vehicles.build({}, Car).save!
+          container.vehicles.build({}, Truck).save!
         end
 
         it "allows STI from the build call" do

data/spec/mongoid/persistable/deletable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -87,7 +86,7 @@ describe Mongoid::Persistable::Deletable do
       context "when the document has been saved" do
 
         before do
-          address.save
+          address.save!
           address.delete
         end
 
@@ -106,11 +105,11 @@ describe Mongoid::Persistable::Deletable do
       context "when the document has been saved" do
 
         let(:address) do
-          person.addresses.create(street: "Bond Street")
+          person.addresses.create!(street: "Bond Street")
         end
 
         let(:location) do
-          address.locations.create(name: "Home")
+          address.locations.create!(name: "Home")
         end
 
         let(:from_db) do
@@ -134,19 +133,19 @@ describe Mongoid::Persistable::Deletable do
     context "when deleting subclasses" do
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       context "when deleting a single document" do
@@ -198,19 +197,19 @@ describe Mongoid::Persistable::Deletable do
       end
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       before do
@@ -242,19 +241,19 @@ describe Mongoid::Persistable::Deletable do
       end
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       before do
@@ -358,7 +357,7 @@ describe Mongoid::Persistable::Deletable do
   describe "#delete_all" do
 
     let!(:person) do
-      Person.create(title: "sir")
+      Person.create!(title: "sir")
     end
 
     context "when no conditions are provided" do
@@ -379,7 +378,7 @@ describe Mongoid::Persistable::Deletable do
     context "when conditions are provided" do
 
       let!(:person_two) do
-        Person.create
+        Person.create!
       end
 
       context "when no conditions attribute provided" do
@@ -415,7 +414,7 @@ describe Mongoid::Persistable::Deletable do
       context 'when the write concern is unacknowledged' do
 
         before do
-          Person.create(title: 'miss')
+          Person.create!(title: 'miss')
         end
 
         let!(:deleted) do

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -87,7 +86,7 @@ describe Mongoid::Persistable::Destroyable do
       context "when the document has been saved" do
 
         before do
-          address.save
+          address.save!
           address.destroy
         end
 
@@ -135,11 +134,11 @@ describe Mongoid::Persistable::Destroyable do
       context "when the document has been saved" do
 
         let(:address) do
-          person.addresses.create(street: "Bond Street")
+          person.addresses.create!(street: "Bond Street")
         end
 
         let(:location) do
-          address.locations.create(name: "Home")
+          address.locations.create!(name: "Home")
         end
 
         let(:from_db) do
@@ -250,7 +249,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when no validation callback returns false" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "returns true" do
@@ -261,7 +260,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when a validation callback returns false" do
 
       let(:album) do
-        Album.create
+        Album.create!
       end
 
       before do
@@ -283,7 +282,7 @@ describe Mongoid::Persistable::Destroyable do
   describe "#destroy_all" do
 
     let!(:person) do
-      Person.create(title: "sir")
+      Person.create!(title: "sir")
     end
 
     context "when no conditions are provided" do
@@ -304,7 +303,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when conditions are provided" do
 
       let!(:person_two) do
-        Person.create
+        Person.create!
       end
 
       context "when no conditions attribute provided" do
@@ -326,7 +325,7 @@ describe Mongoid::Persistable::Destroyable do
     context 'when the write concern is unacknowledged' do
 
       before do
-        Person.create(title: 'miss')
+        Person.create!(title: 'miss')
       end
 
       let!(:removed) do

data/spec/mongoid/persistable/incrementable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -45,7 +44,7 @@ describe Mongoid::Persistable::Incrementable do
       end
 
       let(:person) do
-        Person.create(age: 10, score: 100)
+        Person.create!(age: 10, score: 100)
       end
 
       context "when providing string fields" do
@@ -126,11 +125,11 @@ describe Mongoid::Persistable::Incrementable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "test", number: 10, no: 100)
+        person.addresses.create!(street: "test", number: 10, no: 100)
       end
 
       context "when providing string fields" do
@@ -190,19 +189,19 @@ describe Mongoid::Persistable::Incrementable do
       end
 
       let(:survey) do
-        Survey.create
+        Survey.create!
       end
 
       let(:question) do
-        survey.questions.create(content: 'foo')
+        survey.questions.create!(content: 'foo')
       end
 
       let!(:first_answer) do
-        question.answers.create(position: 99)
+        question.answers.create!(position: 99)
       end
 
       let!(:second_answer) do
-        question.answers.create(position: 1)
+        question.answers.create!(position: 1)
       end
 
       context "when providing string fields" do
@@ -228,7 +227,7 @@ describe Mongoid::Persistable::Incrementable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(age: 10, score: 100)
+        Person.create!(age: 10, score: 100)
       end
 
       it "marks a dirty change for the incremented fields" do

data/spec/mongoid/persistable/logical_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -45,7 +44,7 @@ describe Mongoid::Persistable::Logical do
       end
 
       let(:person) do
-        Person.create(age: 60, score: 60, inte: 60)
+        Person.create!(age: 60, score: 60, inte: 60)
       end
 
       context "when provided string fields" do
@@ -111,11 +110,11 @@ describe Mongoid::Persistable::Logical do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", number: 60, no: 60, house: 60)
+        person.addresses.create!(street: "t", number: 60, no: 60, house: 60)
       end
 
       context "when provided string fields" do
@@ -146,7 +145,7 @@ describe Mongoid::Persistable::Logical do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(age: 10, score: 100)
+        Person.create!(age: 10, score: 100)
       end
 
       it "marks a dirty change for the modified fields" do

data/spec/mongoid/persistable/poppable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -37,7 +36,7 @@ describe Mongoid::Persistable::Poppable do
       end
 
       let(:person) do
-        Person.create(array: [ 1, 2, 3, 4 ], aliases: [ "a", "b" ])
+        Person.create!(array: [ 1, 2, 3, 4 ], aliases: [ "a", "b" ])
       end
 
       context "when provided string fields" do
@@ -89,11 +88,11 @@ describe Mongoid::Persistable::Poppable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "test", services: [ 1, 2, 3, 4 ], aliases: [ "a", "b" ])
+        person.addresses.create!(street: "test", services: [ 1, 2, 3, 4 ], aliases: [ "a", "b" ])
       end
 
       context "when provided string fields" do
@@ -118,7 +117,7 @@ describe Mongoid::Persistable::Poppable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [1, 2, 3])
+        Person.create!(test_array: [1, 2, 3])
       end
 
       it "marks a dirty change for the popped fields" do

data/spec/mongoid/persistable/pullable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -37,7 +36,7 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -89,11 +88,11 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -118,7 +117,7 @@ describe Mongoid::Persistable::Pullable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 1, 2, 3 ])
       end
 
       it "marks a dirty change for the pulled fields" do
@@ -162,7 +161,7 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -216,11 +215,11 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -245,7 +244,7 @@ describe Mongoid::Persistable::Pullable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 1, 2, 3, 4 ])
+        Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
       end
 
       it "marks a dirty change for the pulled fields" do

data/spec/mongoid/persistable/pushable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -45,7 +44,7 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 2 ], array: [ 4, 5 ])
+        Person.create!(aliases: [ 1, 2 ], array: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -155,11 +154,11 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1 ], a: [ 4, 5 ])
+        person.addresses.create!(street: "t", services: [ 1 ], a: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -195,7 +194,7 @@ describe Mongoid::Persistable::Pushable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
       it "marks a dirty change for the modified fields" do
@@ -251,7 +250,7 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when provided string fields" do
@@ -311,11 +310,11 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1 ], a: [ 4, 5 ])
+        person.addresses.create!(street: "t", services: [ 1 ], a: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -340,7 +339,7 @@ describe Mongoid::Persistable::Pushable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
       it "marks a dirty change for the pushed fields" do

data/spec/mongoid/persistable/renamable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -57,7 +56,7 @@ describe Mongoid::Persistable::Renamable do
       end
 
       let(:person) do
-        Person.create(title: "sir", dob: date)
+        Person.create!(title: "sir", dob: date)
       end
 
       context "when provided symbol names" do
@@ -109,7 +108,7 @@ describe Mongoid::Persistable::Renamable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:name) do
@@ -138,7 +137,7 @@ describe Mongoid::Persistable::Renamable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       it "marks a dirty change for the renamed fields" do

data/spec/mongoid/persistable/savable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -8,7 +7,7 @@ describe Mongoid::Persistable::Savable do
   describe "#save" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:contextable_item) do
@@ -16,7 +15,7 @@ describe Mongoid::Persistable::Savable do
     end
 
     let(:persisted_contextable_item) do
-      ContextableItem.create(title: 'sir')
+      ContextableItem.create!(title: 'sir')
     end
 
     context "when skipping validation" do
@@ -47,7 +46,7 @@ describe Mongoid::Persistable::Savable do
       context "when saving document that is a belongs to child" do
 
         let(:account) do
-          Account.create
+          Account.create!(name: 'Foobar')
         end
 
         let(:alert) do
@@ -149,7 +148,7 @@ describe Mongoid::Persistable::Savable do
     context "when validation fails" do
 
       let(:address) do
-        person.addresses.create(city: "London")
+        person.addresses.create!(city: "London")
       end
 
       before do
@@ -166,7 +165,7 @@ describe Mongoid::Persistable::Savable do
       context "when performing modification and insert ops" do
 
         let(:owner) do
-          Owner.create(name: "Blah")
+          Owner.create!(name: "Blah")
         end
 
         let!(:birthday) do
@@ -229,7 +228,7 @@ describe Mongoid::Persistable::Savable do
         end
 
         let!(:person) do
-          Person.create(
+          Person.create!(
             title: "Blah",
             addresses: [ address ]
           )
@@ -457,7 +456,7 @@ describe Mongoid::Persistable::Savable do
     context "when the changed attribute is not writable" do
 
       before do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       let(:person) do
@@ -474,7 +473,7 @@ describe Mongoid::Persistable::Savable do
       context 'when the changed attribute is aliased' do
 
         before do
-          Person.create(at: Time.now)
+          Person.create!(at: Time.now)
         end
 
         let(:person) do
@@ -483,7 +482,7 @@ describe Mongoid::Persistable::Savable do
 
         it "saves the document" do
           person.aliased_timestamp = Time.now
-          expect(person.save(validate: false)).to be true
+          expect(person.save!(validate: false)).to be true
         end
       end
     end
@@ -495,21 +494,26 @@ describe Mongoid::Persistable::Savable do
     end
 
     context "when validation context exists" do
+
       context "on new document" do
+
         it "returns true" do
           contextable_item.title = "sir"
           expect(contextable_item.save(context: :in_context)).to be true
         end
+
         it "returns false" do
           expect(contextable_item.save(context: :in_context)).to be false
         end
       end
 
       context "on persisted document" do
+
         it "returns true" do
           persisted_contextable_item.title = "lady"
           expect(persisted_contextable_item.save(context: :in_context)).to be true
         end
+
         it "returns false" do
           persisted_contextable_item.title = nil
           expect(persisted_contextable_item.save(context: :in_context)).to be false
@@ -627,7 +631,7 @@ describe Mongoid::Persistable::Savable do
     context "when the document has associations" do
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:writer) do