mongoid 7.1.1 → 8.1.0

data/spec/mongoid/contextual/atomic_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -8,15 +7,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -77,7 +76,8 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let(:criteria) do
         Band.where(members: [ "DAVE" ]).collation(locale: 'en_US', strength: 2)
@@ -104,15 +104,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_each_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -173,7 +173,8 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let(:criteria) do
         Band.where(members: [ "DAVE" ]).collation(locale: 'en_US', strength: 2)
@@ -200,7 +201,7 @@ describe Mongoid::Contextual::Atomic do
   describe "#bit" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let(:criteria) do
@@ -244,10 +245,11 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ], likes: 60)
+        Band.create!(members: [ "Dave" ], likes: 60)
       end
 
       let(:criteria) do
@@ -271,15 +273,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#inc" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let!(:beatles) do
-      Band.create(years: 2)
+      Band.create!(years: 2)
     end
 
     let(:criteria) do
@@ -323,10 +325,11 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -350,11 +353,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pop" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Martin" ])
+      Band.create!(members: [ "Dave", "Martin" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -395,10 +398,11 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -422,11 +426,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pull" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Alan" ])
+      Band.create!(members: [ "Dave", "Alan" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -449,10 +453,11 @@ describe Mongoid::Contextual::Atomic do
       expect(smiths.reload.members).to be_nil
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -478,11 +483,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -506,10 +511,11 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let(:criteria) do
@@ -535,11 +541,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -563,14 +569,15 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -600,11 +607,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -628,14 +635,15 @@ describe Mongoid::Contextual::Atomic do
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -661,11 +669,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -677,26 +685,27 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -708,15 +717,15 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
   end
@@ -724,11 +733,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#set" do
 
     let!(:depeche_mode) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -743,12 +752,25 @@ describe Mongoid::Contextual::Atomic do
       context.set(name: "Recoil")
     end
 
-    it "sets existing fields" do
-      expect(depeche_mode.reload.name).to eq("Recoil")
+    shared_examples 'writes as expected' do
+      it "sets existing fields" do
+        expect(depeche_mode.reload.name).to eq("Recoil")
+      end
+
+      it "sets non existent fields" do
+        expect(smiths.reload.name).to eq("Recoil")
+      end
     end
 
-    it "sets non existent fields" do
-      expect(smiths.reload.name).to eq("Recoil")
+    include_examples 'writes as expected'
+
+    context 'when fields being set have been projected out' do
+
+      let(:criteria) do
+        Band.only(:genres)
+      end
+
+      include_examples 'writes as expected'
     end
   end
 
@@ -757,11 +779,11 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting a single field" do
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -778,27 +800,28 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name)
         end
 
-        it "unsets the first existing field" do
-          expect(depeche_mode.reload.name).to be_nil
-        end
-
-        it "unsets the last existing field" do
-          expect(new_order.reload.name).to be_nil
+        it "unsets the fields from all documents" do
+          depeche_mode.reload
+          new_order.reload
+          expect(depeche_mode.name).to be_nil
+          expect(depeche_mode.years).to_not be_nil
+          expect(new_order.name).to be_nil
+          expect(new_order.years).to_not be_nil
         end
       end
 
       context "when the field is aliased" do
-
         before do
           context.unset(:years)
         end
 
-        it "unsets the first existing field" do
-          expect(depeche_mode.reload.years).to be_nil
-        end
-
-        it "unsets the last existing field" do
-          expect(new_order.reload.years).to be_nil
+        it "unsets the fields from all documents" do
+          depeche_mode.reload
+          new_order.reload
+          expect(depeche_mode.name).to_not be_nil
+          expect(depeche_mode.years).to be_nil
+          expect(new_order.name).to_not be_nil
+          expect(new_order.years).to be_nil
         end
       end
     end
@@ -806,7 +829,8 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting multiple fields" do
 
       let!(:new_order) do
-        Band.create(name: "New Order", genres: [ "electro", "dub" ], years: 10)
+        Band.create!(name: "New Order", genres: %w[electro dub], years: 10,
+          likes: 200, rating: 4.3, origin: 'Space')
       end
 
       let(:criteria) do
@@ -823,12 +847,13 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name, :genres)
         end
 
-        it "unsets name field" do
-          expect(new_order.reload.name).to be_nil
-        end
-
-        it "unsets genres field" do
-          expect(new_order.reload.genres).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to be_nil
+          expect(new_order.years).to_not be_nil
+          expect(new_order.likes).to_not be_nil
+          expect(new_order.rating).to_not be_nil
         end
       end
 
@@ -838,24 +863,59 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name, :years)
         end
 
-        it "unsets the unaliased field" do
-          expect(new_order.reload.name).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to_not be_nil
+          expect(new_order.rating).to_not be_nil
+        end
+      end
+
+      context "when using Hash arguments" do
+
+        before do
+          context.unset({ years: true, likes: "" }, { rating: false, origin: nil })
+        end
+
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to_not be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to be_nil
+          expect(new_order.rating).to be_nil
+          expect(new_order.origin).to be_nil
+        end
+      end
+
+      context "when mixing argument types" do
+
+        before do
+          context.unset(:name, [:years], { likes: "" }, { rating: false })
         end
 
-        it "unsets the aliased field" do
-          expect(new_order.reload.years).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to be_nil
+          expect(new_order.rating).to be_nil
         end
       end
     end
 
-    context 'when the criteria has a collation', if: collation_supported? do
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -871,7 +931,9 @@ describe Mongoid::Contextual::Atomic do
       end
 
       it "unsets the unaliased field" do
-        expect(depeche_mode.reload.name).to be_nil
+        depeche_mode.reload
+        expect(depeche_mode.name).to be_nil
+        expect(depeche_mode.years).to_not be_nil
       end
     end
   end

data/spec/mongoid/contextual/geo_near_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -17,11 +16,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when results are returned" do
@@ -49,8 +48,17 @@ describe Mongoid::Contextual::GeoNear do
         described_class.new(collection, criteria, [ 52, 13 ])
       end
 
-      it "returns 0.0" do
-        expect(geo_near.average_distance).to be_nil
+      let(:expected_value) do
+        if ClusterConfig.instance.fcv_ish == '4.0' && ClusterConfig.instance.topology == :sharded
+          # https://jira.mongodb.org/browse/SERVER-50074
+          0.0
+        else
+          nil
+        end
+      end
+
+      it "is nil except for 4.0 sharded when it is 0" do
+        expect(geo_near.average_distance).to eq expected_value
       end
     end
   end
@@ -66,11 +74,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when no options are provided" do
@@ -130,7 +138,7 @@ describe Mongoid::Contextual::GeoNear do
       end
     end
 
-    context "when spcifying spherical" do
+    context "when specifying spherical" do
 
       let(:criteria) do
         Bar.all
@@ -203,11 +211,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:geo_near) do
@@ -248,11 +256,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:criteria) do
@@ -283,11 +291,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when results are returned" do
@@ -332,11 +340,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Pub.create(location: [ 52.30, 13.25 ])
+      Pub.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Pub.create(location: [ 52.30, 13.35 ])
+      Pub.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when results are returned" do
@@ -367,11 +375,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:criteria) do
@@ -422,11 +430,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:criteria) do