mongoid 7.1.1 → 8.1.0

data/spec/mongoid/persistable/pullable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -37,7 +36,7 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -89,11 +88,11 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -118,7 +117,7 @@ describe Mongoid::Persistable::Pullable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 1, 2, 3 ])
       end
 
       it "marks a dirty change for the pulled fields" do
@@ -128,6 +127,42 @@ describe Mongoid::Persistable::Pullable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 1, 2, 3 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.pull(test_array: 1)
+          expect(person.test_array).to eq([ 2, 3 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.pull(test_array: 1)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 
   describe "#pull_all" do
@@ -162,7 +197,7 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -216,11 +251,11 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
       context "when providing string keys" do
@@ -245,7 +280,7 @@ describe Mongoid::Persistable::Pullable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 1, 2, 3, 4 ])
+        Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
       end
 
       it "marks a dirty change for the pulled fields" do
@@ -255,5 +290,41 @@ describe Mongoid::Persistable::Pullable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.pull_all(test_array: [ 1, 2 ])
+          expect(person.test_array).to eq([ 3, 4 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.pull_all(test_array: [ 1, 2 ])
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/pushable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -45,7 +44,7 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 2 ], array: [ 4, 5 ])
+        Person.create!(aliases: [ 1, 2 ], array: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -155,11 +154,11 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1 ], a: [ 4, 5 ])
+        person.addresses.create!(street: "t", services: [ 1 ], a: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -195,7 +194,7 @@ describe Mongoid::Persistable::Pushable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
       it "marks a dirty change for the modified fields" do
@@ -205,6 +204,42 @@ describe Mongoid::Persistable::Pushable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 2, 3 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.add_to_set(test_array: [ 1, 4 ])
+          expect(person.test_array).to eq([ 1, 2, 3, 4 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.add_to_set(test_array: [ 1, 4 ])
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 
   describe "#push" do
@@ -251,7 +286,7 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create(aliases: [ 1, 2, 3 ], array: [ 4, 5, 6 ])
+        Person.create!(aliases: [ 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
       context "when provided string fields" do
@@ -311,11 +346,11 @@ describe Mongoid::Persistable::Pushable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t", services: [ 1 ], a: [ 4, 5 ])
+        person.addresses.create!(street: "t", services: [ 1 ], a: [ 4, 5 ])
       end
 
       context "when provided string fields" do
@@ -340,7 +375,7 @@ describe Mongoid::Persistable::Pushable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(test_array: [ 1, 2, 3 ])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
       it "marks a dirty change for the pushed fields" do
@@ -350,5 +385,41 @@ describe Mongoid::Persistable::Pushable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(test_array: [ 1, 2, 3 ])
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.push(test_array: [ 1, 4 ])
+          expect(person.test_array).to eq([ 1, 2, 3, 1, 4 ])
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.push(test_array: [ 1, 4 ])
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/renamable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -57,7 +56,7 @@ describe Mongoid::Persistable::Renamable do
       end
 
       let(:person) do
-        Person.create(title: "sir", dob: date)
+        Person.create!(title: "sir", dob: date)
       end
 
       context "when provided symbol names" do
@@ -109,7 +108,7 @@ describe Mongoid::Persistable::Renamable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:name) do
@@ -138,7 +137,7 @@ describe Mongoid::Persistable::Renamable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       it "marks a dirty change for the renamed fields" do
@@ -148,5 +147,41 @@ describe Mongoid::Persistable::Renamable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(title: "sir")
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "test_array" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.rename title: :salutation
+          expect(person.reload.salutation).to eq("sir")
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.rename(title: :salutation)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end