mongoid 7.1.1 → 8.1.0

data/spec/integration/associations/embeds_many_spec.rb

@@ -0,0 +1,219 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'embeds_many associations' do
+
+  context 're-associating the same object' do
+    context 'with dependent: destroy' do
+      let(:canvas) do
+        Canvas.create!(shapes: [Shape.new])
+      end
+
+      let!(:shape) { canvas.shapes.first }
+
+      it 'does not destroy the dependent object' do
+        canvas.shapes = [shape]
+        canvas.save!
+        canvas.reload
+        canvas.shapes.should == [shape]
+      end
+    end
+  end
+
+  context 'clearing association when parent is not saved' do
+    let!(:parent) { Canvas.create!(shapes: [Shape.new]) }
+
+    let(:unsaved_parent) { Canvas.new(id: parent.id, shapes: [Shape.new]) }
+
+    context "using #clear" do
+      it 'deletes the target from the database' do
+        unsaved_parent.shapes.clear
+
+        unsaved_parent.shapes.should be_empty
+
+        unsaved_parent.new_record?.should be true
+        parent.reload
+        parent.shapes.should be_empty
+      end
+    end
+
+    shared_examples 'does not delete the target from the database' do
+      it 'does not delete the target from the database' do
+        unsaved_parent.shapes.should be_empty
+
+        unsaved_parent.new_record?.should be true
+        parent.reload
+        parent.shapes.length.should == 1
+      end
+    end
+
+    context "using #delete_all" do
+      before do
+        unsaved_parent.shapes.delete_all
+      end
+
+      include_examples 'does not delete the target from the database'
+    end
+
+    context "using #destroy_all" do
+      before do
+        unsaved_parent.shapes.destroy_all
+      end
+
+      include_examples 'does not delete the target from the database'
+    end
+  end
+
+  context 'assigning attributes to the same association' do
+    context 'setting then clearing' do
+      let(:canvas) do
+        Canvas.create!(shapes: [Shape.new])
+      end
+
+      shared_examples 'persists correctly' do
+        it 'persists correctly' do
+          canvas.shapes.should be_empty
+          _canvas = Canvas.find(canvas.id)
+          _canvas.shapes.should be_empty
+        end
+      end
+
+      context 'via assignment operator' do
+        before do
+          canvas.shapes = [Shape.new, Shape.new]
+          canvas.shapes = []
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+
+      context 'via attributes=' do
+        before do
+          canvas.attributes = {shapes: [Shape.new, Shape.new]}
+          canvas.attributes = {shapes: []}
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+
+      context 'via assign_attributes' do
+        before do
+          canvas.assign_attributes(shapes: [Shape.new, Shape.new])
+          canvas.assign_attributes(shapes: [])
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+    end
+
+    context 'clearing then setting' do
+      let(:canvas) do
+        Canvas.create!(shapes: [Shape.new])
+      end
+
+      shared_examples 'persists correctly' do
+        it 'persists correctly' do
+          canvas.shapes.length.should eq 2
+          _canvas = Canvas.find(canvas.id)
+          _canvas.shapes.length.should eq 2
+        end
+      end
+
+      context 'via assignment operator' do
+        before do
+          canvas.shapes = []
+          canvas.shapes = [Shape.new, Shape.new]
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+
+      context 'via attributes=' do
+        before do
+          canvas.attributes = {shapes: []}
+          canvas.attributes = {shapes: [Shape.new, Shape.new]}
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+
+      context 'via assign_attributes' do
+        before do
+          canvas.assign_attributes(shapes: [])
+          canvas.assign_attributes(shapes: [Shape.new, Shape.new])
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+    end
+
+    context 'updating a child then clearing' do
+      let(:canvas) do
+        Canvas.create!(shapes: [Shape.new])
+      end
+
+      shared_examples 'persists correctly' do
+        it 'persists correctly' do
+          canvas.shapes.should be_empty
+          _canvas = Canvas.find(canvas.id)
+          _canvas.shapes.should be_empty
+        end
+      end
+
+      context 'via assignment operator' do
+        before do
+          # Mongoid uses the new value of `x` in the $pullAll query,
+          # which doesn't match the document that is in the database,
+          # resulting in the empty array assignment not taking effect.
+          canvas.shapes.first.x = 1
+          canvas.shapes = []
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+
+      context 'via attributes=' do
+        before do
+          canvas.shapes.first.x = 1
+          canvas.attributes = {shapes: []}
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+
+      context 'via assign_attributes' do
+        before do
+          canvas.shapes.first.x = 1
+          canvas.assign_attributes(shapes: [])
+          canvas.save!
+        end
+
+        include_examples 'persists correctly'
+      end
+    end
+  end
+
+  context 'when an anonymous class defines an embeds_many association' do
+    let(:klass) do
+      Class.new do
+        include Mongoid::Document
+        embeds_many :addresses
+      end
+    end
+
+    it 'loads the association correctly' do
+      expect { klass }.to_not raise_error
+      expect { klass.new.addresses }.to_not raise_error
+      expect(klass.new.addresses.build).to be_a Address
+    end
+  end
+end

data/spec/integration/associations/embeds_one_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'embeds_one associations' do
+
+  context 're-associating the same object' do
+    context 'with dependent: destroy' do
+      let(:canvas) do
+        Canvas.create!(palette: Palette.new)
+      end
+
+      let!(:palette) { canvas.palette }
+
+      it 'does not destroy the dependent object' do
+        canvas.palette = canvas.palette
+        canvas.save!
+        canvas.reload
+        canvas.palette.should == palette
+      end
+    end
+  end
+
+  context 'when an anonymous class defines an embeds_one association' do
+    let(:klass) do
+      Class.new do
+        include Mongoid::Document
+        embeds_one :address
+      end
+    end
+
+    it 'loads the association correctly' do
+      expect { klass }.to_not raise_error
+      expect { klass.new.address }.to_not raise_error
+      instance = klass.new
+      address = Address.new
+      instance.address = address
+      expect(instance.address).to eq address
+    end
+  end
+end

data/spec/integration/associations/foreign_key_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 require_relative './foreign_key_spec_models'
@@ -28,6 +27,15 @@ describe 'Association foreign key configuration' do
       expect(email.company.id).to eq(company.id)
     end
 
+    it "has the correct criteria" do
+      company = ForeignKeySpec::Company.create!(c: "3")
+      email = ForeignKeySpec::Email.create!(company: company)
+
+      criteria = ForeignKeySpec::Email.where(company: company)
+
+      expect(criteria.selector).to eq({ "c_ref" => "3" })
+    end
+
     context 'with default scope' do
       context 'using default scope' do
         it 'looks up child' do

data/spec/integration/associations/foreign_key_spec_models.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 module ForeignKeySpec
   class Company

data/spec/integration/associations/has_and_belongs_to_many_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'has_and_belongs_to_many associations' do
+
+  context 'when an anonymous class defines a has_and_belongs_to_many association' do
+    let(:klass) do
+      Class.new do
+        include Mongoid::Document
+        has_and_belongs_to_many :movies, inverse_of: nil
+      end
+    end
+
+    it 'loads the association correctly' do
+      expect { klass }.to_not raise_error
+      expect { klass.new.movies }.to_not raise_error
+      expect(klass.new.movies.build).to be_a Movie
+    end
+  end
+end

data/spec/integration/associations/has_many_spec.rb

@@ -0,0 +1,128 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'mongoid/association/referenced/has_many_models'
+
+describe 'has_many associations' do
+  context 'destroying parent in transaction with dependent child' do
+    require_transaction_support
+
+    let(:company) { HmmCompany.create! }
+    let(:address) { HmmAddress.create!(company: company) }
+
+    before do
+      Company.delete_all
+      Address.delete_all
+    end
+
+    context 'dependent: :destroy' do
+      before do
+        HmmCompany.class_eval do
+          has_one :address, class_name: 'HmmAddress', dependent: :destroy
+        end
+      end
+
+      it 'destroys' do
+        address
+
+        HmmCompany.count.should == 1
+        HmmAddress.count.should == 1
+
+        company.with_session do |session|
+          session.with_transaction do
+            company.destroy!
+          end
+        end
+
+        HmmCompany.count.should == 0
+        HmmAddress.count.should == 0
+      end
+    end
+
+    context 'dependent: :restrict_with_error' do
+      before do
+        HmmCompany.class_eval do
+          has_one :address, class_name: 'HmmAddress', dependent: :restrict_with_error
+        end
+      end
+
+      it 'destroys' do
+        address
+
+        HmmCompany.count.should == 1
+        HmmAddress.count.should == 1
+
+        lambda do
+          company.with_session do |session|
+            session.with_transaction do
+              company.destroy!
+            end
+          end
+        end.should raise_error(Mongoid::Errors::DocumentNotDestroyed)
+
+        HmmCompany.count.should == 1
+        HmmAddress.count.should == 1
+      end
+    end
+  end
+
+  context 'when child does not have parent association' do
+    context 'Child.new' do
+      it 'creates a child instance' do
+        HmmBusSeat.new.should be_a(HmmBusSeat)
+      end
+    end
+
+    context 'assignment to child in parent' do
+      let(:parent) { HmmBus.new }
+
+      it 'raises InverseNotFound' do
+        lambda do
+          parent.seats << HmmBusSeat.new
+        end.should raise_error(Mongoid::Errors::InverseNotFound)
+      end
+    end
+  end
+
+  context 're-associating the same object' do
+    context 'with dependent: destroy' do
+      let(:wiki_page) do
+        WikiPage.create!
+      end
+
+      let!(:comment) do
+        Comment.create!(wiki_page: wiki_page, title: 'hi') do
+          wiki_page.reload
+        end
+      end
+
+      it 'does not destroy the dependent object' do
+        wiki_page.comments.should == [comment]
+        wiki_page.comments = [comment]
+        wiki_page.save!
+        wiki_page.reload
+        wiki_page.comments.should == [comment]
+      end
+    end
+
+    context 'without dependent: destroy' do
+      let(:series) do
+        Series.create!
+      end
+
+      let!(:book) do
+        Book.create!(series: series).tap do
+          series.reload
+        end
+      end
+
+      it 'does not destroy the dependent object' do
+        series.books.should == [book]
+        series.books = [book]
+        series.save!
+        series.reload
+        series.books.should == [book]
+      end
+    end
+  end
+end

data/spec/integration/associations/has_one_spec.rb

@@ -0,0 +1,272 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'mongoid/association/referenced/has_one_models'
+
+describe 'has_one associations' do
+  context 'destroying parent in transaction with dependent child' do
+    require_transaction_support
+
+    let(:college) { HomCollege.create! }
+    let(:address) { HomAddress.create!(college: college) }
+
+    before do
+      HomCollege.delete_all
+      HomAddress.delete_all
+    end
+
+    context 'dependent: :destroy' do
+      before do
+        HomCollege.class_eval do
+          has_one :address, class_name: 'HomAddress', dependent: :destroy
+        end
+      end
+
+      it 'destroys' do
+        address
+
+        HomCollege.count.should == 1
+        HomAddress.count.should == 1
+
+        HomCollege.with_session do |session|
+          session.with_transaction do
+            college.destroy!
+          end
+        end
+
+        HomCollege.count.should == 0
+        HomAddress.count.should == 0
+      end
+    end
+
+    context 'dependent: :restrict_with_error' do
+      before do
+        HomCollege.class_eval do
+          has_one :address, class_name: 'HomAddress', dependent: :restrict_with_error
+        end
+      end
+
+      it 'does not destroy' do
+        address
+
+        HomCollege.count.should == 1
+        HomAddress.count.should == 1
+
+        lambda do
+          HomCollege.with_session do |session|
+            session.with_transaction do
+              college.destroy!
+            end
+          end
+        end.should raise_error(Mongoid::Errors::DocumentNotDestroyed)
+
+        HomCollege.count.should == 1
+        HomAddress.count.should == 1
+      end
+    end
+  end
+
+  context 'when calling methods on target' do
+    let(:parent) do
+      HomCollege.create!.tap do |college|
+        HomAccreditation.create!(college: college)
+      end
+    end
+
+    shared_examples 'delegates to the field' do |reloaded: false|
+      context 'non-conflicting field name' do
+        it 'delegates to the field' do
+          parent.accreditation.price.should == 42
+        end
+
+        context 'using send' do
+          it 'delegates to the field' do
+            parent.accreditation.send(:price).should == 42
+          end
+        end
+      end
+
+      context 'field name that conflicts with Kernel' do
+        it 'delegates to the field' do
+          parent.accreditation.format.should == 'fmt'
+        end
+
+        context 'using send' do
+          it 'delegates to the field' do
+            if reloaded
+              pending 'MONGOID-5018'
+            end
+
+            parent.accreditation.send(:format).should == 'fmt'
+          end
+        end
+      end
+    end
+
+    include_examples 'delegates to the field'
+
+    context 'after reloading parent' do
+      before do
+        parent.reload
+      end
+
+      include_examples 'delegates to the field', reloaded: true
+    end
+  end
+
+  context 'when child does not have parent association' do
+    context 'Child.new' do
+      it 'creates a child instance' do
+        HomBusDriver.new.should be_a(HomBusDriver)
+      end
+    end
+
+    context 'assignment to child in parent' do
+      let(:parent) { HomBus.new }
+
+      it 'raises InverseNotFound' do
+        lambda do
+          parent.driver = HomBusDriver.new
+        end.should raise_error(Mongoid::Errors::InverseNotFound)
+      end
+    end
+  end
+
+  context 're-associating the same object' do
+    context 'with dependent: destroy' do
+      let(:person) do
+        Person.create!
+      end
+
+      let!(:game) do
+        Game.create!(person: person) do
+          person.reload
+        end
+      end
+
+      it 'does not destroy the dependent object' do
+        person.game.should == game
+        person.game = person.game
+        person.save!
+        person.reload
+        person.game.should == game
+      end
+    end
+
+    context 'without dependent: destroy' do
+      let(:person) do
+        Person.create!
+      end
+
+      let!(:account) do
+        Account.create!(person: person, name: 'foo').tap do
+          person.reload
+        end
+      end
+
+      it 'does not destroy the dependent object' do
+        person.account.should == account
+        person.account = person.account
+        person.save!
+        person.reload
+        person.account.should == account
+      end
+    end
+  end
+
+  context "when assigning to a has_one" do
+    let(:post) { HomPost.create! }
+    let(:comment1) { HomComment.create!(content: "Comment 1") }
+
+    context "when assigning the same value" do
+      let(:comment2) { HomComment.create! }
+
+      it "persists it correctly" do
+        post.comment = comment1
+        post.reload
+        expect(post.comment).to eq(comment1)
+
+        post.comment = comment1
+        post.reload
+        expect(post.comment).to eq(comment1)
+      end
+    end
+
+    context "when assigning two values with the same _id" do
+      let(:comment2) { HomComment.new(id: comment1.id) }
+
+      it "raises a duplicate key error" do
+        post.comment = comment1
+        expect do
+          post.comment = comment2
+        end.to raise_error(Mongo::Error::OperationFailure, /duplicate key/)
+      end
+    end
+
+    context "when duping the object and changing attributes" do
+      let(:comment2) { comment1.dup }
+
+      before do
+        comment2.content = "Comment 2"
+
+        post.comment = comment1
+        post.reload
+      end
+
+      it "updates the attributes correctly" do
+        post.comment = comment2
+        post.reload
+
+        expect(post.comment).to eq(comment2)
+        expect(post.comment.content).to eq(comment2.content)
+      end
+    end
+
+    context "when explicitly setting the foreign key" do
+      let(:comment2) { HomComment.new(post_id: post.id, content: "2") }
+
+      it "persists the new comment" do
+        post.comment = comment1
+        post.reload
+
+        post.comment = comment2
+        post.reload
+
+        expect(post.comment).to eq(comment2)
+        expect(post.comment.content).to eq(comment2.content)
+      end
+    end
+
+    context "when reassigning the same value" do
+      let(:comment2) { HomComment.create!(content: "Comment 2") }
+
+      it "persists it correctly" do
+        post.comment = comment1
+        post.reload
+        expect(post.comment).to eq(comment1)
+
+        post.comment = comment2
+        post.reload
+        expect(post.comment).to eq(comment2)
+
+        post.comment = comment1
+        post.reload
+        expect(post.comment).to eq(nil)
+      end
+    end
+  end
+
+  context "when overwriting an association" do
+    let(:post1) { HomPost.create!(title: "post 1") }
+    let(:post2) { HomPost.create!(title: "post 2") }
+    let(:comment) { HomComment.create(post: post1) }
+
+    it "does not overwrite the original value" do
+      pending "MONGOID-3999"
+      p1 = comment.post
+      expect(p1.title).to eq("post 1")
+      comment.post = post2
+      expect(p1.title).to eq("post 1")
+    end
+  end
+end