mongoid 7.1.1 → 8.1.0

data/spec/integration/criteria/alias_query_spec.rb

@@ -0,0 +1,161 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'distinct on aliased fields' do
+
+  let(:client) { Person.collection.client }
+
+  let(:subscriber) do
+    Mrss::EventSubscriber.new
+  end
+
+  before do
+    client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+  end
+
+  after do
+    client.unsubscribe(Mongo::Monitoring::COMMAND, subscriber)
+  end
+
+  let(:event) do
+    subscriber.single_command_started_event('distinct')
+  end
+
+  let(:command) { event.command }
+
+  context 'when broken_alias_handling is not set' do
+    config_override :broken_alias_handling, false
+
+    context 'top level field' do
+      let(:query) do
+        Person.distinct(:test)
+      end
+
+      it 'expands the alias' do
+        query
+
+        command['key'].should == 't'
+      end
+    end
+
+    context 'embedded document field' do
+      let(:query) do
+        Person.distinct('phone_numbers.extension')
+      end
+
+      it 'expands the alias' do
+        query
+
+        command['key'].should == 'phone_numbers.ext'
+      end
+    end
+  end
+
+  context 'when broken_alias_handling is set' do
+    config_override :broken_alias_handling, true
+
+    context 'top level field' do
+      let(:query) do
+        Person.distinct(:test)
+      end
+
+      it 'expands the alias' do
+        query
+
+        command['key'].should == 't'
+      end
+    end
+
+    context 'embedded document field' do
+      let(:query) do
+        Person.distinct('phone_numbers.extension')
+      end
+
+      it 'deos not expands the alias' do
+        query
+
+        command['key'].should == 'phone_numbers.extension'
+      end
+    end
+  end
+end
+
+describe 'pluck on aliased fields' do
+
+  let(:client) { Person.collection.client }
+
+  let(:subscriber) do
+    Mrss::EventSubscriber.new
+  end
+
+  before do
+    client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+  end
+
+  after do
+    client.unsubscribe(Mongo::Monitoring::COMMAND, subscriber)
+  end
+
+  let(:event) do
+    subscriber.single_command_started_event('find')
+  end
+
+  let(:command) { event.command }
+
+  context 'when broken_alias_handling is not set' do
+    config_override :broken_alias_handling, false
+
+    context 'top level field' do
+      let(:query) do
+        Person.pluck(:test)
+      end
+
+      it 'expands the alias' do
+        query
+
+        command['projection'].should == {'t' => true}
+      end
+    end
+
+    context 'embedded document field' do
+      let(:query) do
+        Person.pluck('phone_numbers.extension')
+      end
+
+      it 'expands the alias' do
+        query
+
+        command['projection'].should == {'phone_numbers.ext' => true}
+      end
+    end
+  end
+
+  context 'when broken_alias_handling is set' do
+    config_override :broken_alias_handling, true
+
+    context 'top level field' do
+      let(:query) do
+        Person.pluck(:test)
+      end
+
+      it 'expands the alias' do
+        query
+
+        command['projection'].should == {'t' => true}
+      end
+    end
+
+    context 'embedded document field' do
+      let(:query) do
+        Person.pluck('phone_numbers.extension')
+      end
+
+      it 'does not expand the alias' do
+        query
+
+        command['projection'].should == {'phone_numbers.extension' => true}
+      end
+    end
+  end
+end

data/spec/integration/criteria/date_field_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Queries on Date fields' do
+  let(:query) do
+    Band.where(founded: arg)
+  end
+
+  let(:selector) { query.selector }
+
+  shared_examples 'converts to beginning of day in UTC' do
+    it 'converts to beginning of day in UTC' do
+      selector['founded'].should == Time.utc(arg.year, arg.month, arg.day)
+    end
+  end
+
+  context 'using Time' do
+    let(:arg) do
+      Time.now.freeze
+    end
+
+    it_behaves_like 'converts to beginning of day in UTC'
+  end
+
+  context 'using TimeWithZone' do
+    let(:time_zone_name) { 'Pacific Time (US & Canada)' }
+    let(:arg) { Time.now.in_time_zone(time_zone_name).freeze }
+
+    it_behaves_like 'converts to beginning of day in UTC'
+  end
+
+  context 'using DateTime' do
+    let(:arg) do
+      DateTime.now.freeze
+    end
+
+    it_behaves_like 'converts to beginning of day in UTC'
+  end
+end

data/spec/integration/criteria/default_scope_spec.rb

@@ -18,4 +18,55 @@ describe 'Criteria and default scope' do
       sort_options.keys.should == %w(name status)
     end
   end
+
+  context 'default scope + logical operator' do
+
+    context 'logical operator applied to a criteria' do
+      let(:base) { Appointment.where }
+
+      it 'has default scope' do
+        base.selector.should == {'active' => true}
+      end
+
+      context '.or' do
+        let(:criteria) do
+          base.or(timed: true)
+        end
+
+        it 'adds new condition in parallel to default scope conditions' do
+          criteria.selector.should == {'$or' => [
+            {'active' => true},
+            {'timed' => true},
+          ]}
+        end
+      end
+
+      context '.any_of' do
+        let(:criteria) do
+          base.any_of(timed: true)
+        end
+
+        it 'maintains default scope conditions' do
+          criteria.selector.should == {'active' => true, 'timed' => true}
+        end
+      end
+    end
+
+    context 'logical operator called on the class' do
+      let(:base) { Appointment }
+
+      context '.or' do
+        let(:criteria) do
+          base.or(timed: true)
+        end
+
+        it 'adds new condition in parallel to default scope conditions' do
+          criteria.selector.should == {'$or' => [
+            {'active' => true},
+            {'timed' => true},
+          ]}
+        end
+      end
+    end
+  end
 end

data/spec/integration/criteria/logical_spec.rb

@@ -25,6 +25,36 @@ describe 'Criteria logical operations' do
       bands = Band.where(name: /Proj/).and(Band.where(name: /u/))
       expect(bands.to_a).to eq([sp])
     end
+
+    context "when broken_and feature flag is not set" do
+      config_override :broken_and, false
+
+      it 'combines existing `$and` clause in query and `where` condition' do
+        bands = Band.where(id: 1).and({year: {'$in' => [2020]}}, {year: {'$in' => [2021]}}).where(id: 2)
+        expect(bands.selector).to eq(
+          {
+            "_id"=>1,
+            "year"=>{"$in"=>[2020]},
+            "$and"=>[{"year"=>{"$in"=>[2021]}}, {"_id"=>2}]
+          }
+        )
+      end
+    end
+
+    context "when broken_and feature flag is set" do
+      config_override :broken_and, true
+
+      it 'combines existing `$and` clause in query and `where` condition' do
+        bands = Band.where(id: 1).and({year: {'$in' => [2020]}}, {year: {'$in' => [2021]}}).where(id: 2)
+        expect(bands.selector).to eq(
+          {
+            "_id"=>1,
+            "year"=>{"$in"=>[2020]},
+            "$and"=>[{"_id"=>2}]
+          }
+        )
+      end
+    end
   end
 
   describe 'or' do
@@ -47,6 +77,19 @@ describe 'Criteria logical operations' do
       bands = Band.where(name: /jecti/).or(Band.where(name: /ush/))
       expect(bands.order_by(name: 1).to_a).to eq([ap, im])
     end
+
+    context 'when using a symbol operator' do
+      context 'when field has a serializer' do
+        let!(:doc) { Dokument.create! }
+
+        it 'works' do
+          scope = Dokument.or(:created_at.lte => DateTime.now).sort(id: 1)
+          # input was converted from DateTime to Time
+          scope.criteria.selector['$or'].first['created_at']['$lte'].should be_a(Time)
+          scope.to_a.should == [doc]
+        end
+      end
+    end
   end
 
   describe 'not' do

data/spec/integration/criteria/range_spec.rb

@@ -0,0 +1,359 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Queries with Range criteria' do
+  let(:now_utc) { Time.utc(2020, 1, 1, 16, 0, 0, 0) }
+  let(:now_in_zone) { now_utc.in_time_zone('Asia/Tokyo') }
+  let(:today) { Date.new(2020, 1, 1) }
+
+  let(:labels) do
+    [ Label.new(age: 12), Label.new(age: 16) ]
+  end
+
+  let!(:band1) { Band.create!(likes: 0, rating: 0.9, founded: today, updated_at: now_utc) }
+  let!(:band2) { Band.create!(likes: 1, rating: 1.0, founded: today + 1.day, updated_at: now_utc + 1.days) }
+  let!(:band3) { Band.create!(likes: 2, rating: 2.9, founded: today + 2.days, updated_at: now_utc + 2.days) }
+  let!(:band4) { Band.create!(likes: 3, rating: 3.0, founded: today + 3.days, updated_at: now_utc + 3.days) }
+  let!(:band5) { Band.create!(likes: 4, rating: 3.1, founded: today + 4.days, updated_at: now_utc + 4.days, labels: labels) }
+
+  context 'Range<Integer> criteria vs Integer field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(likes: 1..3).to_a).to eq [band2, band3, band4]
+      expect(Band.where(likes: 1...3).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(likes: eval('1..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(likes: eval('..3')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(likes: eval('...3')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Integer> criteria vs Float field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(rating: 1..3).to_a).to eq [band2, band3, band4]
+      expect(Band.where(rating: 1...3).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(rating: eval('1..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(rating: eval('..3')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(rating: eval('...3')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Float> criteria vs Integer field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(likes: 0.95..3.05).to_a).to eq [band2, band3, band4]
+      expect(Band.where(likes: 0.95...3.0).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(likes: eval('0.95..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(likes: eval('..3.05')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(likes: eval('...3.0')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Float> criteria vs Float field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(rating: 0.95..3.05).to_a).to eq [band2, band3, band4]
+      expect(Band.where(rating: 0.95...3.0).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(rating: eval('0.95..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(rating: eval('..3.05')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(rating: eval('...3.0')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Time> criteria vs Time field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(updated_at: (now_utc + 1.day)..(now_utc + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(updated_at: (now_utc + 1.day)...(now_utc + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(updated_at: eval('(now_utc + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(updated_at: eval('..(now_utc + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(updated_at: eval('...(now_utc + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Time> criteria vs Date field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(founded: (now_utc + 1.day)..(now_utc + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(founded: (now_utc + 1.day)...(now_utc + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(founded: eval('(now_utc + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(founded: eval('..(now_utc + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(founded: eval('...(now_utc + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<ActiveSupport::TimeWithZone> criteria vs Time field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(updated_at: (now_in_zone + 1.day)..(now_in_zone + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(updated_at: (now_in_zone + 1.day)...(now_in_zone + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(updated_at: eval('(now_in_zone + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(updated_at: eval('..(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(updated_at: eval('...(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<ActiveSupport::TimeWithZone> criteria vs Date field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(founded: (now_in_zone + 1.day)..(now_in_zone + 3.days)).to_a).to eq [band3, band4, band5]
+      expect(Band.where(founded: (now_in_zone + 1.day)...(now_in_zone + 3.days)).to_a).to eq [band3, band4]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(founded: eval('(now_in_zone + 1.day)..')).to_a).to eq [band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(founded: eval('..(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3, band4, band5]
+        expect(Band.where(founded: eval('...(now_in_zone + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+      end
+    end
+  end
+
+  context 'Range<Date> criteria vs Date field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(founded: (today + 1.day)..(today + 3.days)).to_a).to eq [band2, band3, band4]
+      expect(Band.where(founded: (today + 1.day)...(today + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(founded: eval('(today + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(founded: eval('..(today + 3.days)')).to_a).to eq [band1, band2, band3, band4]
+        expect(Band.where(founded: eval('...(today + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Date> criteria vs Time field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where(updated_at: (today + 1.day)..(today + 3.days)).to_a).to eq [band2, band3]
+      expect(Band.where(updated_at: (today + 1.day)...(today + 3.days)).to_a).to eq [band2, band3]
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where(updated_at: eval('(today + 1.day)..')).to_a).to eq [band2, band3, band4, band5]
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where(updated_at: eval('..(today + 3.days)')).to_a).to eq [band1, band2, band3]
+        expect(Band.where(updated_at: eval('...(today + 3.days)')).to_a).to eq [band1, band2, band3]
+      end
+    end
+  end
+
+  context 'Range<Integer> criteria vs embedded Integer field' do
+
+    it 'returns objects within the range' do
+      expect(Band.where("labels.age" => 10..18).to_a).to eq [band5]
+      expect(Band.where("labels.age" => 13...16).to_a).to eq []
+    end
+
+    it "does not return objects out of range" do
+      expect(Band.where("labels.age" => 13..14).to_a).to eq []
+    end
+
+    context 'endless range' do
+      ruby_version_gte '2.6'
+
+      it 'returns all objects above the value' do
+        expect(Band.where("labels.age": eval('1..')).to_a).to eq [band5]
+      end
+
+      it 'does not return the objects under the value' do
+        expect(Band.where("labels.age": eval('100..')).to_a).to eq []
+      end
+    end
+
+    context 'beginless range' do
+      ruby_version_gte '2.7'
+
+      it 'returns all objects under the value' do
+        expect(Band.where("labels.age": eval('..16')).to_a).to eq [band5]
+      end
+      it 'does not return the objects above the value' do
+        expect(Band.where("labels.age": eval('...12')).to_a).to eq []
+      end
+    end
+  end
+
+  context 'Range<Integer> criteria vs Array<Integer>' do
+    let!(:band6) { Band.create!(genres: [12, 16]) }
+
+    it 'returns objects within the range' do
+      expect(Band.where("genres" => 10..18).to_a).to eq [band6]
+    end
+
+    it "does not return objects out of range" do
+      expect(Band.where("genres" => 13..14).to_a).to eq []
+    end
+  end
+
+  context 'Range<Integer> criteria vs aliased Array<Integer>' do
+    let!(:person) { Person.create!(array: [12, 16]) }
+
+    it 'returns objects within the range' do
+      expect(Person.where("array" => 10..18).to_a).to eq [person]
+    end
+
+    it "does not return objects out of range" do
+      expect(Person.where("array" => 13..14).to_a).to eq []
+    end
+  end
+
+  context 'Range<Integer> criteria vs Array<Hash<Symbol, Integer>>' do
+    let!(:band6) { Band.create!(genres: [{x: 12}, {x: 16}]) }
+
+    it 'returns objects within the range' do
+      expect(Band.where("genres.x" => 10..18).to_a).to eq [band6]
+    end
+
+    it "does not return objects out of range" do
+      expect(Band.where("genres.x" => 13..14).to_a).to eq []
+    end
+  end
+
+  context 'Range<Integer> criteria vs aliased/doubly embedded Integer' do
+    let!(:person) do
+      Person.create!(passport: Passport.new).tap do |b|
+        b.passport.passport_pages.create!(num_stamps: 12)
+        b.passport.passport_pages.create!(num_stamps: 16)
+      end
+    end
+
+    config_override :broken_alias_handling, false
+
+    it 'returns objects within the range' do
+      expect(Person.where("passport.passport_pages.num_stamps" => 10..18).to_a).to eq [person]
+    end
+
+    it "does not return objects out of range" do
+      expect(Person.where("passport.passport_pages.num_stamps" => 13..14).to_a).to eq []
+    end
+  end
+end