mongoid 7.1.1 → 8.1.0

data/spec/mongoid/attributes/nested_spec.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
+require_relative '../association/referenced/has_many_models'
+require_relative '../association/referenced/has_and_belongs_to_many_models'
+require_relative './nested_spec_models'
 
 describe Mongoid::Attributes::Nested do
 
@@ -192,7 +194,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       context "when adding existing document to a relation" do
-        let(:preference) { Preference.create(name: 'sample preference') }
+        let(:preference) { Preference.create!(name: 'sample preference') }
         let(:person) do
           Person.new(
             preferences_attributes: { 0 => { id: preference.id, name: preference.name } }
@@ -234,7 +236,7 @@ describe Mongoid::Attributes::Nested do
     end
   end
 
-  describe "##{name}_attributes=" do
+  describe "*_attributes=" do
 
     context "when the parent document is new" do
 
@@ -243,7 +245,7 @@ describe Mongoid::Attributes::Nested do
         context "when the parent document is persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -273,7 +275,7 @@ describe Mongoid::Attributes::Nested do
             context "when saving the parent" do
 
               before do
-                person.save
+                person.save!
                 person.reload
               end
 
@@ -375,7 +377,7 @@ describe Mongoid::Attributes::Nested do
             context "when all attributes are empty" do
 
               let(:product) do
-                Product.create(name: "testing")
+                Product.create!(name: "testing")
               end
 
               it "does not add the document" do
@@ -608,7 +610,7 @@ describe Mongoid::Attributes::Nested do
                       end
 
                       let(:owner) do
-                        PetOwner.create
+                        PetOwner.create!
                       end
 
                       let!(:pet) do
@@ -617,7 +619,7 @@ describe Mongoid::Attributes::Nested do
 
                       before do
                         owner.pet_attributes = { id: pet.id, _destroy: truth }
-                        owner.save
+                        owner.save!
                       end
 
                       it "destroys the existing document" do
@@ -1035,7 +1037,7 @@ describe Mongoid::Attributes::Nested do
         context "when the parent document is persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -1069,7 +1071,7 @@ describe Mongoid::Attributes::Nested do
             context "when saving the parent" do
 
               before do
-                person.save
+                person.save!
                 person.reload
               end
 
@@ -1185,7 +1187,7 @@ describe Mongoid::Attributes::Nested do
             context "when the parent is saved" do
 
               before do
-                band.save
+                band.save!
               end
 
               it "runs the first child create callbacks" do
@@ -1354,7 +1356,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.addresses_attributes =
                     { "foo" => { "id" => "test", "street" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Address with id\(s\)/)
               end
             end
           end
@@ -1377,7 +1379,7 @@ describe Mongoid::Attributes::Nested do
                   end
 
                   let!(:record) do
-                    band.records.create
+                    band.records.create!
                   end
 
                   let(:attributes) do
@@ -1415,17 +1417,17 @@ describe Mongoid::Attributes::Nested do
                   end
 
                   let!(:band) do
-                    Band.create
+                    Band.create!
                   end
 
                   let!(:record) do
-                    band.records.create
+                    band.records.create!
                   end
 
                   before do
                     band.records_attributes =
                       { "foo" => { "id" => record.id, "_destroy" => true }}
-                    band.save
+                    band.save!
                   end
 
                   it "deletes the child document" do
@@ -1450,7 +1452,7 @@ describe Mongoid::Attributes::Nested do
                   context "when the parent is persisted" do
 
                     let!(:persisted) do
-                      Person.create(age: 42)
+                      Person.create!(age: 42)
                     end
 
                     context "when the child halts the callback chain in a before callback" do
@@ -1458,11 +1460,11 @@ describe Mongoid::Attributes::Nested do
                       context "when the child is not paranoid" do
 
                         let(:actor) do
-                          Actor.create
+                          Actor.create!
                         end
 
                         let!(:thing) do
-                          actor.things.create
+                          actor.things.create!
                         end
 
                         before do
@@ -1480,11 +1482,11 @@ describe Mongoid::Attributes::Nested do
                     context "when only 1 child has the default persisted" do
 
                       let!(:app_one) do
-                        persisted.appointments.create
+                        persisted.appointments.create!
                       end
 
                       let!(:app_two) do
-                        persisted.appointments.create.tap do |app|
+                        persisted.appointments.create!.tap do |app|
                           app.unset(:timed)
                         end
                       end
@@ -1501,7 +1503,7 @@ describe Mongoid::Attributes::Nested do
                               "bar" => { "id" => app_one.id, "_destroy" => true },
                               "foo" => { "id" => app_two.id, "_destroy" => true }
                             }
-                          from_db.save
+                          from_db.save!
                         end
 
                         it "destroys both children" do
@@ -1576,7 +1578,7 @@ describe Mongoid::Attributes::Nested do
                       context "when the parent is persisted" do
 
                         let!(:persisted) do
-                          Person.create do |p|
+                          Person.create! do |p|
                             p.addresses << [ address_one, address_two ]
                           end
                         end
@@ -1623,7 +1625,7 @@ describe Mongoid::Attributes::Nested do
                           context "when saving the parent" do
 
                             before do
-                              persisted.save
+                              persisted.save!
                             end
 
                             it "deletes the marked document from the relation" do
@@ -1679,7 +1681,7 @@ describe Mongoid::Attributes::Nested do
                           context "when saving the parent" do
 
                             before do
-                              persisted.save
+                              persisted.save!
                             end
 
                             it "deletes the marked document from the relation" do
@@ -2391,8 +2393,8 @@ describe Mongoid::Attributes::Nested do
               end
 
               before do
-                pizza.topping = Topping.create(name: "cheese")
-                pizza.update_attributes(topping_attributes: { name: "onions" })
+                pizza.topping = Topping.create!(name: "cheese")
+                pizza.update_attributes!(topping_attributes: { name: "onions" })
               end
 
               it "persists the attribute changes" do
@@ -2967,7 +2969,7 @@ describe Mongoid::Attributes::Nested do
         context "when ids are passed" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -3013,7 +3015,7 @@ describe Mongoid::Attributes::Nested do
                       { "0" =>
                         { "id" => BSON::ObjectId.new.to_s, "title" => "Rogue" }
                       }
-                  }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                  }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
                 end
               end
             end
@@ -3032,7 +3034,7 @@ describe Mongoid::Attributes::Nested do
                       "0" => { "id" => post_one.id, "title" => "testing again" },
                       "1" => { "id" => post_two.id, "title" => "$$$" }
                     }
-                  person.save
+                  person.save!
                 end
 
                 it "does not perist the invalid value" do
@@ -3047,7 +3049,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.posts_attributes =
                     { "foo" => { "id" => "test", "title" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
               end
             end
           end
@@ -3308,7 +3310,7 @@ describe Mongoid::Attributes::Nested do
               context "when the parent is saved" do
 
                 before do
-                  person.save
+                  person.save!
                   person.posts_attributes =
                     [
                       { "title" => "Third" },
@@ -3723,7 +3725,7 @@ describe Mongoid::Attributes::Nested do
         context "when ids are passed" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -3764,7 +3766,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.preferences_attributes =
                     { "foo" => { "id" => "test", "name" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
               end
             end
           end
@@ -4305,7 +4307,7 @@ describe Mongoid::Attributes::Nested do
     end
   end
 
-  describe "#update_attributes" do
+  describe "#update_attributes!" do
 
     before do
       Person.send(:undef_method, :addresses_attributes=)
@@ -4315,11 +4317,11 @@ describe Mongoid::Attributes::Nested do
     context "when embedding one level behind a has many" do
 
       let(:node) do
-        Node.create
+        Node.create!
       end
 
       let!(:server) do
-        node.servers.create(name: "prod")
+        node.servers.create!(name: "prod")
       end
 
       context "when adding a new embedded document" do
@@ -4338,7 +4340,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          node.update_attributes(attributes)
+          node.update_attributes!(attributes)
         end
 
         it "adds the new embedded document" do
@@ -4354,11 +4356,11 @@ describe Mongoid::Attributes::Nested do
     context "when deleting the child document" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:service) do
-        person.services.create(sid: "123")
+        person.services.create!(sid: "123")
       end
 
       let(:attributes) do
@@ -4370,7 +4372,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       before do
-        person.update_attributes(attributes)
+        person.update_attributes!(attributes)
       end
 
       it "removes the document from the parent" do
@@ -4396,27 +4398,20 @@ describe Mongoid::Attributes::Nested do
 
     context "when nesting multiple levels and parent is timestamped" do
 
-      around do |example|
-        original_relations = Location.relations
-        Location.embedded_in :address, touch: true
-        example.run
-        Location.relations = original_relations
-      end
-
       after do
         Address.reset_callbacks(:save)
       end
 
       let(:dokument) do
-        Dokument.create
+        Dokument.create!
       end
 
       let!(:address) do
-        dokument.addresses.create(street: "hobrecht")
+        dokument.addresses.create!(street: "hobrecht")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:attributes) do
@@ -4428,7 +4423,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       before do
-        address.update_attributes(attributes)
+        address.update_attributes!(attributes)
         address.reload
       end
 
@@ -4440,21 +4435,21 @@ describe Mongoid::Attributes::Nested do
     context "when nesting multiple levels" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when second level is a one to many" do
 
         let(:person_one) do
-          Person.create
+          Person.create!
         end
 
         let!(:address_one) do
-          person_one.addresses.create(street: "hobrecht")
+          person_one.addresses.create!(street: "hobrecht")
         end
 
         let!(:location_one) do
-          address_one.locations.create(name: "home")
+          address_one.locations.create!(name: "home")
         end
 
         context "when destroying a second level document" do
@@ -4471,7 +4466,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person_one.update_attributes(attributes)
+            person_one.update_attributes!(attributes)
           end
 
           it "deletes the document from the relation" do
@@ -4486,15 +4481,15 @@ describe Mongoid::Attributes::Nested do
         context "when destroying a second level document with callbacks" do
 
           let(:band) do
-            Band.create(name: "Tool")
+            Band.create!(name: "Tool")
           end
 
           let(:record) do
-            band.records.create(name: "Undertow")
+            band.records.create!(name: "Undertow")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Sober")
+            record.tracks.create!(name: "Sober")
           end
 
           context "when cascading callbacks" do
@@ -4521,7 +4516,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              band.update_attributes(attributes)
+              band.update_attributes!(attributes)
             end
 
             it "removes the child from the relation" do
@@ -4554,7 +4549,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
             end
 
             let(:address) do
@@ -4577,11 +4572,11 @@ describe Mongoid::Attributes::Nested do
           context "when adding to an existing document in the first level" do
 
             let!(:address) do
-              person.addresses.create(street: "hobrecht")
+              person.addresses.create!(street: "hobrecht")
             end
 
             let!(:location) do
-              address.locations.create(name: "work")
+              address.locations.create!(name: "work")
             end
 
             let(:attributes) do
@@ -4594,7 +4589,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
               person.reload
             end
 
@@ -4625,7 +4620,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person.update_attributes(attributes)
+            person.update_attributes!(attributes)
           end
 
           let(:address) do
@@ -4651,7 +4646,7 @@ describe Mongoid::Attributes::Nested do
         context "when the nested document is not polymorphic" do
 
           let!(:address) do
-            person.addresses.create(street: "Alexanderstr", number: 1)
+            person.addresses.create!(street: "Alexanderstr", number: 1)
           end
 
           let!(:code) do
@@ -4674,7 +4669,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person.update_attributes(attributes)
+            person.update_attributes!(attributes)
           end
 
           it "updates the first level embedded document" do
@@ -4691,7 +4686,7 @@ describe Mongoid::Attributes::Nested do
           context "when the first level is an embeds many" do
 
             let!(:address) do
-              person.addresses.create(street: "Alexanderstr", number: 1)
+              person.addresses.create!(street: "Alexanderstr", number: 1)
             end
 
             let!(:target) do
@@ -4714,7 +4709,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
             end
 
             it "updates the first level embedded document" do
@@ -4750,7 +4745,7 @@ describe Mongoid::Attributes::Nested do
               end
 
               before do
-                person.update_attributes(attributes)
+                person.update_attributes!(attributes)
               end
 
               it "updates the nested embedded document" do
@@ -4767,7 +4762,7 @@ describe Mongoid::Attributes::Nested do
       context "when updating with valid attributes" do
 
         let(:user) do
-          User.create
+          User.create!
         end
 
         let(:params) do
@@ -4777,7 +4772,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          user.update_attributes(params)
+          user.update_attributes!(params)
         end
 
         around do |example|
@@ -4803,11 +4798,11 @@ describe Mongoid::Attributes::Nested do
       context "when the document is freshly loaded from the db" do
 
         let!(:node) do
-          Node.create
+          Node.create!
         end
 
         let!(:server) do
-          node.servers.create(name: "test")
+          node.servers.create!(name: "test")
         end
 
         before do
@@ -4840,11 +4835,11 @@ describe Mongoid::Attributes::Nested do
     context "when the relation is an embeds many" do
 
       let(:league) do
-        League.create
+        League.create!
       end
 
       let!(:division) do
-        league.divisions.create(name: "Old Name")
+        league.divisions.create!(name: "Old Name")
       end
 
       context "when additional validation is set" do
@@ -4899,7 +4894,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          league.update_attributes(params)
+          league.update_attributes!(params)
         end
 
         it "sets the nested attributes" do
@@ -4919,7 +4914,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            league.update_attributes(new_params)
+            league.update_attributes!(new_params)
           end
 
           it "sets the nested attributes" do
@@ -4929,4 +4924,77 @@ describe Mongoid::Attributes::Nested do
       end
     end
   end
+
+  context "when destroying has_many child using nested attributes" do
+    let(:school) do
+      School.create
+    end
+
+    let!(:student) do
+      school.students.create
+    end
+
+    before do
+      school.attributes = {
+        '_id': school.id,
+        'students_attributes': [{
+          '_id': student.id,
+          '_destroy': 1
+          }]
+        }
+    end
+
+    it "is able to access the parent in the after_destroy callback" do
+      expect(school.after_destroy_triggered).to eq(true)
+    end
+  end
+
+  context "when destroying has_many child using nested attributes" do
+    let(:school) do
+      HabtmmSchool.create!(students: [student])
+    end
+
+    let(:student) do
+      HabtmmStudent.create!
+    end
+
+    before do
+      student.schools << school
+      school.attributes = {
+        '_id': school.id,
+        'students_attributes': [{
+          '_id': student.id,
+          '_destroy': 1
+          }]
+        }
+    end
+
+    it "is able to access the parent in the after_destroy callback" do
+      expect(school.reload.after_destroy_triggered).to eq(true)
+    end
+  end
+
+  context "when using a multi-leveled nested attribute on a referenced association" do
+    let(:author) { NestedAuthor.create }
+    let(:one_level_params) { { post_attributes: { title: 'test' } } }
+    let(:two_levels_params) { { post_attributes: { comments_attributes: [ { body: 'test' } ] } } }
+
+    it "creates a 1st-depth child model" do
+      author.update_attributes(one_level_params)
+      expect(author.post.persisted?).to be true
+    end
+
+    it "creates a 1st-depth child model, and a 2nd-depth child model" do
+      author.update_attributes(two_levels_params)
+      expect(author.post.comments.count).to eq 1
+    end
+
+    context "the 1st-depth child model already exists" do
+      it "creates a 2nd-depth child model" do
+        author.create_post(title: 'test')
+        author.update_attributes(two_levels_params)
+        expect(author.post.comments.count).to eq 1
+      end
+    end
+  end
 end

data/spec/mongoid/attributes/nested_spec_models.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+class NestedAuthor
+  include Mongoid::Document
+
+  field :name, type: String
+  has_one :post, class_name: "NestedPost"
+  accepts_nested_attributes_for :post
+end
+
+class NestedComment
+  include Mongoid::Document
+
+  field :body, type: String
+  belongs_to :post, class_name: "NestedPost"
+end
+
+class NestedPost
+  include Mongoid::Document
+
+  field :title, type: String
+  belongs_to :author, class_name: "NestedAuthor"
+  has_many :comments, class_name: "NestedComment"
+  accepts_nested_attributes_for :comments
+end
+
+class NestedBook
+  include Mongoid::Document
+
+  embeds_one :cover, class_name: "NestedCover"
+  embeds_many :pages, class_name: "NestedPage"
+
+  accepts_nested_attributes_for :cover, :pages
+end
+
+class NestedCover
+  include Mongoid::Document
+
+  field :title, type: String
+  embedded_in :book, class_name: "NestedBook"
+end
+
+class NestedPage
+  include Mongoid::Document
+
+  field :number, type: Integer
+  embedded_in :book, class_name: "NestedBook"
+end