mongoid 7.0.13 → 7.1.0.rc0

data/spec/mongoid/errors/invalid_path_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongoid::Errors::InvalidPath do

data/spec/mongoid/errors/invalid_relation_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::InvalidRelation do
@@ -18,13 +21,13 @@ describe Mongoid::Errors::InvalidRelation do
 
     it "contains the problem in the message" do
       expect(error.message).to include(
-                                   "Defining a relation named 'crazy_method' is not allowed."
+                                   "Defining an association named 'crazy_method' is not allowed."
                                )
     end
 
     it "contains the summary in the message" do
       expect(error.message).to include(
-                                   "Defining this relation would override the method 'crazy_method'"
+                                   "Defining this association would override the method 'crazy_method'"
                                )
     end
 

data/spec/mongoid/errors/invalid_scope_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::InvalidScope do

data/spec/mongoid/errors/invalid_set_polymorphic_relation_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::InvalidSetPolymorphicRelation do

data/spec/mongoid/errors/invalid_storage_options_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::InvalidStorageOptions do

data/spec/mongoid/errors/invalid_time_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::InvalidTime do

data/spec/mongoid/errors/inverse_not_found_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::InverseNotFound do
@@ -16,7 +19,7 @@ describe Mongoid::Errors::InverseNotFound do
 
     it "contains the summary in the message" do
       expect(error.message).to include(
-        "hen adding a document to a relation, Mongoid attempts to link"
+        "hen adding a document to an association, Mongoid attempts to link"
       )
     end
 

data/spec/mongoid/errors/mixed_client_configuration_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::MixedClientConfiguration do

data/spec/mongoid/errors/mixed_relations_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::MixedRelations do

data/spec/mongoid/errors/mongoid_error_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongoid::Errors::MongoidError do

data/spec/mongoid/errors/nested_attributes_metadata_not_found_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NestedAttributesMetadataNotFound do
@@ -10,19 +13,19 @@ describe Mongoid::Errors::NestedAttributesMetadataNotFound do
 
     it "contains the problem in the message" do
       expect(error.message).to include(
-        "Could not find metadata for relation 'posts' on model: Person."
+        "Could not find metadata for association 'posts' on model: Person."
       )
     end
 
     it "contains the summary in the message" do
       expect(error.message).to include(
-        "When defining nested attributes for a relation, Mongoid needs"
+        "When defining nested attributes for an association, Mongoid needs"
       )
     end
 
     it "contains the resolution in the message" do
       expect(error.message).to include(
-        "Make sure that there is a relation defined named 'posts' on Person"
+        "Make sure that there is an association defined named 'posts' on Person"
       )
     end
   end

data/spec/mongoid/errors/no_client_config_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoClientConfig do

data/spec/mongoid/errors/no_client_database_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoClientDatabase do

data/spec/mongoid/errors/no_client_hosts_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoClientHosts do

data/spec/mongoid/errors/no_clients_config_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoClientsConfig do

data/spec/mongoid/errors/no_environment_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoEnvironment do

data/spec/mongoid/errors/no_map_reduce_output_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoMapReduceOutput do

data/spec/mongoid/errors/no_metadata_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongoid::Errors::NoMetadata do
@@ -13,11 +16,11 @@ describe Mongoid::Errors::NoMetadata do
     end
 
     it "contains the summary in the message" do
-      expect(error.message).to include("Mongoid sets the metadata of a relation on the")
+      expect(error.message).to include("Mongoid sets the metadata of an association on the")
     end
 
     it "contains the resolution in the message" do
-      expect(error.message).to include("Ensure that your relations on the Address model")
+      expect(error.message).to include("Ensure that your associations on the Address model")
     end
   end
 end

data/spec/mongoid/errors/no_parent_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::NoParent do
@@ -22,7 +25,7 @@ describe Mongoid::Errors::NoParent do
 
     it "contains the resolution in the message" do
       expect(error.message).to include(
-        "Ensure that you've set the parent relation if instantiating"
+        "Ensure that you've set the parent association if instantiating"
       )
     end
   end

data/spec/mongoid/errors/readonly_attribute_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::ReadonlyAttribute do

data/spec/mongoid/errors/readonly_document_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::ReadonlyDocument do

data/spec/mongoid/errors/scope_overwrite_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::ScopeOverwrite do

data/spec/mongoid/errors/too_many_nested_attribute_records_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::TooManyNestedAttributeRecords do

data/spec/mongoid/errors/unknown_attribute_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::UnknownAttribute do

data/spec/mongoid/errors/unsaved_document_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::UnsavedDocument do
@@ -24,7 +27,7 @@ describe Mongoid::Errors::UnsavedDocument do
 
     it "contains the summary in the message" do
       expect(error.message).to include(
-        "You cannot call create or create! through the relation"
+        "You cannot call create or create! through the association"
       )
     end
 

data/spec/mongoid/errors/unsupported_javascript_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::UnsupportedJavascript do

data/spec/mongoid/errors/validations_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Errors::Validations do

data/spec/mongoid/extensions/array_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Array do
@@ -352,56 +355,36 @@ describe Mongoid::Extensions::Array do
 
   describe "#__mongoize_time__" do
 
-    context "when using active support's time zone" do
-
-      before do
-        Mongoid.use_activesupport_time_zone = true
-        ::Time.zone = "Tokyo"
-      end
+    let(:array) do
+      [ 2010, 11, 19, 00, 24, 49.123457 ]
+    end
 
-      after do
-        ::Time.zone = "Berlin"
-      end
+    let(:mongoized) do
+      array.__mongoize_time__
+    end
 
-      let(:array) do
-        [ 2010, 11, 19, 00, 24, 49 ]
-      end
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
 
-      let(:time) do
-        array.__mongoize_time__
-      end
-
-      it "converts to a time" do
-        expect(time).to eq(::Time.zone.local(*array))
-      end
+      # In AS time zone (could be different from Ruby time zone)
+      let(:expected_time) { ::Time.zone.local(*array).in_time_zone }
 
       it "converts to the as time zone" do
-        expect(time.zone).to eq("JST")
+        expect(mongoized.zone).to eq("JST")
       end
+
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
+      it_behaves_like 'maintains precision when mongoized'
     end
 
     context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
 
-      before do
-        Mongoid.use_activesupport_time_zone = false
-      end
+      # In Ruby time zone (could be different from AS time zone)
+      let(:expected_time) { ::Time.local(*array).in_time_zone }
 
-      after do
-        Mongoid.use_activesupport_time_zone = true
-        Time.zone = nil
-      end
-
-      let(:array) do
-        [ 2010, 11, 19, 00, 24, 49 ]
-      end
-
-      let(:time) do
-        array.__mongoize_time__
-      end
-
-      it "converts to a time" do
-        expect(time).to eq(Time.local(*array))
-      end
+      it_behaves_like 'mongoizes to Time'
+      it_behaves_like 'maintains precision when mongoized'
     end
   end
 
@@ -415,8 +398,8 @@ describe Mongoid::Extensions::Array do
           [{ "_id" => { "$in" => [] }}]
         end
 
-        it "returns true" do
-          expect(array).to be_blank_criteria
+        it "is false" do
+          expect(array.blank_criteria?).to be false
         end
       end
 
@@ -426,8 +409,8 @@ describe Mongoid::Extensions::Array do
           [{ "_id" => "test" }, { "_id" => { "$in" => [] }}]
         end
 
-        it "returns true" do
-          expect(array).to be_blank_criteria
+        it "is false" do
+          expect(array.blank_criteria?).to be false
         end
       end
     end

data/spec/mongoid/extensions/big_decimal_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::BigDecimal do

data/spec/mongoid/extensions/binary_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe BSON::Binary do

data/spec/mongoid/extensions/boolean_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Boolean do

data/spec/mongoid/extensions/date_class_mongoize_spec.rb

@@ -0,0 +1,336 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Extensions::Date do
+
+  describe ".mongoize" do
+
+    context "when provided a date" do
+
+      let(:date) do
+        Date.new(2010, 1, 1)
+      end
+
+      let(:mongoized) do
+        Date.mongoize(date)
+      end
+
+      let(:expected) do
+        Time.utc(2010, 1, 1, 0, 0, 0)
+      end
+
+      it "returns the time" do
+        expect(mongoized).to eq(expected)
+      end
+    end
+
+    context "when provided a string" do
+      # This also configures a non-UTC time zone for AS which we want
+      include_context 'using AS time zone'
+
+      context "when the string is a valid date" do
+
+        let(:mongoized) do
+          Date.mongoize('2010-01-01')
+        end
+
+        let(:expected) do
+          # Date is always serialized as UTC time with zero time component
+          # on the specified date, regardless of time zone.
+          # This allows the application to change its time zone and
+          # retrieve the date back unchanged.
+          Time.utc(2010, 1, 1, 0, 0, 0, 0)
+        end
+
+        it "returns the beginning of date in UTC" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context "when the string is a valid date and time" do
+
+        let(:mongoized) do
+          Date.mongoize("2010-01-01 02:00:00")
+        end
+
+        let(:expected) do
+          # Time component is ignored, date is specified in UTC
+          Time.utc(2010, 1, 1, 0, 0, 0, 0)
+        end
+
+        it "returns beginning of date in UTC" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context "when the string is a valid date and time in later time zone" do
+
+        let(:mongoized) do
+          # Tokyo is +9
+          Date.mongoize("2010-01-01 00:00:00 +1000")
+        end
+
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0, 0)
+        end
+
+        it "returns the date specified in the string without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context "when the string is a valid date and time in earlier time zone" do
+
+        let(:mongoized) do
+          # Tokyo is +9
+          Date.mongoize("2010-01-01 20:00:00 +0400")
+        end
+
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0, 0)
+        end
+
+        it "returns the date specified in the string without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context "when the string is empty" do
+
+        let(:evolved) do
+          Date.mongoize("")
+        end
+
+        it "returns nil" do
+          expect(evolved).to be_nil
+        end
+      end
+
+      context "when the string is an invalid time" do
+
+        it "returns nil" do
+          expect(Date.mongoize("time")).to eq(nil)
+        end
+      end
+    end
+
+    context "when provided a float" do
+      include_context 'using AS time zone'
+
+      let(:float) do
+        time.to_f
+      end
+
+      let(:mongoized) do
+        Date.mongoize(float)
+      end
+
+      context 'float in the same local day' do
+        let(:time) do
+          Time.utc(2010, 1, 1, 2, 3, 4, 123456)
+        end
+
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0, 0)
+        end
+
+        it "returns start of the day as date" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context 'float in a different local day' do
+        let(:time) do
+          Time.utc(2010, 1, 1, 22, 3, 4, 123456)
+        end
+
+        let(:expected) do
+          Time.utc(2010, 1, 2, 0, 0, 0, 0)
+        end
+
+        it "returns start of the day as date" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+    end
+
+    context "when provided an integer" do
+      include_context 'using AS time zone'
+
+      let(:integer) do
+        time.to_i
+      end
+
+      let(:mongoized) do
+        Date.mongoize(integer)
+      end
+
+      context 'integer in the same local day' do
+        let(:time) do
+          Time.utc(2010, 1, 1, 2, 3, 4)
+        end
+
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0, 0)
+        end
+
+        it "returns start of the day as date" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context 'integer in a different local day' do
+        let(:time) do
+          Time.utc(2010, 1, 1, 22, 3, 4)
+        end
+
+        let(:expected) do
+          Time.utc(2010, 1, 2, 0, 0, 0, 0)
+        end
+
+        it "returns start of the day as date" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+    end
+
+    context "when provided a time" do
+      include_context 'using AS time zone'
+
+      let(:mongoized) do
+        Date.mongoize(time)
+      end
+
+      context 'in the same local day' do
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0)
+        end
+
+        let(:time) do
+          Time.utc(2010, 1, 1, 22, 3, 4)
+        end
+
+        it "returns the date specified in the time without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context 'in another local day' do
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0)
+        end
+
+        let(:time) do
+          Time.utc(2010, 1, 1, 2, 3, 4)
+        end
+
+        it "returns the date specified in the time without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+    end
+
+    context "when provided an AS::TimeWithZone" do
+      include_context 'using AS time zone'
+
+      let(:mongoized) do
+        Date.mongoize(time)
+      end
+
+      context 'in the same local day' do
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0)
+        end
+
+        let(:time) do
+          # Tokyo is +9
+          ActiveSupport::TimeZone['PST8PDT'].local(2010, 1, 1, 1, 3, 4)
+        end
+
+        it "returns the date specified in the time without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context 'in another local day' do
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0)
+        end
+
+        let(:time) do
+          ActiveSupport::TimeZone['Moscow'].local(2010, 1, 1, 1, 3, 4)
+        end
+
+        it "returns the date specified in the time without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+    end
+
+    context "when provided a DateTime" do
+      include_context 'using AS time zone'
+
+      let(:mongoized) do
+        Date.mongoize(date_time)
+      end
+
+      context 'in the same local day' do
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0)
+        end
+
+        let(:date_time) do
+          # Tokyo is +9
+          DateTime.parse('2010-01-01 01:03:04 -0800')
+        end
+
+        it "returns the date specified in the time without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+
+      context 'in another local day' do
+        let(:expected) do
+          Time.utc(2010, 1, 1, 0, 0, 0)
+        end
+
+        let(:date_time) do
+          DateTime.parse('2010-01-01 01:03:04 +0100')
+        end
+
+        it "returns the date specified in the time without regard for local day" do
+          expect(mongoized).to eq(expected)
+        end
+      end
+    end
+
+    context "when provided an array" do
+      include_context 'using AS time zone'
+
+      let(:expected) do
+        Time.utc(2010, 1, 1, 0, 0, 0)
+      end
+
+      let(:array) do
+        [ 2010, 1, 1, 2, 3, 4, 0 ]
+      end
+
+      let(:mongoized) do
+        Date.mongoize(array)
+      end
+
+      it "returns the array as a time" do
+        expect(mongoized).to eq(expected)
+      end
+    end
+
+    context "when provided nil" do
+
+      it "returns nil" do
+        expect(Date.mongoize(nil)).to be_nil
+      end
+    end
+  end
+end