mongoid 7.0.13 → 7.1.0.rc0

data/spec/mongoid/association/referenced/has_and_belongs_to_many_models.rb

@@ -1,9 +1,14 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class HabtmmCompany
   include Mongoid::Document
 
   field :c_id, type: Integer
   field :e_ids, type: Array
-  has_and_belongs_to_many :employees, primary_key: :e_id, foreign_key: :e_ids, class_name: 'HabtmmEmployee'
+  has_and_belongs_to_many :employees, class_name: 'HabtmmEmployee',
+    primary_key: :e_id, foreign_key: :e_ids,
+    inverse_primary_key: :c_id, inverse_foreign_key: :c_ids
 end
 
 class HabtmmEmployee
@@ -12,7 +17,26 @@ class HabtmmEmployee
   field :e_id, type: Integer
   field :c_ids, type: Array
   field :habtmm_company_ids, type: Array
-  has_and_belongs_to_many :companies, primary_key: :c_id, foreign_key: :c_ids, class_name: 'HabtmmCompany'
+  has_and_belongs_to_many :companies, class_name: 'HabtmmCompany',
+    primary_key: :c_id, foreign_key: :c_ids,
+    inverse_primary_key: :e_id, inverse_foreign_key: :e_ids
+end
+
+class HabtmmContract
+  include Mongoid::Document
+
+  has_and_belongs_to_many :signatures, class_name: 'HabtmmSignature'
+
+  field :item, type: String
+end
+
+class HabtmmSignature
+  include Mongoid::Document
+
+  has_and_belongs_to_many :contracts, class_name: 'HabtmmContract'
+
+  field :name, type: String
+  field :year, type: Integer
 end
 
 class HabtmmTicket

data/spec/mongoid/association/referenced/has_and_belongs_to_many_query_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './has_and_belongs_to_many_models'
+
+describe Mongoid::Association::Referenced::HasAndBelongsToMany do
+  context 'when projecting with #only' do
+    before do
+      contract = HabtmmContract.create!(item: 'foo')
+      contract.signatures << HabtmmSignature.create!(contracts: [contract], name: 'Dave', year: 2019)
+      contract.save!
+    end
+
+    let(:contract) do
+      HabtmmContract.where(item: 'foo').only(:signature_ids,
+        'signatures._id', 'signatures.name').first
+    end
+
+    let(:signature) { contract.signatures.first }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(signature.name).to eq('Dave')
+      # has a default value specified in the model
+      expect do
+        signature.year
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(signature.attributes.keys).to eq(['_id', 'name'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(signature.name).to eq('Dave')
+      expect(signature.year).to eq(2019)
+    end
+  end
+end

data/spec/mongoid/association/referenced/has_and_belongs_to_many_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany do
@@ -1013,14 +1016,35 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
 
   describe '#inverse_foreign_key' do
 
-    it 'returns nil' do
+    it 'returns generated key' do
       expect(association.inverse_foreign_key).to eq('has_many_left_object_ids')
     end
+
+    context 'with inverse given' do
+      let(:options) do
+        { inverse_of: 'foo' }
+      end
+
+      it 'returns configured key' do
+        expect(association.inverse_foreign_key).to eq('foo_ids')
+      end
+    end
+
+    context 'with primary_key and foreign_key given' do
+      let(:options) do
+        { primary_key: 'foo', foreign_key: 'foo_ref',
+          inverse_primary_key: 'bar', inverse_foreign_key: 'bar_ref' }
+      end
+
+      it 'returns configured key' do
+        expect(association.inverse_foreign_key).to eq('bar_ref')
+      end
+    end
   end
 
   describe '#inverse_foreign_key_setter' do
 
-    it 'returns nil' do
+    it 'returns generated method name' do
       expect(association.inverse_foreign_key_setter).to eq('has_many_left_object_ids=')
     end
   end

data/spec/mongoid/association/referenced/has_many/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany::Binding do

data/spec/mongoid/association/referenced/has_many/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany::Buildable do

data/spec/mongoid/association/referenced/has_many/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany::Eager do
@@ -63,9 +66,15 @@ describe Mongoid::Association::Referenced::HasMany::Eager do
       eager.send(:set_on_parent, person.id, :foo)
     end
 
-    it "doesnt call an extra query" do
-      expect_query(0) do
-        eager.send(:set_on_parent, person.id, :foo)
+    context 'when able to make query count assertions' do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
+
+      it "doesnt call an extra query" do
+        expect_query(0) do
+          eager.send(:set_on_parent, person.id, :foo)
+        end
       end
     end
   end
@@ -77,6 +86,9 @@ describe Mongoid::Association::Referenced::HasMany::Eager do
     end
 
     context "when including the has_many relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       before do
         3.times { Drug.create!(person: person) }
@@ -103,6 +115,9 @@ describe Mongoid::Association::Referenced::HasMany::Eager do
     end
 
     context "when the relation is not polymorphic" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       context "when the eager load has returned documents" do
 

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
@@ -253,111 +256,6 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
         end
       end
     end
-
-    context "when the documents have been loaded" do
-      let(:criteria) do
-        Post.where(person_id: person.id)
-      end
-
-      let!(:enumerable) do
-        described_class.new(criteria)
-      end
-
-      before do
-        enumerable.load_all!
-      end
-
-      it "is _loaded" do
-        expect(enumerable._loaded?).to be true
-      end
-
-      context "when a block is given" do
-        it "returns true when the predicate is true" do
-          expect(
-            enumerable.any? { |doc| true }
-          ).to be true
-        end
-
-        it "returns false when the predicate is false" do
-          expect(
-            enumerable.any? { |doc| false }
-          ).to be false
-        end
-      end
-
-      context "when an argument is given" do
-        ruby_version_gte '2.5'
-
-        it "returns true when the argument is true" do
-          expect(enumerable.any?(Post)).to be true
-        end
-
-        it "returns false when the argument is false" do
-          expect(enumerable.any?(Sandwich)).to be false
-        end
-      end
-
-      context "when both an argument and a block are given" do
-        ruby_version_gte '2.5'
-
-        it "gives precedence to the pattern" do
-          expect(
-            enumerable.any?(Post) { |doc| false }
-          ).to be true
-        end
-      end
-    end
-
-    context "when the documents are not loaded" do
-
-      let(:criteria) do
-        Post.where(person_id: person.id)
-      end
-
-      let!(:enumerable) do
-        described_class.new(criteria)
-      end
-
-      it "is not _loaded" do
-        expect(enumerable._loaded?).to be false
-      end
-
-      context "when a block is given" do
-        it "returns true when the predicate is true" do
-          expect(
-            enumerable.any? { |doc| true }
-          ).to be true
-        end
-
-        it "returns false when the predicate is false" do
-          expect(
-            enumerable.any? { |doc| false }
-          ).to be false
-        end
-      end
-
-      context "when an argument is given" do
-        ruby_version_gte '2.5'
-
-        it "returns true when the argument is true" do
-          expect(enumerable.any?(Post)).to be true
-        end
-
-        it "returns false when the argument is false" do
-          expect(enumerable.any?(Sandwich)).to be false
-        end
-      end
-
-      context "when both an argument and a block are given" do
-        ruby_version_gte '2.5'
-
-        it "gives precedence to the pattern" do
-          expect(
-            enumerable.any?(Post) { |doc| false }
-          ).to be true
-        end
-      end
-    end
   end
 
   describe "#clear" do
@@ -884,7 +782,11 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
     end
   end
 
-  describe "#first" do
+  shared_examples 'first or one' do
+
+    subject do
+      enumerable.public_send(subject_method)
+    end
 
     let(:person) do
       Person.create
@@ -908,12 +810,8 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
             Post.create(person_id: person.id)
           end
 
-          let(:first) do
-            enumerable.first
-          end
-
           it "returns the first unloaded doc" do
-            expect(first).to eq(post)
+            expect(subject).to eq(post)
           end
 
           it "does not load the enumerable" do
@@ -922,7 +820,7 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
 
           it "receives query only once" do
             expect(criteria).to receive(:first).once
-            first
+            subject
           end
         end
 
@@ -940,14 +838,10 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
             enumerable << post_two
           end
 
-          let(:first) do
-            enumerable.first
-          end
-
           context "when a perviously persisted unloaded doc exists" do
 
             it "returns the first added doc" do
-              expect(first).to eq(post)
+              expect(subject).to eq(post)
             end
 
             it "does not load the enumerable" do
@@ -967,12 +861,8 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
           enumerable << post
         end
 
-        let(:first) do
-          enumerable.first
-        end
-
         it "returns the first loaded doc" do
-          expect(first).to eq(post)
+          expect(subject).to eq(post)
         end
 
         it "does not load the enumerable" do
@@ -982,12 +872,8 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
 
       context "when unloaded and added are empty" do
 
-        let(:first) do
-          enumerable.first
-        end
-
         it "returns nil" do
-          expect(first).to be_nil
+          expect(subject).to be_nil
         end
 
         it "does not load the enumerable" do
@@ -1008,12 +894,8 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
           described_class.new([ post ])
         end
 
-        let(:first) do
-          enumerable.first
-        end
-
         it "returns the first loaded doc" do
-          expect(first).to eq(post)
+          expect(subject).to eq(post)
         end
       end
 
@@ -1031,12 +913,8 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
           enumerable << post
         end
 
-        let(:first) do
-          enumerable.first
-        end
-
         it "returns the first added doc" do
-          expect(first).to eq(post)
+          expect(subject).to eq(post)
         end
       end
 
@@ -1046,12 +924,8 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
           described_class.new([])
         end
 
-        let(:first) do
-          enumerable.first
-        end
-
         it "returns nil" do
-          expect(first).to be_nil
+          expect(subject).to be_nil
         end
       end
     end
@@ -1079,9 +953,21 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
       end
 
       it 'does not use the sort on id' do
-        expect(enumerable.first(id_sort: :none)).to eq(first_post)
+        expect(enumerable.send(subject_method, id_sort: :none)).to eq(first_post)
       end
     end
+  end
+
+  describe "#first" do
+    let(:subject_method) do
+      :first
+    end
+
+    it_behaves_like 'first or one'
+
+    subject do
+      enumerable.public_send(subject_method)
+    end
 
     context 'when the id_sort option is not provided' do
 
@@ -1098,15 +984,54 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
       end
 
       let!(:first_post) do
-        person.posts.create(title: "One")
+        person.posts.create(id: 'one', title: "One")
       end
 
       let!(:second_post) do
-        person.posts.create(title: "Two")
+        person.posts.create(id: 'atwo', title: "Two")
       end
 
       it 'uses the sort on id' do
-        expect(enumerable.first).to eq(first_post)
+        expect(subject).to eq(second_post)
+      end
+    end
+  end
+
+  describe "#one" do
+    let(:subject_method) do
+      :one
+    end
+
+    it_behaves_like 'first or one'
+
+    subject do
+      enumerable.public_send(subject_method)
+    end
+
+    context 'when the id_sort option is not provided' do
+
+      let(:person) do
+        Person.create
+      end
+
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      let!(:first_post) do
+        person.posts.create(id: 'one', title: "One")
+      end
+
+      let!(:second_post) do
+        person.posts.create(id: 'atwo', title: "Two")
+      end
+
+      it 'does not use the sort on id' do
+        expect(subject).to eq(first_post)
       end
     end
   end