mongoid 7.0.13 → 7.1.0.rc0

data/spec/mongoid/association/embedded/embeds_one/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Binding do

data/spec/mongoid/association/embedded/embeds_one/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Buildable do

data/spec/mongoid/association/embedded/embeds_one/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Proxy do

data/spec/mongoid/association/embedded/embeds_one_dnl_models.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 # This file is added as an autoload target, but should never be actually
 # processed.
 

data/spec/mongoid/association/embedded/embeds_one_models.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class EomParent
   include Mongoid::Document
 

data/spec/mongoid/association/embedded/embeds_one_query_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './embeds_one_models'
+
+describe Mongoid::Association::Embedded::EmbedsOne do
+
+  context 'when projecting with #only' do
+    before do
+      parent = EomParent.new(name: 'foo')
+      parent.child = EomChild.new(a: 1, b: 2)
+      parent.save!
+    end
+
+    let(:parent) do
+      EomParent.where(name: 'foo').only(:name, 'child._id', 'child.a').first
+    end
+
+    it 'populates specified fields only' do
+      expect(parent.child.a).to eq(1)
+      # has a default value specified in the model
+      expect do
+        parent.child.b
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(parent.child.attributes.keys).to eq(['_id', 'a'])
+    end
+  end
+end

data/spec/mongoid/association/embedded/embeds_one_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative './embeds_one_models'
 
@@ -453,6 +456,8 @@ describe Mongoid::Association::Embedded::EmbedsOne do
             end
 
             it 'returns the inverse in an array' do
+              pending 'MONGOID-4751'
+
               inverses = association.inverses
               expect(inverses).to eq([:parent])
             end
@@ -951,4 +956,4 @@ describe Mongoid::Association::Embedded::EmbedsOne do
       expect(association.create_relation(owner, target)).to be_a(EmbeddedObject)
     end
   end
-end
+end

data/spec/mongoid/association/macros_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Macros do

data/spec/mongoid/association/nested/many_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Nested::Many do

data/spec/mongoid/association/nested/one_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Nested::One do

data/spec/mongoid/association/options_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Options do

data/spec/mongoid/association/polymorphic_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Polymorphic Associations" do

data/spec/mongoid/association/referenced/belongs_to/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Binding do

data/spec/mongoid/association/referenced/belongs_to/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Buildable do

data/spec/mongoid/association/referenced/belongs_to/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative '../has_many_models'
 
@@ -75,6 +78,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when including the belongs_to association" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
 
@@ -87,6 +93,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when the association is not polymorphic" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       let(:eager) do
         Post.includes(:person).last
@@ -162,6 +171,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when all the values for the belongs_to association are nil" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       before do
         2.times { |i| HmmTicket.create!(person: nil) }

data/spec/mongoid/association/referenced/belongs_to/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Proxy do

data/spec/mongoid/association/referenced/belongs_to_query_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './has_many_models'
+
+describe Mongoid::Association::Referenced::BelongsTo do
+  context 'when projecting with #only' do
+    before do
+      school = HmmSchool.create!(district: 'foo', team: 'Bulldogs')
+      HmmStudent.create!(school: school, name: 'Dave', grade: 10)
+    end
+
+    let(:student) do
+      HmmStudent.where(name: 'Dave').only(:school_id, 'school._id', 'school.district').first
+    end
+
+    let(:school) { student.school }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(school.district).to eq('foo')
+      # has a default value specified in the model
+      expect do
+        school.team
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(student.attributes.keys).to eq(['_id', 'name'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(school.district).to eq('foo')
+      expect(school.team).to eq('Bulldogs')
+    end
+  end
+end

data/spec/mongoid/association/referenced/belongs_to_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative './has_one_models'
 

data/spec/mongoid/association/referenced/has_and_belongs_to_many/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Binding do

data/spec/mongoid/association/referenced/has_and_belongs_to_many/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Buildable do

data/spec/mongoid/association/referenced/has_and_belongs_to_many/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative '../has_and_belongs_to_many_models'
 
@@ -43,6 +46,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when including the has_and_belongs_to_many association" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
         expect_query(2) do
@@ -62,6 +68,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when the association is not polymorphic" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       let(:eager) do
         Person.asc(:_id).includes(:preferences).last
@@ -116,6 +125,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when some related documents no longer exist" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
+
       before do
         # Deleting the first one to meet Builders::Referenced::ManyToMany#query?
         House.collection.find(_id: Person.first.house_ids.first).delete_one
@@ -132,6 +145,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when all the values for the has_and_belongs_to_many association are empty" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       before do
         2.times { |i| HabtmmPerson.create! }

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_persistence_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# encoding: utf-8
 
 require "spec_helper"
 require_relative '../has_and_belongs_to_many_models'
@@ -16,15 +17,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       expect(company.e_ids).to eq([456])
     end
 
-    describe 'nullify' do
+    describe '#nullify' do
       before do
         company.employees << repl_employee
         company.save!
         expect(company.employees.length).to eq(2)
-        repl_employee.habtmm_company_ids = [company.id]
+        repl_employee.c_ids = [company.c_id]
         repl_employee.save!
         repl_employee.reload
-        expect(repl_employee.habtmm_company_ids).to eq([company.id])
+        expect(repl_employee.c_ids).to eq([123])
       end
 
       context 'without replacement' do
@@ -33,7 +34,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         it 'disassociates child from parent' do
           company.employees.nullify
           repl_employee.reload
-          expect(repl_employee.habtmm_company_ids).to eq([])
+          expect(repl_employee.c_ids).to eq([])
         end
       end
 
@@ -48,9 +49,29 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         it 'keeps replacement associated with the parent' do
           company.employees.nullify([repl_employee])
           repl_employee.reload
-          expect(repl_employee.habtmm_company_ids).to eq([company.id])
+          expect(repl_employee.c_ids).to eq([123])
         end
       end
     end
   end
+
+  describe '#<<' do
+    let(:dog) { Dog.create! }
+    let(:breed) { Breed.create! }
+
+    it 'adds association on both ends' do
+      dog.breeds << breed
+      expect(breed.dogs).to eq([dog])
+    end
+
+    context 'with primary_key and foreign_key given' do
+      let(:company) { HabtmmCompany.create!(c_id: 123) }
+      let(:employee) { HabtmmEmployee.create!(e_id: 456) }
+
+      it 'adds association on both ends' do
+        company.employees << employee
+        expect(employee.companies).to eq([company])
+      end
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
@@ -1754,43 +1757,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
     end
 
-    describe "#any?" do
-
-      let(:person) do
-        Person.create
-      end
-
-      context "when nothing exists on the relation" do
-
-        context "when no document is added" do
-
-          let!(:sandwich) do
-            Sandwich.create!
-          end
-
-          it "returns false" do
-            expect(sandwich.meats.any?).to be false
-          end
-        end
-
-        context "when the document is destroyed" do
-
-          before do
-            Meat.create!
-          end
-
-          let!(:sandwich) do
-            Sandwich.create!
-          end
-
-          it "returns false" do
-            sandwich.destroy
-            expect(sandwich.meats.any?).to be false
-          end
-        end
-      end
-    end
-
     context "when documents have been persisted" do
 
       let!(:preference) do
@@ -1880,107 +1846,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     end
   end
 
-  describe "#any?" do
-
-    let(:sandwich) do
-      Sandwich.create
-    end
-
-    context "when nothing exists on the relation" do
-
-      context "when no document is added" do
-
-        let!(:sandwich) do
-          Sandwich.create!
-        end
-
-        it "returns false" do
-          expect(sandwich.meats.any?).to be false
-        end
-      end
-
-      context "when the document is destroyed" do
-
-        before do
-          Meat.create!
-        end
-
-        let!(:sandwich) do
-          Sandwich.create!
-        end
-
-        it "returns false" do
-          sandwich.destroy
-          expect(sandwich.meats.any?).to be false
-        end
-      end
-    end
-
-    context "when appending to a relation and _loaded/_unloaded are empty" do
-
-      let!(:sandwich) do
-        Sandwich.create!
-      end
-
-      before do
-        sandwich.meats << Meat.new
-      end
-
-      it "returns true" do
-        expect(sandwich.meats.any?).to be true
-      end
-    end
-
-    context "when appending to a relation in a transaction" do
-      require_transaction_support
-
-      let!(:sandwich) do
-        Sandwich.create!
-      end
-
-      it "returns true" do
-        sandwich.with_session do |session|
-          session.with_transaction do
-            expect{ sandwich.meats << Meat.new }.to_not raise_error
-            expect(sandwich.meats.any?).to be true
-          end
-        end
-      end
-    end
-
-    context "when documents have been persisted" do
-
-      let!(:meat) do
-        sandwich.meats.create
-      end
-
-      it "returns true" do
-        expect(sandwich.meats.any?).to be true
-      end
-    end
-
-    context "when documents have not been persisted" do
-
-      let!(:meat) do
-        sandwich.meats.build
-      end
-
-      it "returns false" do
-        expect(sandwich.meats.any?).to be true
-      end
-    end
-
-    context "when new documents exist in the database" do
-      before do
-        Meat.create(sandwiches: [sandwich])
-      end
-
-      it "returns true" do
-        expect(sandwich.meats.any?).to be true
-      end
-    end
-  end
-
   [ :create, :create! ].each do |method|
 
     describe "##{method}" do
@@ -2824,8 +2689,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         expect(preferences).to eq([ preference_one ])
       end
 
-      context 'when providing a collation' do
-        min_server_version '3.4'
+      context 'when providing a collation', if: collation_supported? do
 
         let(:preferences) do
           person.preferences.where(name: "FIRST").collation(locale: 'en_US', strength: 2).to_a
@@ -3017,9 +2881,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       person.preferences
     end
 
-    Array.public_instance_methods.each do |method|
+    Array.public_instance_methods.sort.each do |method|
+
+      context "when checking Array##{method}" do
 
-      context "when checking #{method}" do
+        before do
+          expect([].respond_to?(method)).to be true
+        end
 
         it "returns true" do
           expect(preferences.respond_to?(method)).to be true
@@ -3027,9 +2895,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
     end
 
-    Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy.public_instance_methods.each do |method|
+    Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy.public_instance_methods.sort.each do |method|
 
-      context "when checking #{method}" do
+      context "when checking Proxy##{method}" do
 
         it "returns true" do
           expect(preferences.respond_to?(method)).to be true
@@ -3037,9 +2905,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
     end
 
-    Preference.scopes.keys.each do |method|
+    Preference.scopes.keys.sort.each do |method|
 
-      context "when checking #{method}" do
+      context "when checking scope #{method}" do
 
         it "returns true" do
           expect(preferences.respond_to?(method)).to be true
@@ -3050,20 +2918,36 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
   describe "#scoped" do
 
-    let(:person) do
-      Person.new
-    end
-
     let(:scoped) do
       person.preferences.scoped
     end
 
-    it "returns the relation criteria" do
-      expect(scoped).to be_a(Mongoid::Criteria)
+    context 'when association is empty' do
+
+      let(:person) do
+        Person.new
+      end
+
+      it "returns the relation criteria" do
+        expect(scoped).to be_a(Mongoid::Criteria)
+      end
+
+      it "returns with an empty selector" do
+        expect(scoped.selector).to eq("_id" => { "$in" => [] })
+      end
     end
 
-    it "returns with an empty selector" do
-      expect(scoped.selector).to eq({ "$and" => [{ "_id" => { "$in" => [] }}]})
+    context 'when association is not empty' do
+
+      let(:person) do
+        Person.create!(preferences: [
+          Preference.new(id: 123),
+        ])
+      end
+
+      it "returns with a selector including association element ids" do
+        expect(scoped.selector).to eq("_id" => { "$in" => [123] })
+      end
     end
   end