mongoid 7.0.13 → 7.1.0.rc0

data/spec/mongoid/association/referenced/has_many/proxy_query_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# encoding: utf-8
 
 require "spec_helper"
 require_relative '../has_many_models'

data/spec/mongoid/association/referenced/has_many/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany::Proxy do
@@ -2904,8 +2907,7 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
         expect(posts).to eq([ post_one ])
       end
 
-      context 'when providing a collation' do
-        min_server_version '3.4'
+      context 'when providing a collation', if: collation_supported? do
 
         let(:posts) do
           person.posts.where(title: "FIRST").collation(locale: 'en_US', strength: 2)

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class HmmCompany
   include Mongoid::Document
 

data/spec/mongoid/association/referenced/has_many_query_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './has_many_models'
+
+describe Mongoid::Association::Referenced::HasMany do
+  context 'when projecting with #only' do
+    before do
+      school = HmmSchool.create!(district: 'foo')
+      HmmStudent.create!(school: school, name: 'Dave', grade: 10)
+    end
+
+    let(:school) do
+      HmmSchool.where(district: 'foo').only('students._id', 'students.name').first
+    end
+
+    let(:student) { school.students.first }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(student.name).to eq('Dave')
+      # has a default value specified in the model
+      expect do
+        student.grade
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(student.attributes.keys).to eq(['_id', 'name'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(student.name).to eq('Dave')
+      expect(student.grade).to eq(10)
+    end
+  end
+end

data/spec/mongoid/association/referenced/has_many_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany do

data/spec/mongoid/association/referenced/has_one/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Binding do

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Buildable do

data/spec/mongoid/association/referenced/has_one/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Eager do
@@ -63,9 +66,15 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
       eager.send(:set_on_parent, person.username, :foo)
     end
 
-    it "doesnt call an extra query" do
-      expect_query(0) do
-        eager.send(:set_on_parent, person.username, :foo)
+    context 'when able to make query count assertions' do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
+
+      it "doesnt call an extra query" do
+        expect_query(0) do
+          eager.send(:set_on_parent, person.username, :foo)
+        end
       end
     end
   end
@@ -82,6 +91,9 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
 
     context "when including the has_one relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
 
@@ -95,6 +107,9 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
 
     context "when including more than one has_one relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries 3 times" do
 

data/spec/mongoid/association/referenced/has_one/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Proxy do

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class HomCollege
   include Mongoid::Document
 

data/spec/mongoid/association/referenced/has_one_query_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './has_one_models'
+
+describe Mongoid::Association::Referenced::HasOne do
+  context 'when projecting with #only' do
+    before do
+      college = HomCollege.create!(state: 'ny')
+      HomAccreditation.create!(college: college, degree: 'cs', year: 2017)
+    end
+
+    let(:college) do
+      HomCollege.where(state: 'ny').only('accreditation._id', 'accreditation.degree').first
+    end
+
+    let(:accreditation) { college.accreditation }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(accreditation.degree).to eq('cs')
+      # has a default value specified in the model
+      expect do
+        accreditation.year
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(legislator.attributes.keys).to eq(['_id', 'degree'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(accreditation.degree).to eq('cs')
+      expect(accreditation.year).to eq(2017)
+    end
+  end
+end

data/spec/mongoid/association/referenced/has_one_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative './has_one_models'
 

data/spec/mongoid/association/reflections_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Reflections do

data/spec/mongoid/association/syncable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Syncable Association" do

data/spec/mongoid/association_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association do

data/spec/mongoid/atomic/modifiers_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Modifiers do

data/spec/mongoid/atomic/paths/embedded/many_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths::Embedded::Many do

data/spec/mongoid/atomic/paths/embedded/one_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths::Embedded::One do

data/spec/mongoid/atomic/paths/root_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths::Root do

data/spec/mongoid/atomic/paths_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths do
@@ -265,46 +268,5 @@ describe Mongoid::Atomic::Paths do
         end
       end
     end
-
-    context "when the same class is embedded in multiple associations" do
-
-      let(:customer) do
-        Customer.new
-      end
-
-      context "assignment after saving" do
-
-        it "correctly sets the association for the embedded class" do
-          pending 'MONGOID-5039'
-
-          customer.home_address = CustomerAddress.new
-          customer.work_address = CustomerAddress.new
-
-          expect(customer.home_address.atomic_path).to eq("home_address")
-          expect(customer.work_address.atomic_path).to eq("work_address")
-
-          customer.save!
-
-          customer.home_address = CustomerAddress.new
-          customer.work_address = CustomerAddress.new
-
-          expect(customer.home_address.atomic_path).to eq("home_address")
-          expect(customer.work_address.atomic_path).to eq("work_address")
-        end
-      end
-
-      context "inverse assignment" do
-
-        it "correctly returns the path for each embedded class" do
-          pending 'MONGOID-5039'
-
-          customer.work_address = CustomerAddress.new
-          customer.work_address.addressable = customer
-
-          expect(customer.home_address.atomic_path).to eq("home_address")
-          expect(customer.work_address.atomic_path).to eq("work_address")
-        end
-      end
-    end
   end
 end

data/spec/mongoid/atomic_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Atomic do

data/spec/mongoid/attributes/nested_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Attributes::Nested do

data/spec/mongoid/attributes/readonly_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Attributes::Readonly do

data/spec/mongoid/attributes_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Attributes do
@@ -242,97 +245,6 @@ describe Mongoid::Attributes do
         end
       end
 
-      context "when the field was not explicitly defined" do
-
-        context "when excluding with only and the field was not excluded" do
-
-          let(:from_db) do
-            Person.only(:_id).first
-          end
-
-          it "raises an error" do
-            expect {
-              from_db[:undefined_field]
-            }.to raise_error(ActiveModel::MissingAttributeError)
-          end
-        end
-
-        context "when excluding with without and the field was excluded" do
-
-          let(:from_db) do
-            Person.without(:title).first
-          end
-
-          it "raises an error" do
-            expect {
-              from_db[:title]
-            }.to raise_error(ActiveModel::MissingAttributeError)
-          end
-        end
-
-        context "when excluding with without and the field was not excluded" do
-
-          let(:from_db) do
-            Person.without(:title).first
-          end
-
-          it "returns nil" do
-            from_db[:undefined_field].should be nil
-          end
-        end
-      end
-
-      context 'when projecting with #only' do
-        let!(:person) do
-          Person.create(title: 'sir', name: { first_name: 'Jose', language: { name: 'es' } })
-        end
-
-        context 'when projecting an embedded association' do
-          let(:from_db) do
-            Person.only(:name).first
-          end
-
-          context 'when retrieving a field of the association using the dot notation' do
-
-            it 'retrieves the field' do
-              pending 'MONGOID-5032, fixed in 7.3'
-
-              expect(from_db['name.first_name']).to eq 'Jose'
-            end
-          end
-
-          context 'when retrieving a field of a nested association using the dot notation' do
-            it 'retrieves the field' do
-              pending 'MONGOID-5032, fixed in 7.3'
-
-              expect(from_db['name.language.name']).to eq 'es'
-            end
-          end
-        end
-
-        context 'when projecting a sub-association of an embedded association' do
-          let(:from_db) do
-            Person.only('name.language').first
-          end
-
-          context 'when retrieving a field under the projected sub-association' do
-            it 'retrieves the field' do
-              pending 'MONGOID-5032, fixed in 7.3'
-
-              expect(from_db['name.language.name']).to eq 'es'
-            end
-          end
-
-          context 'when retrieving a non-projected field' do
-            it 'raises MissingAttributeError' do
-              expect do
-                from_db['name.first_name']
-              end.to raise_error(ActiveModel::MissingAttributeError)
-            end
-          end
-        end
-      end
-
       context "when the attribute does not exist" do
 
         before do
@@ -417,67 +329,6 @@ describe Mongoid::Attributes do
         expect(terms).to eq(true)
       end
     end
-
-    context 'when the field is not explicitly defined' do
-      let(:bar) { Bar.new }
-
-      before do
-        bar['missing_field'] = 42
-      end
-
-      it 'writes the value into attributes' do
-        bar.attributes.should == {'_id' => bar.id, 'missing_field' => 42}
-      end
-
-      it 'makes the attribute accessible via []' do
-        bar['missing_field'].should == 42
-      end
-
-      context 'when writing fields on a document with projection' do
-
-        let!(:person) do
-          Person.create(title: "sir")
-        end
-
-        context "when excluding with only and the field was not excluded" do
-
-          let(:from_db) do
-            Person.only(:_id).first
-          end
-
-          it "raises an error" do
-            expect {
-              from_db[:undefined_field] = 'x'
-            }.to raise_error(ActiveModel::MissingAttributeError)
-          end
-        end
-
-        context "when excluding with without and the field was excluded" do
-
-          let(:from_db) do
-            Person.without(:title).first
-          end
-
-          it "raises an error" do
-            expect {
-              from_db[:title] = 'x'
-            }.to raise_error(ActiveModel::MissingAttributeError)
-          end
-        end
-
-        context "when excluding with without and the field was not excluded" do
-
-          let(:from_db) do
-            Person.without(:title).first
-          end
-
-          it "writes the value" do
-            from_db[:undefined_field] = 'x'
-            from_db[:undefined_field].should == 'x'
-          end
-        end
-      end
-    end
   end
 
   describe "#_id" do
@@ -1042,50 +893,6 @@ describe Mongoid::Attributes do
         expect(person.age_before_type_cast).to eq("old")
       end
     end
-
-    context 'when reading fields on a document with projection' do
-
-      let!(:person) do
-        Person.create(title: "sir")
-      end
-
-      context "when excluding with only and the field was not excluded" do
-
-        let(:from_db) do
-          Person.only(:_id).first
-        end
-
-        it "raises an error" do
-          expect {
-            from_db.read_attribute(:undefined_field)
-          }.to raise_error(ActiveModel::MissingAttributeError)
-        end
-      end
-
-      context "when excluding with without and the field was excluded" do
-
-        let(:from_db) do
-          Person.without(:title).first
-        end
-
-        it "raises an error" do
-          expect {
-            from_db.read_attribute(:title)
-          }.to raise_error(ActiveModel::MissingAttributeError)
-        end
-      end
-
-      context "when excluding with without and the field was not excluded" do
-
-        let(:from_db) do
-          Person.without(:title).first
-        end
-
-        it "returns nil" do
-          from_db.read_attribute(:undefined_field).should be nil
-        end
-      end
-    end
   end
 
   describe "#attribute_present?" do
@@ -1542,16 +1349,10 @@ describe Mongoid::Attributes do
     context "when attribute is a Hash" do
       let(:person) { Person.new map: { somekey: "somevalue" } }
 
-      it "raises an error when trying to set a value of invalid type - array" do
-        expect do
+      it "raises an error when try to set an invalid value" do
+        expect {
           person.map = []
-        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type Array cannot be written to a field of type Hash/)
-      end
-
-      it "raises an error when trying to set a value of invalid type - boolean" do
-        expect do
-          person.map = false
-        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type FalseClass cannot be written to a field of type Hash/)
+        }.to raise_error(Mongoid::Errors::InvalidValue)
       end
 
       it "can set a Hash value" do
@@ -1566,16 +1367,10 @@ describe Mongoid::Attributes do
         expect(person.aliases).to eq([ :alias_1 ])
       end
 
-      it "raises an error when trying to set a value of invalid type - hash" do
-        expect do
+      it "raises an error when try to set an invalid value" do
+        expect {
           person.aliases = {}
-        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type Hash cannot be written to a field of type Array/)
-      end
-
-      it "raises an error when trying to set a value of invalid type - boolean" do
-        expect do
-          person.aliases = false
-        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type FalseClass cannot be written to a field of type Array/)
+        }.to raise_error(Mongoid::Errors::InvalidValue)
       end
     end
 
@@ -1591,51 +1386,6 @@ describe Mongoid::Attributes do
         expect(dictionary.description).to eq('foo')
       end
     end
-
-    context 'when writing fields on a document with projection' do
-
-      let!(:person) do
-        Person.create(title: "sir")
-      end
-
-      context "when excluding with only and the field was not excluded" do
-
-        let(:from_db) do
-          Person.only(:_id).first
-        end
-
-        it "raises an error" do
-          expect {
-            from_db.write_attribute(:undefined_field, 'x')
-          }.to raise_error(ActiveModel::MissingAttributeError)
-        end
-      end
-
-      context "when excluding with without and the field was excluded" do
-
-        let(:from_db) do
-          Person.without(:title).first
-        end
-
-        it "raises an error" do
-          expect {
-            from_db.write_attribute(:title, 'x')
-          }.to raise_error(ActiveModel::MissingAttributeError)
-        end
-      end
-
-      context "when excluding with without and the field was not excluded" do
-
-        let(:from_db) do
-          Person.without(:title).first
-        end
-
-        it "writes the value" do
-          from_db.write_attribute(:undefined_field, 'x')
-          from_db.read_attribute(:undefined_field).should == 'x'
-        end
-      end
-    end
   end
 
   describe "#typed_value_for" do
@@ -1675,7 +1425,7 @@ describe Mongoid::Attributes do
   end
 
   describe "#typed_attributes"  do
-
+    
     let(:date_time) do
       DateTime.current
     end