mongoid 7.0.13 → 7.1.0.rc0

data/lib/mongoid/extensions.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 class BSON::ObjectId
   def as_json(options = nil)
     { "$oid" => to_s }

data/lib/mongoid/extensions/array.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Array
@@ -43,26 +45,41 @@ module Mongoid
 
       # Converts the array for storing as a time.
       #
+      # @note Returns a local time in the default time zone.
+      #
       # @example Convert the array to a time.
       #   [ 2010, 1, 1 ].__mongoize_time__
+      #   # => 2010-01-01 00:00:00 -0500
       #
-      # @return [ Time ] The time.
+      # @return [ Time | ActiveSupport::TimeWithZone ] Local time in the
+      #   configured default time zone corresponding to date/time components
+      #   in this array.
       #
       # @since 3.0.0
       def __mongoize_time__
         ::Time.configured.local(*self)
       end
 
-      # Check if the array is part of a blank relation criteria.
+      # Checks whether conditions given in this array are known to be
+      # unsatisfiable, i.e., querying with this array will always return no
+      # documents.
+      #
+      # This method used to assume that the array is the list of criteria
+      # to be used with an $and operator. This assumption is no longer made;
+      # therefore, since the interpretation of conditions in the array differs
+      # between $and, $or and $nor operators, this method now always returns
+      # false.
       #
-      # @example Is the array blank criteria?
-      #   [].blank_criteria?
+      # This method is deprecated. Mongoid now uses
+      # +_mongoid_unsatisfiable_criteria?+ internally; this method is retained
+      # for backwards compatibility only. It always returns false.
       #
-      # @return [ true, false ] If the array is blank criteria.
+      # @return [ false ] Always false.
       #
       # @since 3.1.0
+      # @deprecated
       def blank_criteria?
-        any?(&:blank_criteria?)
+        false
       end
 
       # Is the array a set of multiple arguments in a method?

data/lib/mongoid/extensions/big_decimal.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module BigDecimal

data/lib/mongoid/extensions/boolean.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   class Boolean
 

data/lib/mongoid/extensions/date.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Date
@@ -12,9 +14,12 @@ module Mongoid
       # Convert the date into a time.
       #
       # @example Convert the date to a time.
-      #   date.__mongoize_time__
+      #   Date.new(2018, 11, 1).__mongoize_time__
+      #   # => Thu, 01 Nov 2018 00:00:00 EDT -04:00
       #
-      # @return [ Time ] The converted time.
+      # @return [ Time | ActiveSupport::TimeWithZone ] Local time in the
+      #   configured default time zone corresponding to local midnight of
+      #   this date.
       #
       # @since 3.0.0
       def __mongoize_time__
@@ -64,7 +69,12 @@ module Mongoid
         def mongoize(object)
           unless object.blank?
             begin
-              time = object.__mongoize_time__
+              if object.is_a?(String)
+                # https://jira.mongodb.org/browse/MONGOID-4460
+                time = ::Time.parse(object)
+              else
+                time = object.__mongoize_time__
+              end
               ::Time.utc(time.year, time.month, time.day)
             rescue ArgumentError
               nil

data/lib/mongoid/extensions/date_time.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module DateTime
@@ -8,13 +10,12 @@ module Mongoid
       # @example Mongoize the date time.
       #   date_time.__mongoize_time__
       #
-      # @return [ Time ] The mongoized time.
+      # @return [ Time | ActiveSupport::TimeWithZone ] The mongoized time.
       #
       # @since 3.0.0
       def __mongoize_time__
-        return to_time if utc? && Mongoid.use_utc?
         if Mongoid.use_activesupport_time_zone?
-          in_time_zone(::Time.zone).to_time
+          in_time_zone(::Time.zone)
         else
           time = to_time
           time.respond_to?(:getlocal) ? time.getlocal : time

data/lib/mongoid/extensions/decimal128.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Decimal128

data/lib/mongoid/extensions/false_class.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module FalseClass

data/lib/mongoid/extensions/float.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Float
 
-      # Convert the float into a time.
+      # Converts the float into a time as the number of seconds since the epoch.
       #
       # @example Convert the float into a time.
       #   1335532685.117847.__mongoize_time__
       #
-      # @return [ Time ] The float as a time.
+      # @return [ Time | ActiveSupport::TimeWithZone ] The time.
       #
       # @since 3.0.0
       def __mongoize_time__
-        ::Time.at(self)
+        ::Time.configured.at(self)
       end
 
       # Is the float a number?

data/lib/mongoid/extensions/hash.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Hash
@@ -46,27 +48,63 @@ module Mongoid
             value.each_pair do |_key, _value|
               value[_key] = (key == "$rename") ? _value.to_s : mongoize_for(key, klass, _key, _value)
             end
-            consolidated[key] ||= {}
-            consolidated[key].update(value)
+            (consolidated[key] ||= {}).merge!(value)
           else
-            consolidated["$set"] ||= {}
-            consolidated["$set"].update(key => mongoize_for(key, klass, key, value))
+            (consolidated["$set"] ||= {}).merge!(key => mongoize_for(key, klass, key, value))
           end
         end
         consolidated
       end
 
-      # Check if the hash is part of a blank relation criteria.
+      # Checks whether conditions given in this hash are known to be
+      # unsatisfiable, i.e., querying with this hash will always return no
+      # documents.
+      #
+      # This method only handles condition shapes that Mongoid itself uses when
+      # it builds association queries. It does not guarantee that a false
+      # return value means the condition can produce a non-empty document set -
+      # only that if the return value is true, the condition always produces
+      # an empty document set.
+      #
+      # @example Unsatisfiable conditions
+      #   {'_id' => {'$in' => []}}._mongoid_unsatisfiable_criteria?
+      #   # => true
+      #
+      # @example Conditions which could be satisfiable
+      #   {'_id' => '123'}._mongoid_unsatisfiable_criteria?
+      #   # => false
+      #
+      # @example Conditions which are unsatisfiable that this method does not handle
+      #   {'foo' => {'$in' => []}}._mongoid_unsatisfiable_criteria?
+      #   # => false
+      #
+      # @return [ true | false ] Whether hash contains known unsatisfiable
+      #   conditions.
+      # @api private
+      def _mongoid_unsatisfiable_criteria?
+        unsatisfiable_criteria = { "_id" => { "$in" => [] }}
+        return true if self == unsatisfiable_criteria
+        return false unless length == 1 && keys == %w($and)
+        value = values.first
+        value.is_a?(Array) && value.any? do |sub_v|
+          sub_v.is_a?(Hash) && sub_v._mongoid_unsatisfiable_criteria?
+        end
+      end
+
+      # Checks whether conditions given in this hash are known to be
+      # unsatisfiable, i.e., querying with this hash will always return no
+      # documents.
       #
-      # @example Is the hash blank criteria?
-      #   {}.blank_criteria?
+      # This method is deprecated. Mongoid now uses
+      # +_mongoid_unsatisfiable_criteria?+ internally; this method is retained
+      # for backwards compatibility only.
       #
-      # @return [ true, false ] If the hash is blank criteria.
+      # @return [ true | false ] Whether hash contains known unsatisfiable
+      #   conditions.
       #
       # @since 3.1.0
-      def blank_criteria?
-        self == { "_id" => { "$in" => [] }}
-      end
+      # @deprecated
+      alias :blank_criteria? :_mongoid_unsatisfiable_criteria?
 
       # Deletes an id value from the hash.
       #

data/lib/mongoid/extensions/integer.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Integer
 
-      # Returns the integer as a time.
+      # Converts the integer into a time as the number of seconds since the epoch.
       #
       # @example Convert the integer to a time.
       #   1335532685.__mongoize_time__
       #
-      # @return [ Time ] The converted time.
+      # @return [ Time | ActiveSupport::TimeWithZone ] The time.
       #
       # @since 3.0.0
       def __mongoize_time__
-        ::Time.at(self)
+        ::Time.configured.at(self)
       end
 
       # Is the integer a number?

data/lib/mongoid/extensions/module.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Module

data/lib/mongoid/extensions/nil_class.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module NilClass

data/lib/mongoid/extensions/object.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Object
@@ -30,12 +32,18 @@ module Mongoid
 
       # Mongoize a plain object into a time.
       #
+      # @note This method should not be used, because it does not
+      #   return correct results for non-Time objects. Override
+      #   __mongoize_time__ in classes that are time-like to return an
+      #   instance of Time or ActiveSupport::TimeWithZone.
+      #
       # @example Mongoize the object.
       #   object.__mongoize_time__
       #
       # @return [ Object ] self.
       #
       # @since 3.0.0
+      # @deprecated
       def __mongoize_time__
         self
       end
@@ -76,14 +84,18 @@ module Mongoid
         self
       end
 
-      # Check if the object is part of a blank relation criteria.
+      # Checks whether conditions given in this object are known to be
+      # unsatisfiable, i.e., querying with this object will always return no
+      # documents.
       #
-      # @example Is the object blank criteria?
-      #   "".blank_criteria?
+      # This method is deprecated. Mongoid now uses
+      # +_mongoid_unsatisfiable_criteria?+ internally; this method is retained
+      # for backwards compatibility only. It always returns false.
       #
-      # @return [ true, false ] If the object is blank criteria.
+      # @return [ false ] Always false.
       #
       # @since 3.1.0
+      # @deprecated
       def blank_criteria?
         false
       end

data/lib/mongoid/extensions/object_id.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module ObjectId

data/lib/mongoid/extensions/range.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Range

data/lib/mongoid/extensions/regexp.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Regexp
@@ -9,7 +11,7 @@ module Mongoid
         # type.
         #
         # @example Mongoize the object.
-        #   Regexp.mongoize(/\A[abc]/)
+        #   Regexp.mongoize(/^[abc]/)
         #
         # @param [ Regexp, String ] object The object to mongoize.
         #

data/lib/mongoid/extensions/set.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Set

data/lib/mongoid/extensions/string.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module String
 
-      # @attribute [rw] unconvertable_to_bson If the document is unconvetable.
+      # @attribute [rw] unconvertable_to_bson If the document is unconvertable.
       attr_accessor :unconvertable_to_bson
 
       # Evolve the string into an object id if possible.
@@ -32,20 +34,27 @@ module Mongoid
 
       # Mongoize the string for storage.
       #
+      # @note Returns a local time in the default time zone.
+      #
       # @example Mongoize the string.
       #   "2012-01-01".__mongoize_time__
+      #   # => 2012-01-01 00:00:00 -0500
       #
-      # @note The extra parse from Time is because ActiveSupport::TimeZone
-      #   either returns nil or Time.now if the string is empty or invalid,
-      #   which is a regression from pre-3.0 and also does not agree with
-      #   the core Time API.
-      #
-      # @return [ Time ] The time.
+      # @return [ Time | ActiveSupport::TimeWithZone ] Local time in the
+      #   configured default time zone corresponding to this string.
       #
       # @since 3.0.0
       def __mongoize_time__
-        ::Time.parse(self)
-        ::Time.configured.parse(self)
+        # This extra parse from Time is because ActiveSupport::TimeZone
+        # either returns nil or Time.now if the string is empty or invalid,
+        # which is a regression from pre-3.0 and also does not agree with
+        # the core Time API.
+        parsed = ::Time.parse(self)
+        if ::Time == ::Time.configured
+          parsed
+        else
+          ::Time.configured.parse(self)
+        end
       end
 
       # Convert the string to a collection friendly name.

data/lib/mongoid/extensions/symbol.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
 # encoding: utf-8
+
 module Mongoid
   module Extensions
     module Symbol