mongo 2.6.4 → 2.7.0.rc0

data/spec/mongo/server_spec.rb

@@ -2,14 +2,13 @@ require 'spec_helper'
 
 describe Mongo::Server do
 
-  let(:topology) do
-    double('topology')
-  end
+  declare_topology_double
 
   let(:cluster) do
     double('cluster').tap do |cl|
       allow(cl).to receive(:topology).and_return(topology)
       allow(cl).to receive(:app_metadata).and_return(app_metadata)
+      allow(cl).to receive(:options).and_return({})
     end
   end
 
@@ -32,7 +31,7 @@ describe Mongo::Server do
   describe '#==' do
 
     let(:server) do
-      described_class.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     after do
@@ -56,7 +55,7 @@ describe Mongo::Server do
       context 'when the addresses match' do
 
         let(:other) do
-          described_class.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+          described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
         end
 
         it 'returns true' do
@@ -71,7 +70,7 @@ describe Mongo::Server do
         end
 
         let(:other) do
-          described_class.new(other_address, cluster, monitoring, listeners, TEST_OPTIONS)
+          described_class.new(other_address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
         end
 
         it 'returns false' do
@@ -84,7 +83,7 @@ describe Mongo::Server do
   describe '#disconnect!' do
 
     let(:server) do
-      described_class.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     it 'stops the monitor instance' do
@@ -102,7 +101,7 @@ describe Mongo::Server do
         cluster,
         monitoring,
         listeners,
-        TEST_OPTIONS.merge(:heartbeat_frequency => 5)
+        SpecConfig.instance.test_options.merge(:heartbeat_frequency => 5)
       )
     end
 
@@ -120,14 +119,34 @@ describe Mongo::Server do
     end
 
     it 'sets the options' do
-      expect(server.options).to eq(TEST_OPTIONS.merge(:heartbeat_frequency => 5))
+      expect(server.options).to eq(SpecConfig.instance.test_options.merge(:heartbeat_frequency => 5))
+    end
+
+    it 'creates monitor with monitoring app metadata' do
+      expect(server.monitor.options[:app_metadata]).to be_a(Mongo::Server::Monitor::AppMetadata)
+    end
+
+    context 'monitoring_io: false' do
+      let(:server) do
+        described_class.new(
+          address,
+          cluster,
+          monitoring,
+          listeners,
+          SpecConfig.instance.test_options.merge(monitoring_io: false)
+        )
+      end
+
+      it 'does not create monitoring thread' do
+        expect(server.monitor.instance_variable_get('@thread')).to be nil
+      end
     end
   end
 
   describe '#scan!' do
 
     let(:server) do
-      described_class.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     after do
@@ -143,7 +162,7 @@ describe Mongo::Server do
   describe '#reconnect!' do
 
     let(:server) do
-      described_class.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     before do
@@ -163,7 +182,7 @@ describe Mongo::Server do
   describe 'retry_writes?' do
 
     let(:server) do
-      described_class.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     before do

data/spec/mongo/session/session_pool_spec.rb

@@ -1,6 +1,8 @@
 require 'spec_helper'
 
-describe Mongo::Session::SessionPool, if: test_sessions? do
+describe Mongo::Session::SessionPool do
+  min_server_version '3.6'
+  require_topology :replica_set, :sharded
 
   let(:cluster) do
     authorized_client.cluster

data/spec/mongo/session_spec.rb

@@ -1,6 +1,8 @@
 require 'spec_helper'
 
-describe Mongo::Session, if: test_sessions? do
+describe Mongo::Session do
+  min_server_version '3.6'
+  require_topology :replica_set, :sharded
 
   let(:session) do
     authorized_client.start_session(options)
@@ -210,7 +212,7 @@ describe Mongo::Session, if: test_sessions? do
     end
   end
 
-  describe '#retry_writes?', if: test_sessions? do
+  describe '#retry_writes?' do
 
     context 'when the option is set to true' do
 
@@ -239,6 +241,7 @@ describe Mongo::Session, if: test_sessions? do
     end
 
     context 'when the option is not defined' do
+      require_no_retry_writes
 
       let(:client) do
         authorized_client
@@ -249,4 +252,63 @@ describe Mongo::Session, if: test_sessions? do
       end
     end
   end
+
+  describe '#session_id' do
+    it 'returns a BSON::Document' do
+      expect(session.session_id).to be_a(BSON::Document)
+    end
+
+    context 'ended session' do
+      before do
+        session.end_session
+      end
+
+      it 'raises SessionEnded' do
+        expect do
+          session.session_id
+        end.to raise_error(Mongo::Error::SessionEnded)
+      end
+    end
+  end
+
+  describe '#txn_num' do
+    it 'returns an integer' do
+      expect(session.txn_num).to be_a(Integer)
+    end
+
+    context 'ended session' do
+      before do
+        session.end_session
+      end
+
+      it 'raises SessionEnded' do
+        expect do
+          session.txn_num
+        end.to raise_error(Mongo::Error::SessionEnded)
+      end
+    end
+  end
+
+  describe '#next_txn_num' do
+    it 'returns an integer' do
+      expect(session.next_txn_num).to be_a(Integer)
+    end
+
+    it 'increments transaction number on each call' do
+      expect(session.next_txn_num).to eq(1)
+      expect(session.next_txn_num).to eq(2)
+    end
+
+    context 'ended session' do
+      before do
+        session.end_session
+      end
+
+      it 'raises SessionEnded' do
+        expect do
+          session.next_txn_num
+        end.to raise_error(Mongo::Error::SessionEnded)
+      end
+    end
+  end
 end

data/spec/mongo/session_transaction_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+class SessionTransactionSpecError < StandardError; end
+
+describe Mongo::Session do
+  min_server_version '4.0'
+  require_topology :replica_set, :sharded
+
+  let(:session) do
+    authorized_client.start_session(session_options)
+  end
+
+  let(:session_options) do
+    {}
+  end
+
+  let(:collection) do
+    authorized_client['session-transaction-test']
+  end
+
+  before do
+    collection.delete_many
+  end
+
+  describe '#with_transaction' do
+    context 'callback successful' do
+      it 'commits' do
+        session.with_transaction do
+          collection.insert_one(a: 1)
+        end
+
+        result = collection.find(a: 1).first
+        expect(result[:a]).to eq(1)
+      end
+
+      it 'propagates callback\'s return value' do
+        rv = session.with_transaction do
+          42
+        end
+        expect(rv).to eq(42)
+      end
+    end
+
+    context 'callback raises' do
+      it 'propagates the exception' do
+        expect do
+          session.with_transaction do
+            raise SessionTransactionSpecError, 'test error'
+          end
+        end.to raise_error(SessionTransactionSpecError, 'test error')
+      end
+    end
+
+    context 'callback aborts transaction' do
+      it 'does not raise exceptions and propagates callback\'s return value' do
+        rv = session.with_transaction do
+          session.abort_transaction
+          42
+        end
+        expect(rv).to eq(42)
+      end
+    end
+  end
+end

data/spec/mongo/socket/ssl_spec.rb

@@ -1,13 +1,14 @@
 require 'spec_helper'
 
-describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
+describe Mongo::Socket::SSL do
+  require_ssl
 
   let(:address) do
     default_address
   end
 
   let(:resolver) do
-    address.instance_variable_get(:@resolver)
+    address.send(:create_resolver, {})
   end
 
   let(:socket_timeout) do
@@ -19,15 +20,15 @@ describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
   end
 
   let(:options) do
-    SSL_OPTIONS
+    SpecConfig.instance.ssl_options
   end
 
   let (:key_string) do
-    File.read(CLIENT_KEY_PEM)
+    File.read(SpecConfig.instance.client_key_pem)
   end
 
   let (:cert_string) do
-    File.read(CLIENT_CERT_PEM)
+    File.read(SpecConfig.instance.client_cert_pem)
   end
 
   let (:ca_cert_string) do
@@ -278,7 +279,49 @@ describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
       end
     end
 
-    context 'when ruby version is < 2.4.1', if: (RUBY_VERSION < '2.4.1' && SpecConfig.instance.ssl?) do
+    context 'when the hostname is incorrect' do
+      let(:host_name) do
+        'incorrect_hostname'
+      end
+
+      context 'when the hostname is verified' do
+        it 'raises an error' do
+          error = nil
+          begin
+            described_class.new(
+              address.host,
+              address.port,
+              host_name,
+              30,
+              ::Socket::PF_INET,
+              options.merge(ssl_verify_hostname: true)
+            ).connect!
+          rescue => e
+            error = e
+          end
+
+          expect(error).to be_a(Mongo::Error::SocketError)
+          expect(error.message).to eq('SSL handshake failed due to a hostname mismatch.')
+        end
+      end
+
+      context 'when the hostname is not verified' do
+        it 'raises an error' do
+          expect {
+            described_class.new(
+              address.host,
+              address.port,
+              host_name,
+              30,
+              ::Socket::PF_INET,
+              options.merge(ssl_verify_hostname: false)
+            ).connect!
+          }.not_to raise_error
+        end
+      end
+    end
+
+    context 'when ruby version is < 2.4.1', if: (RUBY_VERSION < '2.4.1') do
 
       context 'when a key is passed, but it is not of the right type' do
 
@@ -302,7 +345,9 @@ describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
 
     # Note that as of MRI 2.4, Creating a socket with the wrong key type raises
     # a NoMethodError because #private? is attempted to be called on the key.
-    context 'when ruby version is >= 2.4.1', if: (RUBY_VERSION >= '2.4.1' && SpecConfig.instance.ssl?) do
+    # In jruby 9.2 a TypeError is raised.
+    # In jruby 9.1 a OpenSSL::PKey::PKeyError is raised.
+    context 'when ruby version is >= 2.4.1', if: (RUBY_VERSION >= '2.4.1') do
 
       context 'when a key is passed, but it is not of the right type' do
 
@@ -316,10 +361,24 @@ describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
           }
         end
 
+        let(:expected_exception) do
+          if SpecConfig.instance.jruby?
+            if RUBY_VERSION >= '2.5.0'
+              # jruby 9.2
+              TypeError
+            else
+              # jruby 9.1
+              OpenSSL::OpenSSLError
+            end
+          else
+            NoMethodError
+          end
+        end
+
         it 'raises a NoMethodError' do
           expect{
             socket.connect!
-          }.to raise_exception(NoMethodError)
+          }.to raise_exception(expected_exception)
         end
       end
     end
@@ -332,10 +391,27 @@ describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
         )
       end
 
+      let(:expected_exception) do
+        if SpecConfig.instance.jruby?
+          # java.lang.ClassCastException: org.bouncycastle.asn1.DERApplicationSpecific cannot be cast to org.bouncycastle.asn1.ASN1Sequence
+          # https://github.com/jruby/jruby-openssl/issues/171
+          Exception
+        else
+          # mri
+          if RUBY_VERSION >= '2.4.0'
+            # OpenSSL::PKey::PKeyError: Could not parse PKey: no start line
+            OpenSSL::OpenSSLError
+          else
+            # ArgumentError: Could not parse PKey: no start line
+            ArgumentError
+          end
+        end
+      end
+
       it 'raises an exception' do
         expect {
           socket.connect!
-        }.to raise_exception
+        }.to raise_exception(expected_exception)
       end
     end
 
@@ -464,7 +540,7 @@ describe Mongo::Socket::SSL, if: SpecConfig.instance.ssl? do
       end
 
       before do
-        ENV['SSL_CERT_FILE']= CA_PEM
+        ENV['SSL_CERT_FILE'] = CA_PEM
         socket.connect!
       end
 

data/spec/mongo/uri/srv_protocol_spec.rb

@@ -256,7 +256,7 @@ describe Mongo::URI::SRVProtocol do
 
     describe '#client_options' do
 
-      let(:db)          { TEST_DB }
+      let(:db)          { SpecConfig.instance.test_db }
       let(:servers)     { 'test5.test.build.10gen.cc' }
       let(:string)      { "#{scheme}#{credentials}@#{servers}/#{db}" }
       let(:user)        { 'tyler' }
@@ -268,7 +268,7 @@ describe Mongo::URI::SRVProtocol do
       end
 
       it 'includes the database in the options' do
-        expect(options[:database]).to eq(TEST_DB)
+        expect(options[:database]).to eq(SpecConfig.instance.test_db)
       end
 
       it 'includes the user in the options' do
@@ -346,7 +346,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:write]).to eq(concern)
+            expect(new_local_client(string).options[:write]).to eq(concern)
           end
         end
 
@@ -359,7 +359,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:write]).to eq(concern)
+            expect(new_local_client(string).options[:write]).to eq(concern)
           end
         end
 
@@ -372,7 +372,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:write]).to eq(concern)
+            expect(new_local_client(string).options[:write]).to eq(concern)
           end
         end
 
@@ -385,7 +385,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:write]).to eq(concern)
+            expect(new_local_client(string).options[:write]).to eq(concern)
           end
         end
 
@@ -399,7 +399,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:write]).to eq(concern)
+            expect(new_local_client(string).options[:write]).to eq(concern)
           end
         end
       end
@@ -416,7 +416,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
 
@@ -429,7 +429,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
 
@@ -442,7 +442,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
 
@@ -455,7 +455,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
 
@@ -468,7 +468,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
       end
@@ -489,7 +489,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
 
@@ -507,7 +507,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:read]).to eq(read)
+            expect(new_local_client(string).options[:read]).to eq(read)
           end
         end
       end
@@ -527,7 +527,7 @@ describe Mongo::URI::SRVProtocol do
         end
 
         it 'sets the options on a client created with the uri' do
-          expect(Mongo::Client.new(string).options[:read]).to eq(read)
+          expect(new_local_client(string).options[:read]).to eq(read)
         end
 
         context 'when the read preference and max staleness combination is invalid' do
@@ -540,7 +540,7 @@ describe Mongo::URI::SRVProtocol do
 
             it 'raises an exception when read preference is accessed on the client' do
               expect {
-                Mongo::Client.new(string).server_selector
+                new_local_client(string).server_selector
               }.to raise_exception(Mongo::Error::InvalidServerPreference)
             end
           end
@@ -552,7 +552,7 @@ describe Mongo::URI::SRVProtocol do
             end
 
             it 'does not raise an exception until the read preference is used' do
-              expect(Mongo::Client.new(string).read_preference).to eq(BSON::Document.new(mode: :secondary, max_staleness: 89))
+              expect(new_local_client(string).read_preference).to eq(BSON::Document.new(mode: :secondary, max_staleness: 89))
             end
           end
         end
@@ -567,7 +567,7 @@ describe Mongo::URI::SRVProtocol do
         end
 
         it 'sets the options on a client created with the uri' do
-          expect(Mongo::Client.new(string).options[:replica_set]).to eq(rs_name)
+          expect(new_local_client(string).options[:replica_set]).to eq(rs_name)
         end
       end
 
@@ -583,11 +583,11 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech]).to eq(expected)
           end
 
           it 'is case-insensitive' do
-            expect(Mongo::Client.new(string.downcase).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string.downcase).options[:auth_mech]).to eq(expected)
           end
         end
 
@@ -600,11 +600,11 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech]).to eq(expected)
           end
 
           it 'is case-insensitive' do
-            expect(Mongo::Client.new(string.downcase).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string.downcase).options[:auth_mech]).to eq(expected)
           end
         end
 
@@ -617,11 +617,11 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech]).to eq(expected)
           end
 
           it 'is case-insensitive' do
-            expect(Mongo::Client.new(string.downcase).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string.downcase).options[:auth_mech]).to eq(expected)
           end
         end
 
@@ -634,11 +634,11 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech]).to eq(expected)
           end
 
           it 'is case-insensitive' do
-            expect(Mongo::Client.new(string.downcase).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string.downcase).options[:auth_mech]).to eq(expected)
           end
         end
 
@@ -651,18 +651,18 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech]).to eq(expected)
           end
 
           it 'is case-insensitive' do
-            expect(Mongo::Client.new(string.downcase).options[:auth_mech]).to eq(expected)
+            expect(new_local_client(string.downcase).options[:auth_mech]).to eq(expected)
           end
 
           context 'when a username is not provided' do
 
             it 'recognizes the mechanism with no username' do
-              expect(Mongo::Client.new(string.downcase).options[:auth_mech]).to eq(expected)
-              expect(Mongo::Client.new(string.downcase).options[:user]).to be_nil
+              expect(new_local_client(string.downcase).options[:auth_mech]).to eq(expected)
+              expect(new_local_client(string.downcase).options[:user]).to be_nil
             end
           end
         end
@@ -679,7 +679,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_source]).to eq(source)
+            expect(new_local_client(string).options[:auth_source]).to eq(source)
           end
         end
 
@@ -692,7 +692,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_source]).to eq(expected)
+            expect(new_local_client(string).options[:auth_source]).to eq(expected)
           end
         end
       end
@@ -712,7 +712,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech_properties]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech_properties]).to eq(expected)
           end
         end
 
@@ -728,7 +728,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech_properties]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech_properties]).to eq(expected)
           end
         end
 
@@ -746,7 +746,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech_properties]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech_properties]).to eq(expected)
           end
         end
 
@@ -772,7 +772,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           it 'sets the options on a client created with the uri' do
-            expect(Mongo::Client.new(string).options[:auth_mech_properties]).to eq(expected)
+            expect(new_local_client(string).options[:auth_mech_properties]).to eq(expected)
           end
         end
       end
@@ -900,7 +900,7 @@ describe Mongo::URI::SRVProtocol do
         let(:options) { "appname=srv_test" }
 
         it 'sets the app name on the client' do
-          expect(Mongo::Client.new(string).options[:app_name]).to eq(:srv_test)
+          expect(new_local_client(string).options[:app_name]).to eq(:srv_test)
         end
       end
 
@@ -908,7 +908,7 @@ describe Mongo::URI::SRVProtocol do
         let(:options) { "compressors=zlib" }
 
         it 'sets the compressors as an array on the client' do
-          expect(Mongo::Client.new(string).options[:compressors]).to eq(['zlib'])
+          expect(new_local_client(string).options[:compressors]).to eq(['zlib'])
         end
       end
 
@@ -916,7 +916,7 @@ describe Mongo::URI::SRVProtocol do
         let(:options) { "compressors=snoopy" }
 
         let(:client) do
-          Mongo::Client.new(string)
+          new_local_client(string)
         end
 
         it 'sets no compressors on the client and warns' do
@@ -929,7 +929,7 @@ describe Mongo::URI::SRVProtocol do
         let(:options) { "zlibCompressionLevel=6" }
 
         it 'sets the zlib compression level on the client' do
-          expect(Mongo::Client.new(string).options[:zlib_compression_level]).to eq(6)
+          expect(new_local_client(string).options[:zlib_compression_level]).to eq(6)
         end
       end
     end