mongo 2.6.4 → 2.7.0.rc0

data/spec/mongo/server/description_query_methods_spec.rb

@@ -0,0 +1,288 @@
+require 'spec_helper'
+
+# For conciseness these tests are arranged by description types
+# rather than by methods being tested, as is customary
+describe Mongo::Server::Description do
+  let(:address) do
+    Mongo::Address.new(authorized_primary.address.to_s)
+  end
+
+  let(:desc_options) { {} }
+  let(:ok) { 1 }
+  let(:description) { described_class.new(address, desc_options) }
+
+  shared_examples_for 'is unknown' do
+    it 'is unknown' do
+      expect(description).to be_unknown
+    end
+
+    %w(
+      arbiter ghost hidden mongos passive primary secondary standalone
+      other
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is not data-bearing' do
+      expect(description.data_bearing?).to be false
+    end
+  end
+
+  context 'unknown' do
+    context 'empty description' do
+      it_behaves_like 'is unknown'
+    end
+  end
+
+  context 'ghost' do
+    let(:desc_options) { {'isreplicaset' => true,
+      'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => ok} }
+
+    it 'is ghost' do
+      expect(description).to be_ghost
+    end
+
+    %w(
+      arbiter hidden mongos passive primary secondary standalone
+      other unknown
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is not data-bearing' do
+      expect(description.data_bearing?).to be false
+    end
+
+    context 'ok: 0' do
+      let(:ok) { 0 }
+
+      it_behaves_like 'is unknown'
+    end
+  end
+
+  context 'mongos' do
+    let(:desc_options) { {'msg' => 'isdbgrid',
+      'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => ok} }
+
+    it 'is mongos' do
+      expect(description).to be_mongos
+    end
+
+    %w(
+      arbiter hidden passive primary secondary standalone
+      other unknown ghost
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is data-bearing' do
+      expect(description.data_bearing?).to be true
+    end
+
+    context 'ok: 0' do
+      let(:ok) { 0 }
+
+      it_behaves_like 'is unknown'
+    end
+  end
+
+  context 'primary' do
+    let(:desc_options) { {'ismaster' => true,
+      'minWireVersion' => 2, 'maxWireVersion' => 8,
+      'setName' => 'foo', 'ok' => ok} }
+
+    it 'is primary' do
+      expect(description).to be_primary
+    end
+
+    %w(
+      arbiter hidden passive mongos secondary standalone
+      other unknown ghost
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is data-bearing' do
+      expect(description.data_bearing?).to be true
+    end
+
+    context 'ok: 0' do
+      let(:ok) { 0 }
+
+      it_behaves_like 'is unknown'
+    end
+  end
+
+  context 'secondary' do
+    let(:desc_options) { {'secondary' => true,
+      'minWireVersion' => 2, 'maxWireVersion' => 8,
+      'setName' => 'foo', 'ok' => ok} }
+
+    it 'is secondary' do
+      expect(description).to be_secondary
+    end
+
+    %w(
+      arbiter hidden passive mongos primary standalone
+      other unknown ghost
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is data-bearing' do
+      expect(description.data_bearing?).to be true
+    end
+
+    context 'ok: 0' do
+      let(:ok) { 0 }
+
+      it_behaves_like 'is unknown'
+    end
+
+    it 'is not passive' do
+      expect(description).not_to be_passive
+    end
+
+    context 'passive' do
+      let(:desc_options) { {'secondary' => true,
+        'minWireVersion' => 2, 'maxWireVersion' => 8,
+        'setName' => 'foo', 'passive' => true, 'ok' => ok} }
+
+      it 'is passive' do
+        expect(description).to be_passive
+      end
+
+      it 'is data-bearing' do
+        expect(description.data_bearing?).to be true
+      end
+
+      context 'ok: 0' do
+        let(:ok) { 0 }
+
+        it_behaves_like 'is unknown'
+
+        it 'is not passive' do
+          expect(description).not_to be_passive
+        end
+      end
+    end
+  end
+
+  context 'arbiter' do
+    let(:desc_options) { {'arbiterOnly' => true,
+      'minWireVersion' => 2, 'maxWireVersion' => 8,
+      'setName' => 'foo', 'ok' => ok} }
+
+    it 'is arbiter' do
+      expect(description).to be_arbiter
+    end
+
+    %w(
+      secondary hidden passive mongos primary standalone
+      other unknown ghost
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is not data-bearing' do
+      expect(description.data_bearing?).to be false
+    end
+
+    context 'ok: 0' do
+      let(:ok) { 0 }
+
+      it_behaves_like 'is unknown'
+    end
+  end
+
+  context 'standalone' do
+    let(:desc_options) { {'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => ok} }
+
+    it 'is standalone' do
+      expect(description).to be_standalone
+    end
+
+    %w(
+      secondary hidden passive mongos primary arbiter
+      other unknown ghost
+    ).each do |type|
+      it "is not #{type}" do
+        expect(description.send("#{type}?")).to be false
+      end
+    end
+
+    it 'is data-bearing' do
+      expect(description.data_bearing?).to be true
+    end
+
+    context 'ok: 0' do
+      let(:ok) { 0 }
+
+      it_behaves_like 'is unknown'
+    end
+  end
+
+  context 'other' do
+
+    shared_examples_for 'is other' do
+
+      it 'is other' do
+        expect(description).to be_other
+      end
+
+      %w(
+        secondary passive mongos primary arbiter
+        standalone unknown ghost
+      ).each do |type|
+        it "is not #{type}" do
+          expect(description.send("#{type}?")).to be false
+        end
+      end
+
+      it 'is not data-bearing' do
+        expect(description.data_bearing?).to be false
+      end
+
+      context 'ok: 0' do
+        let(:ok) { 0 }
+
+        it_behaves_like 'is unknown'
+      end
+    end
+
+    context 'hidden: true' do
+      let(:desc_options) { {'setName' => 'foo',
+        'minWireVersion' => 2, 'maxWireVersion' => 8,
+        'hidden' => true, 'ok' => ok} }
+
+      it_behaves_like 'is other'
+
+      it 'is hidden' do
+        expect(description).to be_hidden
+      end
+    end
+
+    context 'not hidden: true' do
+      let(:desc_options) { {'setName' => 'foo',
+        'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => ok} }
+
+      it_behaves_like 'is other'
+
+      it 'is not hidden' do
+        expect(description).not_to be_hidden
+      end
+    end
+  end
+end

data/spec/mongo/server/description_spec.rb

@@ -39,39 +39,13 @@ describe Mongo::Server::Description do
     Mongo::Monitoring.new(monitoring: false)
   end
 
-  let(:topology) do
-    double('topology')
-  end
+  declare_topology_double
 
   let(:cluster) do
     double('cluster').tap do |cl|
       allow(cl).to receive(:topology).and_return(topology)
       allow(cl).to receive(:app_metadata).and_return(app_metadata)
-    end
-  end
-
-  describe '#arbiter?' do
-
-    context 'when the server is an arbiter' do
-
-      let(:description) do
-        described_class.new(address, { 'arbiterOnly' => true, 'setName' => 'test' })
-      end
-
-      it 'returns true' do
-        expect(description).to be_arbiter
-      end
-    end
-
-    context 'when the server is not an arbiter' do
-
-      let(:description) do
-        described_class.new(address, replica)
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_arbiter
-      end
+      allow(cl).to receive(:options).and_return({})
     end
   end
 
@@ -121,60 +95,6 @@ describe Mongo::Server::Description do
     end
   end
 
-  describe '#ghost?' do
-
-    context 'when the server is a ghost' do
-
-      let(:config) do
-        { 'isreplicaset' => true }
-      end
-
-      let(:description) do
-        described_class.new(address, config)
-      end
-
-      it 'returns true' do
-        expect(description).to be_ghost
-      end
-    end
-
-    context 'when the server is not a ghost' do
-
-      let(:description) do
-        described_class.new(address, replica)
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_ghost
-      end
-    end
-  end
-
-  describe '#hidden?' do
-
-    context 'when the server is hidden' do
-
-      let(:description) do
-        described_class.new(address, { 'hidden' => true })
-      end
-
-      it 'returns true' do
-        expect(description).to be_hidden
-      end
-    end
-
-    context 'when the server is not hidden' do
-
-      let(:description) do
-        described_class.new(address, replica)
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_hidden
-      end
-    end
-  end
-
   describe '#hosts' do
 
     let(:description) do
@@ -260,7 +180,7 @@ describe Mongo::Server::Description do
       end
 
       it 'returns the default' do
-        expect(description.max_wire_version).to eq(0)
+        expect(description.max_wire_version).to be nil
       end
     end
   end
@@ -285,7 +205,7 @@ describe Mongo::Server::Description do
       end
 
       it 'returns the default' do
-        expect(description.min_wire_version).to eq(0)
+        expect(description.min_wire_version).to be nil
       end
     end
   end
@@ -319,60 +239,6 @@ describe Mongo::Server::Description do
     end
   end
 
-  describe '#mongos?' do
-
-    context 'when the server is a mongos' do
-
-      let(:config) do
-        { 'msg' => 'isdbgrid', 'ismaster' => true }
-      end
-
-      let(:description) do
-        described_class.new(address, config)
-      end
-
-      it 'returns true' do
-        expect(description).to be_mongos
-      end
-    end
-
-    context 'when the server is not a mongos' do
-
-      let(:description) do
-        described_class.new(address, replica)
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_mongos
-      end
-    end
-  end
-
-  describe '#passive?' do
-
-    context 'when the server is passive' do
-
-      let(:description) do
-        described_class.new(address, { 'passive' => true })
-      end
-
-      it 'returns true' do
-        expect(description).to be_passive
-      end
-    end
-
-    context 'when the server is not passive' do
-
-      let(:description) do
-        described_class.new(address, replica)
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_passive
-      end
-    end
-  end
-
   describe '#passives' do
 
     context 'when passive servers exists' do
@@ -425,17 +291,6 @@ describe Mongo::Server::Description do
 
   describe '#primary?' do
 
-    context 'when the server is not a primary' do
-
-      let(:description) do
-        described_class.new(address, { 'ismaster' => false })
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_primary
-      end
-    end
-
     context 'when the server is a primary' do
 
       context 'when the hostname contains no capital letters' do
@@ -453,7 +308,8 @@ describe Mongo::Server::Description do
 
         let(:description) do
           described_class.new('localhost:27017',
-                              { 'ismaster' => true,
+                              { 'ismaster' => true, 'ok' => 1,
+                                'minWireVersion' => 2, 'maxWireVersion' => 3,
                                 'primary' => 'LOCALHOST:27017',
                                 'setName' => 'itsASet!'})
         end
@@ -471,8 +327,8 @@ describe Mongo::Server::Description do
       described_class.new(address, { 'secondary' => false }, 4.5)
     end
 
-    it 'defaults to 0' do
-      expect(described_class.new(address).average_round_trip_time).to eq(0)
+    it 'defaults to nil' do
+      expect(described_class.new(address).average_round_trip_time).to be nil
     end
 
     it 'can be set via the constructor' do
@@ -505,31 +361,6 @@ describe Mongo::Server::Description do
     end
   end
 
-  describe '#secondary?' do
-
-    context 'when the server is not a secondary' do
-
-      let(:description) do
-        described_class.new(address, { 'secondary' => false })
-      end
-
-      it 'returns true' do
-        expect(description).to_not be_secondary
-      end
-    end
-
-    context 'when the server is a secondary' do
-
-      let(:description) do
-        described_class.new(address, { 'secondary' => true, 'setName' => 'test' })
-      end
-
-      it 'returns false' do
-        expect(description).to be_secondary
-      end
-    end
-  end
-
   describe '#servers' do
 
     let(:config) do
@@ -547,37 +378,14 @@ describe Mongo::Server::Description do
     end
   end
 
-  describe '#standalone?' do
-
-    context 'when the server is standalone' do
-
-      let(:description) do
-        described_class.new(address, { 'ismaster' => true, 'ok' => 1 })
-      end
-
-      it 'returns true' do
-        expect(description).to be_standalone
-      end
-    end
-
-    context 'when the server is part of a replica set' do
-
-      let(:description) do
-        described_class.new(address, replica)
-      end
-
-      it 'returns false' do
-        expect(description).to_not be_standalone
-      end
-    end
-  end
-
   describe '#server_type' do
 
     context 'when the server is an arbiter' do
 
       let(:description) do
-        described_class.new(address, { 'arbiterOnly' => true, 'setName' => 'test' })
+        described_class.new(address, { 'arbiterOnly' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3,
+          'setName' => 'test', 'ok' => 1 })
       end
 
       it 'returns :arbiter' do
@@ -588,7 +396,8 @@ describe Mongo::Server::Description do
     context 'when the server is a ghost' do
 
       let(:description) do
-        described_class.new(address, { 'isreplicaset' => true })
+        described_class.new(address, { 'isreplicaset' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 })
       end
 
       it 'returns :ghost' do
@@ -599,7 +408,8 @@ describe Mongo::Server::Description do
     context 'when the server is a mongos' do
 
       let(:config) do
-        { 'msg' => 'isdbgrid', 'ismaster' => true }
+        { 'msg' => 'isdbgrid', 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 }
       end
 
       let(:description) do
@@ -625,7 +435,9 @@ describe Mongo::Server::Description do
     context 'when the server is a secondary' do
 
       let(:description) do
-        described_class.new(address, { 'secondary' => true, 'setName' => 'test' })
+        described_class.new(address, { 'secondary' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3,
+          'setName' => 'test', 'ok' => 1 })
       end
 
       it 'returns :secondary' do
@@ -636,7 +448,8 @@ describe Mongo::Server::Description do
     context 'when the server is standalone' do
 
       let(:description) do
-        described_class.new(address, { 'ismaster' => true, 'ok' => 1 })
+        described_class.new(address, { 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 })
       end
 
       it 'returns :standalone' do
@@ -644,54 +457,40 @@ describe Mongo::Server::Description do
       end
     end
 
-    context 'when the description has no configuration' do
-
-      let(:description) do
-        described_class.new(address)
-      end
-
-      it 'returns :unknown' do
-        expect(description.server_type).to eq(:unknown)
-      end
-    end
-  end
-
-  describe '#unknown?' do
-
-    context 'when the description has no configuration' do
+    context 'when the server is hidden' do
 
       let(:description) do
-        described_class.new(address)
+        described_class.new(address, { 'ismaster' => false,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'setName' => 'test',
+          'hidden' => true, 'ok' => 1 })
       end
 
-      it 'returns true' do
-        expect(description).to be_unknown
+      it 'returns :other' do
+        expect(description.server_type).to eq(:other)
       end
     end
 
-    context 'when the command was not ok' do
+    context 'when the server is other' do
 
       let(:description) do
-        described_class.new(address, { 'ok' => 0 })
+        described_class.new(address, { 'ismaster' => false,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'setName' => 'test',
+          'ok' => 1 })
       end
 
-      it 'returns true' do
-        expect(description).to be_unknown
+      it 'returns :other' do
+        expect(description.server_type).to eq(:other)
       end
     end
 
-    context 'when the description has a configuration' do
-
-      let(:config) do
-        { 'hosts' => [ '127.0.0.1:27019', '127.0.0.1:27020' ], 'ok' => 1 }
-      end
+    context 'when the description has no configuration' do
 
       let(:description) do
-        described_class.new(address, config)
+        described_class.new(address)
       end
 
-      it 'returns false' do
-        expect(description).to_not be_unknown
+      it 'returns :unknown' do
+        expect(description.server_type).to eq(:unknown)
       end
     end
   end
@@ -832,7 +631,8 @@ describe Mongo::Server::Description do
     context 'when the description is from a standalone' do
 
       let(:description) do
-        described_class.new(address, { 'ismaster' => true, 'ok' => 1 })
+        described_class.new(address, { 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 })
       end
 
       it 'returns false' do
@@ -868,7 +668,8 @@ describe Mongo::Server::Description do
     context 'when a logical session timeout value is not in the config' do
 
       let(:description) do
-        described_class.new(address, { 'ismaster' => true, 'ok' => 1 })
+        described_class.new(address, { 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 })
       end
 
       it 'returns nil' do
@@ -929,12 +730,34 @@ describe Mongo::Server::Description do
       end
 
       let(:other) do
-        described_class.new(address, { 'ismaster' => true, 'ok' => 1 })
+        described_class.new(address, { 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 })
       end
 
       it 'returns false' do
         expect(description == other).to be(false)
       end
     end
+
+    context 'when one config is a subset of the other' do
+      let(:one) do
+        described_class.new(address, { 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3, 'ok' => 1 })
+      end
+
+      let(:two) do
+        described_class.new(address, { 'ismaster' => true,
+          'minWireVersion' => 2, 'maxWireVersion' => 3,
+          'ok' => 1, 'setName' => 'mongodb_set' })
+      end
+
+      it 'returns false when first config is the receiver' do
+        expect(one == two).to be false
+      end
+
+      it 'returns false when second config is the receiver' do
+        expect(two == one).to be false
+      end
+    end
   end
 end