mongo 2.6.4 → 2.7.0.rc0

data/spec/integration/heartbeat_events_spec.rb

@@ -0,0 +1,116 @@
+require 'spec_helper'
+
+class TestHeartbeatSubscriber
+  def initialize
+    @started_events = []
+    @succeeded_events = []
+    @failed_events = []
+  end
+
+  attr_reader :started_events, :succeeded_events, :failed_events
+
+  def started(event)
+    @started_events << event
+  end
+
+  def succeeded(event)
+    @succeeded_events << event
+  end
+
+  def failed(event)
+    @failed_events << event
+  end
+end
+
+describe 'Heartbeat events' do
+  class HeartbeatEventsSpecTestException < StandardError; end
+
+  let(:subscriber) { TestHeartbeatSubscriber.new }
+
+  before(:all) do
+    ClientRegistry.instance.close_all_clients
+  end
+
+  before do
+    Mongo::Monitoring::Global.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+  end
+
+  after do
+    Mongo::Monitoring::Global.unsubscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+  end
+
+  let(:client) { new_local_client([SpecConfig.instance.addresses.first],
+    authorized_client.options.merge(server_selection_timeout: 0.1, connect: :direct)) }
+
+  it 'notifies on successful heartbeats' do
+    client.database.command(ismaster: 1)
+
+    started_event = subscriber.started_events.first
+    expect(started_event).not_to be nil
+    expect(started_event.address).to be_a(Mongo::Address)
+    expect(started_event.address.seed).to eq(SpecConfig.instance.addresses.first)
+
+    succeeded_event = subscriber.succeeded_events.first
+    expect(succeeded_event).not_to be nil
+    expect(succeeded_event.address).to be_a(Mongo::Address)
+    expect(succeeded_event.address.seed).to eq(SpecConfig.instance.addresses.first)
+
+    failed_event = subscriber.failed_events.first
+    expect(failed_event).to be nil
+  end
+
+  it 'notifies on failed heartbeats' do
+    exc = HeartbeatEventsSpecTestException.new
+    expect_any_instance_of(Mongo::Server::Monitor::Connection).to receive(:ismaster).at_least(:once).and_raise(exc)
+
+    expect do
+      client.database.command(ismaster: 1)
+    end.to raise_error(Mongo::Error::NoServerAvailable)
+
+    started_event = subscriber.started_events.first
+    expect(started_event).not_to be nil
+    expect(started_event.address).to be_a(Mongo::Address)
+    expect(started_event.address.seed).to eq(SpecConfig.instance.addresses.first)
+
+    succeeded_event = subscriber.succeeded_events.first
+    expect(succeeded_event).to be nil
+
+    failed_event = subscriber.failed_events.first
+    expect(failed_event).not_to be nil
+    expect(failed_event.error).to be exc
+    expect(failed_event.failure).to be exc
+    expect(failed_event.address).to be_a(Mongo::Address)
+    expect(failed_event.address.seed).to eq(SpecConfig.instance.addresses.first)
+  end
+
+  context 'when monitoring option is false' do
+    let(:client) { new_local_client([SpecConfig.instance.addresses.first],
+      authorized_client.options.merge(server_selection_timeout: 0.1, connect: :direct,
+        monitoring: false)) }
+
+    shared_examples_for 'does not notify on heartbeats' do
+      it 'does not notify on heartbeats' do
+        client.database.command(ismaster: 1)
+
+        started_event = subscriber.started_events.first
+        expect(started_event).to be nil
+      end
+    end
+
+    it_behaves_like 'does not notify on heartbeats'
+
+    context 'when a subscriber is added manually' do
+      let(:client) do
+        sdam_proc = Proc.new do |client|
+          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+        end
+
+        new_local_client([SpecConfig.instance.addresses.first],
+          authorized_client.options.merge(server_selection_timeout: 0.1, connect: :direct,
+            monitoring: false, sdam_proc: sdam_proc))
+      end
+
+      it_behaves_like 'does not notify on heartbeats'
+    end
+  end
+end

data/spec/integration/retryable_writes_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe 'Retryable writes integration tests' do
   include PrimarySocket
 
-  after do
+  before do
     authorized_collection.delete_many
   end
 
@@ -164,7 +164,9 @@ describe 'Retryable writes integration tests' do
             end
 
             before do
-              expect(client.cluster).to receive(:scan!).twice
+              # server selector can call scan! until it finds a server,
+              # hence more than two scan! calls may be issued
+              expect(client.cluster).to receive(:scan!).at_least(:twice).and_call_original
             end
 
             it 'does not retry writes and raises the second error' do
@@ -178,7 +180,9 @@ describe 'Retryable writes integration tests' do
           context 'when the second error is a SocketTimeoutError' do
 
             before do
-              expect(client.cluster).to receive(:scan!).twice
+              # server selector can call scan! until it finds a server,
+              # hence more than two scan! calls may be issued
+              expect(client.cluster).to receive(:scan!).at_least(:twice).and_call_original
             end
 
             let(:second_error) do
@@ -196,7 +200,9 @@ describe 'Retryable writes integration tests' do
           context 'when the second error is a retryable OperationFailure' do
 
             before do
-              expect(client.cluster).to receive(:scan!).twice
+              # server selector can call scan! until it finds a server,
+              # hence more than two scan! calls may be issued
+              expect(client.cluster).to receive(:scan!).at_least(:twice).and_call_original
             end
 
             let(:second_error) do
@@ -249,6 +255,10 @@ describe 'Retryable writes integration tests' do
 
   shared_examples_for 'an operation that is not retried' do
 
+    let!(:client) do
+      authorized_client_without_retry_writes
+    end
+
     before do
       # Note that for writes, server.connectable? is called, refreshing the socket
       allow(primary_server).to receive(:connectable?).and_return(true)
@@ -271,7 +281,7 @@ describe 'Retryable writes integration tests' do
     end
 
     let!(:collection) do
-      client[TEST_COLL, write: WRITE_CONCERN]
+      client[TEST_COLL, write: SpecConfig.instance.write_concern]
     end
 
     before do
@@ -300,7 +310,7 @@ describe 'Retryable writes integration tests' do
       context 'when the collection has write concern acknowledged' do
 
         let!(:collection) do
-          client[TEST_COLL, write: WRITE_CONCERN]
+          client[TEST_COLL, write: SpecConfig.instance.write_concern]
         end
 
         context 'when the server supports retryable writes' do
@@ -378,7 +388,7 @@ describe 'Retryable writes integration tests' do
       context 'when the collection has write concern acknowledged' do
 
         let!(:collection) do
-          client[TEST_COLL, write: WRITE_CONCERN]
+          client[TEST_COLL, write: SpecConfig.instance.write_concern]
         end
 
         it_behaves_like 'an operation that is not retried'
@@ -412,7 +422,7 @@ describe 'Retryable writes integration tests' do
       context 'when the collection has write concern acknowledged' do
 
         let!(:collection) do
-          client[TEST_COLL, write: WRITE_CONCERN]
+          client[TEST_COLL, write: SpecConfig.instance.write_concern]
         end
 
         it_behaves_like 'an operation that is not retried'

data/spec/integration/sdam_events_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe 'SDAM events' do
+  let(:subscriber) { Mongo::SDAMMonitoring::TestSubscriber.new }
+
+  before do
+    ClientRegistry.instance.close_all_clients
+  end
+
+  describe 'server closed event' do
+    it 'is published when client is closed' do
+      client = ClientRegistry.instance.new_local_client(
+        SpecConfig.instance.addresses, SpecConfig.instance.test_options)
+      client.subscribe(Mongo::Monitoring::SERVER_CLOSED, subscriber)
+
+      # get the client connected
+      client.database.command(ismaster: 1)
+      expect(subscriber.events).to be_empty
+
+      client.close
+
+      expect(subscriber.events).not_to be_empty
+      event = subscriber.first_event('server_closed_event')
+      expect(event).not_to be_nil
+    end
+  end
+
+  describe 'topology closed event' do
+    it 'is published when client is closed' do
+      client = ClientRegistry.instance.new_local_client(
+        SpecConfig.instance.addresses, SpecConfig.instance.test_options)
+      client.subscribe(Mongo::Monitoring::TOPOLOGY_CLOSED, subscriber)
+
+      # get the client connected
+      client.database.command(ismaster: 1)
+      expect(subscriber.events).to be_empty
+
+      client.close
+
+      expect(subscriber.events).not_to be_empty
+      event = subscriber.first_event('topology_closed_event')
+      expect(event).not_to be_nil
+
+      expect(event.topology).to eql(client.cluster.topology)
+    end
+  end
+end

data/spec/integration/server_description_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe 'Server description' do
+  describe '#op_time' do
+    require_topology :replica_set
+    min_server_version '3.4'
+
+    let(:client) { ClientRegistry.instance.global_client('authorized') }
+    let(:desc) { client.cluster.servers.first.description }
+
+    it 'is set' do
+      client.database.command(ismaster: 1)
+
+      expect(desc.op_time).to be_a(BSON::Timestamp)
+    end
+  end
+
+  describe '#last_write_date' do
+    require_topology :replica_set
+    min_server_version '3.4'
+
+    let(:client) { ClientRegistry.instance.global_client('authorized') }
+    let(:desc) { client.cluster.servers.first.description }
+
+    it 'is set' do
+      client.database.command(ismaster: 1)
+
+      expect(desc.last_write_date).to be_a(Time)
+    end
+  end
+
+  describe '#last_update_time' do
+    before do
+      ClientRegistry.instance.close_all_clients
+    end
+
+    let(:client) { ClientRegistry.instance.global_client('authorized') }
+    let(:desc) { client.cluster.servers.first.description }
+
+    it 'is set' do
+      client.database.command(ismaster: 1)
+
+      expect(desc.last_update_time).to be_a(Time)
+      # checked in the last 3 seconds
+      expect(Time.now - desc.last_update_time < 3).to be true
+    end
+  end
+end

data/spec/integration/time_zone_querying_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe 'Time zone querying' do
+  let(:collection) { authorized_client[:time_zone_querying] }
+
+  before do
+    collection.delete_many
+    collection.insert_many([
+      {id: 1, created_at: Time.utc(2020, 10, 1, 23)},
+      {id: 2, created_at: Time.utc(2020, 10, 2, 0)},
+      {id: 3, created_at: Time.utc(2020, 10, 2, 1)},
+    ])
+  end
+
+  context 'UTC time' do
+    let(:time) { Time.utc(2020, 10, 1, 23, 22) }
+
+    it 'finds correctly' do
+      view = collection.find({created_at: {'$gt' => time}})
+      expect(view.count).to eq(2)
+      expect(view.map { |doc| doc[:id] }.sort).to eq([2, 3])
+    end
+  end
+
+  context 'local time with zone' do
+    let(:time) { Time.parse('2020-10-01T19:30:00-0500') }
+
+    it 'finds correctly' do
+      view = collection.find({created_at: {'$gt' => time}})
+      expect(view.count).to eq(1)
+      expect(view.first[:id]).to eq(3)
+    end
+  end
+
+  context 'when ActiveSupport support is enabled' do
+    before do
+      unless SpecConfig.instance.active_support?
+        skip "ActiveSupport support is not enabled"
+      end
+    end
+
+    context 'ActiveSupport::TimeWithZone' do
+      let(:time) { Time.parse('2020-10-01T19:30:00-0500').in_time_zone('America/New_York') }
+
+      it 'finds correctly' do
+        view = collection.find({created_at: {'$gt' => time}})
+        expect(view.count).to eq(1)
+        expect(view.first[:id]).to eq(3)
+      end
+    end
+  end
+end

data/spec/lite_spec_helper.rb

@@ -1,18 +1,20 @@
 COVERAGE_MIN = 90
 CURRENT_PATH = File.expand_path(File.dirname(__FILE__))
-SERVER_DISCOVERY_TESTS = Dir.glob("#{CURRENT_PATH}/support/sdam/**/*.yml")
-SDAM_MONITORING_TESTS = Dir.glob("#{CURRENT_PATH}/support/sdam_monitoring/*.yml")
-SERVER_SELECTION_RTT_TESTS = Dir.glob("#{CURRENT_PATH}/support/server_selection/rtt/*.yml")
-SERVER_SELECTION_TESTS = Dir.glob("#{CURRENT_PATH}/support/server_selection/selection/**/*.yml")
-MAX_STALENESS_TESTS = Dir.glob("#{CURRENT_PATH}/support/max_staleness/**/*.yml")
-CRUD_TESTS = Dir.glob("#{CURRENT_PATH}/support/crud_tests/**/*.yml")
-RETRYABLE_WRITES_TESTS = Dir.glob("#{CURRENT_PATH}/support/retryable_writes_tests/**/*.yml")
-COMMAND_MONITORING_TESTS = Dir.glob("#{CURRENT_PATH}/support/command_monitoring/**/*.yml")
-CONNECTION_STRING_TESTS = Dir.glob("#{CURRENT_PATH}/support/connection_string_tests/*.yml")
-DNS_SEEDLIST_DISCOVERY_TESTS = Dir.glob("#{CURRENT_PATH}/support/dns_seedlist_discovery_tests/*.yml")
-GRIDFS_TESTS = Dir.glob("#{CURRENT_PATH}/support/gridfs_tests/*.yml")
-TRANSACTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/support/transactions_tests/*.yml")
-CHANGE_STREAMS_TESTS = Dir.glob("#{CURRENT_PATH}/support/change_streams_tests/*.yml")
+SERVER_DISCOVERY_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/sdam/**/*.yml")
+SDAM_MONITORING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/sdam_monitoring/*.yml")
+SERVER_SELECTION_RTT_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/server_selection_rtt/*.yml")
+SERVER_SELECTION_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/server_selection/**/*.yml")
+MAX_STALENESS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/max_staleness/**/*.yml")
+CRUD_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/crud/**/*.yml")
+RETRYABLE_WRITES_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/retryable_writes/**/*.yml")
+COMMAND_MONITORING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/command_monitoring/**/*.yml")
+CONNECTION_STRING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/connection_string/*.yml")
+URI_OPTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/uri_options/*.yml")
+DNS_SEEDLIST_DISCOVERY_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/dns_seedlist_discovery/*.yml")
+GRIDFS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/gridfs/*.yml")
+TRANSACTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions/*.yml")
+TRANSACTIONS_API_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions_api/*.yml")
+CHANGE_STREAMS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/change_streams/*.yml")
 
 if ENV['DRIVERS_TOOLS']
   CLIENT_CERT_PEM = ENV['DRIVER_TOOLS_CLIENT_CERT_PEM']
@@ -32,9 +34,19 @@ else
 end
 
 require 'mongo'
-begin
-  require 'byebug'
-rescue LoadError
+
+unless ENV['CI']
+  begin
+    require 'byebug'
+  rescue LoadError
+    # jruby - try pry
+    begin
+      require 'pry'
+    # jruby likes to raise random error classes, in this case
+    # NameError in addition to LoadError
+    rescue Exception
+    end
+  end
 end
 
 require 'support/spec_config'
@@ -45,6 +57,7 @@ unless SpecConfig.instance.client_debug?
 end
 Encoding.default_external = Encoding::UTF_8
 
+require 'ice_nine'
 require 'support/matchers'
 require 'support/lite_constraints'
 require 'support/event_subscriber'
@@ -58,11 +71,53 @@ require 'support/connection_string'
 require 'support/gridfs'
 require 'support/transactions'
 require 'support/change_streams'
+require 'support/common_shortcuts'
+require 'support/client_registry'
+require 'support/client_registry_macros'
+require 'support/json_ext_formatter'
+require 'support/sdam_formatter_integration'
+
+if SpecConfig.instance.mri?
+  require 'timeout_interrupt'
+else
+  require 'timeout'
+  TimeoutInterrupt = Timeout
+end
 
 RSpec.configure do |config|
-  if ENV['CI'] && SpecConfig.instance.jruby?
-    config.formatter = 'documentation'
+  config.extend(CommonShortcuts)
+  config.extend(LiteConstraints)
+  config.include(ClientRegistryMacros)
+
+  if SpecConfig.instance.ci?
+    SdamFormatterIntegration.subscribe
+    config.add_formatter(JsonExtFormatter, File.join(File.dirname(__FILE__), '../tmp/rspec.json'))
+
+    config.around(:each) do |example|
+      SdamFormatterIntegration.assign_log_entries(nil)
+      begin
+        example.run
+      ensure
+        SdamFormatterIntegration.assign_log_entries(example.id)
+      end
+    end
   end
 
-  config.extend(LiteConstraints)
+  if SpecConfig.instance.ci?
+    # Allow a max of 30 seconds per test.
+    # Tests should take under 10 seconds ideally but it seems
+    # we have some that run for more than 10 seconds in CI.
+    config.around(:each) do |example|
+      TimeoutInterrupt.timeout(45) do
+        example.run
+      end
+    end
+  end
+end
+
+EventSubscriber.initialize
+
+if SpecConfig.instance.active_support?
+  require "active_support/time"
+  require 'mongo/active_support'
 end