mongo 2.6.4 → 2.7.0.rc0

data/spec/mongo/cluster_spec.rb

@@ -6,10 +6,19 @@ describe Mongo::Cluster do
     Mongo::Monitoring.new(monitoring: false)
   end
 
-  let(:cluster) do
-    described_class.new(SpecConfig.instance.addresses, monitoring, TEST_OPTIONS)
+  let(:cluster_with_semaphore) do
+    described_class.new(SpecConfig.instance.addresses, monitoring,
+      SpecConfig.instance.test_options.merge(
+        server_selection_semaphore: Mongo::Semaphore.new))
   end
 
+  let(:cluster_without_io) do
+    described_class.new(SpecConfig.instance.addresses, monitoring,
+      SpecConfig.instance.test_options.merge(monitoring_io: false))
+  end
+
+  let(:cluster) { cluster_without_io }
+
   describe '#==' do
 
     context 'when the other is a cluster' do
@@ -19,22 +28,24 @@ describe Mongo::Cluster do
         context 'when the options are the same' do
 
           let(:other) do
-            described_class.new(SpecConfig.instance.addresses, monitoring, TEST_OPTIONS)
+            described_class.new(SpecConfig.instance.addresses, monitoring,
+              SpecConfig.instance.test_options.merge(monitoring_io: false))
           end
 
           it 'returns true' do
-            expect(cluster).to eq(other)
+            expect(cluster_without_io).to eq(other)
           end
         end
 
         context 'when the options are not the same' do
 
           let(:other) do
-            described_class.new([ '127.0.0.1:27017' ], monitoring, TEST_OPTIONS.merge(:replica_set => 'test'))
+            described_class.new([ '127.0.0.1:27017' ], monitoring,
+              SpecConfig.instance.test_options.merge(replica_set: 'test', monitoring_io: false))
           end
 
           it 'returns false' do
-            expect(cluster).to_not eq(other)
+            expect(cluster_without_io).to_not eq(other)
           end
         end
       end
@@ -42,11 +53,12 @@ describe Mongo::Cluster do
       context 'when the addresses are not the same' do
 
         let(:other) do
-          described_class.new([ '127.0.0.1:27018' ], monitoring, TEST_OPTIONS)
+          described_class.new([ '127.0.0.1:27999' ], monitoring,
+            SpecConfig.instance.test_options.merge(monitoring_io: false))
         end
 
         it 'returns false' do
-          expect(cluster).to_not eq(other)
+          expect(cluster_without_io).to_not eq(other)
         end
       end
     end
@@ -54,7 +66,7 @@ describe Mongo::Cluster do
     context 'when the other is not a cluster' do
 
       it 'returns false' do
-        expect(cluster).to_not eq('test')
+        expect(cluster_without_io).to_not eq('test')
       end
     end
   end
@@ -66,14 +78,14 @@ describe Mongo::Cluster do
     end
 
     it 'delegates to the topology' do
-      expect(cluster.has_readable_server?).to eq(cluster.topology.has_readable_server?(cluster))
+      expect(cluster_without_io.has_readable_server?).to eq(cluster_without_io.topology.has_readable_server?(cluster_without_io))
     end
   end
 
   describe '#has_writable_server?' do
 
     it 'delegates to the topology' do
-      expect(cluster.has_writable_server?).to eq(cluster.topology.has_writable_server?(cluster))
+      expect(cluster_without_io.has_writable_server?).to eq(cluster_without_io.topology.has_writable_server?(cluster_without_io))
     end
   end
 
@@ -84,8 +96,8 @@ describe Mongo::Cluster do
     end
 
     it 'displays the cluster seeds and topology' do
-      expect(cluster.inspect).to include('topology')
-      expect(cluster.inspect).to include('servers')
+      expect(cluster_without_io.inspect).to include('topology')
+      expect(cluster_without_io.inspect).to include('servers')
     end
   end
 
@@ -101,7 +113,7 @@ describe Mongo::Cluster do
         described_class.new(
           [ '127.0.0.1:27017' ],
           monitoring,
-          TEST_OPTIONS.merge(:connect => :replica_set, :replica_set => 'testing')
+          {monitoring_io: false, connect: :replica_set, replica_set: 'testing'},
         )
       end
 
@@ -113,7 +125,11 @@ describe Mongo::Cluster do
     context 'when the option is not provided' do
 
       let(:cluster) do
-        described_class.new([ '127.0.0.1:27017' ], monitoring, TEST_OPTIONS.merge(connect: :direct).delete_if { |k| k == :replica_set })
+        described_class.new(
+          [ '127.0.0.1:27017' ],
+          monitoring,
+          {monitoring_io: false, connect: :direct},
+        )
       end
 
       it 'returns nil' do
@@ -142,17 +158,25 @@ describe Mongo::Cluster do
   end
 
   describe '#servers' do
+    let(:cluster) { cluster_with_semaphore }
 
-    context 'when topology is single', if: single_seed? do
+    context 'when topology is single' do
+      before do
+        unless ClusterConfig.instance.single_server?
+          skip 'Topology is not a single server'
+        end
+      end
 
-      context 'when the server is a mongos', if: single_mongos?  do
+      context 'when the server is a mongos' do
+        require_topology :sharded
 
         it 'returns the mongos' do
           expect(cluster.servers.size).to eq(1)
         end
       end
 
-      context 'when the server is a replica set member', if: single_rs_member? do
+      context 'when the server is a replica set member' do
+        require_topology :replica_set
 
         it 'returns the replica set member' do
           expect(cluster.servers.size).to eq(1)
@@ -163,55 +187,55 @@ describe Mongo::Cluster do
     context 'when the cluster has no servers' do
 
       let(:servers) do
-        [nil]
+        []
       end
 
       before do
-        cluster.instance_variable_set(:@servers, servers)
-        cluster.instance_variable_set(:@topology, topology)
+        cluster_without_io.instance_variable_set(:@servers, servers)
+        cluster_without_io.instance_variable_set(:@topology, topology)
       end
 
       context 'when topology is Single' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::Single.new({}, monitoring)
+          Mongo::Cluster::Topology::Single.new({}, monitoring, cluster_without_io)
         end
 
         it 'returns an empty array' do
-          expect(cluster.servers).to eq([])
+          expect(cluster_without_io.servers).to eq([])
         end
       end
 
-      context 'when topology is ReplicaSet' do
+      context 'when topology is ReplicaSetNoPrimary' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::ReplicaSet.new({}, monitoring)
+          Mongo::Cluster::Topology::ReplicaSetNoPrimary.new({replica_set_name: 'foo'}, monitoring, cluster_without_io)
         end
 
         it 'returns an empty array' do
-          expect(cluster.servers).to eq([])
+          expect(cluster_without_io.servers).to eq([])
         end
       end
 
       context 'when topology is Sharded' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::Sharded.new({}, monitoring)
+          Mongo::Cluster::Topology::Sharded.new({}, monitoring, cluster_without_io)
         end
 
         it 'returns an empty array' do
-          expect(cluster.servers).to eq([])
+          expect(cluster_without_io.servers).to eq([])
         end
       end
 
       context 'when topology is Unknown' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::Unknown.new({}, monitoring)
+          Mongo::Cluster::Topology::Unknown.new({}, monitoring, cluster_without_io)
         end
 
         it 'returns an empty array' do
-          expect(cluster.servers).to eq([])
+          expect(cluster_without_io.servers).to eq([])
         end
       end
     end
@@ -221,8 +245,10 @@ describe Mongo::Cluster do
 
     context 'when topology is Single' do
 
+      let(:cluster) { cluster_with_semaphore }
+
       let(:topology) do
-        Mongo::Cluster::Topology::Single.new({})
+        Mongo::Cluster::Topology::Single.new({}, cluster)
       end
 
       before do
@@ -236,6 +262,7 @@ describe Mongo::Cluster do
   end
 
   describe '#disconnect!' do
+    let(:cluster) { cluster_with_semaphore }
 
     let(:known_servers) do
       cluster.instance_variable_get(:@servers)
@@ -245,20 +272,45 @@ describe Mongo::Cluster do
       cluster.instance_variable_get(:@periodic_executor)
     end
 
-    before do
-      known_servers.each do |server|
-        expect(server).to receive(:disconnect!).and_call_original
+    describe 'disconnection' do
+      before do
+        known_servers.each do |server|
+          expect(server).to receive(:disconnect!).and_call_original
+        end
+        expect(periodic_executor).to receive(:stop!).and_call_original
+      end
+
+      it 'disconnects each server and the cursor reaper and returns true' do
+        expect(cluster.disconnect!).to be(true)
       end
-      expect(periodic_executor).to receive(:stop!).and_call_original
     end
 
-    it 'disconnects each server and the cursor reaper and returns true' do
-      expect(cluster.disconnect!).to be(true)
+    describe 'repeated disconnection' do
+      before do
+        known_servers.each do |server|
+          expect(server).to receive(:disconnect!).and_call_original
+        end
+        expect(periodic_executor).to receive(:stop!).and_call_original
+      end
+
+      let(:monitoring) { Mongo::Monitoring.new }
+      let(:subscriber) { Mongo::SDAMMonitoring::TestSubscriber.new }
+
+      it 'publishes server closed event once' do
+        monitoring.subscribe(Mongo::Monitoring::SERVER_CLOSED, subscriber)
+        expect(cluster.disconnect!).to be(true)
+        expect(subscriber.first_event('server_closed_event')).not_to be nil
+        subscriber.events.clear
+        expect(cluster.disconnect!).to be(true)
+        expect(subscriber.first_event('server_closed_event')).to be nil
+      end
     end
   end
 
   describe '#reconnect!' do
 
+    let(:cluster) { cluster_with_semaphore }
+
     let(:periodic_executor) do
       cluster.instance_variable_get(:@periodic_executor)
     end
@@ -307,7 +359,6 @@ describe Mongo::Cluster do
 
     before do
       cluster.instance_variable_set(:@servers, servers)
-      cluster.instance_variable_set(:@addresses, addresses)
       cluster.remove('127.0.0.1:27017')
     end
 
@@ -316,148 +367,7 @@ describe Mongo::Cluster do
     end
 
     it 'removes the host from the list of addresses' do
-      expect(cluster.instance_variable_get(:@addresses)).to eq([address_b])
-    end
-  end
-
-  describe '#add_hosts' do
-
-    let(:servers) do
-      [nil]
-    end
-
-    let(:hosts) do
-      ["127.0.0.1:27018"]
-    end
-
-    let(:description) do
-      Mongo::Server::Description.new(double('address'), { 'hosts' => hosts })
-    end
-
-    before do
-      cluster.instance_variable_set(:@servers, servers)
-      cluster.instance_variable_set(:@topology, topology)
-    end
-
-    context 'when the topology allows servers to be added' do
-
-      let(:topology) do
-        double('topology').tap do |t|
-          allow(t).to receive(:add_hosts?).and_return(true)
-        end
-      end
-
-      it 'adds the servers' do
-        expect(cluster).to receive(:add).once
-        cluster.add_hosts(description)
-      end
-    end
-
-    context 'when the topology does not allow servers to be added' do
-
-      let(:topology) do
-        double('topology').tap do |t|
-          allow(t).to receive(:add_hosts?).and_return(false)
-        end
-      end
-
-      it 'does not add the servers' do
-        expect(cluster).not_to receive(:add)
-        cluster.add_hosts(description)
-      end
-    end
-  end
-
-  describe '#remove_hosts' do
-
-    let(:listeners) do
-      Mongo::Event::Listeners.new
-    end
-
-    let(:address) do
-      Mongo::Address.new('127.0.0.1:27017')
-    end
-
-    let(:monitoring) do
-      Mongo::Monitoring.new(monitoring: false)
-    end
-
-    let(:server) do
-      Mongo::Server.new(address, cluster, monitoring, listeners)
-    end
-
-    let(:servers) do
-      [ server ]
-    end
-
-    let(:hosts) do
-      ["127.0.0.1:27018"]
-    end
-
-    let(:description) do
-      Mongo::Server::Description.new(double('address'), { 'hosts' => hosts })
-    end
-
-    context 'when the topology allows servers to be removed' do
-
-      context 'when the topology allows a specific server to be removed' do
-
-        let(:topology) do
-          double('topology').tap do |t|
-            allow(t).to receive(:remove_hosts?).and_return(true)
-            allow(t).to receive(:remove_server?).and_return(true)
-          end
-        end
-
-        before do
-          cluster.instance_variable_set(:@servers, servers)
-          cluster.instance_variable_set(:@topology, topology)
-        end
-
-        it 'removes the servers' do
-          expect(cluster).to receive(:remove).once
-          cluster.remove_hosts(description)
-        end
-      end
-
-      context 'when the topology does not allow a specific server to be removed' do
-
-        let(:topology) do
-          double('topology').tap do |t|
-            allow(t).to receive(:remove_hosts?).and_return(true)
-            allow(t).to receive(:remove_server?).and_return(false)
-          end
-        end
-
-        before do
-          cluster.instance_variable_set(:@servers, servers)
-          cluster.instance_variable_set(:@topology, topology)
-        end
-
-        it 'removes the servers' do
-          expect(cluster).not_to receive(:remove)
-          cluster.remove_hosts(description)
-        end
-      end
-    end
-
-    context 'when the topology does not allow servers to be removed' do
-
-      let(:topology) do
-        double('topology').tap do |t|
-          allow(t).to receive(:remove_hosts?).and_return(false)
-        end
-      end
-
-      before do
-        cluster.instance_variable_set(:@servers, servers)
-        cluster.instance_variable_set(:@topology, topology)
-      end
-
-      it 'does not remove the servers' do
-        expect(cluster).not_to receive(:remove)
-        cluster.remove_hosts(description)
-      end
+      expect(cluster.addresses).to eq([address_b])
     end
   end
 
@@ -485,13 +395,13 @@ describe Mongo::Cluster do
   describe '#app_metadata' do
 
     it 'returns an AppMetadata object' do
-      expect(cluster.app_metadata).to be_a(Mongo::Cluster::AppMetadata)
+      expect(cluster_without_io.app_metadata).to be_a(Mongo::Server::AppMetadata)
     end
 
     context 'when the client has an app_name set' do
 
       let(:cluster) do
-        authorized_client.with(app_name: 'cluster_test').cluster
+        authorized_client.with(app_name: 'cluster_test', monitoring_io: false).cluster
       end
 
       it 'constructs an AppMetadata object with the app_name' do
@@ -511,69 +421,6 @@ describe Mongo::Cluster do
     end
   end
 
-  describe '#logical_session_timeout' do
-
-    let(:listeners) do
-      Mongo::Event::Listeners.new
-    end
-
-    let(:monitoring) do
-      Mongo::Monitoring.new(monitoring: false)
-    end
-
-    let(:server_one) do
-      Mongo::Server.new(default_address, cluster, monitoring, listeners)
-    end
-
-    let(:server_two) do
-      Mongo::Server.new(default_address, cluster, monitoring, listeners)
-    end
-
-    let(:servers) do
-      [ server_one, server_two ]
-    end
-
-    before do
-      allow(cluster).to receive(:servers).and_return(servers)
-    end
-
-    context 'when one server has a nil logical session timeout value' do
-
-      before do
-        allow(server_one).to receive(:logical_session_timeout).and_return(7)
-        allow(server_two).to receive(:logical_session_timeout).and_return(nil)
-      end
-
-      it 'returns nil' do
-        expect(cluster.logical_session_timeout).to be(nil)
-      end
-    end
-
-    context 'when all servers have a logical session timeout value' do
-
-      before do
-        allow(server_one).to receive(:logical_session_timeout).and_return(7)
-        allow(server_two).to receive(:logical_session_timeout).and_return(3)
-      end
-
-      it 'returns the minimum' do
-        expect(cluster.logical_session_timeout).to be(3)
-      end
-    end
-
-    context 'when no servers have a logical session timeout value' do
-
-      before do
-        allow(server_one).to receive(:logical_session_timeout).and_return(nil)
-        allow(server_two).to receive(:logical_session_timeout).and_return(nil)
-      end
-
-      it 'returns nil' do
-        expect(cluster.logical_session_timeout).to be(nil)
-      end
-    end
-  end
-
   describe '#cluster_time' do
 
     let(:operation) do
@@ -594,7 +441,8 @@ describe Mongo::Cluster do
   describe '#update_cluster_time' do
 
     let(:cluster) do
-      described_class.new(SpecConfig.instance.addresses, monitoring, TEST_OPTIONS.merge(heartbeat_frequency: 1000))
+      described_class.new(SpecConfig.instance.addresses, monitoring,
+        SpecConfig.instance.test_options.merge(heartbeat_frequency: 1000, monitoring_io: false))
     end
 
     let(:result) do
@@ -690,4 +538,105 @@ describe Mongo::Cluster do
       end
     end
   end
+
+  describe '#sessions_supported?' do
+    context 'in server < 3.6' do
+      max_server_version '3.4'
+
+      context 'in single topology' do
+        require_topology :single
+
+        let(:client) { ClientRegistry.instance.global_client('authorized') }
+
+        it 'is false' do
+          expect(client.cluster.send(:sessions_supported?)).to be false
+        end
+      end
+
+      context 'in single topology with replica set name set' do
+        require_topology :replica_set
+
+        let(:client) do
+          new_local_client([SpecConfig.instance.addresses.first],
+            SpecConfig.instance.test_options.merge(
+              connect: :direct, replica_set: ClusterConfig.instance.replica_set_name))
+        end
+
+        it 'is false' do
+          expect(client.cluster.send(:sessions_supported?)).to be false
+        end
+      end
+
+      context 'in replica set topology' do
+        require_topology :replica_set
+
+        let(:client) { ClientRegistry.instance.global_client('authorized') }
+
+        it 'is false' do
+          expect(client.cluster.send(:sessions_supported?)).to be false
+        end
+      end
+
+      context 'in sharded topology' do
+        require_topology :sharded
+
+        let(:client) { ClientRegistry.instance.global_client('authorized') }
+
+        it 'is false' do
+          expect(client.cluster.send(:sessions_supported?)).to be false
+        end
+      end
+    end
+
+    context 'in server 3.6+' do
+      min_server_version '3.6'
+
+      context 'in single topology' do
+        require_topology :single
+
+        let(:client) { ClientRegistry.instance.global_client('authorized') }
+
+        # Contrary to the session spec, 3.6 and 4.0 standalone servers
+        # report a logical session timeout and thus are considered to
+        # support sessions
+        it 'is true' do
+          expect(client.cluster.send(:sessions_supported?)).to be true
+        end
+      end
+
+      context 'in single topology with replica set name set' do
+        require_topology :replica_set
+
+        let(:client) do
+          new_local_client([SpecConfig.instance.addresses.first],
+            SpecConfig.instance.test_options.merge(
+              connect: :direct, replica_set: ClusterConfig.instance.replica_set_name))
+        end
+
+        it 'is true' do
+          expect(client.cluster.send(:sessions_supported?)).to be true
+        end
+      end
+
+      context 'in replica set topology' do
+        require_topology :replica_set
+
+        let(:client) { ClientRegistry.instance.global_client('authorized') }
+
+        it 'is true' do
+          expect(client.cluster.send(:sessions_supported?)).to be true
+        end
+      end
+
+      context 'in sharded topology' do
+        require_topology :sharded
+
+        let(:client) { ClientRegistry.instance.global_client('authorized') }
+
+        it 'is true' do
+          expect(client.cluster.send(:sessions_supported?)).to be true
+        end
+      end
+    end
+  end
 end