mongo 2.6.4 → 2.7.0.rc0

data/spec/mongo/cluster/topology/sharded_spec.rb

@@ -6,8 +6,16 @@ describe Mongo::Cluster::Topology::Sharded do
     Mongo::Address.new('127.0.0.1:27017')
   end
 
+  # Cluster needs a topology and topology needs a cluster...
+  # This temporary cluster is used for topology construction.
+  let(:temp_cluster) do
+    double('temp cluster').tap do |cluster|
+      allow(cluster).to receive(:servers_list).and_return([])
+    end
+  end
+
   let(:topology) do
-    described_class.new({}, monitoring)
+    described_class.new({}, monitoring, temp_cluster)
   end
 
   let(:monitoring) do
@@ -22,31 +30,53 @@ describe Mongo::Cluster::Topology::Sharded do
     double('cluster').tap do |cl|
       allow(cl).to receive(:topology).and_return(topology)
       allow(cl).to receive(:app_metadata).and_return(app_metadata)
+      allow(cl).to receive(:options).and_return({})
     end
   end
 
   let(:mongos) do
-    Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+    Mongo::Server.new(address, cluster, monitoring, listeners,
+      SpecConfig.instance.test_options.merge(monitoring_io: false))
   end
 
   let(:standalone) do
-    Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+    Mongo::Server.new(address, cluster, monitoring, listeners,
+      SpecConfig.instance.test_options.merge(monitoring_io: false))
   end
 
   let(:replica_set) do
-    Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+    Mongo::Server.new(address, cluster, monitoring, listeners,
+      SpecConfig.instance.test_options.merge(monitoring_io: false))
   end
 
   let(:mongos_description) do
-    Mongo::Server::Description.new(address, { 'msg' => 'isdbgrid' })
+    Mongo::Server::Description.new(address, { 'msg' => 'isdbgrid',
+      'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => 1 })
   end
 
   let(:standalone_description) do
-    Mongo::Server::Description.new(address, { 'ismaster' => true })
+    Mongo::Server::Description.new(address, { 'ismaster' => true,
+    'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => 1 })
   end
 
   let(:replica_set_description) do
-    Mongo::Server::Description.new(address, { 'ismaster' => true, 'setName' => 'testing', 'ok' => 1 })
+    Mongo::Server::Description.new(address, { 'ismaster' => true,
+      'minWireVersion' => 2, 'maxWireVersion' => 8,
+      'setName' => 'testing', 'ok' => 1 })
+  end
+
+  describe '#initialize' do
+    let(:topology) do
+      Mongo::Cluster::Topology::Sharded.new(
+        {replica_set_name: 'foo'},
+        monitoring, temp_cluster)
+    end
+
+    it 'does not accept RS name' do
+      expect do
+        topology
+      end.to raise_error(ArgumentError, 'Topology Mongo::Cluster::Topology::Sharded cannot have the :replica_set_name option set')
+    end
   end
 
   describe '.servers' do
@@ -101,54 +131,22 @@ describe Mongo::Cluster::Topology::Sharded do
     end
   end
 
-  describe '#add_hosts?' do
+  describe '#summary' do
+    skip_if_linting
 
-    it 'returns false' do
-      expect(topology.add_hosts?(double('description'), [])).to eq(false)
+    let(:desc1) do
+      Mongo::Server::Description.new(Mongo::Address.new('127.0.0.2:27017'))
     end
-  end
 
-  describe '#remove_hosts?' do
-
-    it 'returns true' do
-      expect(topology.remove_hosts?(double('description'))).to eq(true)
+    let(:desc2) do
+      Mongo::Server::Description.new(Mongo::Address.new('127.0.0.2:27027'))
     end
-  end
-
-  describe '#remove_server?' do
-
-    before do
-      mongos.monitor.instance_variable_set(:@description, mongos_description)
-      replica_set.monitor.instance_variable_set(:@description, replica_set_description)
-    end
-
-    context 'when the server itself should be removed' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:mongos?).and_return(false)
-          allow(d).to receive(:unknown?).and_return(false)
-          allow(d).to receive(:is_server?).and_return(true)
-        end
-      end
-
-      it 'returns true' do
-        expect(topology.remove_server?(description, mongos)).to eq(true)
-      end
-    end
-
-    context 'when the server is neither a mongos nor an unknown' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:mongos?).and_return(true)
-          allow(d).to receive(:is_server?).and_return(false)
-        end
-      end
 
-      it 'returns true' do
-        expect(topology.remove_server?(description, replica_set)).to eq(true)
-      end
+    it 'renders correctly' do
+      expect(topology).to receive(:server_descriptions).and_return({
+        desc1.address.to_s => desc1, desc2.address.to_s => desc2,
+      })
+      expect(topology.summary).to eq('Sharded[127.0.0.2:27017,127.0.0.2:27027]')
     end
   end
 end

data/spec/mongo/cluster/topology/single_spec.rb

@@ -10,8 +10,16 @@ describe Mongo::Cluster::Topology::Single do
     Mongo::Monitoring.new(monitoring: false)
   end
 
+  # Cluster needs a topology and topology needs a cluster...
+  # This temporary cluster is used for topology construction.
+  let(:temp_cluster) do
+    double('temp cluster').tap do |cluster|
+      allow(cluster).to receive(:servers_list).and_return([])
+    end
+  end
+
   let(:topology) do
-    described_class.new({}, monitoring)
+    described_class.new({}, monitoring, temp_cluster)
   end
 
   let(:listeners) do
@@ -22,25 +30,26 @@ describe Mongo::Cluster::Topology::Single do
     double('cluster').tap do |cl|
       allow(cl).to receive(:app_metadata).and_return(app_metadata)
       allow(cl).to receive(:topology).and_return(topology)
+      allow(cl).to receive(:options).and_return({})
     end
   end
 
   describe '.servers' do
 
     let(:mongos) do
-      Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      Mongo::Server.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     let(:standalone) do
-      Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      Mongo::Server.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     let(:standalone_two) do
-      Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      Mongo::Server.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     let(:replica_set) do
-      Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS)
+      Mongo::Server.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
     end
 
     let(:mongos_description) do
@@ -48,11 +57,14 @@ describe Mongo::Cluster::Topology::Single do
     end
 
     let(:standalone_description) do
-      Mongo::Server::Description.new(address, { 'ismaster' => true, 'ok' => 1 })
+      Mongo::Server::Description.new(address, { 'ismaster' => true,
+        'minWireVersion' => 2, 'maxWireVersion' => 8, 'ok' => 1 })
     end
 
     let(:replica_set_description) do
-      Mongo::Server::Description.new(address, { 'ismaster' => true, 'setName' => 'testing' })
+      Mongo::Server::Description.new(address, { 'ismaster' => true,
+        'minWireVersion' => 2, 'maxWireVersion' => 8,
+        'setName' => 'testing' })
     end
 
     before do
@@ -71,6 +83,42 @@ describe Mongo::Cluster::Topology::Single do
     end
   end
 
+  describe '#initialize' do
+    context 'with RS name' do
+      let(:topology) do
+        Mongo::Cluster::Topology::Single.new(
+          {replica_set_name: 'foo'},
+          monitoring, temp_cluster)
+      end
+
+      it 'accepts RS name' do
+        expect(topology.replica_set_name).to eq('foo')
+      end
+    end
+
+    context 'with more than one server in topology' do
+      let(:topology) do
+        Mongo::Cluster::Topology::Single.new({},
+          monitoring, temp_cluster)
+      end
+
+      let(:temp_cluster) do
+        double('temp cluster').tap do |cluster|
+          allow(cluster).to receive(:servers_list).and_return([
+            double('server'),
+            double('server'),
+          ])
+        end
+      end
+
+      it 'fails' do
+        expect do
+          topology
+        end.to raise_error(ArgumentError, 'Cannot instantiate a single topology with more than one server in the cluster')
+      end
+    end
+  end
+
   describe '.replica_set?' do
 
     it 'returns false' do
@@ -106,24 +154,16 @@ describe Mongo::Cluster::Topology::Single do
     end
   end
 
-  describe '#add_hosts?' do
+  describe '#summary' do
+    skip_if_linting
 
-    it 'returns false' do
-      expect(topology.add_hosts?(double('description'), [])).to eq(false)
+    let(:desc) do
+      Mongo::Server::Description.new(Mongo::Address.new('127.0.0.2:27017'))
     end
-  end
 
-  describe '#remove_hosts?' do
-
-    it 'returns false' do
-      expect(topology.remove_hosts?(double('description'))).to eq(false)
-    end
-  end
-
-  describe '#remove_server?' do
-
-    it 'returns false' do
-      expect(topology.remove_server?(double('description'), double('server'))).to eq(false)
+    it 'renders correctly' do
+      expect(topology).to receive(:server_descriptions).and_return({desc.address.to_s => desc})
+      expect(topology.summary).to eq('Single[127.0.0.2:27017]')
     end
   end
 end

data/spec/mongo/cluster/topology/unknown_spec.rb

@@ -6,8 +6,30 @@ describe Mongo::Cluster::Topology::Unknown do
     Mongo::Monitoring.new(monitoring: false)
   end
 
+  # Cluster needs a topology and topology needs a cluster...
+  # This temporary cluster is used for topology construction.
+  let(:temp_cluster) do
+    double('temp cluster').tap do |cluster|
+      allow(cluster).to receive(:servers_list).and_return([])
+    end
+  end
+
   let(:topology) do
-    described_class.new({}, monitoring)
+    described_class.new({}, monitoring, temp_cluster)
+  end
+
+  describe '#initialize' do
+    let(:topology) do
+      Mongo::Cluster::Topology::Unknown.new(
+        {replica_set_name: 'foo'},
+        monitoring, temp_cluster)
+    end
+
+    it 'does not accept RS name' do
+      expect do
+        topology
+      end.to raise_error(ArgumentError, 'Topology Mongo::Cluster::Topology::Unknown cannot have the :replica_set_name option set')
+    end
   end
 
   describe '.servers' do
@@ -63,123 +85,16 @@ describe Mongo::Cluster::Topology::Unknown do
     end
   end
 
-  describe '#add_hosts?' do
-
-    context 'when the description is from an unknown server' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:unknown?).and_return(true)
-        end
-      end
+  describe '#summary' do
+    skip_if_linting
 
-      it 'returns false' do
-        expect(topology.add_hosts?(description, [])).to be(false)
-      end
+    let(:desc) do
+      Mongo::Server::Description.new(Mongo::Address.new('127.0.0.2:27017'))
     end
 
-    context 'when the description is from a ghost server' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:unknown?).and_return(false)
-          allow(d).to receive(:ghost?).and_return(true)
-        end
-      end
-
-      it 'returns false' do
-        expect(topology.add_hosts?(description, [])).to be(false)
-      end
-    end
-
-    context 'when the description is not from an unknown or ghost' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:unknown?).and_return(false)
-          allow(d).to receive(:ghost?).and_return(false)
-        end
-      end
-
-      it 'returns true' do
-        expect(topology.add_hosts?(description, [])).to be(true)
-      end
-    end
-  end
-
-  describe '#remove_hosts?' do
-
-    context 'when the description is from a standalone' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:standalone?).and_return(true)
-        end
-      end
-
-      it 'returns true' do
-        expect(topology.remove_hosts?(description)).to be(true)
-      end
-    end
-
-    context 'when the description is not from a standalone' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:standalone?).and_return(false)
-        end
-      end
-
-      it 'returns true' do
-        expect(topology.remove_hosts?(description)).to be(false)
-      end
-    end
-  end
-
-  describe '#remove_server?' do
-
-     context 'when the description is from a standalone' do
-
-       let(:description) do
-         double('description').tap do |d|
-           allow(d).to receive(:standalone?).and_return(true)
-           allow(d).to receive(:is_server?).and_return(true)
-         end
-       end
-
-       context 'when the description is from the server in question' do
-
-         it 'returns true' do
-           expect(topology.remove_server?(description, double('server'))).to be(true)
-         end
-       end
-
-       context 'when the description is not from the server in question' do
-
-         let(:description) do
-           double('description').tap do |d|
-             allow(d).to receive(:standalone?).and_return(true)
-             allow(d).to receive(:is_server?).and_return(false)
-           end
-         end
-
-         it 'returns false' do
-           expect(topology.remove_server?(description, double('server'))).to be(false)
-         end
-       end
-     end
-
-    context 'when the description is not from a standalone' do
-
-      let(:description) do
-        double('description').tap do |d|
-          allow(d).to receive(:standalone?).and_return(false)
-        end
-      end
-
-      it 'returns false' do
-        expect(topology.remove_server?(description, double('server'))).to be(false)
-      end
+    it 'renders correctly' do
+      expect(topology).to receive(:server_descriptions).and_return({desc.address.to_s => desc})
+      expect(topology.summary).to eq('Unknown[127.0.0.2:27017]')
     end
   end
 end

data/spec/mongo/cluster/topology_spec.rb

@@ -6,26 +6,28 @@ describe Mongo::Cluster::Topology do
     Mongo::Monitoring.new(monitoring: false)
   end
 
+  let(:cluster) { Mongo::Cluster.new(['a'], Mongo::Monitoring.new, monitoring_io: false) }
+
   describe '.initial' do
 
     context 'when provided a replica set option' do
 
       let(:topology) do
-        described_class.initial([ 'a' ], monitoring, connect: :replica_set)
+        described_class.initial(cluster, monitoring, connect: :replica_set, replica_set_name: 'foo')
       end
 
       it 'returns a replica set topology' do
-        expect(topology).to be_a(Mongo::Cluster::Topology::ReplicaSet)
+        expect(topology).to be_a(Mongo::Cluster::Topology::ReplicaSetNoPrimary)
       end
 
       context 'when the option is a String (due to YAML parsing)' do
 
         let(:topology) do
-          described_class.initial([ 'a' ], monitoring, connect: 'replica_set')
+          described_class.initial(cluster, monitoring, connect: 'replica_set', replica_set_name: 'foo')
         end
 
         it 'returns a replica set topology' do
-          expect(topology).to be_a(Mongo::Cluster::Topology::ReplicaSet)
+          expect(topology).to be_a(Mongo::Cluster::Topology::ReplicaSetNoPrimary)
         end
       end
     end
@@ -33,7 +35,7 @@ describe Mongo::Cluster::Topology do
     context 'when provided a single option' do
 
       let(:topology) do
-        described_class.initial([ 'a' ], monitoring, connect: :direct)
+        described_class.initial(cluster, monitoring, connect: :direct)
       end
 
       it 'returns a single topology' do
@@ -41,13 +43,13 @@ describe Mongo::Cluster::Topology do
       end
 
       it 'sets the seed on the topology' do
-        expect(topology.seed).to eq('a')
+        expect(topology.addresses).to eq(['a'])
       end
 
       context 'when the option is a String (due to YAML parsing)' do
 
         let(:topology) do
-          described_class.initial([ 'a' ], monitoring, connect: 'direct')
+          described_class.initial(cluster, monitoring, connect: 'direct')
         end
 
         it 'returns a single topology' do
@@ -55,7 +57,7 @@ describe Mongo::Cluster::Topology do
         end
 
         it 'sets the seed on the topology' do
-          expect(topology.seed).to eq('a')
+          expect(topology.addresses).to eq(['a'])
         end
       end
     end
@@ -63,7 +65,7 @@ describe Mongo::Cluster::Topology do
     context 'when provided a sharded option' do
 
       let(:topology) do
-        described_class.initial([ 'a' ], monitoring, connect: :sharded)
+        described_class.initial(cluster, monitoring, connect: :sharded)
       end
 
       it 'returns a sharded topology' do
@@ -73,7 +75,7 @@ describe Mongo::Cluster::Topology do
       context 'when the option is a String (due to YAML parsing)' do
 
         let(:topology) do
-          described_class.initial([ 'a' ], monitoring, connect: 'sharded')
+          described_class.initial(cluster, monitoring, connect: 'sharded')
         end
 
         it 'returns a sharded topology' do
@@ -87,18 +89,18 @@ describe Mongo::Cluster::Topology do
       context 'when a set name is in the options' do
 
         let(:topology) do
-          described_class.initial([], monitoring, replica_set: 'testing')
+          described_class.initial(cluster, monitoring, replica_set_name: 'testing')
         end
 
         it 'returns a replica set topology' do
-          expect(topology).to be_a(Mongo::Cluster::Topology::ReplicaSet)
+          expect(topology).to be_a(Mongo::Cluster::Topology::ReplicaSetNoPrimary)
         end
       end
 
       context 'when no set name is in the options' do
 
         let(:topology) do
-          described_class.initial([], monitoring, {})
+          described_class.initial(cluster, monitoring, {})
         end
 
         it 'returns an unknown topology' do
@@ -107,4 +109,100 @@ describe Mongo::Cluster::Topology do
       end
     end
   end
+
+  describe '#logical_session_timeout' do
+    skip_if_linting
+
+    let(:listeners) do
+      Mongo::Event::Listeners.new
+    end
+
+    let(:monitoring) do
+      Mongo::Monitoring.new(monitoring: false)
+    end
+
+    let(:server_one) do
+      Mongo::Server.new(Mongo::Address.new('a:27017'),
+        cluster, monitoring, listeners, monitoring_io: false)
+    end
+
+    let(:server_two) do
+      Mongo::Server.new(Mongo::Address.new('b:27017'),
+        cluster, monitoring, listeners, monitoring_io: false)
+    end
+
+    let(:servers) do
+      [ server_one, server_two ]
+    end
+
+    let(:topology) do
+      Mongo::Cluster::Topology::Sharded.new({}, monitoring, cluster)
+    end
+
+    before do
+      expect(cluster).to receive(:servers_list).and_return(servers)
+    end
+
+    context 'when servers are data bearing' do
+      before do
+        expect(server_one.description).to receive(:primary?).and_return(true)
+        allow(server_two.description).to receive(:primary?).and_return(true)
+      end
+
+      context 'when one server has a nil logical session timeout value' do
+
+        before do
+          expect(server_one.description).to receive(:logical_session_timeout).and_return(7)
+          expect(server_two.description).to receive(:logical_session_timeout).and_return(nil)
+        end
+
+        it 'returns nil' do
+          expect(topology.logical_session_timeout).to be(nil)
+        end
+      end
+
+      context 'when all servers have a logical session timeout value' do
+
+        before do
+          expect(server_one.description).to receive(:logical_session_timeout).and_return(7)
+          expect(server_two.description).to receive(:logical_session_timeout).and_return(3)
+        end
+
+        it 'returns the minimum' do
+          expect(topology.logical_session_timeout).to be(3)
+        end
+      end
+
+      context 'when no servers have a logical session timeout value' do
+
+        before do
+          expect(server_one.description).to receive(:logical_session_timeout).and_return(nil)
+          allow(server_two.description).to receive(:logical_session_timeout).and_return(nil)
+        end
+
+        it 'returns nil' do
+          expect(topology.logical_session_timeout).to be(nil)
+        end
+      end
+    end
+
+    context 'when servers are not data bearing' do
+      before do
+        expect(server_one).to be_unknown
+        expect(server_two).to be_unknown
+      end
+
+      context 'when all servers have a logical session timeout value' do
+
+        before do
+          expect(server_one).not_to receive(:logical_session_timeout)
+          expect(server_two).not_to receive(:logical_session_timeout)
+        end
+
+        it 'returns nil' do
+          expect(topology.logical_session_timeout).to be nil
+        end
+      end
+    end
+  end
 end