metric_fu 4.11.3 → 4.11.4

data/lib/metric_fu/metrics/reek/metric.rb

@@ -1,14 +1,13 @@
 module MetricFu
   class MetricReek < Metric
-
     def name
       :reek
     end
 
     def default_run_options
       {
-        :dirs_to_reek => MetricFu::Io::FileSystem.directory('code_dirs'),
-        :config_file_pattern => nil,
+        dirs_to_reek: MetricFu::Io::FileSystem.directory("code_dirs"),
+        config_file_pattern: nil,
       }
     end
 
@@ -23,6 +22,5 @@ module MetricFu
     def activate
       super
     end
-
   end
 end

data/lib/metric_fu/metrics/roodi/generator.rb

@@ -1,40 +1,39 @@
 module MetricFu
   class RoodiGenerator < Generator
-
     def self.metric
       :roodi
     end
 
     def emit
-      files_to_analyze = options[:dirs_to_roodi].map{|dir| Dir[File.join(dir, "**/*.rb")] }
+      files_to_analyze = options[:dirs_to_roodi].map { |dir| Dir[File.join(dir, "**/*.rb")] }
       files = remove_excluded_files(files_to_analyze.flatten)
       config = options[:roodi_config] ? "-config=#{options[:roodi_config]}" : ""
-      args = "#{config} #{files.join(" ")}"
+      args = "#{config} #{files.join(' ')}"
       @output = run!(args)
     end
 
     def analyze
       @output = MetricFu::Utility.strip_escape_codes(@output)
-      @matches = @output.chomp.split("\n").map{|m| m.split(" - ") }
+      @matches = @output.chomp.split("\n").map { |m| m.split(" - ") }
       total = @matches.pop
-      @matches.reject! {|array| array.size < 2 }
+      @matches.reject! { |array| array.size < 2 }
       @matches.map! do |match|
-        file, line = match[0].split(':')
+        file, line = match[0].split(":")
         problem = match[1]
-        {:file => file, :line => line, :problem => problem}
+        { file: file, line: line, problem: problem }
       end
-      @roodi_results = {:total => total, :problems => @matches}
+      @roodi_results = { total: total, problems: @matches }
     end
 
     def to_h
-      {:roodi => @roodi_results}
+      { roodi: @roodi_results }
     end
 
     def per_file_info(out)
       @matches.each do |match|
         out[match[:file]] ||= {}
         out[match[:file]][match[:line]] ||= []
-        out[match[:file]][match[:line]] << {:type => :roodi, :description => match[:problem]}
+        out[match[:file]][match[:line]] << { type: :roodi, description: match[:problem] }
       end
     end
   end

data/lib/metric_fu/metrics/roodi/grapher.rb

@@ -1,4 +1,4 @@
-MetricFu.reporting_require { 'graphs/grapher' }
+MetricFu.reporting_require { "graphs/grapher" }
 module MetricFu
   class RoodiGrapher < Grapher
     attr_accessor :roodi_count, :labels
@@ -16,23 +16,22 @@ module MetricFu
     def get_metrics(metrics, date)
       if metrics && metrics[:roodi]
         @roodi_count.push(metrics[:roodi][:problems].size)
-        @labels.update( { @labels.size => date })
+        @labels.update(@labels.size => date)
       end
     end
 
     def title
-      'Roodi: design problems'
+      "Roodi: design problems"
     end
 
     def data
       [
-        ['roodi', @roodi_count.join(',')]
+        ["roodi", @roodi_count.join(",")]
       ]
     end
 
     def output_filename
-      'roodi.js'
+      "roodi.js"
     end
-
   end
 end

data/lib/metric_fu/metrics/roodi/hotspot.rb

@@ -1,5 +1,4 @@
 class MetricFu::RoodiHotspot < MetricFu::Hotspot
-
   COLUMNS = %w{problems}
 
   def columns
@@ -23,7 +22,7 @@ class MetricFu::RoodiHotspot < MetricFu::Hotspot
   end
 
   def generate_records(data, table)
-    return if data==nil
+    return if data == nil
     Array(data[:problems]).each do |problem|
       table << {
         "metric" => name,
@@ -37,5 +36,4 @@ class MetricFu::RoodiHotspot < MetricFu::Hotspot
     occurences = group.size
     "found #{occurences} design problems"
   end
-
 end

data/lib/metric_fu/metrics/roodi/metric.rb

@@ -1,13 +1,12 @@
 module MetricFu
   class MetricRoodi < Metric
-
     def name
       :roodi
     end
 
     def default_run_options
-      { :dirs_to_roodi => MetricFu::Io::FileSystem.directory('code_dirs'),
-                    :roodi_config => "#{MetricFu::Io::FileSystem.directory('root_directory')}/config/roodi_config.yml"}
+      { dirs_to_roodi: MetricFu::Io::FileSystem.directory("code_dirs"),
+        roodi_config: "#{MetricFu::Io::FileSystem.directory('root_directory')}/config/roodi_config.yml" }
     end
 
     def has_graph?
@@ -21,6 +20,5 @@ module MetricFu
     def activate
       super
     end
-
   end
 end

data/lib/metric_fu/metrics/saikuro/generator.rb

@@ -1,12 +1,10 @@
 # encoding: utf-8
-MetricFu.lib_require       { 'utility'                 }
-MetricFu.metrics_require   { 'saikuro/scratch_file'    }
-MetricFu.metrics_require   { 'saikuro/parsing_element' }
-MetricFu.data_structures_require { 'line_numbers' }
+MetricFu.lib_require       { "utility"                 }
+MetricFu.metrics_require   { "saikuro/scratch_file"    }
+MetricFu.metrics_require   { "saikuro/parsing_element" }
+MetricFu.data_structures_require { "line_numbers" }
 module MetricFu
-
   class SaikuroGenerator < MetricFu::Generator
-
     def self.metric
       :saikuro
     end
@@ -32,11 +30,11 @@ module MetricFu
     def to_h
       @saikuro_data = {
         files:    files_with_relative_paths(@files),
-        classes:  @classes.map { |c| c.to_h },
-        methods:  @meths.map   { |m| m.to_h },
-       }
+        classes:  @classes.map(&:to_h),
+        methods:  @meths.map(&:to_h),
+      }
       clear_scratch_files!
-      {:saikuro => @saikuro_data}
+      { saikuro: @saikuro_data }
     end
 
     def per_file_info(out)
@@ -53,12 +51,12 @@ module MetricFu
       filename = file_data[:filename]
       output = out[filename]
       method_data_for_file_data(file_data) do |method_data|
-         line = line_numbers.start_line_for_method(method_data[:name]).to_s
-         result = {
-           :type => :saikuro,
-           :description => "Complexity #{method_data[:complexity]}"
-         }
-         output[line] <<  result
+        line = line_numbers.start_line_for_method(method_data[:name]).to_s
+        result = {
+          type: :saikuro,
+          description: "Complexity #{method_data[:complexity]}"
+        }
+        output[line] <<  result
       end
       out
     end
@@ -70,7 +68,7 @@ module MetricFu
       mf_log "ruby_parser blew up while trying to parse #{file_path}. You won't have method level Saikuro information for this file."
     end
 
-    def method_data_for_file_data(file_data, &block)
+    def method_data_for_file_data(file_data, &_block)
       return unless block_given?
       file_data[:classes].each do |class_data|
         class_data[:methods].each do |method_data|
@@ -82,7 +80,7 @@ module MetricFu
     private
 
     def erb_file?(filename)
-      File.extname(filename) == '.erb'
+      File.extname(filename) == ".erb"
     end
 
     def file_not_exists?(filename)
@@ -90,7 +88,7 @@ module MetricFu
     end
 
     def sort_methods(methods)
-      methods.sort_by {|method| method.complexity.to_i}.reverse
+      methods.sort_by { |method| method.complexity.to_i }.reverse
     end
 
     def assemble_methods(files)
@@ -107,23 +105,23 @@ module MetricFu
     end
 
     def sort_classes(classes)
-      classes.sort_by {|k| k.complexity.to_i}.reverse
+      classes.sort_by { |k| k.complexity.to_i }.reverse
     end
 
     def assemble_classes(files)
-      files.map {|f| f.elements}.flatten
+      files.map(&:elements).flatten
     end
 
     def sort_files(files)
       files.sort_by do |file|
         file.elements.
-             max {|a,b| a.complexity.to_i <=> b.complexity.to_i}.
-             complexity.to_i
+          max { |a, b| a.complexity.to_i <=> b.complexity.to_i }.
+          complexity.to_i
       end.reverse
     end
 
     def assemble_files
-      SaikuroScratchFile.assemble_files( Dir.glob("#{metric_directory}/**/*.html") )
+      SaikuroScratchFile.assemble_files(Dir.glob("#{metric_directory}/**/*.html"))
     end
 
     def files_with_relative_paths(files)
@@ -136,14 +134,12 @@ module MetricFu
 
     def file_relative_path(file)
       filepath = file.filepath
-      path = filepath.gsub(/^#{metric_directory}\//, '')
+      path = filepath.gsub(/^#{metric_directory}\//, "")
       "#{path}/#{file.filename}"
     end
 
     def clear_scratch_files!
       MetricFu::Utility.rm_rf(metric_directory)
     end
-
   end
-
 end

data/lib/metric_fu/metrics/saikuro/hotspot.rb

@@ -1,5 +1,4 @@
 class MetricFu::SaikuroHotspot < MetricFu::Hotspot
-
   COLUMNS = %w{lines complexity}
 
   def columns
@@ -47,7 +46,6 @@ class MetricFu::SaikuroHotspot < MetricFu::Hotspot
   def present_group(group)
     occurences = group.size
     complexity = get_mean(group.column("complexity"))
-    "#{"average " if occurences > 1}complexity is %.1f" % complexity
+    "#{'average ' if occurences > 1}complexity is %.1f" % complexity
   end
-
 end

data/lib/metric_fu/metrics/saikuro/metric.rb

@@ -1,19 +1,18 @@
 module MetricFu
   class MetricSaikuro < Metric
-
     def name
       :saikuro
     end
 
     def default_run_options
       {
-        :output_directory => MetricFu::Io::FileSystem.scratch_directory(name),
-        :input_directory =>MetricFu::Io::FileSystem.directory('code_dirs'),
-        :cyclo => "",
-        :filter_cyclo => "0",
-        :warn_cyclo => "5",
-        :error_cyclo => "7",
-        :formater => "text",
+        output_directory: MetricFu::Io::FileSystem.scratch_directory(name),
+        input_directory: MetricFu::Io::FileSystem.directory("code_dirs"),
+        cyclo: "",
+        filter_cyclo: "0",
+        warn_cyclo: "5",
+        error_cyclo: "7",
+        formater: "text",
       }
     end
 

data/lib/metric_fu/metrics/saikuro/parsing_element.rb

@@ -1,10 +1,9 @@
 module MetricFu
   class SaikuroParsingElement
-
-    TYPE_REGEX=/Type:(.*) Name/
-    NAME_REGEX=/Name:(.*) Complexity/
-    COMPLEXITY_REGEX=/Complexity:(.*) Lines/
-    LINES_REGEX=/Lines:(.*)/
+    TYPE_REGEX = /Type:(.*) Name/
+    NAME_REGEX = /Name:(.*) Complexity/
+    COMPLEXITY_REGEX = /Complexity:(.*) Lines/
+    LINES_REGEX = /Lines:(.*)/
 
     attr_reader :complexity, :lines, :defs, :element_type
     attr_accessor :name
@@ -23,7 +22,7 @@ module MetricFu
     end
 
     def to_h
-      base = {:name => @name, :complexity => @complexity.to_i, :lines => @lines.to_i}
+      base = { name: @name, complexity: @complexity.to_i, lines: @lines.to_i }
       unless @defs.empty?
         defs = @defs.map do |my_def|
           my_def = my_def.to_h
@@ -32,8 +31,7 @@ module MetricFu
         end
         base[:defs] = defs
       end
-      return base
+      base
     end
-
   end
 end

data/lib/metric_fu/metrics/saikuro/report.html.erb

@@ -40,7 +40,7 @@
 <% @saikuro[:files].each do |file| %>
   <% file[:classes].each do |klass| %>
       <% if !klass[:methods].empty? %>
-        <h3><%= file[:filename] %></h3>
+        <h3><%=link_to_filename(file[:filename])%></h3>
         <h4>Class : <%= klass[:class_name] %></h4>
         <h5>Total complexity : <%= klass[:complexity] %></h5>
         <h5>Total lines : <%= klass[:lines] %></h5>

data/lib/metric_fu/metrics/saikuro/scratch_file.rb

@@ -1,7 +1,6 @@
-MetricFu.metrics_require   { 'saikuro/parsing_element' }
+MetricFu.metrics_require   { "saikuro/parsing_element" }
 module MetricFu
   class SaikuroScratchFile
-
     def self.assemble_files(glob)
       files = []
       glob.each do |path|
@@ -36,7 +35,7 @@ module MetricFu
     end
 
     def filename
-      File.basename(@path, '_cyclo.html')
+      File.basename(@path, "_cyclo.html")
     end
 
     def filepath
@@ -45,38 +44,35 @@ module MetricFu
 
     def to_h
       merge_classes
-      {:classes => @elements}
+      { classes: @elements }
     end
 
     def get_elements(io)
-      begin
-        while (line = io.readline) do
-          return [] if line.nil? || line !~ /\S/
-          element ||= nil
-          if line.match(/START/)
-            unless element.nil?
-              @elements << element
-              element = nil
-            end
-            line = io.readline
-            element = MetricFu::SaikuroParsingElement.new(line)
-          elsif line.match(/END/)
-            @elements << element if element
+      while (line = io.readline)
+        return [] if line.nil? || line !~ /\S/
+        element ||= nil
+        if line.match(/START/)
+          unless element.nil?
+            @elements << element
             element = nil
-          else
-            element << line if element
           end
+          line = io.readline
+          element = MetricFu::SaikuroParsingElement.new(line)
+        elsif line.match(/END/)
+          @elements << element if element
+          element = nil
+        else
+          element << line if element
         end
-      rescue EOFError
-        nil
       end
+    rescue EOFError
+      nil
     end
 
-
     def merge_classes
       new_elements = []
       get_class_names.each do |target_class|
-        elements = @elements.find_all {|el| el.name == target_class }
+        elements = @elements.find_all { |el| el.name == target_class }
         complexity = 0
         lines = 0
         defns = []
@@ -86,12 +82,12 @@ module MetricFu
           defns << el.defs
         end
 
-        new_element = {:class_name => target_class,
-                       :complexity => complexity,
-                       :lines => lines,
-                       :methods => defns.flatten.map {|d| d.to_h}}
+        new_element = { class_name: target_class,
+                        complexity: complexity,
+                        lines: lines,
+                        methods: defns.flatten.map(&:to_h) }
         new_element[:methods] = new_element[:methods].
-                                sort_by {|x| x[:complexity] }.
+                                sort_by { |x| x[:complexity] }.
                                 reverse
 
         new_elements << new_element
@@ -108,6 +104,5 @@ module MetricFu
       end
       class_names
     end
-
   end
 end