metric_fu 4.11.3 → 4.11.4

data/spec/metric_fu/metrics/rcov/hotspot_spec.rb

@@ -1,20 +1,20 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/metric' }
-MetricFu.metrics_require { 'hotspots/hotspot' }
-MetricFu.metrics_require { 'hotspots/analysis/record' }
-MetricFu.metrics_require { 'rcov/hotspot' }
+MetricFu.metrics_require { "hotspots/metric" }
+MetricFu.metrics_require { "hotspots/hotspot" }
+MetricFu.metrics_require { "hotspots/analysis/record" }
+MetricFu.metrics_require { "rcov/hotspot" }
 
 describe MetricFu::RcovHotspot do
   describe "map" do
     let(:zero_row) do
-      MetricFu::Record.new({"percentage_uncovered"=>0.0}, nil)
+      MetricFu::Record.new({ "percentage_uncovered" => 0.0 }, nil)
     end
 
     let(:non_zero_row) do
-      MetricFu::Record.new({"percentage_uncovered"=>0.75}, nil)
+      MetricFu::Record.new({ "percentage_uncovered" => 0.75 }, nil)
     end
 
-    it {expect(subject.map(zero_row)).to eql(0.0)}
-    it {expect(subject.map(non_zero_row)).to eql(0.75)}
+    it { expect(subject.map(zero_row)).to eql(0.0) }
+    it { expect(subject.map(non_zero_row)).to eql(0.75) }
   end
 end

data/spec/metric_fu/metrics/rcov/rcov_line_spec.rb

@@ -0,0 +1,89 @@
+require "spec_helper"
+require "metric_fu/metrics/rcov/rcov_line"
+
+describe MetricFu::RCovLine do
+  describe "#to_h" do
+    it "returns a hash with the content and was_run" do
+      rcov_line = RCovLine.new("some content", 1)
+
+      expect(rcov_line.to_h).to eq(content: "some content", was_run: 1)
+    end
+  end
+
+  describe "#covered?" do
+    it "returns true if was_run is 1" do
+      rcov_line = RCovLine.new("", 1)
+
+      expect(rcov_line.covered?).to eq(true)
+    end
+
+    it "returns false if was_run is 0" do
+      rcov_line = RCovLine.new("", 0)
+
+      expect(rcov_line.covered?).to eq(false)
+    end
+
+    it "returns false if was_run is nil" do
+      rcov_line = RCovLine.new("", nil)
+
+      expect(rcov_line.covered?).to eq(false)
+    end
+  end
+
+  describe "#missed?" do
+    it "returns true if was_run is 0" do
+      rcov_line = RCovLine.new("", 0)
+
+      expect(rcov_line.missed?).to eq(true)
+    end
+
+    it "returns false if was_run is 1" do
+      rcov_line = RCovLine.new("", 1)
+
+      expect(rcov_line.missed?).to eq(false)
+    end
+
+    it "returns false if was_run is nil" do
+      rcov_line = RCovLine.new("", nil)
+
+      expect(rcov_line.missed?).to eq(false)
+    end
+  end
+
+  describe "#ignored?" do
+    it "returns true if was_run is nil" do
+      rcov_line = RCovLine.new("", nil)
+
+      expect(rcov_line.ignored?).to eq(true)
+    end
+
+    it "returns false if was_run is 1" do
+      rcov_line = RCovLine.new("", 1)
+
+      expect(rcov_line.ignored?).to eq(false)
+    end
+
+    it "returns false if was_run is 0" do
+      rcov_line = RCovLine.new("", 0)
+
+      expect(rcov_line.ignored?).to eq(false)
+    end
+  end
+
+  describe "#css_class" do
+    it "returns '' for an ignored line" do
+      rcov_line = RCovLine.new("", nil)
+      expect(rcov_line.css_class).to eq("")
+    end
+
+    it "returns 'rcov_not_run' for a missed line" do
+      rcov_line = RCovLine.new("", 0)
+      expect(rcov_line.css_class).to eq("rcov_not_run")
+    end
+
+    it "returns 'rcov_run' for a covered line" do
+      rcov_line = RCovLine.new("", 1)
+      expect(rcov_line.css_class).to eq("rcov_run")
+    end
+  end
+end

data/spec/metric_fu/metrics/rcov/simplecov_formatter_spec.rb

@@ -1,26 +1,25 @@
-require 'spec_helper'
-require 'simplecov'
-require 'metric_fu/metrics/rcov/simplecov_formatter'
-require 'metric_fu/metrics/rcov/generator'
+require "spec_helper"
+require "simplecov"
+require "metric_fu/metrics/rcov/simplecov_formatter"
+require "metric_fu/metrics/rcov/generator"
 
 describe SimpleCov::Formatter::MetricFu do
   before do
     @rcov_file =  subject.coverage_file_path
-    File.delete( @rcov_file ) if File.exists?( @rcov_file )
+    File.delete(@rcov_file) if File.exists?(@rcov_file)
 
     @result = SimpleCov::Result.new(
-      {
-       FIXTURE.fixtures_path.join('coverage.rb').expand_path.to_s =>
-        [1,1,1,1,nil,1,0,1,1,nil,0,1,1]
-      }
-    )
 
+       FIXTURE.fixtures_path.join("coverage.rb").expand_path.to_s =>
+        [1, 1, 1, 1, nil, 1, 0, 1, 1, nil, 0, 1, 1]
+
+    )
   end
 
   it "test_format" do
-    SimpleCov::Formatter::MetricFu.new.format( @result )
+    SimpleCov::Formatter::MetricFu.new.format(@result)
 
-    expect(File.exists?( @rcov_file )).to be_truthy
+    expect(File.exists?(@rcov_file)).to be_truthy
   end
 
   if SimpleCov.running
@@ -28,7 +27,7 @@ describe SimpleCov::Formatter::MetricFu do
   else
     it "test_create_content" do
       content = SimpleCov::Formatter::MetricFu::FormatLikeRCov.new(@result).format
-      test = "\="*80
+      test = "\=" * 80
 
       expect(content).to match(/#{test}/)
       expect(content).to match(/!!     value \* value/)
@@ -37,33 +36,32 @@ describe SimpleCov::Formatter::MetricFu do
     if defined?(JRUBY_VERSION)
       STDOUT.puts "Skipping spec 'cause JRuby doesn't do Coverage right"
     else
-    it "calculates the same coverage from an RCov report as from SimpleCov" do
-      SimpleCov.start # start coverage
-      require 'fixtures/coverage-153'
-      result = SimpleCov.result # end coverage
-      source_file = result.source_files.first
+      it "calculates the same coverage from an RCov report as from SimpleCov" do
+        SimpleCov.start # start coverage
+        require "fixtures/coverage-153"
+        result = SimpleCov.result # end coverage
+        source_file = result.source_files.first
 
+        # formatter ouputs this from simplecov result
+        rcov_text = SimpleCov::Formatter::MetricFu::FormatLikeRCov.new(result).format
 
-      # formatter ouputs this from simplecov result
-      rcov_text = SimpleCov::Formatter::MetricFu::FormatLikeRCov.new(result).format
+        # generator analyzes the rcov text
+        analyzed_rcov_text = MetricFu::RCovFormatCoverage.new(rcov_text).to_h
+        # [:lines, :percent_run, :methods]
+        covered_lines_from_rcov_text = analyzed_rcov_text["./spec/fixtures/coverage-153.rb"][:lines]
+        # https://github.com/colszowka/simplecov/blob/master/lib/simplecov/source_file.rb
+        expect(source_file.coverage.count).to eq(covered_lines_from_rcov_text.count)
 
-      # generator analyzes the rcov text
-      analyzed_rcov_text = MetricFu::RCovFormatCoverage.new(rcov_text).to_h
-      # [:lines, :percent_run, :methods]
-      covered_lines_from_rcov_text = analyzed_rcov_text['./spec/fixtures/coverage-153.rb'][:lines]
-      # https://github.com/colszowka/simplecov/blob/master/lib/simplecov/source_file.rb
-      expect(source_file.coverage.count).to eq(covered_lines_from_rcov_text.count)
+        line_coverage_from_rcov_text = covered_lines_from_rcov_text.map { |line| line[:was_run] }
+        expect(source_file.coverage).to eq(line_coverage_from_rcov_text)
 
-      line_coverage_from_rcov_text = covered_lines_from_rcov_text.map{|line| line[:was_run] }
-      expect(source_file.coverage).to eq(line_coverage_from_rcov_text)
+        expect(source_file.covered_percent).to eq(MetricFu::RCovFormatCoverage::TestCoverage.percent_run(covered_lines_from_rcov_text))
 
-      expect(source_file.covered_percent).to eq(MetricFu::RCovFormatCoverage::TestCoverage.percent_run(covered_lines_from_rcov_text))
-
-      source_file.lines.each_with_index do |line, index|
-        expect(line.coverage).to eq(line_coverage_from_rcov_text[index])
+        source_file.lines.each_with_index do |line, index|
+          expect(line.coverage).to eq(line_coverage_from_rcov_text[index])
+        end
       end
     end
-    end
 
   end
 end

data/spec/metric_fu/metrics/reek/configuration_spec.rb

@@ -1,12 +1,12 @@
-require 'spec_helper'
-require 'shared/configured'
+require "spec_helper"
+require "shared/configured"
 
-describe MetricFu::Configuration, 'for reek' do
-  it_behaves_like 'configured' do
+describe MetricFu::Configuration, "for reek" do
+  it_behaves_like "configured" do
     it "should set @reek to {:dirs_to_reek => @code_dirs}" do
-      load_metric 'reek'
+      load_metric "reek"
       expect(MetricFu::Metric.get_metric(:reek).run_options).to eq(
-              {:config_file_pattern=>nil, :dirs_to_reek => ['lib']}
+              config_file_pattern: nil, dirs_to_reek: ["lib"]
       )
     end
   end

data/spec/metric_fu/metrics/reek/generator_spec.rb

@@ -1,10 +1,10 @@
 require "spec_helper"
-MetricFu.metrics_require { 'reek/generator' }
+MetricFu.metrics_require { "reek/generator" }
 
 describe MetricFu::ReekGenerator do
   describe "emit" do
-    let(:options) { {:dirs_to_reek => []} }
-    let(:files_to_analyze) { ['lib/foo.rb','lib/bar.rb'] }
+    let(:options) { { dirs_to_reek: [] } }
+    let(:files_to_analyze) { ["lib/foo.rb", "lib/bar.rb"] }
     let(:reek) { MetricFu::ReekGenerator.new(options) }
 
     before :each do
@@ -12,54 +12,53 @@ describe MetricFu::ReekGenerator do
     end
 
     it "includes config file pattern into reek parameters when specified" do
-      options.merge!({:config_file_pattern => 'lib/config/*.reek' })
+      options.merge!(config_file_pattern: "lib/config/*.reek")
       expect(reek).to receive(:run!) do |args|
-        expect(args).to include('--config', 'lib/config/*.reek')
-      end.and_return('')
+        expect(args).to include("--config", "lib/config/*.reek")
+      end.and_return("")
       reek.emit
     end
 
     it "doesn't add an empty parameter when no config file pattern is specified" do
       expect(reek).to receive(:run!) do |args|
-        expect(args).not_to include('')
-      end.and_return('')
+        expect(args).not_to include("")
+      end.and_return("")
       reek.emit
     end
 
     it "turns off color output from reek output, for reek 1.3.7 or greater" do
-      allow(reek).to receive(:reek_version).and_return('1.3.7')
+      allow(reek).to receive(:reek_version).and_return("1.3.7")
       expect(reek).to receive(:run!) do |args|
-        expect(args).to include('--no-color')
+        expect(args).to include("--no-color")
       end.and_return("")
       reek.emit
     end
 
     it "does not set an (invalid) --no-color option for reek < 1.3.7" do
-      allow(reek).to receive(:reek_version).and_return('1.3.6')
+      allow(reek).to receive(:reek_version).and_return("1.3.6")
       expect(reek).to receive(:run!) do |args|
-        expect(args).not_to include('--no-color')
+        expect(args).not_to include("--no-color")
       end.and_return("")
       reek.emit
     end
 
     it "disables lines numbers from reek output" do
       expect(reek).to receive(:run!) do |args|
-        expect(args).to include('--no-line-numbers')
+        expect(args).to include("--no-line-numbers")
       end.and_return("")
       reek.emit
     end
 
     it "includes files to analyze into reek parameters" do
       expect(reek).to receive(:run!) do |args|
-        expect(args).to include('lib/foo.rb', 'lib/bar.rb')
+        expect(args).to include("lib/foo.rb", "lib/bar.rb")
       end.and_return("")
       reek.emit
     end
   end
 
-  #TODO review tested output
+  # TODO review tested output
   describe "analyze method" do
-
     before :each do
       MetricFu::Configuration.run {}
       allow(File).to receive(:directory?).and_return(true)
@@ -110,10 +109,10 @@ NewlineController#some_method calls current_user.<< "new line\n" multiple times
 
       it "should NOT insert nil smells into the array when there's a newline in the method call" do
         expect(@matches.last[:code_smells]).to eq(@matches.last[:code_smells].compact)
-        expect(@matches.last).to eq({:file_path=>"app/controllers/newline_controller.rb",
-                                  :code_smells=>[{:type=>"Duplication",
-                                                    :method=>"\"",
-                                                    :message=>"multiple times"}]})
+        expect(@matches.last).to eq(file_path: "app/controllers/newline_controller.rb",
+                                    code_smells: [{ type: "Duplication",
+                                                    method: "\"",
+                                                    message: "multiple times" }])
         # Note: hopefully a temporary solution until I figure out how to deal with newlines in the method call more effectively -Jake 5/11/2009
       end
     end

data/spec/metric_fu/metrics/reek/grapher_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'reek/grapher' }
+MetricFu.metrics_require { "reek/grapher" }
 
 describe ReekGrapher do
   before :each do
@@ -45,7 +45,7 @@ describe ReekGrapher do
 
       it "should set a hash of code smells to reek_count" do
         @reek_grapher.get_metrics(@metrics, @date)
-        expect(@reek_grapher.reek_count).to eq({
+        expect(@reek_grapher.reek_count).to eq(
           "Uncommunicative Name" => [27],
           "Feature Envy" => [20],
           "Utility Function" => [15],
@@ -54,11 +54,11 @@ describe ReekGrapher do
           "Control Couple" => [4],
           "Duplication" => [48],
           "Large Class" => [1]
-        })
+        )
       end
 
       it "should update labels with the date" do
-        expect(@reek_grapher.labels).to receive(:update).with({ 0 => "1/2" })
+        expect(@reek_grapher.labels).to receive(:update).with(0 => "1/2")
         @reek_grapher.get_metrics(@metrics, @date)
       end
     end

data/spec/metric_fu/metrics/roodi/configuration_spec.rb

@@ -1,16 +1,14 @@
-require 'spec_helper'
-require 'shared/configured'
-
-describe MetricFu::Configuration, 'for roodi' do
-  it_behaves_like 'configured' do
+require "spec_helper"
+require "shared/configured"
 
+describe MetricFu::Configuration, "for roodi" do
+  it_behaves_like "configured" do
     it "should set @roodi to {:dirs_to_roodi => @code_dirs}" do
-      load_metric 'roodi'
+      load_metric "roodi"
       expect(MetricFu::Metric.get_metric(:roodi).run_options).to eq(
-              { :dirs_to_roodi => directory('code_dirs'),
-                  :roodi_config => "#{directory('root_directory')}/config/roodi_config.yml"}
+               dirs_to_roodi: directory("code_dirs"),
+               roodi_config: "#{directory('root_directory')}/config/roodi_config.yml"
               )
     end
-
   end
 end

data/spec/metric_fu/metrics/roodi/generator_spec.rb

@@ -1,17 +1,17 @@
 require "spec_helper"
-MetricFu.metrics_require { 'roodi/generator' }
+MetricFu.metrics_require { "roodi/generator" }
 
 describe MetricFu::RoodiGenerator do
   describe "emit" do
     it "should add config options when present" do
-      options = {:roodi_config => 'lib/config/roodi_config.yml', :dirs_to_roodi => []}
+      options = { roodi_config: "lib/config/roodi_config.yml", dirs_to_roodi: [] }
       roodi = MetricFu::RoodiGenerator.new(options)
       expect(roodi).to receive(:run!).with(/-config=lib\/config\/roodi_config\.yml/).and_return("")
       roodi.emit
     end
 
     it "should NOT add config options when NOT present" do
-      options = {:dirs_to_roodi => []}
+      options = { dirs_to_roodi: [] }
       roodi = MetricFu::RoodiGenerator.new(options)
       allow(roodi).to receive(:run!)
       expect(roodi).to receive(:run!).with(/-config/).never

data/spec/metric_fu/metrics/roodi/grapher_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'roodi/grapher' }
+MetricFu.metrics_require { "roodi/grapher" }
 
 describe RoodiGrapher do
   before :each do
@@ -49,7 +49,7 @@ describe RoodiGrapher do
       end
 
       it "should update labels with the date" do
-        expect(@roodi_grapher.labels).to receive(:update).with({ 0 => "1/2" })
+        expect(@roodi_grapher.labels).to receive(:update).with(0 => "1/2")
         @roodi_grapher.get_metrics(@metrics, @date)
       end
     end

data/spec/metric_fu/metrics/saikuro/configuration_spec.rb

@@ -3,24 +3,23 @@ require "shared/configured"
 
 describe MetricFu::Configuration, "for saikuro" do
   it_behaves_like "configured" do
-
-      it "should set @saikuro to { :output_directory => @scratch_directory + '/saikuro',
-                                   :input_directory => @code_dirs,
-                                   :cyclo => '',
-                                   :filter_cyclo => '0',
-                                   :warn_cyclo => '5',
-                                   :error_cyclo => '7',
-                                   :formater => 'text' }" do
-        load_metric "saikuro"
-        expect(MetricFu::Metric.get_metric(:saikuro).run_options).to eq(
-                { :output_directory => "#{scratch_directory}/saikuro",
-                      :input_directory => ["lib"],
-                      :cyclo => "",
-                      :filter_cyclo => "0",
-                      :warn_cyclo => "5",
-                      :error_cyclo => "7",
-                      :formater => "text"}
-                      )
-      end
+    it "should set @saikuro to { :output_directory => @scratch_directory + '/saikuro',
+                                 :input_directory => @code_dirs,
+                                 :cyclo => '',
+                                 :filter_cyclo => '0',
+                                 :warn_cyclo => '5',
+                                 :error_cyclo => '7',
+                                 :formater => 'text' }" do
+      load_metric "saikuro"
+      expect(MetricFu::Metric.get_metric(:saikuro).run_options).to eq(
+               output_directory: "#{scratch_directory}/saikuro",
+               input_directory: ["lib"],
+               cyclo: "",
+               filter_cyclo: "0",
+               warn_cyclo: "5",
+               error_cyclo: "7",
+               formater: "text"
+                    )
+    end
   end
 end