metric_fu 4.11.3 → 4.11.4

data/lib/metric_fu/metrics/cane/generator.rb

@@ -1,4 +1,4 @@
-MetricFu.metrics_require { 'cane/violations' }
+MetricFu.metrics_require { "cane/violations" }
 module MetricFu
   class CaneGenerator < Generator
     attr_reader :violations, :total_violations
@@ -23,8 +23,9 @@ module MetricFu
     end
 
     def to_h
-      {:cane => {:total_violations => @total_violations, :violations => @violations}}
+      { cane: { total_violations: @total_violations, violations: @violations } }
     end
+
     private
 
     def abc_max_param
@@ -36,11 +37,11 @@ module MetricFu
     end
 
     def no_doc_param
-      options[:no_doc] == 'y' ? " --no-doc" : ""
+      options[:no_doc] == "y" ? " --no-doc" : ""
     end
 
     def no_readme_param
-      options[:no_readme] == 'y' ? " --no-readme" : ""
+      options[:no_readme] == "y" ? " --no-readme" : ""
     end
 
     def violations_by_category
@@ -54,12 +55,12 @@ module MetricFu
 
     def category_from(description)
       category_descriptions = {
-        :abc_complexity => /ABC complexity/,
-        :line_style => /style requirements/,
-        :comment => /comment/,
-        :documentation => /documentation/
+        abc_complexity: /ABC complexity/,
+        line_style: /style requirements/,
+        comment: /comment/,
+        documentation: /documentation/
       }
-      category, desc_matcher = category_descriptions.find {|k,v| description =~ v}
+      category, desc_matcher = category_descriptions.find { |_k, v| description =~ v }
       mf_debug desc_matcher.inspect
       category
     end

data/lib/metric_fu/metrics/cane/grapher.rb

@@ -1,4 +1,4 @@
-MetricFu.reporting_require { 'graphs/grapher' }
+MetricFu.reporting_require { "graphs/grapher" }
 module MetricFu
   class CaneGrapher < Grapher
     attr_accessor :cane_violations, :labels
@@ -16,24 +16,22 @@ module MetricFu
     def get_metrics(metrics, date)
       if metrics && metrics[:cane]
         @cane_violations.push(metrics[:cane][:total_violations].to_i)
-        @labels.update( { @labels.size => date })
+        @labels.update(@labels.size => date)
       end
     end
 
     def title
-      'Cane: code quality threshold violations'
+      "Cane: code quality threshold violations"
     end
 
     def data
       [
-        ['cane', @cane_violations.join(',')]
+        ["cane", @cane_violations.join(",")]
       ]
     end
 
     def output_filename
-      'cane.js'
+      "cane.js"
     end
-
   end
 end
-

data/lib/metric_fu/metrics/cane/metric.rb

@@ -1,18 +1,17 @@
 module MetricFu
   class MetricCane < Metric
-
     def name
       :cane
     end
 
     def default_run_options
       {
-        :dirs_to_cane => MetricFu::Io::FileSystem.directory('code_dirs'),
-        :abc_max => 15,
-        :line_length => 80,
-        :no_doc => 'n',
-        :no_readme => 'n',
-        :filetypes => ['rb']
+        dirs_to_cane: MetricFu::Io::FileSystem.directory("code_dirs"),
+        abc_max: 15,
+        line_length: 80,
+        no_doc: "n",
+        no_readme: "n",
+        filetypes: ["rb"]
       }
     end
 
@@ -31,6 +30,5 @@ module MetricFu
     def activate
       super
     end
-
   end
 end

data/lib/metric_fu/metrics/cane/report.html.erb

@@ -15,7 +15,7 @@
   <% count = 0 %>
   <% @cane[:violations][:abc_complexity].each do |violation| %>
     <tr class='<%= cycle("light", "dark", count) %>'>
-      <td><%=violation[:file]%></td>
+      <td><%=link_to_filename(violation[:file])%></td>
       <td><%=violation[:method]%></td>
       <td><%=violation[:complexity]%></td>
     </tr>
@@ -33,7 +33,7 @@
   <% count = 0 %>
   <% @cane[:violations][:line_style].each do |violation| %>
     <tr class='<%= cycle("light", "dark", count) %>'>
-      <td><%=violation[:line]%></td>
+      <td><%=link_to_filename(*violation[:line].split(':'))%></td>
       <td><%=violation[:description]%></td>
     </tr>
     <% count += 1 %>
@@ -63,7 +63,7 @@
   <% count = 0 %>
   <% @cane[:violations][:comment].each do |violation| %>
     <tr class='<%= cycle("light", "dark", count) %>'>
-      <td><%=violation[:line]%></td>
+      <td><%=link_to_filename(*violation[:line].split(':'))%></td>
       <td><%=violation[:class_name]%></td>
     </tr>
     <% count += 1 %>

data/lib/metric_fu/metrics/cane/violations.rb

@@ -4,7 +4,7 @@ module MetricFu
       def self.parse(violation_list)
         violation_list.split(/\n/).map do |violation|
           file, method, complexity = violation.split
-          {:file => file, :method => method, :complexity => complexity}
+          { file: file, method: method, complexity: complexity }
         end
       end
     end
@@ -12,8 +12,8 @@ module MetricFu
     class LineStyle
       def self.parse(violation_list)
         violation_list.split(/\n/).map do |violation|
-          line, description = violation.split(/\s{2,}/).reject{|x|x.strip==''}
-          {:line => line, :description => description}
+          line, description = violation.split(/\s{2,}/).reject { |x|x.strip == "" }
+          { line: line, description: description }
         end
       end
     end
@@ -22,7 +22,7 @@ module MetricFu
       def self.parse(violation_list)
         violation_list.split(/\n/).map do |violation|
           line, class_name = violation.split
-          {:line => line, :class_name => class_name}
+          { line: line, class_name: class_name }
         end
       end
     end
@@ -30,7 +30,7 @@ module MetricFu
     class Documentation
       def self.parse(violation_list)
         violation_list.split(/\n/).map do |violation|
-          {:description => violation.strip}
+          { description: violation.strip }
         end
       end
     end
@@ -38,7 +38,7 @@ module MetricFu
     class Others
       def self.parse(violation_list)
         violation_list.split(/\n/).map do |violation|
-          {:description => violation.strip}
+          { description: violation.strip }
         end
       end
     end

data/lib/metric_fu/metrics/churn/generator.rb

@@ -1,7 +1,5 @@
 module MetricFu
-
   class ChurnGenerator < Generator
-
     def self.metric
       :churn
     end
@@ -16,7 +14,7 @@ module MetricFu
 
     def analyze
       if @output.nil? || @output.size.zero?
-        @churn = {:churn => {}}
+        @churn = { churn: {} }
       else
         @churn = @output
       end
@@ -25,7 +23,7 @@ module MetricFu
 
     # ensure hash only has the :churn key
     def to_h
-      {:churn => @churn[:churn]}
+      { churn: @churn[:churn] }
     end
 
     # @param args [Hash] churn metric run options
@@ -35,7 +33,5 @@ module MetricFu
       #    instead of the default String
       ::Churn::ChurnCalculator.new(args).report(false)
     end
-
   end
-
 end

data/lib/metric_fu/metrics/churn/hotspot.rb

@@ -1,5 +1,4 @@
 class MetricFu::ChurnHotspot < MetricFu::Hotspot
-
   COLUMNS = %w{times_changed}
 
   def columns
@@ -28,7 +27,7 @@ class MetricFu::ChurnHotspot < MetricFu::Hotspot
   end
 
   def generate_records(data, table)
-   return if data==nil
+    return if data == nil
     Array(data[:changes]).each do |change|
       table << {
         "metric" => :churn,
@@ -41,5 +40,4 @@ class MetricFu::ChurnHotspot < MetricFu::Hotspot
   def present_group(group)
     "detected high level of churn (changed #{group[0].times_changed} times)"
   end
-
 end

data/lib/metric_fu/metrics/churn/metric.rb

@@ -1,16 +1,15 @@
 module MetricFu
   class MetricChurn < Metric
-
     def name
       :churn
     end
 
     def default_run_options
       {
-        :start_date => %q("1 year ago"),
-        :minimum_churn_count => 10,
-        :ignore_files => [],
-        :data_directory => MetricFu::Io::FileSystem.scratch_directory(name)
+        start_date: '"1 year ago"',
+        minimum_churn_count: 10,
+        ignore_files: [],
+        data_directory: MetricFu::Io::FileSystem.scratch_directory(name)
       }
     end
 
@@ -23,9 +22,8 @@ module MetricFu
     end
 
     def activate
-      activate_library('churn/calculator')
+      activate_library("churn/calculator")
       super
     end
-
   end
 end

data/lib/metric_fu/metrics/flay/generator.rb

@@ -1,7 +1,5 @@
 module MetricFu
-
   class FlayGenerator < Generator
-
     def self.metric
       :flay
     end
@@ -12,28 +10,28 @@ module MetricFu
     end
 
     def analyze
-      @matches = @output.chomp.split("\n\n").map{|m| m.split("\n  ") }
+      @matches = @output.chomp.split("\n\n").map { |m| m.split("\n  ") }
     end
 
     def to_h
-      {:flay => calculate_result(@matches)}
+      { flay: calculate_result(@matches) }
     end
 
     # TODO: move into analyze method
     def calculate_result(matches)
-      total_score = matches.shift.first.split('=').last.strip
+      total_score = matches.shift.first.split("=").last.strip
       target = []
       matches.each do |problem|
         reason = problem.shift.strip
         lines_info = problem.map do |full_line|
           name, line = full_line.split(":").map(&:strip)
-          {:name => name, :line => line}
+          { name: name, line: line }
         end
-        target << [:reason => reason, :matches => lines_info]
+        target << [reason: reason, matches: lines_info]
       end
       {
-        :total_score => total_score,
-        :matches => target.flatten
+        total_score: total_score,
+        matches: target.flatten
       }
     end
 
@@ -43,13 +41,11 @@ module MetricFu
       flay_mass = options[:minimum_score]
       return "" unless flay_mass
 
-
       "--mass #{flay_mass} "
     end
 
     def dirs_to_flay
       options[:dirs_to_flay].join(" ")
     end
-
   end
 end

data/lib/metric_fu/metrics/flay/grapher.rb

@@ -1,4 +1,4 @@
-MetricFu.reporting_require { 'graphs/grapher' }
+MetricFu.reporting_require { "graphs/grapher" }
 module MetricFu
   class FlayGrapher < Grapher
     attr_accessor :flay_score, :labels
@@ -16,23 +16,22 @@ module MetricFu
     def get_metrics(metrics, date)
       if metrics && metrics[:flay]
         @flay_score.push(metrics[:flay][:total_score].to_i)
-        @labels.update( { @labels.size => date })
+        @labels.update(@labels.size => date)
       end
     end
 
     def title
-      'Flay: duplication'
+      "Flay: duplication"
     end
 
     def data
       [
-        ['flay', @flay_score.join(',')]
+        ["flay", @flay_score.join(",")]
       ]
     end
 
     def output_filename
-      'flay.js'
+      "flay.js"
     end
-
   end
 end

data/lib/metric_fu/metrics/flay/hotspot.rb

@@ -1,5 +1,4 @@
 class MetricFu::FlayHotspot < MetricFu::Hotspot
-
   COLUMNS = %w{flay_reason flay_matching_reason}
 
   def columns
@@ -23,23 +22,23 @@ class MetricFu::FlayHotspot < MetricFu::Hotspot
   end
 
   def generate_records(data, table)
-    return if data==nil
+    return if data == nil
     Array(data[:matches]).each do |match|
       problems  = match[:reason]
-      matching_reason = problems.gsub(/^[0-9]+\) /,'').gsub(/\:[0-9]+/,'')
+      matching_reason = problems.gsub(/^[0-9]+\) /, "").gsub(/\:[0-9]+/, "")
       files     = []
       locations = []
       match[:matches].each do |file_match|
-        file_path = file_match[:name].sub(%r{^/},'')
+        file_path = file_match[:name].sub(%r{^/}, "")
         locations << "#{file_path}:#{file_match[:line]}"
         files     << file_path
       end
       files = files.uniq
       files.each do |file|
         table << {
-          "metric" => self.name,
+          "metric" => name,
           "file_path" => file,
-          "flay_reason" => problems+" files: #{locations.join(', ')}",
+          "flay_reason" => problems + " files: #{locations.join(', ')}",
           "flay_matching_reason" => matching_reason
         }
       end
@@ -50,5 +49,4 @@ class MetricFu::FlayHotspot < MetricFu::Hotspot
     occurences = group.size
     "found #{occurences} code duplications"
   end
-
 end

data/lib/metric_fu/metrics/flay/metric.rb

@@ -1,16 +1,15 @@
 module MetricFu
   class MetricFlay < Metric
-
     def name
       :flay
     end
 
     def default_run_options
-      { :dirs_to_flay => MetricFu::Io::FileSystem.directory('code_dirs'),
-      # MetricFu has been setting the minimum score as 100 for
-      # a long time. This is a really big number, considering
-      # the default is 16. Setting it to nil to use the Flay default.
-      :minimum_score => nil,
+      { dirs_to_flay: MetricFu::Io::FileSystem.directory("code_dirs"),
+        # MetricFu has been setting the minimum score as 100 for
+        # a long time. This is a really big number, considering
+        # the default is 16. Setting it to nil to use the Flay default.
+        minimum_score: nil,
       }
     end
 
@@ -25,6 +24,5 @@ module MetricFu
     def activate
       super
     end
-
   end
 end

data/lib/metric_fu/metrics/flog/generator.rb

@@ -1,9 +1,8 @@
-require 'pathname'
-require 'optparse'
+require "pathname"
+require "optparse"
 
 module MetricFu
   class FlogGenerator < Generator
-
     def self.metric
       :flog
     end
@@ -21,7 +20,7 @@ module MetricFu
       @method_containers = {}
       @flogger.calculate
       @flogger.each_by_score do |full_method_name, score, operators|
-        container_name = full_method_name.split('#').first
+        container_name = full_method_name.split("#").first
         path = @flogger.method_locations[full_method_name]
         if @method_containers[container_name]
           @method_containers[container_name].add_method(full_method_name, operators, score, path)
@@ -35,20 +34,20 @@ module MetricFu
     end
 
     def to_h
-      sorted_containers = @method_containers.values.sort_by {|c| c.highest_score}.reverse
-      {:flog => { :total => @flogger.total_score,
-                  :average => @flogger.average,
-                  :method_containers => sorted_containers.map {|method_container| method_container.to_h}}}
+      sorted_containers = @method_containers.values.sort_by(&:highest_score).reverse
+      { flog: { total: @flogger.total_score,
+                average: @flogger.average,
+                method_containers: sorted_containers.map(&:to_h) } }
     end
 
     def per_file_info(out)
-      @method_containers.each_pair do |klass, container|
-        container.methods.each_pair do |method_name, data|
+      @method_containers.each_pair do |_klass, container|
+        container.methods.each_pair do |_method_name, data|
           next if data[:path].nil?
 
-          file, line = data[:path].split(':')
+          file, line = data[:path].split(":")
 
-          out[file][line] << {:type => :flog, :description => "Score of %.2f" % data[:score]}
+          out[file][line] << { type: :flog, description: "Score of %.2f" % data[:score] }
         end
       end
     end
@@ -63,22 +62,22 @@ module MetricFu
       @methods = {}
     end
 
-    def add_path path
+    def add_path(path)
       return unless path
-      @path ||= path.split(':').first
+      @path ||= path.split(":").first
     end
 
     def add_method(full_method_name, operators, score, path)
-      @methods[full_method_name] = {:operators => operators, :score => score, :path => path}
+      @methods[full_method_name] = { operators: operators, score: score, path: path }
     end
 
     def to_h
-      { :name => @name,
-        :path => @path || '',
-        :total_score => total_score,
-        :highest_score => highest_score,
-        :average_score => average_score,
-        :methods => @methods}
+      { name: @name,
+        path: @path || "",
+        total_score: total_score,
+        highest_score: highest_score,
+        average_score: average_score,
+        methods: @methods }
     end
 
     def highest_score
@@ -88,11 +87,11 @@ module MetricFu
     private
 
     def method_scores
-      @method_scores ||= @methods.values.map {|v| v[:score] }
+      @method_scores ||= @methods.values.map { |v| v[:score] }
     end
 
     def total_score
-      @total_score ||= method_scores.inject(0) {|sum, score| sum += score}
+      @total_score ||= method_scores.inject(0) { |sum, score| sum += score }
     end
 
     def average_score