metric_fu 4.11.3 → 4.11.4

data/spec/metric_fu/configuration_spec.rb

@@ -2,101 +2,89 @@ require "spec_helper"
 require "shared/configured"
 
 describe MetricFu::Configuration do
-
-it_behaves_like "configured" do
-
-  describe "#is_cruise_control_rb?" do
-
-    before(:each) { get_new_config }
-    describe "when the CC_BUILD_ARTIFACTS env var is not nil" do
-
-      before(:each) do
-        ENV["CC_BUILD_ARTIFACTS"] = "is set"
+  it_behaves_like "configured" do
+    describe "#is_cruise_control_rb?" do
+      before(:each) { get_new_config }
+      describe "when the CC_BUILD_ARTIFACTS env var is not nil" do
+        before(:each) do
+          ENV["CC_BUILD_ARTIFACTS"] = "is set"
+        end
+
+        it "should return true"  do
+          expect(@config.is_cruise_control_rb?).to be_truthy
+        end
+
+        after(:each)  do
+          ENV["CC_BUILD_ARTIFACTS"] = nil
+          FileUtils.rm_rf(File.join(MetricFu.root_dir, "is set"))
+        end
       end
 
-      it "should return true"  do
-        expect(@config.is_cruise_control_rb?).to be_truthy
-      end
+      describe "when the CC_BUILD_ARTIFACTS env var is nil" do
+        before(:each) { ENV["CC_BUILD_ARTIFACTS"] = nil }
 
-      after(:each)  do
-        ENV["CC_BUILD_ARTIFACTS"] = nil
-        FileUtils.rm_rf(File.join(MetricFu.root_dir, "is set"))
+        it "should return false" do
+          expect(@config.is_cruise_control_rb?).to be_falsey
+        end
       end
-
     end
 
-    describe "when the CC_BUILD_ARTIFACTS env var is nil" do
-      before(:each) { ENV["CC_BUILD_ARTIFACTS"] = nil }
-
-      it "should return false" do
-        expect(@config.is_cruise_control_rb?).to be_falsey
+    describe "#reset" do
+      describe "when there is a CC_BUILD_ARTIFACTS environment variable" do
+        before do
+          ENV["CC_BUILD_ARTIFACTS"] = "foo"
+          @config = MetricFu.configuration
+          @config.reset
+          MetricFu.configure
+        end
+        it "should return the CC_BUILD_ARTIFACTS environment variable" do
+          compare_paths(base_directory, ENV["CC_BUILD_ARTIFACTS"])
+        end
+        after do
+          ENV["CC_BUILD_ARTIFACTS"] = nil
+          FileUtils.rm_rf(File.join(MetricFu.root_dir, "foo"))
+        end
       end
-    end
-  end
-
-  describe "#reset" do
 
-    describe "when there is a CC_BUILD_ARTIFACTS environment variable" do
-
-      before do
-        ENV["CC_BUILD_ARTIFACTS"] = "foo"
-        @config = MetricFu.configuration
-        @config.reset
-        MetricFu.configure
-      end
-      it "should return the CC_BUILD_ARTIFACTS environment variable" do
-        compare_paths(base_directory, ENV["CC_BUILD_ARTIFACTS"])
-      end
-      after do
-        ENV["CC_BUILD_ARTIFACTS"] = nil
-        FileUtils.rm_rf(File.join(MetricFu.root_dir, "foo"))
+      describe "when there is no CC_BUILD_ARTIFACTS environment variable" do
+        before(:each) do
+          ENV["CC_BUILD_ARTIFACTS"] = nil
+          get_new_config
+        end
+        it "should return 'tmp/metric_fu'" do
+          expect(base_directory).to eq(MetricFu.artifact_dir)
+        end
+
+        it "should set @metric_fu_root_directory to the base of the "\
+        "metric_fu application" do
+          app_root = File.join(File.dirname(__FILE__), "..", "..")
+          app_root_absolute_path = File.expand_path(app_root)
+          metric_fu_absolute_path = File.expand_path(metric_fu_root)
+          expect(metric_fu_absolute_path).to eq(app_root_absolute_path)
+          expect(MetricFu.root.to_s).to eq(app_root_absolute_path)
+        end
+
+        it "should set @scratch_directory to scratch relative "\
+        "to @base_directory" do
+          scratch_dir = MetricFu.scratch_dir
+          expect(scratch_directory).to eq(scratch_dir)
+        end
+
+        it "should set @output_directory to output relative "\
+        "to @base_directory" do
+          output_dir = MetricFu.output_dir
+          expect(output_directory).to eq(output_dir)
+        end
       end
     end
 
-    describe "when there is no CC_BUILD_ARTIFACTS environment variable" do
+    describe "#platform" do
+      before(:each) { get_new_config }
 
-      before(:each) do
-        ENV["CC_BUILD_ARTIFACTS"] = nil
-        get_new_config
-      end
-      it "should return 'tmp/metric_fu'" do
-        expect(base_directory).to eq(MetricFu.artifact_dir)
+      it "should return the value of the PLATFORM constant" do
+        this_platform = RUBY_PLATFORM
+        expect(@config.platform).to eq(this_platform)
       end
-
-      it "should set @metric_fu_root_directory to the base of the "\
-      "metric_fu application" do
-        app_root = File.join(File.dirname(__FILE__), "..", "..")
-        app_root_absolute_path = File.expand_path(app_root)
-        metric_fu_absolute_path = File.expand_path(metric_fu_root)
-        expect(metric_fu_absolute_path).to eq(app_root_absolute_path)
-        expect(MetricFu.root.to_s).to      eq(app_root_absolute_path)
-      end
-
-      it "should set @scratch_directory to scratch relative "\
-      "to @base_directory" do
-        scratch_dir = MetricFu.scratch_dir
-        expect(scratch_directory).to eq(scratch_dir)
-      end
-
-      it "should set @output_directory to output relative "\
-      "to @base_directory" do
-        output_dir = MetricFu.output_dir
-        expect(output_directory).to eq(output_dir)
-      end
-
-    end
-
-  end
-
-  describe "#platform" do
-
-    before(:each) { get_new_config }
-
-    it "should return the value of the PLATFORM constant" do
-      this_platform = RUBY_PLATFORM
-      expect(@config.platform).to eq(this_platform)
     end
   end
-
-end
 end

data/spec/metric_fu/data_structures/line_numbers_spec.rb

@@ -1,9 +1,9 @@
 require "spec_helper"
-MetricFu.data_structures_require { 'line_numbers' }
+MetricFu.data_structures_require { "line_numbers" }
 
 describe MetricFu::LineNumbers do
   FIXTURE_DATA = ->(paths) {
-    FIXTURE.load_file( ['line_numbers'].concat(Array(paths)) )
+    FIXTURE.load_file(["line_numbers"].concat(Array(paths)))
   }
   describe "in_method?" do
     it "should know if a line is NOT in a method" do
@@ -51,7 +51,7 @@ describe MetricFu::LineNumbers do
 
     it "should work with modules" do
       ln = MetricFu::LineNumbers.new(FIXTURE_DATA["module.rb"])
-      expect(ln.method_at_line(4)).to eq('KickAss#get_beat_up?')
+      expect(ln.method_at_line(4)).to eq("KickAss#get_beat_up?")
     end
 
     it "should work with module surrounding class" do
@@ -59,7 +59,5 @@ describe MetricFu::LineNumbers do
       expect(ln.method_at_line(5)).to eq("StuffModule::ThingClass#do_it")
       # ln.method_at_line(12).should == "StuffModule#blah" #why no work?
     end
-
   end
-
 end

data/spec/metric_fu/data_structures/location_spec.rb

@@ -1,8 +1,7 @@
 require "spec_helper"
-MetricFu.data_structures_require { 'location' }
+MetricFu.data_structures_require { "location" }
 
 describe MetricFu::Location do
-
   context "with non-standard Reek method names" do
     # reek reports the method with :: not # on modules like
     # module ApplicationHelper \n def signed_in?, convert it so it records correctly
@@ -13,33 +12,29 @@ describe MetricFu::Location do
     end
 
     it "has method name" do
-      expect(@location.method_name).to eq('ApplicationHelper#section_link')
+      expect(@location.method_name).to eq("ApplicationHelper#section_link")
     end
 
     it "has nil file path" do
-      expect(@location.file_path).to   eq(nil)
+      expect(@location.file_path).to eq(nil)
     end
 
     it "has class name" do
-      expect(@location.class_name).to  eq('ApplicationHelper')
+      expect(@location.class_name).to eq("ApplicationHelper")
     end
-
   end
 
   context "using new" do
-
     before do
       @location = Location.new("lib/foo.rb", "Foo", "Foo#some_method")
     end
 
     it "should return fully qualified method" do
-      expect(@location.method_name).to eq('Foo#some_method')
+      expect(@location.method_name).to eq("Foo#some_method")
     end
-
   end
 
   context "using .for with class" do
-
     before do
       @location = Location.for("Module::Foo")
     end
@@ -53,58 +48,49 @@ describe MetricFu::Location do
     end
 
     it "has class_name" do
-      expect(@location.class_name).to eq('Foo')
+      expect(@location.class_name).to eq("Foo")
     end
-
   end
 
   context "using .for with method" do
-
     before do
       @location = Location.for("Module::Foo#some_method")
     end
 
     it "strips module from class name" do
-      expect(@location.class_name).to eq('Foo')
+      expect(@location.class_name).to eq("Foo")
     end
 
     it "strips module from method name" do
-      expect(@location.method_name).to eq('Foo#some_method')
+      expect(@location.method_name).to eq("Foo#some_method")
     end
 
     it "has nil file_path" do
       expect(@location.file_path).to be nil
     end
-
   end
 
   context "with class method" do
-
     it "provides non-qualified name" do
       location = Location.for("Foo.some_class_method")
-      expect(location.simple_method_name).to eq('.some_class_method')
+      expect(location.simple_method_name).to eq(".some_class_method")
     end
-
   end
 
   context "with instance method" do
-
     it "provides non-qualified name" do
       location = Location.for("Foo#some_class_method")
-      expect(location.simple_method_name).to eq('#some_class_method')
+      expect(location.simple_method_name).to eq("#some_class_method")
     end
-
   end
-    context "testing equality" do
+  context "testing equality" do
     before :each do
-
-      @location1 = MetricFu::Location.get('/some/path','some_class','some_method')
+      @location1 = MetricFu::Location.get("/some/path", "some_class", "some_method")
 
       # ensure that we get a new object
-      @location2 = MetricFu::Location.new('/some/path','some_class','some_method')
+      @location2 = MetricFu::Location.new("/some/path", "some_class", "some_method")
     end
     it "should match two locations with the same paths as equal" do
-
       hsh1 = {}
       hsh1[@location1] = 1
 
@@ -117,12 +103,8 @@ describe MetricFu::Location do
       expect(@location1.eql?(@location2)).to be_truthy
     end
 
-
     it "should produce the same hash value given the same paths" do
-
       expect(@location1.hash).to eq(@location2.hash)
     end
-
   end
-
 end

data/spec/metric_fu/formatter/configuration_spec.rb

@@ -1,15 +1,14 @@
-require 'spec_helper'
-require 'shared/configured'
-
-describe MetricFu::Configuration, 'for formatters' do
-  it_behaves_like 'configured' do
+require "spec_helper"
+require "shared/configured"
 
+describe MetricFu::Configuration, "for formatters" do
+  it_behaves_like "configured" do
     describe "#configure_formatter" do
       before(:each) { get_new_config }
 
       context "given a built-in formatter" do
         before do
-          @config.configure_formatter('html')
+          @config.configure_formatter("html")
         end
 
         it "adds to the list of formatters" do
@@ -19,8 +18,8 @@ describe MetricFu::Configuration, 'for formatters' do
 
       context "given a custom formatter by class name" do
         before do
-          stub_const('MyCustomFormatter', Class.new() { def initialize(*); end })
-          @config.configure_formatter('MyCustomFormatter')
+          stub_const("MyCustomFormatter", Class.new { def initialize(*); end })
+          @config.configure_formatter("MyCustomFormatter")
         end
 
         it "adds to the list of formatters" do
@@ -30,10 +29,10 @@ describe MetricFu::Configuration, 'for formatters' do
 
       context "given multiple formatters" do
         before do
-          stub_const('MyCustomFormatter', Class.new() { def initialize(*); end })
-          @config.configure_formatter('html')
-          @config.configure_formatter('yaml')
-          @config.configure_formatter('MyCustomFormatter')
+          stub_const("MyCustomFormatter", Class.new { def initialize(*); end })
+          @config.configure_formatter("html")
+          @config.configure_formatter("yaml")
+          @config.configure_formatter("MyCustomFormatter")
         end
 
         it "adds each to the list of formatters" do
@@ -41,6 +40,5 @@ describe MetricFu::Configuration, 'for formatters' do
         end
       end
     end
-
   end
 end

data/spec/metric_fu/formatter/html_spec.rb

@@ -1,8 +1,7 @@
 require "spec_helper"
-MetricFu.formatter_require { 'html' }
+MetricFu.formatter_require { "html" }
 
 describe MetricFu::Formatter::HTML do
-
   before do
     setup_fs
 
@@ -12,14 +11,14 @@ describe MetricFu::Formatter::HTML do
     # for some platforms.
     config = MetricFu.configuration
     if config.mri?
-       @metric_with_graph = :cane
+      @metric_with_graph = :cane
     else
-       @metric_with_graph = :stats
-       config.templates_configuration do |c|
-         c.syntax_highlighting = false
-       end
+      @metric_with_graph = :stats
+      config.templates_configuration do |c|
+        c.syntax_highlighting = false
+      end
     end
-    allow(MetricFu::Metric.get_metric(@metric_with_graph)).to receive(:run_external).and_return('')
+    allow(MetricFu::Metric.get_metric(@metric_with_graph)).to receive(:run_external).and_return("")
     @metric_without_graph = :hotspots
     config.configure_metrics.each do |metric|
       metric.enabled = true if [@metric_with_graph, @metric_without_graph].include?(metric.name)
@@ -34,30 +33,29 @@ describe MetricFu::Formatter::HTML do
   end
 
   context "In general" do
-
     it "creates a report yaml file" do
       # For backward compatibility.
       expect {
-      MetricFu::Formatter::HTML.new.finish
+        MetricFu::Formatter::HTML.new.finish
       }.to create_file("#{directory('base_directory')}/report.yml")
     end
 
     it "creates a data yaml file" do
       # For use with graphs.
       expect {
-      MetricFu::Formatter::HTML.new.finish
+        MetricFu::Formatter::HTML.new.finish
       }.to create_file("#{directory('data_directory')}/#{MetricFu.report_id}.yml")
     end
 
     it "creates a report index html file" do
       expect {
-      MetricFu::Formatter::HTML.new.finish
+        MetricFu::Formatter::HTML.new.finish
       }.to create_file("#{directory('output_directory')}/index.html")
     end
 
     it "creates templatized html files for each metric" do
       expect {
-      MetricFu::Formatter::HTML.new.finish
+        MetricFu::Formatter::HTML.new.finish
       }.to create_files([
         "#{directory('output_directory')}/#{@metric_with_graph}.html",
         "#{directory('output_directory')}/#{@metric_without_graph}.html"
@@ -66,46 +64,43 @@ describe MetricFu::Formatter::HTML do
 
     it "copies common javascripts to the output directory" do
       expect {
-      MetricFu::Formatter::HTML.new.finish
+        MetricFu::Formatter::HTML.new.finish
       }.to create_file("#{directory('output_directory')}/highcharts*.js")
     end
 
     it "creates graphs for appropriate metrics" do
       expect {
-      MetricFu::Formatter::HTML.new.finish
+        MetricFu::Formatter::HTML.new.finish
       }.to create_files([
         "#{directory('output_directory')}/#{@metric_with_graph}.js",
       ])
     end
 
-
     it "can open the results in the browser" do
       allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
       formatter = MetricFu::Formatter::HTML.new
-      path = MetricFu.run_path.join(directory('output_directory'))
-      uri = URI.join(URI.escape("file://#{path}/"), 'index.html')
+      path = MetricFu.run_path.join(directory("output_directory"))
+      uri = URI.join(URI.escape("file://#{path}/"), "index.html")
       expect(Launchy).to receive(:open).with(uri)
       formatter.finish
       formatter.display_results
     end
-
   end
 
   context "given a custom output directory" do
-
     before do
-      @output = 'customdir'
+      @output = "customdir"
     end
 
     it "creates the report index html file in the custom output directory" do
       expect {
-      MetricFu::Formatter::HTML.new(output: @output).finish
+        MetricFu::Formatter::HTML.new(output: @output).finish
       }.to create_file("#{directory('base_directory')}/#{@output}/index.html")
     end
 
     it "creates templatized html files for each metric in the custom output directory" do
       expect {
-      MetricFu::Formatter::HTML.new(output: @output).finish
+        MetricFu::Formatter::HTML.new(output: @output).finish
       }.to create_files([
         "#{directory('base_directory')}/#{@output}/#{@metric_with_graph}.html",
         "#{directory('base_directory')}/#{@output}/#{@metric_without_graph}.html"
@@ -114,13 +109,13 @@ describe MetricFu::Formatter::HTML do
 
     it "copies common javascripts to the custom output directory" do
       expect {
-      MetricFu::Formatter::HTML.new(output: @output).finish
+        MetricFu::Formatter::HTML.new(output: @output).finish
       }.to create_file("#{directory('base_directory')}/#{@output}/highcharts*.js")
     end
 
     it "creates graphs for appropriate metrics in the custom output directory " do
       expect {
-      MetricFu::Formatter::HTML.new(output: @output).finish
+        MetricFu::Formatter::HTML.new(output: @output).finish
       }.to create_file(
         "#{directory('base_directory')}/#{@output}/#{@metric_with_graph}.js",
       )
@@ -130,16 +125,14 @@ describe MetricFu::Formatter::HTML do
       allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
       formatter = MetricFu::Formatter::HTML.new(output: @output)
       path = MetricFu.run_path.join("#{directory('base_directory')}/#{@output}")
-      uri = URI.join(URI.escape("file://#{path}/"), 'index.html')
+      uri = URI.join(URI.escape("file://#{path}/"), "index.html")
       expect(Launchy).to receive(:open).with(uri)
       formatter.finish
       formatter.display_results
     end
-
   end
 
   after do
     cleanup_fs
   end
-
 end