metric_fu 4.11.3 → 4.11.4

data/spec/metric_fu/metrics/hotspots/analysis/analyzer_tables_spec.rb

@@ -1,8 +1,7 @@
-require 'spec_helper'
-MetricFu.metrics_require { 'hotspots/analysis/analyzer_tables' }
+require "spec_helper"
+MetricFu.metrics_require { "hotspots/analysis/analyzer_tables" }
 
 describe MetricFu::AnalyzerTables do
-
   before do
     enable_hotspots
   end
@@ -13,7 +12,7 @@ describe MetricFu::AnalyzerTables do
       common_columns = %w{metric}
       granularities =  %w{file_path class_name method_name}
       tool_analyzers = MetricFu::Hotspot.analyzers
-      analyzer_columns = common_columns + granularities + tool_analyzers.map{|analyzer| analyzer.columns}.flatten
+      analyzer_columns = common_columns + granularities + tool_analyzers.map(&:columns).flatten
 
       analyzer_tables = MetricFu::AnalyzerTables.new(analyzer_columns)
       tool_analyzers.each do |analyzer|
@@ -28,31 +27,28 @@ describe MetricFu::AnalyzerTables do
   end
 
   context "with Stats data" do
-
     before do
       @result_hash = HOTSPOT_DATA["stats.yml"]
       @table = analyzer_table(@result_hash).table
     end
 
     it "should have codeLOC" do
-      row = @table.find{|row| row['stat_name'] == :codeLOC}
-      expect(row['stat_value']).to eq(4222)
+      row = @table.find { |row| row["stat_name"] == :codeLOC }
+      expect(row["stat_value"]).to eq(4222)
     end
 
     it "should have testLOC" do
-      row = @table.find{|row| row['stat_name'] == :testLOC}
-      expect(row['stat_value']).to eq(2111)
+      row = @table.find { |row| row["stat_name"] == :testLOC }
+      expect(row["stat_value"]).to eq(2111)
     end
 
     it "should have code_to_test_ratio" do
-      row = @table.find{|row| row['stat_name'] == :code_to_test_ratio}
-      expect(row['stat_value']).to eq(2)
+      row = @table.find { |row| row["stat_name"] == :code_to_test_ratio }
+      expect(row["stat_value"]).to eq(2)
     end
-
   end
 
   context "with three different path representations of file (from Saikuro, Flog, and Reek)" do
-
     before do
       @result_hash = HOTSPOT_DATA["three_metrics_on_same_file.yml"]
       @table = analyzer_table(@result_hash).table
@@ -60,17 +56,16 @@ describe MetricFu::AnalyzerTables do
 
     specify "all records should have full file_path" do
       @table.each do |row|
-        expect(row['file_path']).to eq('lib/client/client.rb')
+        expect(row["file_path"]).to eq("lib/client/client.rb")
       end
     end
 
     specify "all records should have class name" do
-      expect(@table.select{|rows| rows.fetch(:class_name, :no_key) == nil }.size).to eq(0)
+      expect(@table.select { |rows| rows.fetch(:class_name, :no_key) == nil }.size).to eq(0)
     end
 
     specify "one record should not have method name" do
-      expect(@table.select{|rows| rows.fetch(:method_name, :no_key) == nil }.size).to eq(0)
+      expect(@table.select { |rows| rows.fetch(:method_name, :no_key) == nil }.size).to eq(0)
     end
-
   end
 end

data/spec/metric_fu/metrics/hotspots/analysis/ranking_spec.rb

@@ -1,16 +1,14 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/analysis/ranking' }
+MetricFu.metrics_require { "hotspots/analysis/ranking" }
 
 describe MetricFu::Ranking do
-
   context "with many items" do
-
     specify "#top" do
       ranking = Ranking.new
       ranking[:a] = 10
       ranking[:b] = 50
       ranking[:c] = 1
-      expect(ranking.top).to eq([:b,:a, :c])
+      expect(ranking.top).to eq([:b, :a, :c])
     end
 
     specify "lowest item is at 0 percentile" do
@@ -28,7 +26,5 @@ describe MetricFu::Ranking do
       ranking[:d] = 5
       expect(ranking.percentile(:b)).to eq(0.75)
     end
-
   end
-
 end

data/spec/metric_fu/metrics/hotspots/analysis/rankings_spec.rb

@@ -1,8 +1,7 @@
-require 'spec_helper'
-MetricFu.metrics_require { 'hotspots/analysis/rankings' }
+require "spec_helper"
+MetricFu.metrics_require { "hotspots/analysis/rankings" }
 
 describe MetricFu::HotspotRankings do
-
   before do
     enable_hotspots
   end
@@ -14,7 +13,7 @@ describe MetricFu::HotspotRankings do
       common_columns = %w{metric}
       granularities =  %w{file_path class_name method_name}
       tool_analyzers = MetricFu::Hotspot.analyzers
-      analyzer_columns = common_columns + granularities + tool_analyzers.map{|analyzer| analyzer.columns}.flatten
+      analyzer_columns = common_columns + granularities + tool_analyzers.map(&:columns).flatten
 
       analyzer_tables = MetricFu::AnalyzerTables.new(analyzer_columns)
       tool_analyzers.each do |analyzer|
@@ -30,8 +29,8 @@ describe MetricFu::HotspotRankings do
   context "with several types of data" do
     it "gives all files, in order, from worst to best" do
       expected = [
-                  "lib/client/client.rb",
-                  "lib/client/foo.rb"]
+        "lib/client/client.rb",
+        "lib/client/foo.rb"]
       expect(rankings(result_hash).worst_files).to eq(expected)
     end
     def result_hash
@@ -39,7 +38,6 @@ describe MetricFu::HotspotRankings do
     end
   end
   context "with Reek data" do
-
     before do
       @result_hash = HOTSPOT_DATA["reek.yml"]
     end
@@ -55,10 +53,8 @@ describe MetricFu::HotspotRankings do
     it "gives worst file" do
       expect(rankings(@result_hash).worst_files[0]).to eq("lib/client/client.rb")
     end
-
   end
   context "with Saikuro data" do
-
     before do
       @result_hash = HOTSPOT_DATA["saikuro.yml"]
     end
@@ -70,10 +66,8 @@ describe MetricFu::HotspotRankings do
     it "gives worst class" do
       expect(rankings(@result_hash).worst_classes[0]).to eq("Bitly")
     end
-
   end
   context "with Flog data" do
-
     before do
       @result_hash = HOTSPOT_DATA["flog.yml"]
     end
@@ -89,11 +83,9 @@ describe MetricFu::HotspotRankings do
     it "gives worst file" do
       expect(rankings(@result_hash).worst_files[0]).to eq("lib/generators/rcov.rb:57")
     end
-
   end
 
   context "with Roodi data" do
-
     before do
       @result_hash = HOTSPOT_DATA["roodi.yml"]
     end
@@ -101,6 +93,5 @@ describe MetricFu::HotspotRankings do
     it "gives worst file" do
       expect(rankings(@result_hash).worst_files[0]).to eq("lib/client/client.rb")
     end
-
   end
 end

data/spec/metric_fu/metrics/hotspots/analysis/table_spec.rb

@@ -1,8 +1,6 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/analysis/table' }
+MetricFu.metrics_require { "hotspots/analysis/table" }
 
 describe MetricFu::Table do
-
   it "needs tests"
-
 end

data/spec/metric_fu/metrics/hotspots/generator_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/generator' }
+MetricFu.metrics_require { "hotspots/generator" }
 
 describe MetricFu::HotspotsGenerator do
   describe "analyze method" do
-
     it "should be empty on error" do
       hotspots = MetricFu::HotspotsGenerator.new
       hotspots.instance_variable_set(:@analyzer, nil)
       result = hotspots.analyze
-      expect(result).to eq({:files => [], :classes => [], :methods => []})
+      expect(result).to eq(files: [], classes: [], methods: [])
     end
 
     it "should put the changes into a hash" do
@@ -20,13 +19,13 @@ describe MetricFu::HotspotsGenerator do
       expect(result.keys).to eq(expected.keys)
 
       # for each granularity's location details
-      result.each do |granularity,location_details|
+      result.each do |granularity, location_details|
         # map 2d array for this granularity of [details, location]
-        expected_result = expected.fetch(granularity).map {|ld| [ld.fetch('details'), ld.fetch('location')] }
+        expected_result = expected.fetch(granularity).map { |ld| [ld.fetch("details"), ld.fetch("location")] }
         # verify all the location details for this granularity match elements of expected_result
         location_details.each do |location_detail|
-          location = location_detail.fetch('location')
-          details  = location_detail.fetch('details')
+          location = location_detail.fetch("location")
+          details  = location_detail.fetch("details")
           # get the location_detail array where the  where the locations (second element) match
           expected_location_details = expected_result.rassoc(location)
           # get the details (first element) from the expected location_details array
@@ -44,5 +43,4 @@ describe MetricFu::HotspotsGenerator do
       expect(hotspots.analyze.keys).to eq([:files, :classes, :methods])
     end
   end
-
 end

data/spec/metric_fu/metrics/hotspots/hotspot_analyzer_spec.rb

@@ -1,12 +1,10 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/hotspot_analyzer' }
+MetricFu.metrics_require { "hotspots/hotspot_analyzer" }
 
 describe MetricFu::HotspotAnalyzer do
-
   it "should have its own tests regarding how it orchestrates the analysis of results, rankings, tables, and analyzed_problems"
 
   it "#hotspots aka worst_items"
 
   it "#analyzed_problems"
-
 end

data/spec/metric_fu/metrics/hotspots/hotspot_spec.rb

@@ -1,16 +1,15 @@
-require 'spec_helper'
-MetricFu.metrics_require { 'hotspots/hotspot' }
+require "spec_helper"
+MetricFu.metrics_require { "hotspots/hotspot" }
 
 describe MetricFu::Hotspot do
-
   before do
     enable_hotspots
   end
 
   it "returns an array of of the analyzers that subclass it" do
     expected_analyzers = [ReekHotspot, RoodiHotspot,
-      FlogHotspot, ChurnHotspot, SaikuroHotspot,
-      FlayHotspot, StatsHotspot, RcovHotspot]
+                          FlogHotspot, ChurnHotspot, SaikuroHotspot,
+                          FlayHotspot, StatsHotspot, RcovHotspot]
 
     expect(MetricFu::Hotspot.analyzers.size).to eq(expected_analyzers.size)
   end

data/spec/metric_fu/metrics/rails_best_practices/configuration_spec.rb

@@ -1,11 +1,9 @@
-require 'spec_helper'
-require 'shared/configured'
-
-describe MetricFu::Configuration, 'for rails_best_practices' do
-  it_behaves_like 'configured' do
+require "spec_helper"
+require "shared/configured"
 
+describe MetricFu::Configuration, "for rails_best_practices" do
+  it_behaves_like "configured" do
     describe "if #rails? is true " do
-
       before(:each) do
         @config = MetricFu.configuration
         allow(@config).to receive(:rails?).and_return(true)
@@ -23,12 +21,11 @@ describe MetricFu::Configuration, 'for rails_best_practices' do
       end
 
       it "should set @rails_best_practices to {}" do
-        load_metric 'rails_best_practices'
+        load_metric "rails_best_practices"
         expect(MetricFu::Metric.get_metric(:rails_best_practices).run_options).to eql({})
       end
     end
 
-
     describe "if #rails? is false " do
       before(:each) do
         get_new_config
@@ -39,9 +36,8 @@ describe MetricFu::Configuration, 'for rails_best_practices' do
       end
 
       it "should set the registered code_dirs to ['lib']" do
-        expect(directory('code_dirs')).to eq(['lib'])
+        expect(directory("code_dirs")).to eq(["lib"])
       end
     end
-
   end
 end

data/spec/metric_fu/metrics/rails_best_practices/generator_spec.rb

@@ -1,12 +1,11 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rails_best_practices/generator' }
+MetricFu.metrics_require { "rails_best_practices/generator" }
 
 describe RailsBestPracticesGenerator do
-
   break if metric_not_activated?(:rails_best_practices)
 
   describe "emit method" do
-    let(:analyzer) { ::RailsBestPractices::Analyzer.new('.', { 'silent' => true }) }
+    let(:analyzer) { ::RailsBestPractices::Analyzer.new(".",  "silent" => true) }
     context "RailsBestPractices provides the expected API" do
       it { expect(analyzer).to respond_to :analyze }
       it { expect(analyzer).to respond_to :errors }

data/spec/metric_fu/metrics/rails_best_practices/grapher_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rails_best_practices/grapher' }
+MetricFu.metrics_require { "rails_best_practices/grapher" }
 
 describe RailsBestPracticesGrapher do
   before :each do
@@ -50,11 +50,11 @@ describe RailsBestPracticesGrapher do
 
       it "should push 0 to rails_best_practices_count when no problems were found" do
         expect(@stats_grapher.rails_best_practices_count).to receive(:push).with(0)
-        @stats_grapher.get_metrics({ :rails_best_practices => {} }, @date)
+        @stats_grapher.get_metrics({ rails_best_practices: {} }, @date)
       end
 
       it "should update labels with the date" do
-        expect(@stats_grapher.labels).to receive(:update).with({ 0 => "01022003" })
+        expect(@stats_grapher.labels).to receive(:update).with(0 => "01022003")
         @stats_grapher.get_metrics(@metrics, @date)
       end
     end

data/spec/metric_fu/metrics/rcov/configuration_spec.rb

@@ -1,30 +1,28 @@
-require 'spec_helper'
-require 'shared/configured'
-
-describe MetricFu::Configuration, 'for rcov' do
-  it_behaves_like 'configured' do
+require "spec_helper"
+require "shared/configured"
 
+describe MetricFu::Configuration, "for rcov" do
+  it_behaves_like "configured" do
     it "should set rcov run_options" do
-      load_metric 'rcov'
+      load_metric "rcov"
       expect(
         MetricFu::Metric.get_metric(:rcov).run_options
       ).to eq(
-      {
-        :environment => 'test',
-        :external => nil,
-        :test_files =>  Dir['{spec,test}/**/*_{spec,test}.rb'],
-        :rcov_opts => [
-                "--sort coverage",
-                "--no-html",
-                "--text-coverage",
-                "--no-color",
-                "--profile",
-                "--exclude-only '.*'",
-                '--include-file "\Aapp,\Alib"',
-                "-Ispec"
-              ],
-      })
-    end
 
+        environment: "test",
+        external: nil,
+        test_files: Dir["{spec,test}/**/*_{spec,test}.rb"],
+        rcov_opts: [
+          "--sort coverage",
+          "--no-html",
+          "--text-coverage",
+          "--no-color",
+          "--profile",
+          "--exclude-only '.*'",
+          '--include-file "\Aapp,\Alib"',
+          "-Ispec"
+        ],
+      )
+    end
   end
 end

data/spec/metric_fu/metrics/rcov/generator_spec.rb

@@ -1,26 +1,22 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rcov/generator' }
-require 'shared/test_coverage'
+MetricFu.metrics_require { "rcov/generator" }
+require "shared/test_coverage"
 
 describe MetricFu::RcovGenerator, "configured as rcov" do
-
   it_behaves_like "rcov test coverage generator", :rcov do
-
     describe "emit" do
       before :each do
-        options = {:external =>  nil}
+        options = { external: nil }
         @test_coverage = MetricFu::RcovGenerator.new(@default_options.merge(options))
       end
 
       it "should set the RAILS_ENV" do
-        expect(MetricFu::Utility).to receive(:rm_rf).with(MetricFu::RcovGenerator.metric_directory, :verbose => false)
+        expect(MetricFu::Utility).to receive(:rm_rf).with(MetricFu::RcovGenerator.metric_directory, verbose: false)
         expect(MetricFu::Utility).to receive(:mkdir_p).with(MetricFu::RcovGenerator.metric_directory)
-        options = {:environment => 'metrics', :external => nil}
+        options = { environment: "metrics", external: nil }
         @test_coverage = MetricFu::RcovGenerator.new(@default_options.merge(options))
-        expect(@test_coverage.command).to include('RAILS_ENV=metrics')
+        expect(@test_coverage.command).to include("RAILS_ENV=metrics")
       end
     end
-
   end
-
 end

data/spec/metric_fu/metrics/rcov/grapher_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'rcov/grapher' }
+MetricFu.metrics_require { "rcov/grapher" }
 
 describe RcovGrapher do
   before :each do
@@ -49,7 +49,7 @@ describe RcovGrapher do
       end
 
       it "should update labels with the date" do
-        expect(@rcov_grapher.labels).to receive(:update).with({ 0 => "1/2" })
+        expect(@rcov_grapher.labels).to receive(:update).with(0 => "1/2")
         @rcov_grapher.get_metrics(@metrics, @date)
       end
     end