fortnox-api 0.5.2 → 0.6.0

data/spec/spec_helper.rb

@@ -1,15 +1,18 @@
+# frozen_string_literal: true
+
 ENV['RUBY_ENV'] = 'test'
 
+require 'simplecov'
+
+SimpleCov.start
+
 require 'rspec/collection_matchers'
 require 'webmock/rspec'
 require 'pry'
-require "codeclimate-test-reporter"
 require 'support/matchers'
 require 'support/helpers'
 require 'support/vcr_setup'
 
-CodeClimate::TestReporter.start
-
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
@@ -22,12 +25,12 @@ RSpec.configure do |config|
 
   config.order = 'random'
 
-  WebMock.disable_net_connect!( allow: 'codeclimate.com' )
+  WebMock.disable_net_connect!(allow: 'codeclimate.com')
 
   config.before do
     module Test
       def self.remove_constants
-        constants.each{ |const| remove_const(const) }
+        constants.each { |const| remove_const(const) }
         self
       end
     end
@@ -40,7 +43,7 @@ RSpec.configure do |config|
   # Reset configuration after each test run
   config.after do
     Fortnox::API::DEFAULT_CONFIGURATION.each do |key, value|
-      Fortnox::API.config.send("#{ key }=", value)
+      Fortnox::API.config.send("#{key}=", value)
     end
   end
 end

data/spec/support/helpers.rb

@@ -1 +1,3 @@
-Dir[File.expand_path('spec/support/helpers/*.rb')].each{ |file| require file }
+# frozen_string_literal: true
+
+Dir[File.expand_path('spec/support/helpers/*.rb')].each { |file| require file }

data/spec/support/helpers/configuration_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Helpers
   module Configuration
     def set_api_test_configuration

data/spec/support/helpers/dummy_class_helper.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'dry-types'
 
 module Helpers
   def using_test_classes
-    around( :all ) do |example|
+    around(:all) do |example|
       classes_before_examples = Object.constants
 
       save_dry_types_state
@@ -16,15 +18,13 @@ module Helpers
 
       clean_up_dry_types
 
-      classes_created_by_block.each do |klass|
-        Object.send(:remove_const, klass)
-      end
+      classes_created_by_block.each { |klass| Object.send(:remove_const, klass) }
     end
   end
 
-  alias_method :using_test_class, :using_test_classes
+  alias using_test_class using_test_classes
 
-private
+  private
 
   def save_dry_types_state
     @types = Dry::Types.container._container.keys
@@ -32,8 +32,7 @@ private
 
   def clean_up_dry_types
     container = Dry::Types.container._container
-    (container.keys - @types).each{ |key| container.delete(key) }
+    (container.keys - @types).each { |key| container.delete(key) }
     Dry::Types.instance_variable_set('@type_map', Concurrent::Map.new)
   end
-
 end

data/spec/support/helpers/repository_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Helpers
   module Repositories
     # Returns directory for VCR.

data/spec/support/helpers/when_performing_helper.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Helpers
-  def when_performing &block
+  def when_performing(&block)
     block.to_proc
   end
 end

data/spec/support/matchers.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'support/matchers/type'

data/spec/support/matchers/type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'support/matchers/type/attribute_matcher'
 require 'support/matchers/type/type_matcher'
 require 'support/matchers/type/have_nullable_matcher'
@@ -11,7 +13,7 @@ require 'support/matchers/type/have_sized_string_matcher'
 require 'support/matchers/type/have_default_delivery_type_matcher'
 require 'support/matchers/type/have_nullable_string_matcher'
 require 'support/matchers/type/have_sized_float_matcher'
-require 'support/matchers/type/have_house_work_type_matcher'
+require 'support/matchers/type/have_housework_type_matcher'
 require 'support/matchers/type/have_account_number_matcher'
 require 'support/matchers/type/have_discount_type_matcher'
 require 'support/matchers/type/have_sized_integer_matcher'

data/spec/support/matchers/type/attribute_matcher.rb

@@ -1,39 +1,40 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
     class AttributeMatcher
-      def initialize( attribute, valid_hash, attribute_type )
+      def initialize(attribute, valid_hash, attribute_type)
         @attribute = attribute
         @valid_hash = valid_hash.dup
         @attribute_type = attribute_type
         @errors = ''
       end
 
-      def matches? ( klass )
+      def matches?(klass)
         @klass = klass
       end
 
       def description
-        "have #{ @attribute_type } attribute #{ @attribute.inspect }"
+        "have #{@attribute_type} attribute #{@attribute.inspect}"
       end
 
       def failure_message
-        "Expected class to have attribute #{ @attribute.inspect } defined as #{ @attribute_type }, "\
+        "Expected class to have attribute #{@attribute.inspect} defined as #{@attribute_type}, "\
         "but got following errors:
-        #{ @errors }"
+        #{@errors}"
       end
 
       protected
 
-        def expect_error(msg)
-          yield
-
-          @errors << msg
-          false # Fail test since expected error not thrown
-        rescue Dry::Struct::Error
-          # TODO: check if error message is correct
-          true
-        end
+      def expect_error(msg)
+        yield
 
+        @errors << msg
+        false # Fail test since expected error not thrown
+      rescue Dry::Struct::Error
+        # TODO: check if error message is correct
+        true
+      end
     end
   end
 end

data/spec/support/matchers/type/enum_matcher.rb

@@ -1,21 +1,23 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
     class EnumMatcher < TypeMatcher
-      def initialize( attribute, valid_hash, enum_type, enum_types, nonsense_value: 'NONSENSE'.freeze )
+      def initialize(attribute, valid_hash, enum_type, enum_types, nonsense_value: 'NONSENSE')
         valid_value = Fortnox::API::Types.const_get(enum_types).values.first
 
-        super( attribute, valid_hash, enum_type, valid_value, nonsense_value )
+        super(attribute, valid_hash, enum_type, valid_value, nonsense_value)
 
         @enum_type = Fortnox::API::Types.const_get(enum_type)
-        @expected_error = "Exception missing for nonsense value #{ @invalid_value.inspect }"
+        @expected_error = "Exception missing for nonsense value #{@invalid_value.inspect}"
       end
 
       private
 
-        def expected_type?
-          @actual_type = @klass.schema[@attribute]
-          @actual_type == @enum_type
-        end
+      def expected_type?
+        @actual_type = @klass.schema[@attribute]
+        @actual_type == @enum_type
+      end
     end
   end
 end

data/spec/support/matchers/type/have_account_number_matcher.rb

@@ -1,21 +1,23 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_account_number( attribute, valid_hash = {} )
-      HaveAccountNumberMatcher.new( attribute, valid_hash )
+    def have_account_number(attribute, valid_hash = {})
+      HaveAccountNumberMatcher.new(attribute, valid_hash)
     end
 
     class HaveAccountNumberMatcher < TypeMatcher
-      def initialize( attribute, valid_hash )
-        super( attribute, valid_hash, 'account number', 1000, -1 )
-        @expected_error = "Exception missing for invalid value #{ @invalid_value.inspect }".freeze
+      def initialize(attribute, valid_hash)
+        super(attribute, valid_hash, 'account number', 1000, -1)
+        @expected_error = "Exception missing for invalid value #{@invalid_value.inspect}"
       end
 
       private
 
-        def expected_type?
-          @actual_type = @klass.schema[@attribute]
-          @actual_type == Fortnox::API::Types::AccountNumber
-        end
+      def expected_type?
+        @actual_type = @klass.schema[@attribute]
+        @actual_type == Fortnox::API::Types::AccountNumber
+      end
     end
   end
 end

data/spec/support/matchers/type/have_country_code_matcher.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_country_code( attribute, valid_hash = {} )
-      HaveCountryCodeMatcher.new( attribute, valid_hash )
+    def have_country_code(attribute, valid_hash = {})
+      HaveCountryCodeMatcher.new(attribute, valid_hash)
     end
 
     class HaveCountryCodeMatcher < EnumMatcher
-      def initialize( attribute, valid_hash )
-        super( attribute, valid_hash, 'CountryCode', 'CountryCodes', nonsense_value: 'XX'.freeze )
+      def initialize(attribute, valid_hash)
+        super(attribute, valid_hash, 'CountryCode', 'CountryCodes', nonsense_value: 'XX')
       end
     end
   end

data/spec/support/matchers/type/have_currency_matcher.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_currency( attribute, valid_hash = {} )
-      EnumMatcher.new( attribute, valid_hash, 'Currency', 'Currencies' )
+    def have_currency(attribute, valid_hash = {})
+      EnumMatcher.new(attribute, valid_hash, 'Currency', 'Currencies')
     end
   end
 end

data/spec/support/matchers/type/have_customer_type_matcher.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_customer_type( attribute, valid_hash = {} )
-      HaveCustomerTypeMatcher.new( attribute, valid_hash )
+    def have_customer_type(attribute, valid_hash = {})
+      HaveCustomerTypeMatcher.new(attribute, valid_hash)
     end
 
     class HaveCustomerTypeMatcher < EnumMatcher
-      def initialize( attribute, valid_hash )
-        super( attribute, valid_hash, 'CustomerType', 'CustomerTypes' )
+      def initialize(attribute, valid_hash)
+        super(attribute, valid_hash, 'CustomerType', 'CustomerTypes')
       end
     end
   end

data/spec/support/matchers/type/have_default_delivery_type_matcher.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_default_delivery_type( attribute, valid_hash = {} )
-      EnumMatcher.new( attribute, valid_hash, 'DefaultDeliveryType', 'DefaultDeliveryTypeValues' )
+    def have_default_delivery_type(attribute, valid_hash = {})
+      EnumMatcher.new(attribute, valid_hash, 'DefaultDeliveryType', 'DefaultDeliveryTypeValues')
     end
   end
 end

data/spec/support/matchers/type/have_discount_type_matcher.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_discount_type( attribute, valid_hash = {} )
-      EnumMatcher.new( attribute, valid_hash, 'DiscountType', 'DiscountTypes' )
+    def have_discount_type(attribute, valid_hash = {})
+      EnumMatcher.new(attribute, valid_hash, 'DiscountType', 'DiscountTypes')
     end
   end
 end

data/spec/support/matchers/type/have_email_matcher.rb

@@ -1,22 +1,24 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_email( attribute, valid_hash = {} )
-      HaveEmailMatcher.new( attribute, valid_hash )
+    def have_email(attribute, valid_hash = {})
+      HaveEmailMatcher.new(attribute, valid_hash)
     end
 
     class HaveEmailMatcher < TypeMatcher
-      def initialize( attribute, valid_hash )
-        super( attribute, valid_hash, 'email', 'valid@email.com', 'invalid@email_without_top_domain' )
-        @expected_error = "Exception missing for invalid value #{ @invalid_value.inspect }"
+      def initialize(attribute, valid_hash)
+        super(attribute, valid_hash, 'email', 'valid@email.com', 'invalid@email_without_top_domain')
+        @expected_error = "Exception missing for invalid value #{@invalid_value.inspect}"
         @expected_type = Fortnox::API::Types::Email
       end
 
       private
 
-        def expected_type?
-          @actual_type = @klass.schema[@attribute]
-          @actual_type == Fortnox::API::Types::Email
-        end
+      def expected_type?
+        @actual_type = @klass.schema[@attribute]
+        @actual_type == Fortnox::API::Types::Email
+      end
     end
   end
 end

data/spec/support/matchers/type/have_housework_type_matcher.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Matchers
+  module Type
+    def have_housework_type(attribute, valid_hash = {})
+      EnumMatcher.new(attribute, valid_hash, 'HouseworkType', 'HouseworkTypes')
+    end
+  end
+end

data/spec/support/matchers/type/have_nullable_date_matcher.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module Matchers
   module Type
-    def have_nullable_date( attribute, valid_value, invalid_value )
-      HaveNullableDateMatcher.new( attribute, valid_value, invalid_value )
+    def have_nullable_date(attribute, valid_value, invalid_value)
+      HaveNullableDateMatcher.new(attribute, valid_value, invalid_value)
     end
 
     class HaveNullableDateMatcher < HaveNullableMatcher
-      def initialize( attribute, valid_value, invalid_value )
+      def initialize(attribute, valid_value, invalid_value)
         @attribute = attribute
         @valid_value = valid_value
         @invalid_value = invalid_value
@@ -14,45 +16,43 @@ module Matchers
         @failure_description = ''
       end
 
-      def matches?( klass )
+      def matches?(klass)
         @klass = klass
 
         accepts_nil? && accepts_valid_value? && rejects_invalid_value?
       end
 
       def description
-        "have nullable attribute #{ @attribute.inspect }"
+        "have nullable attribute #{@attribute.inspect}"
       end
 
       def failure_message
-        "Expected class to have nullable attribute #{ @attribute.inspect }" << @failure_description
+        "Expected class to have nullable attribute #{@attribute.inspect}" << @failure_description
       end
 
       private
 
-        def accepts_nil?
-          @klass.new(@attribute => nil)
-        end
-
-        def accepts_valid_value?
-          model = @klass.new(@attribute => @valid_value)
-          model.send(@attribute) == @valid_value
-        end
-
-        def rejects_invalid_value?
-          @klass.new(@attribute => @invalid_value)
-
-          @failure_description << " (Expected #{ @expected_error }, but got none)"
-          return false
-        rescue @expected_error => error
-          if error.message == @expected_error_message
-            return true
-          else
-            fail_message = "Expected error message to include #{ expected_message.inspect }, "\
-                           "but was #{ error.message.inspect }"
-            fail(fail_message)
-          end
-        end
+      def accepts_nil?
+        @klass.new(@attribute => nil)
+      end
+
+      def accepts_valid_value?
+        model = @klass.new(@attribute => @valid_value)
+        model.send(@attribute) == @valid_value
+      end
+
+      def rejects_invalid_value?
+        @klass.new(@attribute => @invalid_value)
+
+        @failure_description << " (Expected #{@expected_error}, but got none)"
+        false
+      rescue @expected_error => error
+        return true if error.message == @expected_error_message
+
+        fail_message = "Expected error message to include #{expected_message.inspect}, "\
+                       "but was #{error.message.inspect}"
+        raise(fail_message)
+      end
     end
   end
 end