fortnox-api 0.5.2 → 0.6.0

data/spec/fortnox/api/mappers/edi_information_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/edi_information'
 require 'fortnox/api/mappers/examples/mapper'
 
 describe Fortnox::API::Mapper::EDIInformation do
-  key_map = { 
+  key_map = {
     edi_global_location_number: 'EDIGlobalLocationNumber',
     edi_global_location_number_delivery: 'EDIGlobalLocationNumberDelivery',
     edi_invoice_extra1: 'EDIInvoiceExtra1',
@@ -16,6 +18,6 @@ describe Fortnox::API::Mapper::EDIInformation do
   json_entity_collection = 'EDIInformation'
 
   it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/email_information_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/email_information'
 require 'fortnox/api/mappers/examples/mapper'
 
 describe Fortnox::API::Mapper::EmailInformation do
-  key_map = { 
+  key_map = {
     email_address_bcc: 'EmailAddressBCC',
     email_address_cc: 'EmailAddressCC'
   }
@@ -12,6 +14,6 @@ describe Fortnox::API::Mapper::EmailInformation do
   json_entity_collection = 'EmailInformation'
 
   it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/examples/mapper.rb

@@ -1,25 +1,33 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/LineLength
 shared_examples_for 'mapper' do |key_map, json_entity_wrapper = nil, json_collection_wrapper = nil, check_constants: true|
-  it{ is_expected.to respond_to(:wrapped_json_collection_to_entities_hash) }
-  it{ is_expected.to respond_to(:wrapped_json_hash_to_entity_hash) }
-  it{ is_expected.to respond_to(:entity_to_hash) }
+  # rubocop:enable Metrics/LineLength
+
+  it { is_expected.to respond_to(:wrapped_json_collection_to_entities_hash) }
+  it { is_expected.to respond_to(:wrapped_json_hash_to_entity_hash) }
+  it { is_expected.to respond_to(:entity_to_hash) }
 
   if check_constants
     describe 'key_map' do
-      subject{ described_class::KEY_MAP }
-      it{ is_expected.to eq(key_map) }
+      subject { described_class::KEY_MAP }
+
+      it { is_expected.to eq(key_map) }
     end
 
     unless json_entity_wrapper.nil?
       describe 'json_entity_wrapper' do
-        subject{ described_class::JSON_ENTITY_WRAPPER }
-        it{ is_expected.to eq(json_entity_wrapper) }
+        subject { described_class::JSON_ENTITY_WRAPPER }
+
+        it { is_expected.to eq(json_entity_wrapper) }
       end
     end
 
     unless json_collection_wrapper.nil?
       describe 'json_collection_wrapper' do
-        subject{ described_class::JSON_COLLECTION_WRAPPER }
-        it{ is_expected.to eq(json_collection_wrapper) }
+        subject { described_class::JSON_COLLECTION_WRAPPER }
+
+        it { is_expected.to eq(json_collection_wrapper) }
       end
     end
   end

data/spec/fortnox/api/mappers/invoice_row_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/invoice_row'
@@ -5,15 +7,18 @@ require 'fortnox/api/mappers/examples/mapper'
 
 describe Fortnox::API::Mapper::InvoiceRow do
   key_map = {
-    vat: 'VAT',
+    housework: 'HouseWork',
+    housework_hours_to_report: 'HouseWorkHoursToReport',
+    housework_type: 'HouseWorkType',
     price_excluding_vat: 'PriceExcludingVAT',
-    total_excluding_vat: 'TotalExcludingVAT'
+    total_excluding_vat: 'TotalExcludingVAT',
+    vat: 'VAT'
   }
 
   json_entity_type = 'InvoiceRow'
   json_entity_collection = 'InvoiceRows'
 
   it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/invoice_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/invoice'
@@ -10,6 +12,7 @@ describe Fortnox::API::Mapper::Invoice do
       edi_information: 'EDIInformation',
       eu_quarterly_report: 'EUQuarterlyReport',
       freight_vat: 'FreightVAT',
+      housework: 'HouseWork',
       ocr: 'OCR',
       total_vat: 'TotalVAT',
       vat_included: 'VATIncluded'
@@ -19,6 +22,6 @@ describe Fortnox::API::Mapper::Invoice do
   json_entity_collection = 'Invoices'
 
   it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/order_row_spec.rb

@@ -1,14 +1,21 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/order_row'
 require 'fortnox/api/mappers/examples/mapper'
 
 describe Fortnox::API::Mapper::OrderRow do
-  key_map = { vat: 'VAT' }
+  key_map = {
+    housework: 'HouseWork',
+    housework_hours_to_report: 'HouseWorkHoursToReport',
+    housework_type: 'HouseWorkType',
+    vat: 'VAT'
+  }
   json_entity_type = 'OrderRow'
   json_entity_collection = 'OrderRows'
 
   it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/order_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/order'
@@ -8,6 +10,7 @@ describe Fortnox::API::Mapper::Order do
     {
       administration_fee_vat: 'AdministrationFeeVAT',
       freight_vat: 'FreightVAT',
+      housework: 'HouseWork',
       total_vat: 'TotalVAT',
       vat_included: 'VATIncluded'
     }
@@ -15,6 +18,6 @@ describe Fortnox::API::Mapper::Order do
   json_entity_collection = 'Orders'
 
   it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/project_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers/project'
@@ -5,6 +7,6 @@ require 'fortnox/api/mappers/examples/mapper'
 
 describe Fortnox::API::Mapper::Project do
   it_behaves_like 'mapper', {}, 'Project', 'Projects' do
-    let(:mapper){ described_class.new }
+    let(:mapper) { described_class.new }
   end
 end

data/spec/fortnox/api/mappers/terms_of_payments_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api'
+require 'fortnox/api/mappers/terms_of_payments'
+require 'fortnox/api/mappers/examples/mapper'
+
+describe Fortnox::API::Mapper::TermsOfPayments do
+  key_map = {}
+  json_entity_type = 'TermsOfPayment'
+  json_entity_collection = 'TermsOfPayments'
+
+  it_behaves_like 'mapper', key_map, json_entity_type, json_entity_collection do
+    let(:mapper) { described_class.new }
+  end
+end

data/spec/fortnox/api/mappers/unit_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api'
+require 'fortnox/api/mappers/unit'
+require 'fortnox/api/models/unit'
+require 'fortnox/api/mappers/examples/mapper'
+
+module Fortnox
+  module API
+    # Shhh Rubocop, we don't need a comment here ... Really
+    module Mapper
+      describe Unit do
+        context 'when mapping model' do
+          let(:model) { Model::Unit.new(code: 'lbs', description: 'Pounds') }
+          let(:serialised_model_hash) { { 'Unit' => { 'Code' => 'lbs', 'Description' => 'Pounds' } } }
+          let(:model_hash) { { code: 'lbs', description: 'Pounds' } }
+
+          describe '#entity_to_hash' do
+            subject { Unit.new.entity_to_hash(model, {}) }
+
+            it { is_expected.to eq(serialised_model_hash) }
+          end
+
+          describe '#wrapped_json_hash_to_entity_hash' do
+            subject { Unit.new.wrapped_json_hash_to_entity_hash(serialised_model_hash) }
+
+            it { is_expected.to eq(model_hash) }
+          end
+        end
+
+        context 'when mapping collection' do
+          let(:serialised_collection_hash) do
+            { 'Units' => [
+              { 'Unit' => { 'Code' => 'lbs', 'Description' => 'Pounds' } },
+              { 'Unit' => { 'Code' => 'ohm', 'Description' => 'Ω' } },
+              { 'Unit' => { 'Code' => 'A/V', 'Description' => 'Ampere volt' } }
+            ] }
+          end
+          let(:collection_hash) do
+            [
+              { unit: { code: 'lbs', description: 'Pounds' } },
+              { unit: { code: 'ohm', description: 'Ω' } },
+              { unit: { code: 'A/V', description: 'Ampere volt' } }
+            ]
+          end
+
+          describe '#wrapped_json_collection_to_entities_hash' do
+            subject { Unit.new.wrapped_json_collection_to_entities_hash(serialised_collection_hash) }
+
+            it { is_expected.to eq(collection_hash) }
+          end
+        end
+      end
+    end
+  end
+end

data/spec/fortnox/api/models/article_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/models/article'
 require 'fortnox/api/models/examples/model'

data/spec/fortnox/api/models/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/models/base'
 require 'fortnox/api/types'
@@ -5,7 +7,7 @@ require 'fortnox/api/types'
 describe Fortnox::API::Model::Base do
   using_test_classes do
     class Entity < Fortnox::API::Model::Base
-      attribute :private, Fortnox::API::Types::String.with( read_only: true )
+      attribute :private, Fortnox::API::Types::String.is(:read_only)
       attribute :string, Fortnox::API::Types::Required::String
       attribute :number, Fortnox::API::Types::Nullable::Integer
       attribute :account, Fortnox::API::Types::AccountNumber
@@ -14,85 +16,91 @@ describe Fortnox::API::Model::Base do
 
   describe '.new' do
     context 'with basic attribute' do
-      subject{ Entity.new( string: 'Test' ) }
+      subject { Entity.new(string: 'Test') }
 
-      it{ is_expected.to be_a Entity }
-      it{ is_expected.to be_new }
-      it{ is_expected.not_to be_saved }
+      it { is_expected.to be_a Entity }
+      it { is_expected.to be_new }
+      it { is_expected.not_to be_saved }
     end
 
     context 'without required attribute' do
-      subject{ ->{ Entity.new({}) } }
+      subject { -> { Entity.new({}) } }
 
-      it{ is_expected.to raise_error Fortnox::API::Exception }
-      it{ is_expected.to raise_error Fortnox::API::MissingAttributeError }
-      it{ is_expected.to raise_error Fortnox::API::MissingAttributeError, /Missing attribute :string/ }
+      it { is_expected.to raise_error Fortnox::API::Exception }
+      it { is_expected.to raise_error Fortnox::API::MissingAttributeError }
+      it { is_expected.to raise_error Fortnox::API::MissingAttributeError, /Missing attribute :string/ }
     end
 
     context 'with invalid attribute value' do
-      subject{ ->{ Entity.new({ string: 'Test', account: 13337 }) } }
+      subject { -> { Entity.new(string: 'Test', account: 13_337) } }
 
-      it{ is_expected.to raise_error Fortnox::API::Exception }
-      it{ is_expected.to raise_error Fortnox::API::AttributeError }
-      it{ is_expected.to raise_error Fortnox::API::AttributeError, /invalid type for :account/ }
+      it { is_expected.to raise_error Fortnox::API::Exception }
+      it { is_expected.to raise_error Fortnox::API::AttributeError }
+      it { is_expected.to raise_error Fortnox::API::AttributeError, /invalid type for :account/ }
     end
   end
 
   describe '.update' do
-    let(:original){ Entity.new( string: 'Test' ) }
+    let(:original) { Entity.new(string: 'Test') }
 
     context 'with new, simple value' do
-      subject{ updated_model }
+      subject { updated_model }
 
-      let(:updated_model){ original.update( string: 'Variant' ) }
+      let(:updated_model) { original.update(string: 'Variant') }
 
-      it{ is_expected.to be_new }
-      it{ is_expected.not_to be_saved }
+      it { is_expected.to be_new }
+      it { is_expected.not_to be_saved }
 
       it 'returns a new object' do
-        is_expected.not_to eql( original )
+        is_expected.not_to eql(original)
       end
 
       describe 'updated attribute' do
-        subject{ updated_model.string }
-        it{ is_expected.to eql( 'Variant' ) }
+        subject { updated_model.string }
+
+        it { is_expected.to eql('Variant') }
       end
 
       describe 'returned class' do
-        subject{ updated_model.class }
-        it{ is_expected.to eql( original.class ) }
+        subject { updated_model.class }
+
+        it { is_expected.to eql(original.class) }
       end
     end
 
     context 'with the same, simple value' do
-      subject( :updated_model ){ original.update( string: 'Test' ) }
+      subject(:updated_model) { original.update(string: 'Test') }
 
       it 'returns the same object' do
-        is_expected.to eql( original )
+        is_expected.to eql(original)
       end
 
       it 'returns a object with the same value' do
-        expect( updated_model.string ).to eql( 'Test' )
+        expect(updated_model.string).to eql('Test')
       end
 
-      it{ is_expected.to be_new }
-      it{ is_expected.not_to be_saved }
+      it { is_expected.to be_new }
+      it { is_expected.not_to be_saved }
     end
 
-    context 'a saved entity' do
-      subject( :updated_entry ){ saved_entry.update( string: 'Updated' ) }
+    context 'when updating' do
+      let(:updated_entity) do
+        saved_entity = Entity.new(string: 'Saved', new: false, unsaved: false)
+        saved_entity.update(string: 'Updated')
+      end
 
-      let( :saved_entry ){ Entity.new( string: 'Saved', new: false, unsaved: false) }
+      describe 'updated entity' do
+        subject { updated_entity }
 
-      before do
-        expect(saved_entry).not_to be_new
-        expect(saved_entry).to be_saved
+        it { is_expected.not_to be_saved }
+        it { is_expected.not_to be_new }
       end
 
-      specify{ expect(updated_entry.string).to eq( 'Updated' ) }
-      it{ is_expected.not_to be_new }
-      it{ is_expected.not_to be_saved }
+      describe 'updated attribute value' do
+        subject { updated_entity.string }
+
+        it { is_expected.to eq('Updated') }
+      end
     end
   end
-
 end

data/spec/fortnox/api/models/customer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/models/customer'
 require 'fortnox/api/models/examples/model'

data/spec/fortnox/api/models/examples/document_base.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'fortnox/api/models/examples/model'
 
 shared_examples_for 'DocumentBase Model' do |row_class, row_attribute, valid_row_hash: {}|
   it_behaves_like 'a model', 1
 
-  context "when having a(n) #{ row_class }" do
+  context "when having a(n) #{row_class}" do
     it 'returns the correct object' do
       row = row_class.new(valid_row_hash)
-      document_base = described_class.new( customer_number: '123', row_attribute => [row] )
-      expect(document_base.send(row_attribute)).to eq([row])
+      document = described_class.new(customer_number: '123', row_attribute => [row])
+      expect(document.send(row_attribute)).to eq([row])
     end
   end
 end