fortnox-api 0.5.2 → 0.6.0

data/spec/fortnox/api/repositories/invoice_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers'
@@ -13,9 +15,9 @@ require 'fortnox/api/repositories/examples/only'
 describe Fortnox::API::Repository::Invoice, order: :defined, integration: true do
   include Helpers::Configuration
 
-  before{ set_api_test_configuration }
+  before { set_api_test_configuration }
 
-  subject(:repository){ described_class.new }
+  subject(:repository) { described_class.new }
 
   required_hash = { customer_number: '1' }
 
@@ -26,7 +28,7 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
                    required_hash,
                    :invoice_rows,
                    nested_model_hash,
-                   [ Fortnox::API::Types::InvoiceRow.new( nested_model_hash ) ]
+                   [Fortnox::API::Types::InvoiceRow.new(nested_model_hash)]
 
   include_examples '.save with specially named attribute',
                    required_hash,
@@ -38,12 +40,12 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
   include_examples '.all', 60
 
   include_examples '.find', 1 do
-    let( :find_by_hash_failure ){ { yourreference: 'Not found' } }
+    let(:find_by_hash_failure) { { yourreference: 'Not found' } }
 
-    let( :single_param_find_by_hash ) do
+    let(:single_param_find_by_hash) do
       { find_hash: { yourreference: 'Gandalf the Grey' }, matches: 2 }
     end
-    let( :multi_param_find_by_hash ) do
+    let(:multi_param_find_by_hash) do
       { find_hash: { yourreference: 'Gandalf the Grey', ourreference: 'Radagast the Brown' },
         matches: 1 }
     end

data/spec/fortnox/api/repositories/order_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers'
@@ -12,9 +14,9 @@ require 'fortnox/api/repositories/examples/search'
 describe Fortnox::API::Repository::Order, order: :defined, integration: true do
   include Helpers::Configuration
 
-  before{ set_api_test_configuration }
+  before { set_api_test_configuration }
 
-  subject(:repository){ described_class.new }
+  subject(:repository) { described_class.new }
 
   required_hash = { customer_number: '1' }
 
@@ -25,19 +27,19 @@ describe Fortnox::API::Repository::Order, order: :defined, integration: true do
                    required_hash,
                    :order_rows,
                    nested_model_hash,
-                   [ Fortnox::API::Types::OrderRow.new( nested_model_hash ) ]
+                   [Fortnox::API::Types::OrderRow.new(nested_model_hash)]
 
   # It is not possible to delete Orders. Therefore, expected nr of Orders
   # when running .all will continue to increase (until 100, which is max by default).
   include_examples '.all', 100
 
   include_examples '.find', 1 do
-    let( :find_by_hash_failure ){ { ourreference: 'Not found' } }
+    let(:find_by_hash_failure) { { ourreference: 'Not found' } }
 
-    let( :single_param_find_by_hash ) do
+    let(:single_param_find_by_hash) do
       { find_hash: { ourreference: 'Belladonna Took' }, matches: 2 }
     end
-    let( :multi_param_find_by_hash ) do
+    let(:multi_param_find_by_hash) do
       { find_hash: { ourreference: 'Belladonna Took', yourreference: 'Bodo Proudfoot' },
         matches: 1 }
     end

data/spec/fortnox/api/repositories/project_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers'
@@ -9,9 +11,9 @@ require 'fortnox/api/repositories/examples/save'
 describe Fortnox::API::Repository::Project, order: :defined, integration: true do
   include Helpers::Configuration
 
-  before{ set_api_test_configuration }
+  before { set_api_test_configuration }
 
-  subject( :repository ){ described_class.new }
+  subject(:repository) { described_class.new }
 
   include_examples '.save',
                    :comments,
@@ -23,10 +25,10 @@ describe Fortnox::API::Repository::Project, order: :defined, integration: true d
   include_examples '.all', 8
 
   include_examples '.find', '1' do
-    let( :find_by_hash_failure ){ { offset: 10000 } }
-    let( :single_param_find_by_hash ){ { find_hash: { limit: 1 }, matches: 1 } }
+    let(:find_by_hash_failure) { { offset: 10_000 } }
+    let(:single_param_find_by_hash) { { find_hash: { limit: 1 }, matches: 1 } }
 
-    let( :multi_param_find_by_hash ) do
+    let(:multi_param_find_by_hash) do
       { find_hash: { limit: 2, offset: 2 }, matches: 2 }
     end
   end

data/spec/fortnox/api/repositories/terms_of_payments_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api'
+require 'fortnox/api/mappers'
+require 'fortnox/api/repositories/terms_of_payments'
+require 'fortnox/api/repositories/examples/all'
+require 'fortnox/api/repositories/examples/find'
+require 'fortnox/api/repositories/examples/save'
+require 'fortnox/api/repositories/examples/save_with_specially_named_attribute'
+require 'fortnox/api/repositories/examples/search'
+
+describe Fortnox::API::Repository::TermsOfPayments, order: :defined, integration: true do
+  include Helpers::Configuration
+
+  subject(:repository) { described_class.new }
+
+  before { set_api_test_configuration }
+
+  required_hash = { code: '15DAYS' }
+
+  include_examples '.save', :description, additional_attrs: required_hash
+
+  include_examples '.all', 9
+
+  include_examples '.find', '15DAYS', find_by_hash: false do
+    let(:find_by_hash_failure) { { code: '15days' } }
+    let(:single_param_find_by_hash) { { find_hash: { code: '30days' }, matches: 1 } }
+  end
+end

data/spec/fortnox/api/repositories/unit_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api'
+require 'fortnox/api/mappers'
+require 'fortnox/api/repositories/unit'
+require 'fortnox/api/repositories/examples/all'
+require 'fortnox/api/repositories/examples/find'
+require 'fortnox/api/repositories/examples/save'
+require 'fortnox/api/repositories/examples/save_with_specially_named_attribute'
+
+describe Fortnox::API::Repository::Unit, order: :defined, integration: true do
+  include Helpers::Configuration
+
+  before { set_api_test_configuration }
+
+  subject(:repository) { described_class.new }
+
+  include_examples '.save',
+                   :description,
+                   additional_attrs: { code: 'blarg' }
+
+  include_examples '.save with specially named attribute',
+                   { description: 'Happy clouds' },
+                   :code,
+                   'woooh'
+
+  include_examples '.all', 6
+
+  include_examples '.find', 'blarg', find_by_hash: false do
+    let(:find_by_hash_failure) { { code: 'notfound' } }
+    let(:single_param_find_by_hash) { { find_hash: { code: 'blarg' }, matches: 1 } }
+  end
+end

data/spec/fortnox/api/types/account_number_spec.rb

@@ -1,28 +1,31 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types'
 require 'fortnox/api/types/examples/types'
 
 describe Fortnox::API::Types do
-  let( :klass ){ Fortnox::API::Types::AccountNumber }
+  let(:klass) { Fortnox::API::Types::AccountNumber }
+
+  context 'when AccountNumber created with nil' do
+    subject { klass[nil] }
 
-  context 'AccountNumber created with nil' do
-    subject{ klass[ nil ] }
-    it{ is_expected.to be_nil }
+    it { is_expected.to be_nil }
   end
 
-  context 'AccountNumber created with empty string' do
+  context 'when AccountNumber created with empty string' do
     include_examples 'raises ConstraintError', ''
   end
 
-  context 'AccountNumber created with valid number' do
+  context 'when AccountNumber created with valid number' do
     include_examples 'equals input', 1234
   end
 
-  context 'AccountNumber created with a too large number' do
-    include_examples 'raises ConstraintError', 10000
+  context 'when AccountNumber created with a too large number' do
+    include_examples 'raises ConstraintError', 10_000
   end
 
-  context 'AccountNumber created with a negative number' do
+  context 'when AccountNumber created with a negative number' do
     include_examples 'raises ConstraintError', -1
   end
 end

data/spec/fortnox/api/types/default_delivery_types_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types/default_delivery_types'
 
 RSpec.describe Fortnox::API::Types::DefaultDeliveryTypes, type: :type do
-  subject{ described_class }
+  subject { described_class }
 
-  it{ is_expected.to have_default_delivery_type( :invoice ) }
-  it{ is_expected.to have_default_delivery_type( :order ) }
-  it{ is_expected.to have_default_delivery_type( :offer ) }
+  it { is_expected.to have_default_delivery_type(:invoice) }
+  it { is_expected.to have_default_delivery_type(:order) }
+  it { is_expected.to have_default_delivery_type(:offer) }
 end

data/spec/fortnox/api/types/edi_information_spec.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types/edi_information'
 
 RSpec.describe Fortnox::API::Types::EDIInformation, type: :type do
-  subject{ described_class }
+  subject { described_class }
 
-  it{ is_expected.to have_nullable_string( :edi_global_location_number ) }
-  it{ is_expected.to have_nullable_string( :edi_global_location_number_delivery ) }
-  it{ is_expected.to have_nullable_string( :edi_invoice_extra1 ) }
-  it{ is_expected.to have_nullable_string( :edi_invoice_extra2 ) }
-  it{ is_expected.to have_nullable_string( :edi_our_electronic_reference ) }
-  it{ is_expected.to have_nullable_string( :edi_your_electronic_reference ) }
+  it { is_expected.to have_nullable_string(:edi_global_location_number) }
+  it { is_expected.to have_nullable_string(:edi_global_location_number_delivery) }
+  it { is_expected.to have_nullable_string(:edi_invoice_extra1) }
+  it { is_expected.to have_nullable_string(:edi_invoice_extra2) }
+  it { is_expected.to have_nullable_string(:edi_our_electronic_reference) }
+  it { is_expected.to have_nullable_string(:edi_your_electronic_reference) }
 end

data/spec/fortnox/api/types/email_information_spec.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types/email_information'
 
 RSpec.describe Fortnox::API::Types::EmailInformation, type: :type do
-  subject{ described_class }
+  subject { described_class }
 
-  it{ is_expected.to have_email( :email_address_to ) }
-  it{ is_expected.to have_email( :email_address_cc ) }
-  it{ is_expected.to have_email( :email_address_bcc ) }
+  it { is_expected.to have_email(:email_address_to) }
+  it { is_expected.to have_email(:email_address_cc) }
+  it { is_expected.to have_email(:email_address_bcc) }
 
-  it{ is_expected.to have_sized_string( :email_subject, 100 ) }
-  it{ is_expected.to have_sized_string( :email_body, 20000 ) }
+  it { is_expected.to have_sized_string(:email_subject, 100) }
+  it { is_expected.to have_sized_string(:email_body, 20_000) }
 end

data/spec/fortnox/api/types/email_spec.rb

@@ -1,28 +1,41 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types'
 require 'fortnox/api/types/examples/types'
 
-describe Fortnox::API::Types do
-  let( :klass ){ Fortnox::API::Types::Email }
+describe Fortnox::API::Types::Email do
+  let(:klass) { described_class }
+
+  context 'when created with nil' do
+    subject { described_class[nil] }
 
-  context 'Email created with nil' do
-    subject{ klass[ nil ] }
-    it{ is_expected.to be_nil }
+    it { is_expected.to be_nil }
   end
 
-  context 'Email created with empty string' do
-    subject{ klass[ '' ] }
-    it{ is_expected.to eq('') }
+  context 'when created with empty string' do
+    subject { described_class[''] }
+
+    it { is_expected.to eq('') }
+  end
+
+  context 'when created with valid email' do
+    emails = ['valid@example.com', 'kanal_75_ab-faktura@mail.unit4agresso.readsoftonline.com']
+
+    emails.each do |email|
+      subject { described_class[input] }
+
+      let(:input) { email }
+      it { is_expected.to eq input }
+    end
   end
 
-  context 'Email created with valid email' do
-    subject{ klass[ input ] }
-    let( :input ){ 'test@example.com' }
-    it{ is_expected.to eq input }
+  context 'when created with invalid email' do
+    include_examples 'raises ConstraintError', 'te$£@st@example.com'
   end
 
-  context 'Email created with more than 1024 characters' do
-    legal_characters = 'abcdefghijklmnopqrstuvwxyz-_+'.split('')
+  context 'when created with more than 1024 characters' do
+    legal_characters = 'abcdefghijklmnopqrstuvwxyz0123456789.-_+'.split('')
     too_long_email = (legal_characters * 35).shuffle.join + '@example.com'
     include_examples 'raises ConstraintError', too_long_email
   end

data/spec/fortnox/api/types/enums_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types'
 require 'fortnox/api/types/examples/enum'
@@ -8,7 +10,7 @@ describe Fortnox::API::Types do
   it_behaves_like 'enum', 'Currency', 'Currencies', auto_crop: true
   it_behaves_like 'enum', 'CustomerType', 'CustomerTypes'
   it_behaves_like 'enum', 'DiscountType', 'DiscountTypes'
-  it_behaves_like 'enum', 'HouseWorkType', 'HouseWorkTypes'
+  it_behaves_like 'enum', 'HouseworkType', 'HouseworkTypes'
   it_behaves_like 'enum', 'VATType', 'VATTypes'
   it_behaves_like 'enum', 'DefaultDeliveryType', 'DefaultDeliveryTypeValues'
   it_behaves_like 'enum', 'ProjectStatusType', 'ProjectStatusTypes'

data/spec/fortnox/api/types/examples/document_row.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
 shared_examples_for 'DocumentRow' do |valid_hash|
-  it{ is_expected.to have_account_number( :account_number, valid_hash ) }
+  it { is_expected.to have_account_number(:account_number, valid_hash) }
 
-  it{ is_expected.to have_sized_string( :article_number, 50, valid_hash ) }
-  it{ is_expected.to have_sized_string( :description, 50, valid_hash ) }
+  it { is_expected.to have_sized_string(:article_number, 50, valid_hash) }
+  it { is_expected.to have_sized_string(:description, 50, valid_hash) }
 
-  it{ is_expected.to have_sized_float( :delivered_quantity, 0.0, 9_999_999_999_999.9, valid_hash ) }
-  it{ is_expected.to have_sized_float( :price, 0.0, 99_999_999_999.9, valid_hash ) }
+  it { is_expected.to have_sized_float(:delivered_quantity, 0.0, 9_999_999_999_999.9, valid_hash) }
+  it { is_expected.to have_sized_float(:price, 0.0, 99_999_999_999.9, valid_hash) }
 
-  it{ is_expected.to have_discount_type( :discount_type, valid_hash ) }
+  it { is_expected.to have_discount_type(:discount_type, valid_hash) }
 
-  it{ is_expected.to have_sized_integer( :house_work_hours_to_report, 0, 99_999, valid_hash ) }
+  it { is_expected.to have_sized_integer(:housework_hours_to_report, 0, 99_999, valid_hash) }
 
-  it{ is_expected.to have_house_work_type( :house_work_type, valid_hash ) }
+  it { is_expected.to have_housework_type(:housework_type, valid_hash) }
 end

data/spec/fortnox/api/types/examples/enum.rb

@@ -1,47 +1,54 @@
+# frozen_string_literal: true
+
 require 'fortnox/api/types/examples/types'
 
 shared_examples_for 'enum' do |name, values, auto_crop: false|
   describe name do
-    let( :klass ){ Fortnox::API::Types.const_get(name) }
+    let(:klass) { Fortnox::API::Types.const_get(name) }
+
+    context 'when created with nil' do
+      subject { klass[nil] }
 
-    context 'created with nil' do
-      subject{ klass[ nil ] }
-      it{ is_expected.to be_nil }
+      it { is_expected.to be_nil }
     end
 
-    context 'created with' do
-      subject{ klass[ input ] }
+    context 'when created' do
+      subject { klass[input] }
+
+      let(:enum_value) { Fortnox::API::Types.const_get(values).values.sample }
 
-      let( :enum_value ){ Fortnox::API::Types.const_get(values).values.sample }
+      context 'with a random member from then enum' do
+        let(:input) { enum_value }
 
-      context 'a random member from then enum' do
-        let(:input){ enum_value }
-        it{ is_expected.to eq enum_value }
+        it { is_expected.to eq enum_value }
       end
 
-      context 'a symoblised, random member from the enum' do
-        let( :input ){ enum_value.to_sym }
-        it{ is_expected.to eq enum_value }
+      context 'with a symoblised, random member from the enum' do
+        let(:input) { enum_value.to_sym }
+
+        it { is_expected.to eq enum_value }
       end
 
-      context 'a lower case, random member from the enum' do
-        let( :input ){ enum_value.downcase }
-        it{ is_expected.to eq enum_value }
+      context 'with a lower case, random member from the enum' do
+        let(:input) { enum_value.downcase }
+
+        it { is_expected.to eq enum_value }
       end
 
-      context 'a string that starts like a random member from the enum' do
-        let( :input ){ enum_value.downcase + 'more string' }
+      context 'with a string that starts like a random member from the enum' do
+        let(:input) { enum_value.downcase + 'more string' }
 
         if auto_crop
-          it{ is_expected.to eq enum_value }
+          it { is_expected.to eq enum_value }
         else
-          subject{ ->{ klass[ input ] } }
-          it{ is_expected.to raise_error(Dry::Types::ConstraintError) }
+          subject { -> { klass[input] } }
+
+          it { is_expected.to raise_error(Dry::Types::ConstraintError) }
         end
       end
     end
 
-    context 'created with invalid input' do
+    context 'when created with invalid input' do
       include_examples 'raises ConstraintError', 'r4nd0m'
     end
   end