fortnox-api 0.5.2 → 0.6.0

data/spec/fortnox/api/models/examples/model.rb

@@ -1,19 +1,22 @@
+# frozen_string_literal: true
+
 shared_examples_for 'a model' do |unique_id|
-  let( :required_attributes ){ described_class::STUB.dup }
-  let( :unique_id_attribute ){ described_class::UNIQUE_ID }
+  let(:required_attributes) { described_class::STUB.dup }
+  let(:unique_id_attribute) { described_class::UNIQUE_ID }
 
   it 'can be initialized' do
-    expect{ described_class.new( required_attributes ) }.not_to raise_error
+    expect { described_class.new(required_attributes) }.not_to raise_error
   end
 
   describe '.unique_id' do
-    subject{ model.unique_id }
-
-    before{ expect(model.send(unique_id_attribute)).to eq unique_id }
+    subject { model.unique_id }
 
-    let( :attributes ){ required_attributes.merge(unique_id_attribute => unique_id) }
-    let( :model ){ described_class.new( attributes ) }
+    let(:model) do
+      described_class.new(
+        required_attributes.merge(unique_id_attribute => unique_id)
+      )
+    end
 
-    it{ is_expected.to eq unique_id }
+    it { is_expected.to eq unique_id }
   end
 end

data/spec/fortnox/api/models/invoice_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/models/invoice'
 require 'fortnox/api/models/examples/document_base'

data/spec/fortnox/api/models/order_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/models/order'
 require 'fortnox/api/models/examples/document_base'

data/spec/fortnox/api/models/project_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/models/project'
 require 'fortnox/api/models/examples/model'

data/spec/fortnox/api/models/terms_of_payments_spec.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api/models/terms_of_payments'
+require 'fortnox/api/models/examples/model'
+
+describe Fortnox::API::Model::TermsOfPayments, type: :model do
+  it_behaves_like 'a model', '1'
+end

data/spec/fortnox/api/models/unit_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api/models/unit'
+
+module Fortnox
+  module API
+    # Shhh Rubocop, we don't need a comment here ... Really
+    module Model
+      describe Unit, type: :model do
+        context 'when created from empty hash' do
+          subject { -> { described_class.new } }
+
+          it { is_expected.to raise_error(Fortnox::API::MissingAttributeError, /Missing attribute.*:code/) }
+        end
+
+        context 'when created from stub' do
+          subject { described_class.stub }
+
+          it { is_expected.to have_attributes(code: '', description: nil) }
+        end
+
+        context 'when created with all attributes' do
+          subject { described_class.new(code: 'lbs', description: 'Pounds') }
+
+          it { is_expected.to have_attributes(code: 'lbs', description: 'Pounds') }
+        end
+      end
+    end
+  end
+end

data/spec/fortnox/api/repositories/article_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 require 'fortnox/api/mappers'
@@ -11,9 +13,9 @@ require 'fortnox/api/repositories/examples/search'
 describe Fortnox::API::Repository::Article, order: :defined, integration: true do
   include Helpers::Configuration
 
-  before{ set_api_test_configuration }
+  before { set_api_test_configuration }
 
-  subject(:repository){ described_class.new }
+  subject(:repository) { described_class.new }
 
   include_examples '.save',
                    :description,
@@ -27,10 +29,10 @@ describe Fortnox::API::Repository::Article, order: :defined, integration: true d
   include_examples '.all', 12
 
   include_examples '.find', '1' do
-    let( :find_by_hash_failure ){ { description: 'Not Found' } }
-    let( :single_param_find_by_hash ){ { find_hash: { articlenumber: 1 }, matches: 3 } }
+    let(:find_by_hash_failure) { { description: 'Not Found' } }
+    let(:single_param_find_by_hash) { { find_hash: { articlenumber: 1 }, matches: 3 } }
 
-    let( :multi_param_find_by_hash ) do
+    let(:multi_param_find_by_hash) do
       { find_hash: { articlenumber: 1, description: 'Cykelpump' }, matches: 1 }
     end
   end

data/spec/fortnox/api/repositories/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 
@@ -15,79 +17,85 @@ describe Fortnox::API::Repository::Base do
 
     require 'dry/container/stub'
     Fortnox::API::Registry.enable_stubs!
-    Fortnox::API::Registry.stub( :test, Model::Test )
+    Fortnox::API::Registry.stub(:test, Model::Test)
   end
 
-  let(:access_token){ '3f08d038-f380-4893-94a0-a08f6e60e67a' }
-  let(:access_token2){ '89feajou-sif8-8f8u-29ja-xdfniokeniod' }
-  let(:client_secret){ 'P5K5vE3Kun' }
-  let(:repository){ Repository::Test.new }
-  let(:application_json){}
+  let(:access_token) { '3f08d038-f380-4893-94a0-a08f6e60e67a' }
+  let(:access_token2) { '89feajou-sif8-8f8u-29ja-xdfniokeniod' }
+  let(:client_secret) { 'P5K5vE3Kun' }
+  let(:repository) { Repository::Test.new }
+  let(:application_json) {}
   let(:headers) do
     {
       'Access-Token' => access_token,
       'Client-Secret' => client_secret,
       'Content-Type' => 'application/json',
-      'Accept' => 'application/json',
+      'Accept' => 'application/json'
     }
   end
 
   describe 'creation' do
     shared_examples_for 'missing configuration' do
-      subject{ ->{ repository } }
+      subject { -> { repository } }
 
-      let(:error){ Fortnox::API::MissingConfiguration }
+      let(:error) { Fortnox::API::MissingConfiguration }
 
-      it{ is_expected.to raise_error( error, /#{message}/ ) }
+      it { is_expected.to raise_error(error, /#{message}/) }
     end
 
     context 'without base url' do
       include_examples 'missing configuration' do
-        before{ Fortnox::API.configure{ |conf| conf.base_url = nil } }
-        let(:message){ 'have to provide a base url' }
+        before { Fortnox::API.configure { |conf| conf.base_url = nil } }
+        let(:message) { 'have to provide a base url' }
       end
     end
 
     context 'without client secret' do
       include_examples 'missing configuration' do
-        before{ Fortnox::API.configure{ |conf| conf.client_secret = nil } }
-        let(:message){ 'have to provide your client secret' }
+        before { Fortnox::API.configure { |conf| conf.client_secret = nil } }
+        let(:message) { 'have to provide your client secret' }
       end
     end
   end
 
   describe '#next_access_token' do
-    before{ Fortnox::API.configure{ |conf| conf.client_secret = client_secret } }
+    before { Fortnox::API.configure { |conf| conf.client_secret = client_secret } }
 
     context 'with default token store' do
       context 'with one access token' do
-        subject{ repository.next_access_token }
+        subject { repository.next_access_token }
+
+        before { Fortnox::API.configure { |conf| conf.access_token = access_token } }
 
-        before{ Fortnox::API.configure{ |conf| conf.access_token = access_token } }
-        it{ is_expected.to eql( access_token ) }
+        it { is_expected.to eql(access_token) }
+      end
 
-        describe 'next request' do
-          before{ repository.next_access_token }
+      context 'with one access token and two subsequent requests' do
+        subject { repository.next_access_token }
+
+        before do
+          Fortnox::API.configure { |conf| conf.access_token = access_token }
+          repository.next_access_token
+        end
 
-          it 'still uses the same token' do
-            is_expected.to eql( access_token )
-          end
+        it 'still uses the same token' do
+          is_expected.to eql(access_token)
         end
       end
 
       context 'with multiple access tokens' do
-        subject{ access_tokens }
+        subject { access_tokens }
 
-        before{ Fortnox::API.configure{ |conf| conf.access_tokens = access_tokens } }
-        let( :access_tokens ){ [access_token, access_token2] }
+        before { Fortnox::API.configure { |conf| conf.access_tokens = access_tokens } }
+        let(:access_tokens) { [access_token, access_token2] }
 
-        it{ is_expected.to include( repository.next_access_token ) }
+        it { is_expected.to include(repository.next_access_token) }
 
         it 'changes token on next request' do
           token1 = repository.next_access_token
           token2 = repository.next_access_token
 
-          expect( token1 ).not_to eql( token2 )
+          expect(token1).not_to eql(token2)
         end
 
         it 'circulates tokens' do
@@ -95,78 +103,83 @@ describe Fortnox::API::Repository::Base do
           repository.next_access_token
           token3 = repository.next_access_token
 
-          expect( token1 ).to eql( token3 )
+          expect(token1).to eql(token3)
         end
       end
     end
 
     context 'with multiple stores' do
-      subject{ repository.next_access_token }
+      subject { repository.next_access_token }
 
-      before do 
+      before do
         Fortnox::API.configure do |config|
           config.access_tokens = { store1: access_token, store2: access_token2 }
         end
       end
 
       describe 'first token store' do
-        let( :repository ){ Repository::Test.new( token_store: :store1) }
+        let(:repository) { Repository::Test.new(token_store: :store1) }
 
-        it{ is_expected.to eql access_token }
+        it { is_expected.to eql access_token }
       end
 
       describe 'second token store' do
-        let( :repository ){ Repository::Test.new( token_store: :store2 ) }
+        let(:repository) { Repository::Test.new(token_store: :store2) }
 
-        it{ is_expected.to eql access_token2 }
+        it { is_expected.to eql access_token2 }
       end
     end
   end
 
-  describe '#get_access_tokens' do
-    subject( :get_access_tokens ){ repository.get_access_tokens }
+  describe '#access_tokens' do
+    subject(:access_tokens) { repository.access_tokens }
 
-    before{ Fortnox::API.configure{ |conf| conf.client_secret = client_secret } }
+    before { Fortnox::API.configure { |conf| conf.client_secret = client_secret } }
 
-    let( :token_store_not_present ){ "no token store named #{ token_store.inspect }." }
-    let( :error ){ Fortnox::API::MissingConfiguration }
+    let(:token_store_not_present) do
+      "There is no token store named #{token_store.inspect}. Available stores are #{available_stores}."
+    end
+
+    let(:error) { Fortnox::API::MissingConfiguration }
 
     context 'with non existing token store' do
-      subject{ ->{ get_access_tokens } }
+      subject { -> { access_tokens } }
 
       before do
-        Fortnox::API.configure{ |conf| conf.access_tokens = { some_store: [access_token] } }
+        Fortnox::API.configure { |conf| conf.access_tokens = { some_store: [access_token] } }
       end
 
-      let( :repository ){ Repository::Test.new( token_store: token_store ) }
-      let( :token_store ){ :non_existing_store }
+      let(:repository) { Repository::Test.new(token_store: token_store) }
+      let(:token_store) { :non_existing_store }
+      let(:available_stores) { [:some_store] }
 
-      it{ is_expected.to raise_error( error, /#{token_store_not_present}/ ) }
+      it { is_expected.to raise_error(error, token_store_not_present) }
     end
 
     context 'with no tokens set' do
-      subject{ ->{ get_access_tokens } }
+      subject { -> { access_tokens } }
 
-      before{ Fortnox::API.configure{ |conf| conf.access_tokens = {} } }
-      let( :token_store ){ :default }
+      before { Fortnox::API.configure { |conf| conf.access_tokens = {} } }
+      let(:token_store) { :default }
+      let(:available_stores) { [] }
 
-      it{ is_expected.to raise_error( error, /#{token_store_not_present}/) }
+      it { is_expected.to raise_error(error, token_store_not_present) }
     end
 
     context 'with one access token in token store' do
-      before{ Fortnox::API.configure{ |conf| conf.access_token = access_token } }
-      let( :token_store ){ :default }
+      before { Fortnox::API.configure { |conf| conf.access_token = access_token } }
+      let(:token_store) { :default }
 
-      it{ is_expected.to eql( access_token ) }
+      it { is_expected.to eql(access_token) }
     end
 
     context 'with multiple access tokens' do
       before do
-        Fortnox::API.configure{ |conf| conf.access_tokens = [access_token, access_token2] }
+        Fortnox::API.configure { |conf| conf.access_tokens = [access_token, access_token2] }
       end
-      let( :token_store ){ :default }
+      let(:token_store) { :default }
 
-      it{ is_expected.to eql( [access_token, access_token2] ) }
+      it { is_expected.to eql([access_token, access_token2]) }
     end
 
     context 'with multiple token stores' do
@@ -175,64 +188,64 @@ describe Fortnox::API::Repository::Base do
           conf.access_tokens = { store_a: store_a_tokens, store_b: store_b_token }
         end
       end
-      let( :store_a_tokens ){ ['token_a1', 'token_a2'] }
-      let( :store_b_token ){ 'token_b1' }
+      let(:store_a_tokens) { %w[token_a1 token_a2] }
+      let(:store_b_token) { 'token_b1' }
 
       context 'with valid store name' do
-        let( :repository ){ Repository::Test.new( token_store: :store_a ) }
+        let(:repository) { Repository::Test.new(token_store: :store_a) }
 
-        it{ is_expected.to eql( store_a_tokens ) }
+        it { is_expected.to eql(store_a_tokens) }
       end
 
       context 'with non collection' do
-        let( :repository ){ Repository::Test.new( token_store: :store_b ) }
+        let(:repository) { Repository::Test.new(token_store: :store_b) }
 
-        it{ is_expected.to eql( store_b_token ) }
+        it { is_expected.to eql(store_b_token) }
       end
 
       context 'with invalid store name' do
-        subject{ ->{ get_access_tokens } }
+        subject { -> { access_tokens } }
 
-        let( :repository ){ Repository::Test.new( token_store: :nonsence_store ) }
+        let(:repository) { Repository::Test.new(token_store: :nonsence_store) }
 
-        it{ is_expected.to raise_error( error ) }
+        it { is_expected.to raise_error(error) }
       end
     end
   end
 
   describe '#check_access_tokens!' do
-    subject{ ->{ repository.check_access_tokens!(tokens) } }
+    subject { -> { repository.check_access_tokens!(tokens) } }
 
-    before{ Fortnox::API.configure{ |conf| conf.client_secret = client_secret } }
-    let( :error ){ Fortnox::API::MissingConfiguration }
-    let( :message ){ "not provided any access tokens in token store #{ token_store.inspect }" }
-    let( :token_store ){ :default }
+    before { Fortnox::API.configure { |conf| conf.client_secret = client_secret } }
+    let(:error) { Fortnox::API::MissingConfiguration }
+    let(:message) { "not provided any access tokens in token store #{token_store.inspect}" }
+    let(:token_store) { :default }
 
     context 'with nil' do
-      let( :tokens ){ nil }
+      let(:tokens) { nil }
 
-      it{ is_expected.to raise_error( error, /#{message}/ ) }
+      it { is_expected.to raise_error(error, /#{message}/) }
     end
 
     context 'with empty array' do
-      let( :tokens ){ [] }
+      let(:tokens) { [] }
 
-      it{ is_expected.to raise_error( error, /#{message}/ ) }
+      it { is_expected.to raise_error(error, /#{message}/) }
     end
 
     context 'with an empty, non default, token store' do
-      before{ Fortnox::API.configure{ |conf| conf.access_tokens = { token_store => tokens } } }
-      let( :repository ){ Repository::Test.new( token_store: token_store ) }
-      let( :tokens ){ [] }
-      let( :token_store ){ :store1 }
+      before { Fortnox::API.configure { |conf| conf.access_tokens = { token_store => tokens } } }
+      let(:repository) { Repository::Test.new(token_store: token_store) }
+      let(:tokens) { [] }
+      let(:token_store) { :store1 }
 
-      it{ is_expected.to raise_error( error, /#{message}/ ) }
+      it { is_expected.to raise_error(error, /#{message}/) }
     end
 
     context 'with valid tokens' do
-      let( :tokens ){ ['12345', 'abcde'] }
+      let(:tokens) { %w[12345 abcde] }
 
-      it{ is_expected.not_to raise_error }
+      it { is_expected.not_to raise_error }
     end
   end
 
@@ -245,7 +258,7 @@ describe Fortnox::API::Repository::Base do
 
       stub_request(
         :get,
-        'https://api.fortnox.se/3/test',
+        'https://api.fortnox.se/3/test'
       ).with(
         headers: headers
       ).to_return(
@@ -253,9 +266,9 @@ describe Fortnox::API::Repository::Base do
       )
     end
 
-    subject{ repository.get( '/test', { body: '' } ) }
+    subject { repository.get('/test', body: '') }
 
-    it{ is_expected.to be_nil }
+    it { is_expected.to be_nil }
   end
 
   describe 'making requests with multiple access tokens' do
@@ -267,13 +280,13 @@ describe Fortnox::API::Repository::Base do
 
       stub_request(
         :get,
-        'https://api.fortnox.se/3/test',
+        'https://api.fortnox.se/3/test'
       ).with(
         headers: {
           'Access-Token' => access_token,
           'Client-Secret' => client_secret,
           'Content-Type' => 'application/json',
-          'Accept' => 'application/json',
+          'Accept' => 'application/json'
         }
       ).to_return(
         status: 200,
@@ -282,13 +295,13 @@ describe Fortnox::API::Repository::Base do
 
       stub_request(
         :get,
-        'https://api.fortnox.se/3/test',
+        'https://api.fortnox.se/3/test'
       ).with(
         headers: {
           'Access-Token' => access_token2,
           'Client-Secret' => client_secret,
           'Content-Type' => 'application/json',
-          'Accept' => 'application/json',
+          'Accept' => 'application/json'
         }
       ).to_return(
         status: 200,
@@ -297,23 +310,26 @@ describe Fortnox::API::Repository::Base do
     end
 
     context 'with subsequent requests on same object' do
-      let!(:response1){ repository.get( '/test', { body: '' } ) }
-      let!(:response2){ repository.get( '/test', { body: '' } ) }
-      let!(:response3){ repository.get( '/test', { body: '' } ) }
+      let!(:response1) { repository.get('/test', body: '') }
+      let!(:response2) { repository.get('/test', body: '') }
+      let!(:response3) { repository.get('/test', body: '') }
 
       # rubocop:disable RSpec/MultipleExpectations
       # All these checks must be run in same it-statement because
       # of the random starting index.
       it 'works' do
-        expect(response1).not_to eq( response2 )
-        expect(response1).to eq( response3 )
-        expect(response3).not_to eq( response2 )
+        expect(response1).not_to eq(response2)
+        expect(response1).to eq(response3)
+        expect(response3).not_to eq(response2)
       end
       # rubocop:enable RSpec/MultipleExpectations
     end
   end
 
   context 'when raising error from remote server' do
+    error_message = 'Räkenskapsår finns inte upplagt. '\
+                    'För att kunna skapa en faktura krävs det att det finns ett räkenskapsår'
+
     before do
       Fortnox::API.configure do |conf|
         conf.client_secret = client_secret
@@ -322,18 +338,23 @@ describe Fortnox::API::Repository::Base do
 
       stub_request(
         :post,
-        'https://api.fortnox.se/3/test',
+        'https://api.fortnox.se/3/test'
       ).to_return(
         status: 500,
-        body: { 'ErrorInformation' => { 'error' => 1, 'message' => 'Räkenskapsår finns inte upplagt. För att kunna skapa en faktura krävs det att det finns ett räkenskapsår' } }.to_json,
-        headers: { 'Content-Type' => 'application/json' },
+        body: {
+          'ErrorInformation' => {
+            'error' => 1,
+            'message' => error_message
+          }
+        }.to_json,
+        headers: { 'Content-Type' => 'application/json' }
       )
     end
 
-    subject{ ->{ repository.post( '/test', { body: '' } ) } }
+    subject { -> { repository.post('/test', body: '') } }
 
-    it{ is_expected.to raise_error( Fortnox::API::RemoteServerError ) }
-    it{ is_expected.to raise_error( 'Räkenskapsår finns inte upplagt. För att kunna skapa en faktura krävs det att det finns ett räkenskapsår' ) }
+    it { is_expected.to raise_error(Fortnox::API::RemoteServerError) }
+    it { is_expected.to raise_error(error_message) }
 
     context 'with debugging enabled' do
       around do |example|
@@ -342,7 +363,7 @@ describe Fortnox::API::Repository::Base do
         Fortnox::API.config.debugging = false
       end
 
-      it{ is_expected.to raise_error( /\<HTTParty\:\:Request\:0x/ ) }
+      it { is_expected.to raise_error(/\<HTTParty\:\:Request\:0x/) }
     end
   end
 end