fortnox-api 0.5.2 → 0.6.0

data/spec/fortnox/api/types/examples/types.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 shared_examples_for 'equals input' do |input|
-  subject{ klass[ input ] }
-  it{ is_expected.to eq input }
+  subject { klass[input] }
+
+  it { is_expected.to eq input }
 end
 
 shared_examples_for 'raises ConstraintError' do |input|
-  subject{ ->{ klass[ input ] } }
-  it{ is_expected.to raise_error(Dry::Types::ConstraintError) }
+  subject { -> { klass[input] } }
+
+  it { is_expected.to raise_error(Dry::Types::ConstraintError) }
 end

data/spec/fortnox/api/types/housework_types_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'fortnox/api'
+require 'fortnox/api/types'
+require 'fortnox/api/repositories/order'
+require 'fortnox/api/models/order'
+require 'fortnox/api/types/order_row'
+
+# rubocop:disable RSpec/DescribeClass
+describe 'HouseworkTypes', integration: true do
+  include Helpers::Configuration
+
+  before { set_api_test_configuration }
+
+  let(:repository) { Fortnox::API::Repository::Order.new }
+  let(:valid_model) do
+    Fortnox::API::Model::Order.new(customer_number: '1', order_rows: [order_row])
+  end
+  let(:order_row) do
+    Fortnox::API::Types::OrderRow.new(ordered_quantity: 1,
+                                      article_number: '0000',
+                                      housework_type: housework_type)
+  end
+
+  shared_examples_for 'housework type' do |type, legacy: false|
+    subject do
+      lambda do
+        VCR.use_cassette("orders/housework_type_#{type.downcase}") do
+          repository.save(valid_model)
+        end
+      end
+    end
+
+    let(:error_message) { 'Skattereduktion för den valda typen av husarbete har upphört.' }
+    let(:housework_type) { Fortnox::API::Types::HouseworkTypes[type] }
+
+    context "when creating an OrderRow with housework_type set to #{type}" do
+      if legacy
+        it 'raises an error' do
+          is_expected.to raise_error(Fortnox::API::RemoteServerError, error_message)
+        end
+      else
+        it { is_expected.not_to raise_error }
+      end
+    end
+  end
+
+  it_behaves_like 'housework type', 'CONSTRUCTION'
+  it_behaves_like 'housework type', 'ELECTRICITY'
+  it_behaves_like 'housework type', 'GLASSMETALWORK'
+  it_behaves_like 'housework type', 'GROUNDDRAINAGEWORK'
+  it_behaves_like 'housework type', 'MASONRY'
+  it_behaves_like 'housework type', 'PAINTINGWALLPAPERING'
+  it_behaves_like 'housework type', 'HVAC'
+  it_behaves_like 'housework type', 'CLEANING'
+  it_behaves_like 'housework type', 'TEXTILECLOTHING'
+  it_behaves_like 'housework type', 'CLEANING'
+  it_behaves_like 'housework type', 'SNOWPLOWING'
+  it_behaves_like 'housework type', 'GARDENING'
+  it_behaves_like 'housework type', 'BABYSITTING'
+  it_behaves_like 'housework type', 'OTHERCARE'
+  it_behaves_like 'housework type', 'OTHERCOSTS'
+
+  it_behaves_like 'housework type', 'COOKING', legacy: true
+  it_behaves_like 'housework type', 'TUTORING', legacy: true
+end
+# rubocop:enable RSpec/DescribeClass

data/spec/fortnox/api/types/invoice_row_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types/invoice_row'
 require 'fortnox/api/types/examples/document_row'
 
 RSpec.describe Fortnox::API::Types::InvoiceRow, type: :type do
-  subject{ described_class }
+  subject { described_class }
 
   it_behaves_like 'DocumentRow', {}
 end

data/spec/fortnox/api/types/model_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'dry-struct'
 require 'fortnox/api/types/model'
@@ -8,7 +10,7 @@ RSpec.describe Fortnox::API::Types::Model do
       module Types
         include Dry::Types.module
 
-        Age = Int.constrained(gt: 18).with(required: true)
+        Age = Int.constrained(gt: 18).is(:required)
       end
 
       class TypesModelUser < Fortnox::API::Types::Model
@@ -16,16 +18,16 @@ RSpec.describe Fortnox::API::Types::Model do
       end
     end
 
-    describe "User inheriting from #{ described_class }" do
-      subject{ ->{ TypesModelUser.new(args) } }
+    describe "User inheriting from #{described_class}" do
+      subject { -> { TypesModelUser.new(args) } }
 
-      it{ is_expected.to raise_error(error) }
+      it { is_expected.to raise_error(error) }
     end
   end
 
   context 'without required keys' do
     include_examples 'raises error', Fortnox::API::MissingAttributeError do
-      let(:args){ {} }
+      let(:args) { {} }
     end
   end
 
@@ -44,13 +46,14 @@ RSpec.describe Fortnox::API::Types::Model do
       end
     end
 
-    subject{ ->{ User.new() } }
+    subject { -> { User.new } }
 
-    it{ is_expected.not_to raise_error }
+    it { is_expected.not_to raise_error }
 
     describe 'optional attribute' do
-      subject{ User.new().optional_string }
-      it{ is_expected.to be nil }
+      subject { User.new.optional_string }
+
+      it { is_expected.to be nil }
     end
   end
 end

data/spec/fortnox/api/types/nullable_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'dry-struct'
 require 'fortnox/api/types'
 
 describe Fortnox::API::Types::Nullable, type: :type do
-  subject{ TestStruct }
+  subject { TestStruct }
 
   describe 'String' do
     using_test_class do
@@ -12,7 +14,7 @@ describe Fortnox::API::Types::Nullable, type: :type do
       end
     end
 
-    it{ is_expected.to have_nullable(:string, 'A simple message', 0, '0') }
+    it { is_expected.to have_nullable(:string, 'A simple message', 0, '0') }
   end
 
   describe 'Float' do
@@ -22,7 +24,7 @@ describe Fortnox::API::Types::Nullable, type: :type do
       end
     end
 
-    it{ is_expected.to have_nullable(:float, 14.0, 'Not a Float!', 0.0) }
+    it { is_expected.to have_nullable(:float, 14.0, 'Not a Float!', 0.0) }
   end
 
   describe 'Integer' do
@@ -32,7 +34,7 @@ describe Fortnox::API::Types::Nullable, type: :type do
       end
     end
 
-    it{ is_expected.to have_nullable(:integer, 14, 14.0, 14) }
+    it { is_expected.to have_nullable(:integer, 14, 14.0, 14) }
   end
 
   describe 'Boolean' do
@@ -42,7 +44,7 @@ describe Fortnox::API::Types::Nullable, type: :type do
       end
     end
 
-    it{ is_expected.to have_nullable(:boolean, true, 'Not a Boolean!', false) }
+    it { is_expected.to have_nullable(:boolean, true, 'Not a Boolean!', false) }
   end
 
   describe 'Date' do
@@ -52,6 +54,6 @@ describe Fortnox::API::Types::Nullable, type: :type do
       end
     end
 
-    it{ is_expected.to have_nullable_date(:date, Date.new(2016, 1, 1), 'Not a Date!') }
+    it { is_expected.to have_nullable_date(:date, Date.new(2016, 1, 1), 'Not a Date!') }
   end
 end

data/spec/fortnox/api/types/order_row_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types/order_row'
 require 'fortnox/api/types/examples/document_row'
@@ -5,9 +7,9 @@ require 'fortnox/api/types/examples/document_row'
 RSpec.describe Fortnox::API::Types::OrderRow, type: :type do
   valid_hash = { ordered_quantity: 10.5 }
 
-  subject{ described_class }
+  subject { described_class }
 
-  it{ is_expected.to require_attribute( :ordered_quantity, valid_hash ) }
+  it { is_expected.to require_attribute(:ordered_quantity, valid_hash) }
 
   it_behaves_like 'DocumentRow', valid_hash
 end

data/spec/fortnox/api/types/required_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types'
 require 'fortnox/api/types/required'
@@ -9,10 +11,10 @@ describe Fortnox::API::Types::Required, type: :type do
   end
 
   shared_examples_for 'required attribute' do |_type|
-    subject{ ->{ TestClass.new({}) } }
+    subject { -> { TestClass.new({}) } }
 
     let(:error_message) do
-      "[#{ TestClass }.new] #{ :required_attribute.inspect } is missing in Hash input"
+      "[#{TestClass}.new] #{:required_attribute.inspect} is missing in Hash input"
     end
 
     it 'raises an error' do

data/spec/fortnox/api/types/sized_spec.rb

@@ -1,65 +1,67 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api/types'
 require 'fortnox/api/types/examples/types'
 
 describe Fortnox::API::Types::Sized do
-
   shared_examples_for 'Sized Types' do
-    context 'created with nil' do
-      subject{ klass[ nil ] }
-      it{ is_expected.to be_nil }
+    context 'when created with nil' do
+      subject { klass[nil] }
+
+      it { is_expected.to be_nil }
     end
   end
 
   describe 'String' do
     max_size = 5
-    let( :klass ){ described_class::String[ max_size ] }
+    let(:klass) { described_class::String[max_size] }
 
     it_behaves_like 'Sized Types'
 
-    context 'created with empty string' do
+    context 'when created with empty string' do
       include_examples 'equals input', ''
     end
 
-    context 'created with fewer characters than the limit' do
+    context 'when created with fewer characters than the limit' do
       include_examples 'equals input', 'a' * (max_size - 1)
     end
 
-    context 'created with valid string' do
+    context 'when created with valid string' do
       include_examples 'equals input', 'a' * max_size
     end
 
-    context 'created with more characters than the limit' do
+    context 'when created with more characters than the limit' do
       include_examples 'raises ConstraintError', 'a' * (max_size + 1)
     end
   end
 
   shared_examples_for 'Sized Numeric' do |type, min, max, step|
-    let( :klass ){ described_class.const_get(type)[ min, max ] }
+    let(:klass) { described_class.const_get(type)[min, max] }
 
     it_behaves_like 'Sized Types'
 
-    context 'created with value below the lower limit' do
+    context 'when created with value below the lower limit' do
       include_examples 'raises ConstraintError', min - step
     end
 
-    context 'created with value at the lower limit' do
+    context 'when created with value at the lower limit' do
       include_examples 'equals input', min
     end
 
-    context 'created with valid number near lower limit' do
+    context 'when created with valid number near lower limit' do
       include_examples 'equals input', min + step
     end
 
-    context 'created with valid number near upper limit' do
+    context 'when created with valid number near upper limit' do
       include_examples 'equals input', max - step
     end
 
-    context 'created with value at the upper limit' do
+    context 'when created with value at the upper limit' do
       include_examples 'equals input', max
     end
 
-    context 'created with value above the upper limit' do
+    context 'when created with value above the upper limit' do
       include_examples 'raises ConstraintError', max + step
     end
   end

data/spec/fortnox/api_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fortnox/api'
 
@@ -12,144 +14,144 @@ describe Fortnox::API do
   end
 
   describe 'configuration defaults' do
-    subject(:config_value){ described_class.config[config_key] }
+    subject(:config_value) { described_class.config[config_key] }
 
-    before{ Fortnox::API::TestBase.new }
+    before { Fortnox::API::TestBase.new }
 
     describe 'base_url' do
-      let( :config_key ){ :base_url }
+      let(:config_key) { :base_url }
 
-      it{ is_expected.to eql 'https://api.fortnox.se/3/' }
+      it { is_expected.to eql 'https://api.fortnox.se/3/' }
     end
 
     describe 'client_secret' do
-      let( :config_key ){ :client_secret }
+      let(:config_key) { :client_secret }
 
-      it{ is_expected.to be_nil }
+      it { is_expected.to be_nil }
     end
 
     describe 'access_token' do
-      let( :config_key ){ :access_token }
+      let(:config_key) { :access_token }
 
-      it{ is_expected.to be_nil }
+      it { is_expected.to be_nil }
     end
 
     describe 'access_tokens' do
-      let( :config_key ){ :access_tokens }
+      let(:config_key) { :access_tokens }
 
-      it{ is_expected.to be_nil }
+      it { is_expected.to be_nil }
     end
 
     describe 'token_store' do
-      let( :config_key ){ :token_store }
+      let(:config_key) { :token_store }
 
-      it{ is_expected.to eql( {} ) }
+      it { is_expected.to eql({}) }
     end
 
     describe 'debugging' do
-      let( :config_key ){ :debugging }
+      let(:config_key) { :debugging }
 
-      it{ is_expected.to be false }
+      it { is_expected.to be false }
     end
 
     describe 'logger' do
-      let( :config_key ){ :logger }
+      let(:config_key) { :logger }
 
-      it{ is_expected.to be_a Logger }
+      it { is_expected.to be_a Logger }
 
       describe 'level' do
-        subject{ config_value.level }
+        subject { config_value.level }
 
-        it{ is_expected.to be Logger::WARN }
+        it { is_expected.to be Logger::WARN }
       end
     end
   end
 
   describe 'access_token' do
     context 'when set to a String' do
-      subject{ described_class.config.access_token }
+      subject { described_class.config.access_token }
 
-      before{ described_class.configure{ |config| config.access_token = value } }
-      let( :value ){ '12345' }
+      before { described_class.configure { |config| config.access_token = value } }
+      let(:value) { '12345' }
 
-      it{ is_expected.to eql value }
+      it { is_expected.to eql value }
     end
 
     shared_examples_for 'invalid argument' do
-      subject{ ->{ described_class.configure{ |config| config.access_token = value } } }
+      subject { -> { described_class.configure { |config| config.access_token = value } } }
 
-      it{ is_expected.to raise_error(ArgumentError, /expected a String/) }
+      it { is_expected.to raise_error(ArgumentError, /expected a String/) }
     end
 
     context 'when set to a Hash' do
       include_examples 'invalid argument' do
-        let( :value ){ { a: '123' } }
+        let(:value) { { a: '123' } }
       end
     end
 
     context 'when set to an Array' do
       include_examples 'invalid argument' do
-        let( :value ){ ['123', '456'] }
+        let(:value) { %w[123 456] }
       end
     end
   end
 
   describe 'access_tokens' do
     context 'when set to a String' do
-      subject{ ->{ described_class.configure{ |config| config.access_tokens = '12345' } } }
+      subject { -> { described_class.configure { |config| config.access_tokens = '12345' } } }
 
-      it{ is_expected.to raise_error(ArgumentError, /expected a Hash or an Array/) }
+      it { is_expected.to raise_error(ArgumentError, /expected a Hash or an Array/) }
     end
 
     shared_examples_for 'valid argument' do
-      subject{ described_class.configure{ |config| config.access_tokens = value } }
+      subject { described_class.configure { |config| config.access_tokens = value } }
 
-      it{ is_expected.to eql( value ) }
+      it { is_expected.to eql(value) }
     end
 
     context 'when set to a Hash' do
       include_examples 'valid argument' do
-        let( :value ){ { a: '123', b: '456' } }
+        let(:value) { { a: '123', b: '456' } }
       end
     end
 
     context 'when set to an Array' do
       include_examples 'valid argument' do
-        let( :value ){ ['123', '456'] }
+        let(:value) { %w[123 456] }
       end
     end
   end
 
   describe 'token_store' do
-    subject{ described_class.config[:token_store] }
+    subject { described_class.config[:token_store] }
 
     context 'when access_token set' do
-      before{ described_class.configure{ |config| config.access_token = access_token } }
-      let( :access_token ){ '12345' }
+      before { described_class.configure { |config| config.access_token = access_token } }
+      let(:access_token) { '12345' }
 
-      it{ is_expected.to eql(default: access_token) }
+      it { is_expected.to eql(default: access_token) }
     end
 
     context 'when access_tokens is' do
-      before{ described_class.configure{ |config| config.access_tokens = access_tokens } }
+      before { described_class.configure { |config| config.access_tokens = access_tokens } }
 
       describe 'a Hash' do
-        let( :access_tokens ){ { a: '123', b: '456' } }
+        let(:access_tokens) { { a: '123', b: '456' } }
 
-        it{ is_expected.to eql( access_tokens ) }
+        it { is_expected.to eql(access_tokens) }
       end
 
       describe 'an Array' do
-        let( :access_tokens ){ ['123', '456'] }
+        let(:access_tokens) { %w[123 456] }
 
-        it{ is_expected.to eql( default: access_tokens ) }
+        it { is_expected.to eql(default: access_tokens) }
       end
     end
   end
 
   describe 'readers for' do
     describe 'debugging' do
-      subject{ described_class.debugging }
+      subject { described_class.debugging }
 
       it 'is available' do
         is_expected.to be false
@@ -157,7 +159,7 @@ describe Fortnox::API do
     end
 
     describe 'logger' do
-      subject{ described_class.logger }
+      subject { described_class.logger }
 
       it 'is available' do
         is_expected.to be_a Logger