foreman_discovery 16.3.5 → 17.0.2

data/locale/zh_TW/foreman_discovery.edit.po

@@ -5,10 +5,11 @@
 # Translators:
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_discovery 16.3.4\n"
+"Project-Id-Version: foreman_discovery 17.1.0\n"
 "Report-Msgid-Bugs-To: \n"
-"PO-Revision-Date: 2020-10-29 17:16+0000\n"
-"Last-Translator: Bryan Kearney <bryan.kearney@gmail.com>\n"
+"POT-Creation-Date: 2021-09-20 17:25+0200\n"
+"PO-Revision-Date: 2021-05-03 08:29+0000\n"
+"Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4\n"
 "Language-Team: Chinese (Taiwan) (http://www.transifex.com/foreman/foreman/lang"
 "uage/zh_TW/)\n"
 "MIME-Version: 1.0\n"
@@ -113,51 +114,51 @@ msgstr "上傳主機的詳情，並視需求建立主機"
 msgid "hash containing facts for the host with minimum set of facts: discovery_bootif, macaddress_eth0, ipaddress, ipaddress_eth0, interfaces: eth0 (example in case primary interface is named eth0)"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:129
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:130
 msgid "Execute rules against a discovered host"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:135 ../app/controllers/discovered_hosts_controller.rb:160
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:136 ../app/controllers/discovered_hosts_controller.rb:160
 msgid "Host %{host} was provisioned with rule %{rule}"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:138
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:139
 msgid "Unable to provision %{host}: %{errors}"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:144 ../app/controllers/discovered_hosts_controller.rb:167
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:145 ../app/controllers/discovered_hosts_controller.rb:167
 msgid "No rule found for host %s"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:151
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:152
 msgid "Execute rules against all currently discovered hosts"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:155 ../app/controllers/discovered_hosts_controller.rb:173
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:156 ../app/controllers/discovered_hosts_controller.rb:173
 msgid "Errors during auto provisioning: %s"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:158 ../app/controllers/discovered_hosts_controller.rb:176
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:159 ../app/controllers/discovered_hosts_controller.rb:176
 msgid "No discovered hosts to provision"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:180
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:181
 msgid "%s discovered hosts were provisioned"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:191
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:192
 msgid "Refreshing the facts of a discovered host"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:200
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:201
 msgid "Rebooting a discovered host"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:209
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:210
 msgid "Rebooting all discovered hosts"
 msgstr ""
 
-#: ../app/controllers/api/v2/discovered_hosts_controller.rb:220 ../app/controllers/discovered_hosts_controller.rb:129
+#: ../app/controllers/api/v2/discovered_hosts_controller.rb:221 ../app/controllers/discovered_hosts_controller.rb:129
 msgid "Discovered hosts are rebooting now"
 msgstr ""
 
@@ -289,58 +290,34 @@ msgstr ""
 msgid "Discovered hosts are provisioning now"
 msgstr ""
 
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "Highlights"
+#: ../app/controllers/discovered_hosts_controller.rb:277
+msgid "Discovered host reported from unknown subnet, communication will not be proxied."
 msgstr ""
 
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "Storage"
-msgstr "儲存裝置"
-
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "Hardware"
-msgstr "硬體"
-
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "Network"
-msgstr "網路"
-
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "Software"
-msgstr "軟體"
-
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "IPMI"
-msgstr "IPMI"
-
-#: ../app/controllers/discovered_hosts_controller.rb:226
-msgid "Miscellaneous"
-msgstr "雜項"
+#: ../app/controllers/discovered_hosts_controller.rb:282
+msgid "Discovered hosts reported from unknown subnet are %s, communication will not be proxied."
+msgstr ""
 
-#: ../app/controllers/discovered_hosts_controller.rb:304
+#: ../app/controllers/discovered_hosts_controller.rb:296
 msgid "No hosts were found with that id or name"
 msgstr "沒有找到擁有此 ID 或名稱的主機"
 
-#: ../app/controllers/discovered_hosts_controller.rb:308
+#: ../app/controllers/discovered_hosts_controller.rb:300
 msgid "No hosts selected"
 msgstr "未選擇主機"
 
-#: ../app/controllers/discovered_hosts_controller.rb:314
+#: ../app/controllers/discovered_hosts_controller.rb:306
 msgid "Something went wrong while selecting hosts - %s"
 msgstr "選擇主機時發生了錯誤 - %s"
 
-#: ../app/controllers/discovery_rules_controller.rb:72
+#: ../app/controllers/discovery_rules_controller.rb:79
 msgid "Rule enabled"
 msgstr ""
 
-#: ../app/controllers/discovery_rules_controller.rb:72
+#: ../app/controllers/discovery_rules_controller.rb:79
 msgid "Rule disabled"
 msgstr ""
 
-#: ../app/helpers/discovered_hosts_helper.rb:10
-msgid "%s ago"
-msgstr "%s 之前"
-
 #: ../app/helpers/discovered_hosts_helper.rb:14 ../app/helpers/discovered_hosts_helper.rb:29 ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:40
 msgid "Auto Provision"
 msgstr ""
@@ -426,6 +403,10 @@ msgid "Enable rule '%s'?"
 msgstr ""
 
 #: ../app/helpers/discovery_rules_helper.rb:33
+msgid "Clone"
+msgstr "複製"
+
+#: ../app/helpers/discovery_rules_helper.rb:34
 msgid "Delete rule '%s'?"
 msgstr ""
 
@@ -449,13 +430,13 @@ msgstr ""
 msgid "must be present."
 msgstr ""
 
-#: ../app/models/discovery_rule.rb:52
+#: ../app/models/discovery_rule.rb:57
 msgid "Host group organization %s must also be associated to the discovery rule"
 msgid_plural "Host group organizations %s must also be associated to the discovery rule"
 msgstr[0] ""
 msgstr[1] ""
 
-#: ../app/models/discovery_rule.rb:56
+#: ../app/models/discovery_rule.rb:61
 msgid "Host group location %s must also be associated to the discovery rule"
 msgid_plural "Host group locations %s must also be associated to the discovery rule"
 msgstr[0] ""
@@ -489,23 +470,23 @@ msgstr ""
 msgid "Facts could not be imported"
 msgstr ""
 
-#: ../app/models/host/discovered.rb:146
+#: ../app/models/host/discovered.rb:155
 msgid "Could not get facts from proxy %{url}: %{error}"
 msgstr ""
 
-#: ../app/models/host/discovered.rb:160
+#: ../app/models/host/discovered.rb:173
 msgid "Unable to perform reboot on %{name} (%{url}): %{msg}"
 msgstr ""
 
-#: ../app/models/host/discovered.rb:164 ../app/models/host/discovered.rb:183
+#: ../app/models/host/discovered.rb:177 ../app/models/host/discovered.rb:200
 msgid "Unable to perform %{action} on %{ips}"
 msgstr ""
 
-#: ../app/models/host/discovered.rb:179
+#: ../app/models/host/discovered.rb:196
 msgid "Unable to perform kexec on %{name} (%{url}): %{msg}"
 msgstr ""
 
-#: ../app/models/host/discovered.rb:203
+#: ../app/models/host/discovered.rb:220
 msgid "Invalid hostname: Could not normalize the hostname"
 msgstr ""
 
@@ -713,6 +694,14 @@ msgstr ""
 msgid "Type of name generator"
 msgstr ""
 
+#: ../app/models/setting/discovered.rb:40
+msgid "Prefer IPv6 to IPv4 when calling discovered nodes"
+msgstr ""
+
+#: ../app/models/setting/discovered.rb:40
+msgid "Prefer IPv6"
+msgstr ""
+
 #: ../app/services/foreman_discovery/fact_parser.rb:4
 msgid "Discovery fact parser does not work with non-discovery host '%{host}'"
 msgstr ""
@@ -725,6 +714,34 @@ msgstr ""
 msgid "Unable to find primary NIC with %{mac} specified via '%{fact}', NIC filter: %{filter}"
 msgstr ""
 
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:7
+msgid "Highlights"
+msgstr ""
+
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:8
+msgid "Storage"
+msgstr "儲存裝置"
+
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:9
+msgid "Hardware"
+msgstr "硬體"
+
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:10
+msgid "Network"
+msgstr "網路"
+
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:11
+msgid "Software"
+msgstr "軟體"
+
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:12
+msgid "IPMI"
+msgstr "IPMI"
+
+#: ../app/services/foreman_discovery/fact_to_category_resolver.rb:13
+msgid "Miscellaneous"
+msgstr "雜項"
+
 #: ../app/services/foreman_discovery/host_converter.rb:47
 msgid "IPAM must be configured for subnet '%s'"
 msgstr ""
@@ -737,6 +754,10 @@ msgstr ""
 msgid "Image API processing error: %{msg} (HTTP/%{code}, body: %{body})"
 msgstr ""
 
+#: ../app/services/foreman_discovery/ui_notifications/new_host.rb:22
+msgid "Host %s has been dicovered"
+msgstr ""
+
 #: ../app/views/dashboard/_discovery_widget.html.erb:5
 msgid "Discovered Host"
 msgid_plural "Discovered Hosts"
@@ -795,11 +816,11 @@ msgstr ""
 msgid "Disks Size"
 msgstr ""
 
-#: ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:16 ../app/views/discovered_hosts/_selected_hosts.html.erb:9
+#: ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:16 ../app/views/discovered_hosts/_selected_hosts.html.erb:9 ../app/views/discovery_rules/index.html.erb:11
 msgid "Location"
 msgstr "位置"
 
-#: ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:17 ../app/views/discovered_hosts/_selected_hosts.html.erb:10
+#: ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:17 ../app/views/discovered_hosts/_selected_hosts.html.erb:10 ../app/views/discovery_rules/index.html.erb:12
 msgid "Organization"
 msgstr "組織"
 
@@ -811,7 +832,7 @@ msgstr "子網路"
 msgid "Last Facts Upload"
 msgstr ""
 
-#: ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:20 ../app/views/discovery_rules/index.html.erb:12
+#: ../app/views/discovered_hosts/_discovered_hosts_list.html.erb:20 ../app/views/discovery_rules/index.html.erb:14
 msgid "Actions"
 msgstr "動作"
 
@@ -959,6 +980,10 @@ msgstr ""
 msgid "Hostnames must not start with numbers. A good approach is to use unique information provided by facter (MAC address, BIOS or serial ID)."
 msgstr ""
 
+#: ../app/views/discovery_rules/clone.erb:1
+msgid "Clone %s"
+msgstr "複製 %s"
+
 #: ../app/views/discovery_rules/edit.html.erb:1
 msgid "Edit %s"
 msgstr "編輯 %s"
@@ -991,7 +1016,7 @@ msgstr "主機群組"
 msgid "Hosts/Limit"
 msgstr ""
 
-#: ../app/views/discovery_rules/index.html.erb:11
+#: ../app/views/discovery_rules/index.html.erb:13
 msgid "DiscoveryRule|Enabled"
 msgstr ""
 
@@ -1012,8 +1037,8 @@ msgid "A summary of discovered hosts"
 msgstr ""
 
 #: ../db/seeds.d/80_discovery_ui_notification.rb:4
-msgid "Hosts"
-msgstr "主機"
+msgid "New hosts"
+msgstr ""
 
 #: ../db/seeds.d/80_discovery_ui_notification.rb:6
 msgid "One or more hosts have been discovered"
@@ -1023,19 +1048,27 @@ msgstr ""
 msgid "Details"
 msgstr "詳細資料"
 
-#: ../lib/foreman_discovery/engine.rb:180
+#: ../db/seeds.d/80_discovery_ui_notification.rb:18
+msgid "Hosts"
+msgstr "主機"
+
+#: ../db/seeds.d/80_discovery_ui_notification.rb:20
+msgid "Error message goes here"
+msgstr ""
+
+#: ../lib/foreman_discovery/engine.rb:176
 msgid "Discovery Kexec template"
 msgstr ""
 
-#: ../lib/foreman_discovery/engine.rb:189
+#: ../lib/foreman_discovery/engine.rb:185
 msgid "Discovery Proxy"
 msgstr ""
 
-#: ../lib/foreman_discovery/engine.rb:190
+#: ../lib/foreman_discovery/engine.rb:186
 msgid "Discovery Proxy to use within this subnet for managing connection to discovered hosts"
 msgstr ""
 
-#: ../lib/foreman_discovery/engine.rb:191
+#: ../lib/foreman_discovery/engine.rb:187
 msgid "ID of Discovery Proxy to use within this subnet for managing connection to discovered hosts"
 msgstr ""
 
@@ -1048,17 +1081,17 @@ msgid "documentation"
 msgstr ""
 
 #: action_names.rb:2
-msgid "Action with sub plans"
-msgstr "有子計畫的動作"
+msgid "Remote action:"
+msgstr "遠端動作："
 
 #: action_names.rb:3
-msgid "Import facts"
-msgstr "匯入詳情"
-
-#: action_names.rb:4
 msgid "Import Puppet classes"
 msgstr "匯入 Puppet 類別"
 
+#: action_names.rb:4
+msgid "Import facts"
+msgstr "匯入詳情"
+
 #: action_names.rb:5
-msgid "Remote action:"
-msgstr "遠端動作："
+msgid "Action with sub plans"
+msgstr "有子計畫的動作"

data/locale/zh_TW/foreman_discovery.po

@@ -5,9 +5,9 @@
 # Translators:
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_discovery 16.2.0\n"
+"Project-Id-Version: foreman_discovery 16.3.4\n"
 "Report-Msgid-Bugs-To: \n"
-"PO-Revision-Date: 2020-05-26 17:21+0000\n"
+"PO-Revision-Date: 2021-01-25 08:35+0000\n"
 "Last-Translator: Transifex Bot <>\n"
 "Language-Team: Chinese (Taiwan) (http://www.transifex.com/foreman/foreman/lang"
 "uage/zh_TW/)\n"
@@ -20,9 +20,6 @@ msgstr ""
 msgid "%s - The following hosts are about to be changed"
 msgstr "%s - 以下主機即將受到更改"
 
-msgid "%s ago"
-msgstr "%s 之前"
-
 msgid "%s discovered hosts were provisioned"
 msgstr ""
 
@@ -33,7 +30,7 @@ msgid "A summary of discovered hosts"
 msgstr ""
 
 msgid "Action with sub plans"
-msgstr ""
+msgstr "有子計畫的動作"
 
 msgid "Actions"
 msgstr "動作"
@@ -80,6 +77,12 @@ msgstr ""
 msgid "Clean all reported facts during provisioning (except discovery facts)"
 msgstr ""
 
+msgid "Clone"
+msgstr ""
+
+msgid "Clone %s"
+msgstr ""
+
 msgid "Collapse All"
 msgstr "全部收回"
 
@@ -145,9 +148,15 @@ msgstr[1] ""
 msgid "Discovered Hosts"
 msgstr ""
 
+msgid "Discovered Rules"
+msgstr ""
+
 msgid "Discovered host '%{host}' has all NICs filtered out, filter: %{filter}"
 msgstr ""
 
+msgid "Discovered host reported from unknown subnet, communication will not be proxied."
+msgstr ""
+
 msgid "Discovered host: %s"
 msgstr "發現的主機：%s"
 
@@ -160,6 +169,9 @@ msgstr ""
 msgid "Discovered hosts from Foreman server at %{foreman_url}"
 msgstr ""
 
+msgid "Discovered hosts reported from unknown subnet are %s, communication will not be proxied."
+msgstr ""
+
 msgid "Discovered hosts summary"
 msgstr ""
 
@@ -226,6 +238,9 @@ msgstr "啟用"
 msgid "Enable rule '%s'?"
 msgstr ""
 
+msgid "Error message goes here"
+msgstr ""
+
 msgid "Error on existing NIC"
 msgstr ""
 
@@ -280,6 +295,9 @@ msgstr "刷新 %s 的詳情失敗"
 msgid "Failed to refresh facts for %{hostname} with error %{error_message}"
 msgstr ""
 
+msgid "For more information please see "
+msgstr ""
+
 msgid "Force DNS"
 msgstr ""
 
@@ -304,6 +322,9 @@ msgstr ""
 msgid "Host"
 msgstr "主機"
 
+msgid "Host %s has been dicovered"
+msgstr ""
+
 msgid "Host %{host} was provisioned with rule %{rule}"
 msgstr ""
 
@@ -324,10 +345,10 @@ msgid "Host of type %s can not be rebooted"
 msgstr ""
 
 msgid "Host's owner type"
-msgstr ""
+msgstr "主機的擁有者類型"
 
 msgid "Host's parameters (array or indexed hash)"
-msgstr ""
+msgstr "主機參數（陣列或索引過的雜湊）"
 
 msgid "Hostname facts"
 msgstr ""
@@ -378,10 +399,10 @@ msgid "Image API returned HTTP/%{code} with '%{body}"
 msgstr ""
 
 msgid "Import Puppet classes"
-msgstr ""
+msgstr "匯入 Puppet 類別"
 
 msgid "Import facts"
-msgstr ""
+msgstr "匯入詳情"
 
 msgid "In addition to @host attribute function rand for random integers is available. Examples:"
 msgstr ""
@@ -471,7 +492,7 @@ msgid "Name"
 msgstr "名稱"
 
 msgid "Name of the parameter"
-msgstr ""
+msgstr "參數名稱"
 
 msgid "Network"
 msgstr "網路"
@@ -482,6 +503,9 @@ msgstr ""
 msgid "New Discovery Rule"
 msgstr ""
 
+msgid "New hosts"
+msgstr ""
+
 msgid "New in the last 24 hours"
 msgstr ""
 
@@ -534,7 +558,7 @@ msgid "PXELinux template to be used when pinning a host to discovery"
 msgstr ""
 
 msgid "Parameter value"
-msgstr ""
+msgstr "參數值"
 
 msgid "Please Confirm"
 msgstr "請確認"
@@ -600,7 +624,7 @@ msgid "Reloading kernel on %s"
 msgstr ""
 
 msgid "Remote action:"
-msgstr ""
+msgstr "遠端動作："
 
 msgid "Reported in the last 7 days"
 msgstr ""
@@ -728,6 +752,9 @@ msgstr ""
 msgid "defines a pattern to assign human-readable hostnames to the matching hosts"
 msgstr ""
 
+msgid "documentation"
+msgstr ""
+
 msgid "enables to limit maximum amount of provisioned hosts per rule"
 msgstr ""
 
@@ -777,13 +804,13 @@ msgid "represents rule name shown to the users"
 msgstr ""
 
 msgid "required if host is managed and custom partition has not been defined"
-msgstr ""
+msgstr "若主機是個受管理的主機，並且尚未定義自訂分割區的話便需要"
 
 msgid "required if host is managed and value is not inherited from host group"
-msgstr ""
+msgstr "若主機是個受管理的主機，並且值不是由主機群組所繼承的話便需要"
 
 msgid "required if not imaged based provisioning and host is managed and value is not inherited from host group"
-msgstr ""
+msgstr "若不是基於映像檔的佈建，而主機受管理並且值並非由主機群組所繼承的話便需要"
 
 msgid "required if value is not inherited from host group or default password in settings"
 msgstr ""

data/package.json

@@ -21,15 +21,15 @@
     "url": "http://projects.theforeman.org/projects/foreman_discovery/issues"
   },
   "peerDependencies": {
-    "@theforeman/vendor": ">= 4.14.0"
+    "@theforeman/vendor": "^6.0.0"
   },
   "devDependencies": {
     "@babel/core": "^7.7.0",
-    "@theforeman/builder": "^4.14.0",
-    "@theforeman/eslint-plugin-foreman": "4.14.0",
-    "@theforeman/stories": "^4.14.0",
-    "@theforeman/test": "^4.14.0",
-    "@theforeman/vendor-dev": "^4.14.0",
+    "@theforeman/builder": "^6.0.0",
+    "@theforeman/eslint-plugin-foreman": "^6.0.0",
+    "@theforeman/stories": "^6.0.0",
+    "@theforeman/test": "^8.0.0",
+    "@theforeman/vendor-dev": "^6.0.0",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.7.2",
     "prettier": "^1.19.1",

data/test/functional/api/v2/discovered_hosts_controller_test.rb

@@ -4,6 +4,8 @@ class Api::V2::DiscoveredHostsControllerTest < ActionController::TestCase
   include FactImporterIsolation
   allow_transactions_for_any_importer
 
+  alias_method  :blueprint, :failed_discovery_blueprint
+
   def switch_controller(klass)
     old_controller = @controller
     @controller = klass.new
@@ -26,6 +28,8 @@ class Api::V2::DiscoveredHostsControllerTest < ActionController::TestCase
     set_default_settings
     ::ForemanDiscovery::NodeAPI::PowerService.any_instance.stubs(:reboot).returns(true)
     ::ForemanDiscovery::HostConverter.stubs(:unused_ip_for_host)
+
+    assert blueprint
   end
 
   def test_get_index
@@ -206,4 +210,9 @@ class Api::V2::DiscoveredHostsControllerTest < ActionController::TestCase
     assert_response :success
   end
 
+  def test_failed_discovery_notification
+    bad_facts = { this_is: 'bad' }
+    post :facts, params: { facts: bad_facts }
+    assert_equal 1, Notification.all.count
+  end
 end

data/test/functional/discovery_rules_controller_test.rb

@@ -12,7 +12,6 @@ class DiscoveryRulesControllerTest < ActionController::TestCase
   test "reader role should get index" do
     get :index, params: {}, session: set_session_user_default_reader
     assert_response :success
-    assert_not_nil assigns(:discovery_rules)
   end
 
   test "should get new" do
@@ -72,6 +71,12 @@ class DiscoveryRulesControllerTest < ActionController::TestCase
     assert_redirected_to discovery_rules_path
   end
 
+  test 'clone' do
+    rule = FactoryBot.create(:discovery_rule)
+    get :clone, params: { :id => rule.id }, session: set_session_user
+    assert_template 'clone'
+  end
+
   private
 
   def initialize_host