dm-validations 0.9.11 → 0.10.0

data/spec/integration/automatic_validation/spec_helper.rb

@@ -0,0 +1,74 @@
+# put validator specific fixture models and helpers here
+#
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite
+
+# TODO: one day we need to get rid of this remaining foobarness
+# and use a few more realistic models with ParanoidBoolean and all
+# that
+
+module TypecastBypassSetter
+  # Bypass typecasting so we can set values for specs
+  def set(attributes)
+    attributes.each do |k, v|
+      instance_variable_set("@#{k}", v)
+    end
+  end
+end
+
+class SailBoat
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,            Integer,    :key => true, :min => 1, :max => 10
+
+  property :name,          String,                                :nullable => false,     :validates       => :presence_test
+  property :description,   String,     :length => 10,                                     :validates       => :length_test_1
+  property :notes,         String,     :length => 2..10,                                  :validates       => :length_test_2
+  property :no_validation, String,                                                        :auto_validation => false
+  property :salesman,      String,                                :nullable => false,     :validates       => [:multi_context_1, :multi_context_2]
+  property :code,          String,     :format => Proc.new { |code| code =~ /A\d{4}\z/ }, :validates       => :format_test
+  property :allow_nil,     String,     :length => 5..10,          :nullable => true,      :validates       => :nil_test
+  property :build_date,    Date,                                                          :validates       => :primitive_test
+  property :float,         Float,      :precision => 2, :scale => 1
+  property :big_decimal,   BigDecimal, :precision => 2, :scale => 1
+
+  include TypecastBypassSetter
+end
+
+class HasNullableBoolean
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,   Integer, :key => true
+  property :bool, Boolean # :nullable => true by default
+
+  include TypecastBypassSetter
+end
+
+class HasNotNullableBoolean
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,   Integer, :key => true
+  property :bool, Boolean, :nullable => false
+
+  include TypecastBypassSetter
+end
+
+class HasNotNullableParanoidBoolean
+  include DataMapper::Resource
+
+  # this one is not Serial intentionally
+  # use Serial in real world apps
+  property :id,   Integer,         :key => true
+  property :bool, ParanoidBoolean, :nullable => false
+
+  include TypecastBypassSetter
+end

data/spec/integration/block_validator/block_validator_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+require 'integration/block_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::G3Concert do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::G3Concert.new(:year => 2004, :participants => "Joe Satriani, Steve Vai, Yngwie Malmsteen", :city => "Denver")
+    @model.should be_valid
+  end
+
+  describe "some non existing year/participants/city combination" do
+    before :all do
+      @model.year = 2015
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "uses error messages returned by the validation block" do
+      @model.errors.on(:participants).should == [ 'this G3 is probably yet to take place' ]
+    end
+  end
+
+
+  describe "existing year/participants/city combination" do
+    before :all do
+      @model.year         = 2001
+      @model.city         = "Los Angeles"
+      @model.participants = "Joe Satriani, Steve Vai, John Petrucci"
+    end
+
+    it_should_behave_like "valid model"
+  end
+end

data/spec/integration/block_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/conditional_validation/if_condition_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+require 'integration/conditional_validation/spec_helper'
+
+describe DataMapper::Validate::Fixtures::UDPPacket do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::UDPPacket.new
+  end
+
+  describe "that is transported encapsulated into IPv4 packet" do
+    before :all do
+      @model.underlying_ip_version = 4
+    end
+
+    describe "and has no checksum" do
+      before :all do
+        @model.checksum = nil
+      end
+
+      it_should_behave_like "valid model"
+    end
+
+    describe "and has no checksum algorithm" do
+      before :all do
+        @model.checksum_algorithm = nil
+      end
+
+      it_should_behave_like "valid model"
+    end
+  end
+
+
+  describe "that is transported encapsulated into IPv6 packet" do
+    before :all do
+      @model.underlying_ip_version = 6
+    end
+
+    describe "and has no checksum" do
+      before :all do
+        @model.checksum = nil
+      end
+
+      it_should_behave_like "invalid model"
+
+      it "has a meaningful error message" do
+        @model.errors.on(:checksum).should == [ 'Checksum is mandatory when used with IPv6' ]
+      end
+    end
+
+    describe "and has no checksum algorithm" do
+      before :all do
+        @model.checksum_algorithm = nil
+      end
+
+      it_should_behave_like "invalid model"
+
+      it "has a meaningful error message" do
+        @model.errors.on(:checksum_algorithm).should == [ 'Checksum is mandatory when used with IPv6' ]
+      end
+    end
+  end
+end

data/spec/integration/conditional_validation/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/confirmation_validator/confirmation_validator_spec.rb

@@ -0,0 +1,74 @@
+require 'spec_helper'
+require 'integration/confirmation_validator/spec_helper'
+
+describe "reservation with mismatched person name", :shared => true do
+  it "has meaningful error message" do
+    @model.errors.on(:person_name).should == [ 'Person name does not match the confirmation' ]
+  end
+end
+
+describe "reservation with mismatched seats number", :shared => true do
+  it "has meaningful error message" do
+    # Proc gets expanded here
+    @model.errors.on(:number_of_seats).should == [ 'Reservation requires confirmation for number_of_seats' ]
+  end
+end
+
+
+describe DataMapper::Validate::Fixtures::Reservation do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::Reservation.new(:person_name                  => "Tyler Durden",
+                                                             :person_name_confirmation     => "Tyler Durden",
+                                                             :number_of_seats              => 2,
+                                                             :seats_confirmation           => 2)
+    @model.should be_valid
+  end
+
+  describe "with matching person name and confirmation" do
+    before :all do
+      @model.person_name = "mismatch"
+    end
+
+    it_should_behave_like "invalid model"
+    it_should_behave_like "reservation with mismatched person name"
+  end
+
+
+  describe "with a blank person name and confirmation" do
+    before :all do
+      @model.person_name = ""
+    end
+
+    it_should_behave_like "invalid model"
+    it_should_behave_like "reservation with mismatched person name"
+  end
+
+
+  describe "with a missing person name and confirmation" do
+    before :all do
+      @model.person_name = nil
+    end
+
+    it_should_behave_like "invalid model"
+    it_should_behave_like "reservation with mismatched person name"
+  end
+
+
+  describe "with mismatching number of seats and confirmation" do
+    before :all do
+      @model.number_of_seats  = -1
+    end
+
+    it_should_behave_like "invalid model"
+    it_should_behave_like "reservation with mismatched seats number"
+  end
+
+
+  describe "with a blank number of seats and confirmation" do
+    before :all do
+      @model.number_of_seats = nil
+    end
+
+    it_should_behave_like "valid model"
+  end
+end

data/spec/integration/confirmation_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/datamapper_models/association_validation_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe DataMapper::Validate::Fixtures::Product do
+  before :all do
+    @parent = DataMapper::Validate::Fixtures::ProductCompany.create(:title => "Apple", :flagship_product => "Macintosh")
+    @parent.should be_valid
+
+    @model  = DataMapper::Validate::Fixtures::Product.new(:name => "MacBook Pro", :company => @parent)
+    @model.should be_valid
+  end
+
+  describe "without company" do
+    before :all do
+      @model.company = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:company).should == [ 'Company must not be blank' ]
+    end
+  end
+end

data/spec/integration/datamapper_models/inheritance_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe DataMapper::Validate::Fixtures::ServiceCompany do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::ServiceCompany.new(:title => "Monsters, Inc.", :area_of_expertise => "Little children's nightmares")
+    @model.valid?
+  end
+
+  describe "without title" do
+    before :all do
+      @model.title = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message for inherited property" do
+      @model.errors.on(:title).should == [ 'Company name is a required field' ]
+    end
+  end
+
+  describe "without area of expertise" do
+    before :all do
+      @model.area_of_expertise = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message for own property" do
+      @model.errors.on(:area_of_expertise).should == [ 'Area of expertise must not be blank' ]
+    end
+  end
+end
+
+
+
+describe DataMapper::Validate::Fixtures::ProductCompany do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::ProductCompany.new(:title => "Apple", :flagship_product => "Macintosh")
+    @model.valid?
+  end
+
+  it_should_behave_like "valid model"
+
+  describe "without title" do
+    before :all do
+      @model.title = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has error message from the subclass itself" do
+      @model.errors.on(:title).should include('Product company must have a name')
+    end
+
+    # this may or may not be a desired behavior,
+    # but append vs. replace is a matter of opinion
+    # anyway
+    #
+    # TODO: there should be a way to clear validations for a field
+    # that subclasses can use
+    it "has error message from superclass" do
+      @model.errors.on(:title).should include('Company name is a required field')
+    end
+  end
+
+
+  describe "without flagship product" do
+    before :all do
+      @model.flagship_product = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message for own property" do
+      @model.errors.on(:flagship_product).should == [ 'Flagship product must not be blank' ]
+    end
+  end
+end

data/spec/integration/duplicated_validations/duplicated_validations_spec.rb

@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+
+require 'spec_helper'
+require 'integration/duplicated_validations/spec_helper'
+
+describe DataMapper::Validate::Fixtures::Page do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::Page.new(:id => 1024)
+  end
+
+  describe "without body" do
+    before :all do
+      @model.body = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "does not have duplicated error messages" do
+      @model.errors.on(:body).should == ["Body must not be blank"]
+    end
+  end
+end

data/spec/integration/duplicated_validations/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/format_validator/email_format_validator_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+require 'integration/format_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::BillOfLading do
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  @valid_email_addresses = [
+        '+1~1+@example.com',
+        '{_dave_}@example.com',
+        '"[[ dave ]]"@example.com',
+        'dave."dave"@example.com',
+        'test@localhost',
+        'test@example.com',
+        'test@example.co.uk',
+        'test@example.com.br',
+        '"J. P. \'s-Gravezande, a.k.a. The Hacker!"@example.com',
+        'me@[187.223.45.119]',
+        'someone@123.com',
+        'simon&garfunkel@songs.com'].each do |email|
+
+    describe "with email value of #{email} (RFC2822 compliant)" do
+      before :all do
+        @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:email => email))
+      end
+
+      it_should_behave_like "valid model"
+    end
+  end
+
+
+  @invalid_email_addresses = [
+        '-- dave --@example.com',
+        '[dave]@example.com',
+        '.dave@example.com',
+        'Max@Job 3:14',
+        'Job@Book of Job',
+        'J. P. \'s-Gravezande, a.k.a. The Hacker!@example.com'].each do |email|
+    describe "with email value of #{email} (non RFC2822 compliant)" do
+      before :all do
+        @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:email => email))
+      end
+
+      it_should_behave_like "invalid model"
+    end
+  end
+
+
+  it 'should have a pre-defined URL format' do
+    bad = [ 'http:// example.com',
+            'ftp://example.com',
+            'http://.com',
+            'http://',
+            'test',
+            '...'
+          ]
+
+    good = [
+            'http://example.com',
+            'http://www.example.com',
+           ]
+
+    bol = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.except(:url))
+    bol.should_not be_valid
+    bol.errors.on(:url).should == [ 'Url has an invalid format' ]
+
+    bad.map do |e|
+      bol.url = e
+      bol.valid?
+      bol.errors.on(:url).should == [ 'Url has an invalid format' ]
+    end
+
+    good.map do |e|
+      bol.url = e
+      bol.valid?
+      bol.errors.on(:url).should be_nil
+    end
+
+  end
+
+  describe 'with a regexp' do
+    before do
+      @bol = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes)
+      @bol.should be_valid
+    end
+
+    describe 'if matched' do
+      before do
+        @bol.username = 'a12345'
+      end
+
+      it 'should validate' do
+        @bol.should be_valid
+      end
+    end
+
+    describe 'if not matched' do
+      before do
+        @bol.username = '12345'
+      end
+
+      it 'should not validate' do
+        @bol.should_not be_valid
+      end
+
+      it 'should set an error message' do
+        @bol.valid?
+        @bol.errors.on(:username).should == [ 'Username must have at least one letter' ]
+      end
+    end
+  end
+end