dm-validations 0.9.11 → 0.10.0

data/spec/integration/length_validator/spec_helper.rb

@@ -1,12 +1,7 @@
-class MotorLaunch
-  include DataMapper::Resource
-  property :id, Integer, :serial => true
-  property :name, String, :auto_validation => false
-end
-
-class BoatDock
-  include DataMapper::Resource
-  property :id, Integer, :serial => true
-  property :name, String, :auto_validation => false, :default => "I'm a long string"
-  validates_length :name, :min => 3
-end
+# put validator specific fixture models and helpers here
+#
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/method_validator/method_validator_spec.rb

@@ -0,0 +1,239 @@
+require 'spec_helper'
+require 'integration/method_validator/spec_helper'
+
+describe "a good fit for DSLs", :shared => true do
+  it "is a good fit for DSLs" do
+    @model.should be_valid_for_implementing_a_dsl
+  end
+
+  it "is totally fine for DSLs" do
+    @model.ensure_appropriate_for_dsls.should be_true
+  end
+end
+
+describe "a poor candidate for DSLs", :shared => true do
+  it "is a poor candidate for DSLs" do
+    @model.should_not be_valid_for_implementing_a_dsl
+  end
+
+  it "is unappropriate for DSLs" do
+    @model.ensure_appropriate_for_dsls.first.should be_false
+  end
+
+  it "has a (more or less) meaningful error message" do
+    @model.errors.on(:ensure_appropriate_for_dsls).should == [ 'may not be so good for domain specific languages' ]
+  end
+end
+
+
+describe "a good fit for game engine core", :shared => true do
+  it "is a good fit for game engine core" do
+    @model.should be_valid_for_implementing_a_game_engine_core
+  end
+
+  it "is appropriate for system programming" do
+    @model.ensure_appropriate_for_system_programming.should be_true
+  end
+end
+
+describe "a poor candidate for game engine core", :shared => true do
+  it "is a poor candidate for game engine core" do
+    @model.should_not be_valid_for_implementing_a_game_engine_core
+  end
+end
+
+
+
+describe "a good fit for kernel hacking", :shared => true do
+  it "is a good fit for kernel hacking" do
+    @model.should be_valid_for_hacking_on_the_kernel
+  end
+
+  it "is appropriate for system programming" do
+    @model.ensure_appropriate_for_system_programming.should be_true
+  end
+end
+
+
+describe "a poor candidate for kernel hacking", :shared => true do
+  it "is not a good fit for kernel hacking" do
+    @model.should_not be_valid_for_hacking_on_the_kernel
+  end
+end
+
+#
+# Note that ProgrammingLanguage is not a DM resource,
+# it is a plain old Ruby object (PORO), or simply put,
+# just a "regular" Ruby class with a bunch of accessors.
+#
+# And yes, assumptions below are full of bullshit and
+# author is a moron, and your favourite programming
+# language is good for EVARYTHIN'!
+#
+#Please see spec_helper.rb next to this file
+#
+
+describe "C" do
+  before :all do
+    @model = ::DataMapper::Validate::Fixtures::ProgrammingLanguage.new(:name                                     => "C",
+                                                                       :allows_system_calls                      => true,
+                                                                       :allows_manual_memory_management          => true,
+                                                                       :approved_by_linus                        => true,
+                                                                       :compiler_excels_at_utilizing_cpu_cache   => true,
+                                                                       :is_very_high_level                       => false,
+                                                                       :does_not_require_explicit_return_keyword => false,
+                                                                       :allows_operator_overload                 => false,
+                                                                       :allows_optional_parentheses              => false
+                                                                       )
+  end
+
+  it_should_behave_like "a good fit for kernel hacking"
+
+  it_should_behave_like "a good fit for game engine core"
+
+  it_should_behave_like "a poor candidate for DSLs"
+end
+
+
+
+describe "C++" do
+  before :all do
+    @model = ::DataMapper::Validate::Fixtures::ProgrammingLanguage.new(:name                                     => "C++",
+                                                                       :allows_system_calls                      => true,
+                                                                       :allows_manual_memory_management          => true,
+                                                                       :approved_by_linus                        => false,
+                                                                       :compiler_excels_at_utilizing_cpu_cache   => true,
+                                                                       :is_very_high_level                       => false,
+                                                                       :does_not_require_explicit_return_keyword => false,
+                                                                       :allows_operator_overload                 => true,
+                                                                       :allows_optional_parentheses              => false
+                                                                       )
+  end
+
+  it_should_behave_like "a poor candidate for kernel hacking"
+
+  it_should_behave_like "a good fit for game engine core"
+
+  it_should_behave_like "a poor candidate for DSLs"
+
+  it "is not approved by Linus" do
+    @model.valid?(:hacking_on_the_kernel)
+    @model.errors.on(:ensure_approved_by_linus_himself).should_not be_blank
+  end
+end
+
+
+describe "Ruby" do
+  before :all do
+    @model = ::DataMapper::Validate::Fixtures::ProgrammingLanguage.new(:name                                     => "Ruby",
+                                                                       # well, C extensions do not really count
+                                                                       :allows_system_calls                      => false,
+                                                                       :allows_manual_memory_management          => false,
+                                                                       :approved_by_linus                        => false,
+                                                                       :compiler_excels_at_utilizing_cpu_cache   => false,
+                                                                       :is_very_high_level                       => true,
+                                                                       :does_not_require_explicit_return_keyword => true,
+                                                                       :allows_operator_overload                 => true,
+                                                                       :allows_optional_parentheses              => true
+                                                                       )
+  end
+
+  it_should_behave_like "a good fit for DSLs"
+
+  it_should_behave_like "a poor candidate for kernel hacking"
+
+  it_should_behave_like "a poor candidate for game engine core"
+
+  it "has a (more or less) meaningful error message" do
+    @model.valid?(:doing_system_programming)
+    @model.errors.on(:ensure_appropriate_for_system_programming).should == [ 'try something that is closer to the metal' ]
+  end
+end
+
+
+describe "Scala" do
+  before :all do
+    @model = ::DataMapper::Validate::Fixtures::ProgrammingLanguage.new(:name                                     => "Scala",
+                                                                       :allows_system_calls                      => false,
+                                                                       :allows_manual_memory_management          => false,
+                                                                       :approved_by_linus                        => false,
+                                                                       :compiler_excels_at_utilizing_cpu_cache   => false,
+                                                                       :is_very_high_level                       => true,
+                                                                       :does_not_require_explicit_return_keyword => true,
+                                                                       :allows_operator_overload                 => true,
+                                                                       :allows_optional_parentheses              => true
+                                                                       )
+  end
+
+  it_should_behave_like "a good fit for DSLs"
+
+  it_should_behave_like "a poor candidate for kernel hacking"
+
+  it_should_behave_like "a poor candidate for game engine core"
+
+  it "has a (more or less) meaningful error message" do
+    @model.valid?(:doing_system_programming)
+    @model.errors.on(:ensure_appropriate_for_system_programming).should == [ 'try something that is closer to the metal' ]
+  end
+end
+
+
+
+describe "Haskell" do
+  before :all do
+    @model = ::DataMapper::Validate::Fixtures::ProgrammingLanguage.new(:name                                     => "Haskell",
+                                                                       :allows_system_calls                      => false,
+                                                                       :allows_manual_memory_management          => false,
+                                                                       :approved_by_linus                        => false,
+                                                                       :compiler_excels_at_utilizing_cpu_cache   => true,
+                                                                       :is_very_high_level                       => true,
+                                                                       :does_not_require_explicit_return_keyword => true,
+                                                                       # operators are not different from any other function
+                                                                       :allows_operator_overload                 => true,
+                                                                       # or, allows explicit parentheses? who cares, we
+                                                                       # are just trying to come up with a relatively
+                                                                       # non-stupid spec example
+                                                                       :allows_optional_parentheses              => true
+                                                                       )
+  end
+
+  it_should_behave_like "a good fit for DSLs"
+
+  it_should_behave_like "a poor candidate for kernel hacking"
+
+  it_should_behave_like "a poor candidate for game engine core"
+
+  it "has a (more or less) meaningful error message" do
+    @model.valid?(:doing_system_programming)
+    @model.errors.on(:ensure_appropriate_for_system_programming).should == [ 'try something that is closer to the metal' ]
+  end
+end
+
+
+describe DataMapper::Validate::Fixtures::Event do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::Event.new(:name => "Fools day 2009")
+  end
+
+  describe "with start time before end time" do
+    before :all do
+      @model.starts_at = DateTime.new(2009, 4, 1, 00, 00, 01)
+      @model.ends_at   = DateTime.new(2009, 4, 1, 23, 59, 59)
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with start time after end time" do
+    before :all do
+      @model.starts_at = DateTime.new(2009, 4, 1, 23, 59, 59)
+      @model.ends_at   = DateTime.new(2009, 4, 1, 00, 00, 01)
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "uses custom error message for property starts_at" do
+      @model.errors.on(:starts_at).should == [ 'Start time cannot be after end time' ]
+    end
+  end
+end

data/spec/integration/method_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/numeric_validator/equality_with_float_type_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+require 'integration/numeric_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::BasketballCourt do
+  describe "with valid set of attributes" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BasketballCourt.valid_instance
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with rim height of 3.05" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BasketballCourt.valid_instance(:rim_height => 3.05)
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with rim height of 3.30" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BasketballCourt.valid_instance(:rim_height => 3.30)
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:rim_height).should == [ 'Rim height must be equal to 3.05' ]
+    end
+  end
+
+
+  describe "with free throw line distance of 4.57" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BasketballCourt.valid_instance(:free_throw_line_distance => 4.57)
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with free throw line distance of 3.10" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BasketballCourt.valid_instance(:free_throw_line_distance => 3.10)
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:free_throw_line_distance).should == [ 'Free throw line distance must be equal to 4.57' ]
+    end
+  end
+end

data/spec/integration/numeric_validator/equality_with_integer_type_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+require 'integration/numeric_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::LerneanHydra do
+  describe "with valid set of attributes" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::LerneanHydra.valid_instance
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with 9 heads" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::LerneanHydra.valid_instance(:head_count => 9)
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with only 3 heads" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::LerneanHydra.valid_instance(:head_count => 3)
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:head_count).should == [ 'Lernean hydra is said to have exactly 9 heads' ]
+    end
+  end
+end

data/spec/integration/numeric_validator/float_type_spec.rb

@@ -1,102 +1,88 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
+require 'spec_helper'
+require 'integration/numeric_validator/spec_helper'
 
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
-
-describe BasketballPlayer do
-  before(:each) do
-    @mj = BasketballPlayer.new(:name => "Michael Jordan", :height => 198.1, :weight => 97.2)
+describe DataMapper::Validate::Fixtures::BasketballPlayer do
+  before :all  do
+    @model = DataMapper::Validate::Fixtures::BasketballPlayer.new(:name => "Michael Jordan", :height => 198.1, :weight => 97.2)
   end
 
   describe "with height as float" do
-    before(:each) do
+    before :all  do
       # no op in this case
     end
 
-    it "is valid" do
-      @mj.should be_valid
-    end
+    it_should_behave_like "valid model"
   end
 
-
   describe "with height as integer" do
-    before(:each) do
-      @mj.height = 198
+    before :all  do
+      @model.height = 198
     end
 
-    it "is valid" do
-      @mj.should be_valid
-    end
+    it_should_behave_like "valid model"
   end
 
-
   describe "with height as string containing only integers" do
-    before(:each) do
-      @mj.height = "198"
+    before :all  do
+      @model.height = "198"
     end
 
-    it "is valid" do
-      @mj.should be_valid
-    end
+    it_should_behave_like "valid model"
   end
 
-
   describe "with height as string containing a float" do
-    before(:each) do
-      @mj.height = "198.1"
+    before :all do
+      @model.height = "198.1"
     end
 
-    it "is valid" do
-      @mj.should be_valid
-    end
+    it_should_behave_like "valid model"
   end
 
+  describe "with height as string containing a float that will be represented in scientific notation" do
+    before :all do
+      @model.height = '0.00004'
+    end
+
+    it_should_behave_like "valid model"
+  end
 
   describe "with height as string containing random alphanumeric characters" do
-    before(:each) do
-      @mj.height = "height=198.1"
+    before :all do
+      @height = 'height=198.1'
+      @model.height = "height=198.1"
     end
 
-    it "is set to 0.0" do
-      @mj.height.should == 0.0
+    it "is should not change the value" do
+      @model.height.should == @height
     end
 
-    it "IS  valid" do
-      # float property is set to 0.0 here
-      @mj.should be_valid
-    end
+    it_should_behave_like "invalid model"
   end
 
-
   describe "with height as string containing random punctuation characters" do
-    before(:each) do
-      @mj.height = "$$ * $?"
+    before :all do
+      @height = '$$ * $?'
+      @model.height = @height
     end
 
-    it "is set to 0.0" do
-      @mj.height.should == 0.0
+    it "is should not change the value" do
+      @model.height.should == @height
     end
 
-    it "IS  valid" do
-      # float property is set to 0.0 here
-      @mj.should be_valid
-    end
+    it_should_behave_like "invalid model"
   end
 
-
   describe "with nil height" do
-    before(:each) do
-      @mj.height = nil
+    before :all do
+      @model.height = nil
+      @model.valid?
     end
 
-    it "is NOT valid" do
-      @mj.should_not be_valid
-    end
+    # typecasting kicks in
+    it_should_behave_like "invalid model"
 
-    it "has a meaningful error message on for the property" do
-      @mj.valid?
-      @mj.errors.on(:height).should include("Height must be a number")
+    it "has a meaningful error message" do
+      @model.errors.on(:height).should == [ 'Height must be a number' ]
     end
   end
 end