dm-validations 0.9.11 → 0.10.0

data/spec/integration/format_validator/format_validator_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+require 'integration/format_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::BillOfLading do
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  describe "with doc no with value of 'BAD CODE :)'" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:doc_no => 'BAD CODE :)'))
+    end
+
+    it_should_behave_like 'invalid model'
+
+    it "has meaningful error message on invalid field" do
+      @model.errors.on(:doc_no).should == [ 'Doc no has an invalid format' ]
+    end
+  end
+
+  describe "with doc no with value of 'A1234'" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:doc_no => 'A1234'))
+    end
+
+    it_should_behave_like 'valid model'
+  end
+
+  describe "with doc no with value of 'B123456X12'" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:doc_no => 'B123456X12'))
+    end
+
+    it_should_behave_like 'valid model'
+  end
+
+  describe "with missing url" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.except(:url))
+    end
+
+    it_should_behave_like 'invalid model'
+  end
+
+  describe "with blank name" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:username => ''))
+    end
+
+    it_should_behave_like 'valid model'
+  end
+
+  describe "with blank email" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:email => ''))
+    end
+
+    it_should_behave_like 'valid model'
+  end
+end

data/spec/integration/format_validator/regexp_validator_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+require 'integration/format_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::BillOfLading do
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  describe "with code of 123456" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:code => '123456'))
+    end
+
+    it_should_behave_like 'valid model'
+  end
+
+
+  describe "with code of 12" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:code => '12'))
+    end
+
+    it_should_behave_like 'invalid model'
+
+    it "has a meaningful error message" do
+      @model.errors.on(:code).should  == [ 'Code format is invalid' ]
+    end
+  end
+end

data/spec/integration/format_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/format_validator/url_format_validator_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+require 'integration/format_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::BillOfLading do
+  def valid_attributes
+    { :id => 1, :doc_no => 'A1234', :email => 'user@example.com', :url => 'http://example.com' }
+  end
+
+  [ 'http:// example.com', 'ftp://example.com', 'http://.com', 'http://', 'test', '...',
+    # these are valid URIs from RFC perspective,
+    # but too often not the case for web apps
+    #
+    # TODO: add another format that is strictly
+    # RFC compliant so it can be used, for instance,
+    # for internal apps that may refer to local domains
+    # like http://backend:8080
+    "http://localhost:4000", "http://localhost" ].each do |uri|
+    describe "with URL of #{uri}" do
+      before :all do
+        @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:url => uri))
+      end
+
+      it_should_behave_like "invalid model"
+
+      it "has a meaningful error message" do
+        @model.errors.on(:url).should == [ 'Url has an invalid format' ]
+      end
+    end
+  end # each
+
+
+  [ 'http://apple.com',
+    'http://www.apple.com',
+    "http://apple.com/",
+    "http://apple.com/iphone",
+    "http://www.google.com/search?client=safari&rls=en-us&q=LED&ie=UTF-8&oe=UTF-8",
+    "http://books.google.com",
+    "http://books.google.com/",
+    "http://db2.clouds.megacorp.net:8080",
+    "https://github.com",
+    "https://github.com/",
+    "http://www.example.com:8088/never/ending/path/segments/",
+    "http://db2.clouds.megacorp.net:8080/resources/10",
+    "http://www.example.com:8088/never/ending/path/segments",
+    "http://books.google.com/books?id=uSUJ3VhH4BsC&printsec=frontcover&dq=subject:%22+Linguistics+%22&as_brr=3&ei=DAHPSbGQE5rEzATk1sShAQ&rview=1",
+    "http://books.google.com:80/books?uid=14472359158468915761&rview=1",
+    "http://books.google.com/books?id=Ar3-TXCYXUkC&printsec=frontcover&rview=1",
+    "http://books.google.com/books/vp6ae081e454d30f89b6bca94e0f96fc14.js",
+    "http://www.google.com/images/cleardot.gif",
+    "http://books.google.com:80/books?id=Ar3-TXCYXUkC&printsec=frontcover&rview=1#PPA5,M1",
+    "http://www.hulu.com/watch/64923/terminator-the-sarah-connor-chronicles-to-the-lighthouse",
+    "http://hulu.com:80/browse/popular/tv",
+    "http://www.hulu.com/watch/62475/the-simpsons-gone-maggie-gone#s-p1-so-i0"
+  ].each do |uri|
+   describe "with URL of #{uri}" do
+     before :all do
+       @model = DataMapper::Validate::Fixtures::BillOfLading.new(valid_attributes.merge(:url => uri))
+     end
+
+     it_should_behave_like "valid model"
+   end
+ end # each
+end # describe DataMapper::Validate::Fixtures::BillOfLading

data/spec/integration/length_validator/default_value_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
+
+describe ::DataMapper::Validate::Fixtures::BoatDock do
+  before :all do
+    @model = ::DataMapper::Validate::Fixtures::BoatDock.new
+  end
+
+  describe "with default values that are valid" do
+    it_should_behave_like "valid model"
+  end
+end

data/spec/integration/length_validator/equality_spec.rb

@@ -0,0 +1,79 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
+
+describe "entity with wrong destination MAC address length", :shared => true do
+  it "has error message with range bounds" do
+    @model.errors.on(:destination_mac).should == [ 'Destination mac must be 6 characters long' ]
+  end
+end
+
+
+describe DataMapper::Validate::Fixtures::EthernetFrame do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::EthernetFrame.valid_instance
+    @model.link_support_fragmentation = false
+  end
+
+  it_should_behave_like "valid model"
+
+  describe "with destination MAC 3 'bits' long" do
+    before :all do
+      @model.destination_mac = "123"
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "entity with wrong destination MAC address length"
+  end
+
+  describe "with destination MAC 8 'bits' long" do
+    before :all do
+      @model.destination_mac = "123abce8"
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "entity with wrong destination MAC address length"
+  end
+
+  # arguable but reasonable for 80% of cases
+  # to treat nil as a 0 lengh value
+  # reported in
+  # http://datamapper.lighthouseapp.com/projects/20609/tickets/646
+  describe "that has no destination MAC address" do
+    before :all do
+      @model.destination_mac = nil
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "entity with wrong destination MAC address length"
+  end
+
+  describe "with a 6 'bits' destination MAC address" do
+    before :all do
+      @model.destination_mac = "a1b2c3"
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with multibyte characters" do
+    before :all do
+      @model = DataMapper::Validate::Fixtures::Currency.valid_instance(
+        :name   => 'Euro',
+        :code   => 'EUR',
+        :symbol => '€'
+      )
+      @model.valid?
+    end
+
+    it_should_behave_like "valid model"
+  end
+end

data/spec/integration/length_validator/error_message_spec.rb

@@ -1,23 +1,20 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
 
-# global first, then local to length validators
-require __dir__.parent.parent + "spec_helper"
-require __dir__ + 'spec_helper'
+describe DataMapper::Validate::Fixtures::Jabberwock do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::Jabberwock.new
+  end
+
+  describe "without snickersnack" do
+    before :all do
+      @model.snickersnack = nil
+    end
+
+    it_should_behave_like "invalid model"
 
-describe DataMapper::Validate::LengthValidator do
-  it "lets user specify custom error message" do
-    class Jabberwock
-      include DataMapper::Resource
-      property :id, Integer, :key => true
-      property :snickersnack, String
-      validates_length :snickersnack, :within => 3..40, :message => "worble warble"
+    it "has custom error message" do
+      @model.errors.on(:snickersnack).should == [ 'worble warble' ]
     end
-    wock = Jabberwock.new
-    wock.should_not be_valid
-    wock.errors.on(:snickersnack).should include('worble warble')
-    wock.snickersnack = "hello"
-    wock.id = 1
-    wock.should be_valid
   end
 end

data/spec/integration/length_validator/maximum_spec.rb

@@ -1,31 +1,47 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-# global first, then local to length validators
-require __dir__.parent.parent + "spec_helper"
-require __dir__ + 'spec_helper'
-
-describe DataMapper::Validate::LengthValidator do
-  it "lets user specify a maximum length of a string field" do
-    class ::MotorLaunch
-      validators.clear!
-      validates_length :name, :max => 5
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
+
+describe "barcode with invalid code length", :shared => true do
+  it "has a meaninful error message with length restrictions mentioned" do
+    @model.errors.on(:code).should == [ 'Code must be at most 10 characters long' ]
+  end
+end
+
+describe ::DataMapper::Validate::Fixtures::Barcode do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::Barcode.valid_instance
+  end
+
+  it_should_behave_like "valid model"
+
+  describe "with a 17 characters long code" do
+    before :all do
+      @model.code = "18283849284728124"
+      @model.valid?
     end
 
-    launch = MotorLaunch.new
-    launch.name = 'a' * 6
-    launch.should_not be_valid
-    launch.errors.on(:name).should include('Name must be less than 5 characters long')
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "barcode with invalid code length"
   end
 
-  it "aliases :maximum for :max" do
-    class ::MotorLaunch
-      validators.clear!
-      validates_length :name, :maximum => 5
+  describe "with a 7 characters long code" do
+    before :all do
+      @model.code = "8372786"
+      @model.valid?
     end
-    launch = MotorLaunch.new
-    launch.name = 'a' * 6
-    launch.should_not be_valid
-    launch.errors.on(:name).should include('Name must be less than 5 characters long')
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with an 11 characters long code" do
+    before :all do
+      @model.code = "83727868754"
+      @model.valid?
+    end
+
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "barcode with invalid code length"
   end
 end

data/spec/integration/length_validator/minimum_spec.rb

@@ -1,31 +1,42 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
 
-# global first, then local to length validators
-require __dir__.parent.parent + "spec_helper"
-require __dir__ + 'spec_helper'
+describe "entity with a name shorter than 2 characters", :shared => true do
+  it "has a meaninful error message with length restrictions mentioned" do
+    @model.errors.on(:name).should == [ 'Name must be at least 2 characters long' ]
+  end
+end
+
+describe ::DataMapper::Validate::Fixtures::Mittelschnauzer do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::Mittelschnauzer.valid_instance
+  end
+
+  it_should_behave_like "valid model"
 
-describe DataMapper::Validate::LengthValidator do
-  it "lets user specify a minimum length of a string field" do
-    class ::MotorLaunch
-      validates_length :name, :min => 3
+  describe "with a 13 characters long name" do
+    it_should_behave_like "valid model"
+  end
+
+  describe "with a single character name" do
+    before :all do
+      @model.name = "R"
+      @model.valid?
     end
 
-    launch = MotorLaunch.new
-    launch.name = 'Ab'
-    launch.should_not be_valid
-    launch.errors.on(:name).should include('Name must be more than 3 characters long')
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "entity with a name shorter than 2 characters"
   end
 
-  it "aliases :minimum for :min" do
-    class ::MotorLaunch
-      validators.clear!
-      validates_length :name, :minimum => 3
+  describe "with blank name" do
+    before :all do
+      @model.name = ""
+      @model.valid?
     end
 
-    launch = MotorLaunch.new
-    launch.name = 'Ab'
-    launch.should_not be_valid
-    launch.errors.on(:name).should include('Name must be more than 3 characters long')
+    it_should_behave_like "invalid model"
+
+    it_should_behave_like "entity with a name shorter than 2 characters"
   end
 end

data/spec/integration/length_validator/range_spec.rb

@@ -1,47 +1,52 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
+require 'spec_helper'
+require 'integration/length_validator/spec_helper'
 
-# global first, then local to length validators
-require __dir__.parent.parent + "spec_helper"
-require __dir__ + 'spec_helper'
+describe DataMapper::Validate::Fixtures::EthernetFrame do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::EthernetFrame.valid_instance
+    @model.link_support_fragmentation = false
+  end
 
-class MotorLaunch
-  validators.clear!
-  validates_length :name, :in => (3..5)
-end
+  it_should_behave_like "valid model"
 
+  describe "with payload that is 7 'bits' long (too short)" do
+    before :all do
+      @model.payload = "1234567"
+      @model.valid?
+    end
 
-describe MotorLaunch do
-  before :each do
-    @launch = MotorLaunch.new
-  end
+    it_should_behave_like "invalid model"
 
-  describe "with a value that is out of range bounds (too long)" do
-    before :each do
-      @launch.name = 'a'
-      @launch.valid?
+    it "has error message with range bounds" do
+      @model.errors.on(:payload).should == [ 'Payload must be between 46 and 1500 characters long' ]
     end
+  end
 
-    it "is invalid" do
-      @launch.should_not be_valid
+
+  describe "with a one character long payload (too short)" do
+    before :all do
+      @model.payload = 'a'
+      @model.valid?
     end
-    it "includes range bounds and field name in error message" do
-      @launch.errors.on(:name).should include('Name must be between 3 and 5 characters long')
+
+    it_should_behave_like "invalid model"
+
+    it "has error message with range bounds" do
+      @model.errors.on(:payload).should == [ 'Payload must be between 46 and 1500 characters long' ]
     end
   end
 
 
-  describe "with a value that is out of range bounds (too short)" do
-    before :each do
-      @launch.name = 'L'
-      @launch.valid?
+  describe "with a 1600 'bits' long payload (needs fragmentation)" do
+    before :all do
+      @model.payload = 'a'
+      @model.valid?
     end
 
-    it "is invalid" do
-      @launch.should_not be_valid
-    end
-    it "includes range bounds and field name in error message" do
-      @launch.errors.on(:name).should include('Name must be between 3 and 5 characters long')
+    it_should_behave_like "invalid model"
+
+    it "has error message with range bounds" do
+      @model.errors.on(:payload).should == [ 'Payload must be between 46 and 1500 characters long' ]
     end
   end
 
@@ -50,46 +55,31 @@ describe MotorLaunch do
   # to treat nil as a 0 lengh value
   # reported in
   # http://datamapper.lighthouseapp.com/projects/20609/tickets/646
-  describe "with a nil value" do
-    before :each do
-      @launch.name = nil
-      @launch.valid?
+  describe "that has no payload" do
+    before :all do
+      @model.payload = nil
+      @model.valid?
     end
 
-    it "is invalid" do
-      @launch.should_not be_valid
-    end
-    it "includes range bounds and field name in error message" do
-      @launch.errors.on(:name).should include('Name must be between 3 and 5 characters long')
+    it_should_behave_like "invalid model"
+
+    it "has error message with range bounds" do
+      @model.errors.on(:payload).should == [ 'Payload must be between 46 and 1500 characters long' ]
     end
   end
 
 
 
-  describe "with a value that is within range bounds" do
-    before :each do
-      @launch.name = 'Lisp'
-      @launch.valid?
-    end
-
-    it "is valid" do
-      @launch.should be_valid
-    end
-    it "has blank error message" do
-      @launch.errors.on(:name).should be_blank
+  describe "with a 50 characters long payload" do
+    before :all do
+      @model.payload = 'Imagine yourself a beautiful bag full of bits here'
+      @model.valid?
     end
-  end
-
 
+    it_should_behave_like "valid model"
 
-  it "aliases :within for :in" do
-    class ::MotorLaunch
-      validators.clear!
-      validates_length :name, :within => (3..5)
+    it "has blank error message" do
+      @model.errors.on(:payload).should be_blank
     end
-
-    launch = MotorLaunch.new
-    launch.name = 'Ride'
-    launch.valid?.should == true
   end
 end