dm-validations 0.9.11 → 0.10.0

data/spec/integration/within_validator/within_validator_spec.rb

@@ -0,0 +1,164 @@
+require 'spec_helper'
+require 'integration/within_validator/spec_helper'
+
+describe DataMapper::Validate::Fixtures::PhoneNumber do
+  before(:all) do
+    @model = DataMapper::Validate::Fixtures::PhoneNumber.new(:type_of_number => 'cell')
+    @model.should be_valid
+  end
+
+  describe "with type of number set to 'home'" do
+    before :all do
+      @model.type_of_number = 'home'
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with type of number set to 'cell'" do
+    before :all do
+      @model.type_of_number = 'cell'
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with type of number set to 'work'" do
+    before :all do
+      @model.type_of_number = 'home'
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with type of number set to 'fax'" do
+    before :all do
+      @model.type_of_number = 'fax'
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has meaningful error message on invalid property" do
+      @model.errors.on(:type_of_number).should == [ 'Should be one of: home, cell or work' ]
+    end
+  end
+end
+
+
+
+describe DataMapper::Validate::Fixtures::MathematicalFunction do
+  before :all do
+    @model = DataMapper::Validate::Fixtures::MathematicalFunction.new(:input => 2, :output => -2)
+    @model.should be_valid
+  end
+
+  describe "with input = 0" do
+    before :all do
+      @model.input = 0
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "notices 'greater than or equal to 1' in the error message" do
+      @model.errors.on(:input).should == [ 'Input must be greater than or equal to 1' ]
+    end
+  end
+
+  describe "with input = -10" do
+    before :all do
+      @model.input = -10
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "notices 'greater than or equal to 1' in the error message" do
+      @model.errors.on(:input).should == [ 'Input must be greater than or equal to 1' ]
+    end
+  end
+
+  describe "with input = -Infinity" do
+    before :all do
+      @model.input = -(1.0/0)
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "notices 'greater than or equal to 1' in the error message" do
+      @model.errors.on(:input).should == [ 'Input must be greater than or equal to 1' ]
+    end
+  end
+
+  describe "with input = 10" do
+    before :all do
+      @model.input = 10
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  describe "with input = Infinity" do
+    before :all do
+      @model.input = (1.0/0)
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+
+  #
+  # Function range
+  #
+
+  describe "with output = 0" do
+    before :all do
+      @model.output = 0
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with output = -10" do
+    before :all do
+      @model.output = -10
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with output = -Infinity" do
+    before :all do
+      @model.output = -(1.0/0)
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with output = 10" do
+    before :all do
+      @model.output = 10
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "uses overriden error message" do
+      @model.errors.on(:output).should == [ 'Negative values or zero only, please' ]
+    end
+  end
+
+
+  describe "with output = Infinity" do
+    before :all do
+      @model.output = (1.0/0)
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "uses overriden error message" do
+      @model.errors.on(:output).should == [ 'Negative values or zero only, please' ]
+    end
+  end
+end

data/spec/public/resource_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+describe DataMapper::Resource do
+  before :all do
+    DataMapper::Validate::Fixtures::Barcode.auto_migrate!
+
+    @resource = DataMapper::Validate::Fixtures::Barcode.new
+  end
+
+  describe '#update' do
+    describe 'when provided valid attributes' do
+      before :all do
+        @response = @resource.update(:code => 'a' * 10)
+      end
+
+      it 'should return true' do
+        @response.should be_true
+      end
+    end
+
+    describe 'when provided invalid attributes' do
+      before :all do
+        @response = @resource.update(:code => 'a' * 11)
+      end
+
+      it 'should return false' do
+        @response.should be_false
+      end
+
+      it 'should set errors' do
+        @resource.errors.to_a.should == [ [ 'Code must be at most 10 characters long' ] ]
+      end
+    end
+
+    describe 'when provided invalid attributes and a context' do
+      before :all do
+        # remove data from previous spec runs
+        ::DataMapper::Validate::Fixtures::Organisation.all.destroy!
+        ::DataMapper::Validate::Fixtures::Department.all.destroy!
+        ::DataMapper::Validate::Fixtures::User.all.destroy!
+
+        organization = DataMapper::Validate::Fixtures::Organisation.create(:name => 'Org 101', :domain => '101')
+        dept         = DataMapper::Validate::Fixtures::Department.create(:name => 'accounting')
+
+        attributes = {
+          :organisation => organization,
+          :user_name    => 'guy',
+          :department   => dept,
+        }
+
+        # create a record that will be a dupe when User#update is executed below
+        DataMapper::Validate::Fixtures::User.create(attributes).should be_saved
+
+        @resource = DataMapper::Validate::Fixtures::User.new
+
+        @response = @resource.update(attributes, :signing_up_for_department_account)
+      end
+
+      it 'should return false' do
+        @response.should be_false
+      end
+
+      it 'should set errors' do
+        @resource.errors.to_a.should == [ [ 'User name is already taken' ] ]
+      end
+    end
+  end
+end

data/spec/spec.opts

@@ -1 +1,2 @@
 --colour
+--loadby random

data/spec/spec_helper.rb

@@ -1,10 +1,14 @@
-require 'pathname'
 require 'rubygems'
 
-gem 'rspec', '~>1.2'
-require 'spec'
+# use local dm-core if running from a typical dev checkout.
+lib = File.join('..', '..', 'dm-core', 'lib')
+$LOAD_PATH.unshift(lib) if File.directory?(lib)
+require 'dm-core'
 
-require Pathname(__FILE__).dirname.expand_path.parent + 'lib/dm-validations'
+# Support running specs with 'rake spec' and 'spec'
+$LOAD_PATH.unshift('lib') unless $LOAD_PATH.include?('lib')
+
+require 'dm-validations'
 
 def load_driver(name, default_uri)
   return false if ENV['ADAPTER'] != name.to_s
@@ -24,3 +28,7 @@ ENV['ADAPTER'] ||= 'sqlite3'
 HAS_SQLITE3  = load_driver(:sqlite3,  'sqlite3::memory:')
 HAS_MYSQL    = load_driver(:mysql,    'mysql://localhost/dm_core_test')
 HAS_POSTGRES = load_driver(:postgres, 'postgres://postgres@localhost/dm_core_test')
+
+ROOT = Pathname(__FILE__).dirname.parent
+Dir[ROOT / 'spec' / 'integration' / 'shared' / '**' / '*.rb'].each { |rb| require(rb) }
+Dir[ROOT / 'spec' / 'fixtures' / '**' / '*.rb'].each { |rb| require(rb) }

data/spec/unit/contextual_validators/emptiness_spec.rb

@@ -0,0 +1,50 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+require 'unit/contextual_validators/spec_helper'
+
+describe DataMapper::Validate::ContextualValidators do
+  before :all do
+    @model = DataMapper::Validate::ContextualValidators.new
+  end
+
+  describe "initially" do
+    it "is empty" do
+      @model.should be_empty
+    end
+  end
+
+
+  describe "after first reference to context" do
+    before :all do
+      @model.context(:create)
+    end
+
+    it "initializes list of validators for referred context" do
+      @model.context(:create).should be_empty
+    end
+  end
+
+
+  describe "after a context being added" do
+    before :all do
+      @model.context(:default) << DataMapper::Validate::RequiredFieldValidator.new(:toc, :when => [:publishing])
+    end
+
+    it "is no longer empty" do
+      @model.should_not be_empty
+    end
+  end
+
+
+  describe "when cleared" do
+    before :all do
+      @model.context(:default) << DataMapper::Validate::RequiredFieldValidator.new(:toc, :when => [:publishing])
+      @model.should_not be_empty
+      @model.clear!
+    end
+
+    it "becomes empty again" do
+      @model.should be_empty
+    end
+  end
+end

data/spec/unit/contextual_validators/execution_spec.rb

@@ -0,0 +1,55 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+require 'unit/contextual_validators/spec_helper'
+
+describe DataMapper::Validate::ContextualValidators do
+  before :all do
+    @model = DataMapper::Validate::ContextualValidators.new
+  end
+
+  describe "#execute(name, target)" do
+    before :each do
+      @validator_one = DataMapper::Validate::RequiredFieldValidator.new(:name)
+      @validator_two = DataMapper::Validate::WithinValidator.new(:operating_system, :set => ["Mac OS X", "Linux", "FreeBSD", "Solaris"])
+
+      @model.context(:default) << @validator_one << @validator_two
+    end
+
+    describe "when context was never referred to before" do
+      it "raises ArgumentError" do
+        lambda { @model.execute(:some_unknown_context, Object.new) }.
+          should raise_error(ArgumentError, /validation context some_unknown_context doesn't seem to be defined/)
+      end
+    end
+
+
+    describe "when target satisfies all validators" do
+      before :each do
+        @target = ::DataMapper::Validate::Fixtures::PieceOfSoftware.new(:name => 'gcc', :operating_system => "Mac OS X")
+        @validator_one.call(@target).should be_true
+        @validator_two.call(@target).should be_true
+
+        @result = @model.execute(:default, @target)
+      end
+
+      it "returns true" do
+        @result.should be_true
+      end
+    end
+
+
+    describe "when target does not satisfy all validators" do
+      before :each do
+        @target = ::DataMapper::Validate::Fixtures::PieceOfSoftware.new(:name => 'Skitch', :operating_system => "Haiku")
+        @validator_one.call(@target).should be_true
+        @validator_two.call(@target).should be_false
+
+        @result = @model.execute(:default, @target)
+      end
+
+      it "returns true" do
+        @result.should be_false
+      end
+    end # describe "when target does not satisfy all validators"
+  end # describe "#execute(name, target)"
+end # describe DataMapper::Validate::ContextualValidators

data/spec/unit/contextual_validators/spec_helper.rb

@@ -0,0 +1,37 @@
+# -*- coding: utf-8 -*-
+
+module DataMapper
+  module Validate
+    module Fixtures
+
+      class PieceOfSoftware
+        #
+        # Behaviors
+        #
+
+        include DataMapper::Validate
+
+        #
+        # Attributes
+        #
+
+        attr_accessor :name, :operating_system
+
+        #
+        # Validations
+        #
+
+        #
+        # API
+        #
+
+        def initialize(attributes = {})
+          attributes.each do |key, value|
+            self.send("#{key}=", value)
+          end
+        end
+      end
+
+    end # Fixtures
+  end # Validate
+end # DataMapper

data/spec/unit/generic_validator/equality_operator_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe DataMapper::Validate::GenericValidator do
+  describe "when types and fields are equal" do
+    it "returns true" do
+      DataMapper::Validate::RequiredFieldValidator.new(:name).
+        should == DataMapper::Validate::RequiredFieldValidator.new(:name)
+    end
+  end # describe "#==" do
+
+
+  describe "when types differ" do
+    it "returns false" do
+      DataMapper::Validate::RequiredFieldValidator.new(:name).
+        should_not == DataMapper::Validate::UniquenessValidator.new(:name)
+    end
+  end
+
+
+  describe "when property names differ" do
+    it "returns false" do
+      DataMapper::Validate::RequiredFieldValidator.new(:first_name).
+        should_not == DataMapper::Validate::RequiredFieldValidator.new(:last_name)
+    end
+  end
+end # describe DataMapper::Validate::GenericValidator

data/spec/unit/validation_errors/adding_spec.rb

@@ -0,0 +1,54 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe DataMapper::Validate::ValidationErrors do
+  before :all do
+    @model = DataMapper::Validate::ValidationErrors.new(Object.new)
+  end
+
+  describe "after first error being added" do
+    before :all do
+      @model.add(:property, "can't be valid, no way")
+    end
+
+    it "is no longer empty" do
+      @model.should_not be_empty
+    end
+
+    it "adds error message to list of errors for given property name" do
+      @model.on(:property).should == ["can't be valid, no way"]
+    end
+  end
+
+
+  describe "after second error being added" do
+    before :all do
+      @model.add(:property, "can't be valid, no way")
+      @model.add(:property, "something else is wrong")
+    end
+
+    it "is no longer empty" do
+      @model.should_not be_empty
+    end
+
+    it "appends error message to list of errors for given property name" do
+      @model.on(:property).should == ["can't be valid, no way", "something else is wrong"]
+    end
+  end
+
+
+  describe "when duplicate error being added" do
+    before :all do
+      @model.add(:property, "can't be valid, no way")
+      @model.add(:property, "can't be valid, no way")
+    end
+
+    it "is no longer empty" do
+      @model.should_not be_empty
+    end
+
+    it "DOES NOT allow duplication" do
+      @model.on(:property).should == ["can't be valid, no way"]
+    end
+  end
+end