dm-validations 0.9.11 → 0.10.0

data/spec/integration/required_field_validator/association_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   class Artist
@@ -16,7 +13,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
     # Properties
     #
 
-    property :id,   Integer, :serial => true
+    property :id,   Serial
     property :name, String,  :auto_validation => false
 
     #
@@ -43,7 +40,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
     # Properties
     #
 
-    property :id,        Integer, :serial => true
+    property :id,        Serial
     property :name,      String,  :auto_validation => false
     property :artist_id, Integer, :index => :artist
 
@@ -81,7 +78,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
 
       it 'has a meaninful error messages on association key property' do
         @album.valid?
-        @album.errors.on(:artist).should include("Artist must not be blank")
+        @album.errors.on(:artist).should == [ 'Artist must not be blank' ]
       end
     end
 

data/spec/integration/required_field_validator/boolean_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   # keep in mind any ScmOperation has a default value for brand property
@@ -39,13 +36,13 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
       it "is not valid for pushing" do
         @operation.should_not be_valid_for_pushing
         @operation.errors.on(:network_connection).
-          first[:pushing].should include("cannot push without network connectivity")
+          first[:pushing].should == 'though git is advanced, it cannot push without network connectivity'
       end
 
       it "is not valid for pulling" do
         @operation.should_not be_valid_for_pulling
         @operation.errors.on(:network_connection).
-          first[:pulling].should include("you must have network connectivity to pull from others")
+          first[:pulling].should == 'you must have network connectivity to pull from others'
       end
 
       it "is not valid in default context" do

data/spec/integration/required_field_validator/date_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   class Holiday
@@ -16,7 +13,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
     # Properties
     #
 
-    property :id, Integer, :serial          => true
+    property :id, Serial
     property :on, Date,    :auto_validation => false
 
     #

data/spec/integration/required_field_validator/datetime_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   class ScheduledOperation
@@ -16,7 +13,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
     # Properties
     #
 
-    property :id, Integer,  :serial          => true
+    property :id, Serial
     property :at, DateTime, :auto_validation => false
 
     #

data/spec/integration/required_field_validator/float_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   #
@@ -21,7 +18,7 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
     # Properties
     #
 
-    property :id,      Integer, :serial          => true
+    property :id,      Serial
     property :percent, Float,   :auto_validation => false
 
     #

data/spec/integration/required_field_validator/integer_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   #

data/spec/integration/required_field_validator/plain_old_ruby_object_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   describe "A plain old Ruby object (not a DM resource)" do
@@ -22,9 +19,9 @@ if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
 
     it "should fail validation with empty, nil, or blank fields" do
       @pc.should_not be_valid
-      @pc.errors.on(:empty).should    include("Empty must not be blank")
-      @pc.errors.on(:nil).should      include("Nil must not be blank")
-      @pc.errors.on(:accessor).should include("Accessor must not be blank")
+      @pc.errors.on(:empty).should    == [ 'Empty must not be blank' ]
+      @pc.errors.on(:nil).should      == [ 'Nil must not be blank' ]
+      @pc.errors.on(:accessor).should == [ 'Accessor must not be blank' ]
     end
 
     it "giving accessor a value should remove validation error" do

data/spec/integration/required_field_validator/shared_examples.rb

@@ -18,7 +18,7 @@ describe GitOperation do
     end
 
     it "points to blank name in the error message" do
-      @operation.errors.on(:name).should include('Name must not be blank')
+      @operation.errors.on(:name).should == [ 'Name must not be blank' ]
     end
   end
 end

data/spec/integration/required_field_validator/spec_helper.rb

@@ -1,68 +1,7 @@
-if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite
 
-  #
-  # SCMs
-  #
-  # This example may look stupid (I am sure it is),
-  # but it is way better than foobars and easier to read/add cases
-  # compared to gardening examples because every software engineer has idea
-  # about SCMs and not every software engineer does gardening often.
-  #
-
-  class ScmOperation
-    include DataMapper::Resource
-
-    #
-    # Property
-    #
-
-    property :id,                 Integer, :serial => true
-
-    # operation name
-    property :name,               String,  :auto_validation => false
-
-    property :committer_name,     String,  :auto_validation => false, :default => "Just another Ruby hacker"
-    property :author_name,        String,  :auto_validation => false, :default => "Just another Ruby hacker"
-    property :network_connection, Boolean, :auto_validation => false
-    property :message,            Text,    :auto_validation => false
-    property :clean_working_copy, Boolean, :auto_validation => false
-
-    #
-    # Validations
-    #
-
-    validates_present :name
-  end
-
-  class SubversionOperation < ScmOperation
-    #
-    # Validations
-    #
-
-    validates_present :network_connection, :when => [:committing, :log_viewing]
-  end
-
-  class GitOperation < ScmOperation
-    #
-    # Validations
-    #
-
-    validates_present :author_name,        :when => :committing
-    validates_present :committer_name,     :when => :committing
-
-    validates_present :message,            :when => :committing
-    validates_present :network_connection, :when => [:pushing, :pulling], :message => {
-      :pushing => "though git is advanced, it cannot push without network connectivity",
-      :pulling => "you must have network connectivity to pull from others"
-    }
-    validates_present :clean_working_copy, :when => :pulling
-  end
-
-
-  [ScmOperation, SubversionOperation, GitOperation].each do |dm_resource|
-    dm_resource.auto_migrate!
-  end
-
-  __dir__ = File.dirname(__FILE__)
-  require File.join(__dir__, "shared_examples")
-end
+require 'integration/required_field_validator/shared_examples'

data/spec/integration/required_field_validator/string_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   # keep in mind any ScmOperation has a default value for brand property

data/spec/integration/required_field_validator/text_type_value_spec.rb

@@ -1,8 +1,5 @@
-require 'pathname'
-__dir__ = Pathname(__FILE__).dirname.expand_path
-
-require __dir__.parent.parent + 'spec_helper'
-require __dir__ + 'spec_helper'
+require 'spec_helper'
+require 'integration/required_field_validator/spec_helper'
 
 if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
   # keep in mind any ScmOperation has a default value for brand property

data/spec/integration/shared/default_validation_context.rb

@@ -0,0 +1,13 @@
+describe "object invalid in default context", :shared => true do
+  it "is not valid in default context" do
+    @model.should_not be_valid
+    @model.should_not be_valid(:default)
+  end
+end
+
+describe "object valid in default context", :shared => true do
+  it "is valid in default context" do
+    @model.should be_valid
+    @model.should be_valid(:default)
+  end
+end

data/spec/integration/shared/valid_and_invalid_model.rb

@@ -0,0 +1,27 @@
+describe "valid model", :shared => true do
+  it "is valid" do
+    @model.should be_valid
+  end
+
+  it "has no error messages" do
+    @model.errors.should be_empty
+  end
+
+  it "has empty list of full error messages" do
+    @model.errors.full_messages.should be_empty
+  end
+end
+
+describe "invalid model", :shared => true do
+  it "is NOT valid" do
+    @model.should_not be_valid
+  end
+
+  it "has error messages" do
+    @model.errors.should_not be_blank
+  end
+
+  it "has list of full error messages" do
+    @model.errors.full_messages.should_not be_blank
+  end
+end

data/spec/integration/uniqueness_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/uniqueness_validator/uniqueness_validator_spec.rb

@@ -0,0 +1,114 @@
+require 'spec_helper'
+require 'integration/uniqueness_validator/spec_helper'
+
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  describe DataMapper::Validate::Fixtures::Department do
+    before :all do
+      ::DataMapper::Validate::Fixtures::Department.create(:name => "HR")
+    end
+
+    describe "with unique name" do
+      before :all do
+        @model = ::DataMapper::Validate::Fixtures::Department.new(:name => "R & D")
+      end
+
+      it_should_behave_like "valid model"
+    end
+
+    describe "with a duplicate name" do
+      before :all do
+        @model = ::DataMapper::Validate::Fixtures::Department.new(:name => "HR")
+      end
+
+      it_should_behave_like "invalid model"
+    end
+  end
+
+
+
+  describe DataMapper::Validate::Fixtures::Organisation do
+    before :all do
+       DataMapper.repository do
+         @model = ::DataMapper::Validate::Fixtures::Organisation.create(:name => 'Apple', :domain => 'apple.com')
+      end
+    end
+
+    describe "with missing domain" do
+      before :all do
+        @model.domain = nil
+      end
+
+      it_should_behave_like "valid model"
+    end
+
+    describe "with a duplicate domain" do
+      before :all do
+        @model.name   = "Fake Apple"
+        @model.domain = "apple.com"
+      end
+
+      it_should_behave_like "invalid model"
+
+      it "has a meaningful error message" do
+        @model.valid?
+        @model.errors.on(:domain).should == [ 'Domain is already taken' ]
+      end
+    end
+
+    it "shouldn't fail on itself when checking for records with identical fields" do
+      @model.name = "Steve Job's Pony Express"
+      @model.should be_valid
+    end
+  end
+
+
+
+  describe DataMapper::Validate::Fixtures::User do
+    before :all do
+      # remove data from previous spec runs
+      ::DataMapper::Validate::Fixtures::Organisation.all.destroy!
+      ::DataMapper::Validate::Fixtures::Department.all.destroy!
+      ::DataMapper::Validate::Fixtures::User.all.destroy!
+
+      DataMapper.repository do
+        @organization = ::DataMapper::Validate::Fixtures::Organisation.create(:name => 'Org 101', :domain => '101')
+        @dept         = ::DataMapper::Validate::Fixtures::Department.create(:name => 'accounting')
+        @user         = ::DataMapper::Validate::Fixtures::User.create(:organisation => @organization, :user_name => 'guy', :department => @dept)
+
+        @organization.should be_saved
+        @dept.should be_saved
+        @user.should be_saved
+      end
+    end
+
+    describe "with username not valid across the organization" do
+      before :all do
+        @model = ::DataMapper::Validate::Fixtures::User.new(:organisation => @organization, :user_name => 'guy')
+      end
+
+      it "is not valid for signing up" do
+        @model.should_not be_valid_for_signing_up_for_organization_account
+      end
+
+      it "has a meaningful error message" do
+        @model.errors.on(:user_name).should == [ 'User name is already taken' ]
+      end
+    end
+
+
+    describe "with username not valid across the department" do
+      before :all do
+        @model = ::DataMapper::Validate::Fixtures::User.new(:user_name => 'guy', :department => @dept)
+      end
+
+      it "is not valid for setting up the account" do
+        @model.should_not be_valid_for_signing_up_for_department_account
+      end
+
+      it "has a meaningful error message" do
+        @model.errors.on(:user_name).should == [ 'User name is already taken' ]
+      end
+    end
+  end # describe DataMapper::Validate::Fixtures::User
+end # if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES

data/spec/integration/within_validator/spec_helper.rb

@@ -0,0 +1,5 @@
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite