decidim-initiatives 0.16.1 → 0.17.0

data/app/commands/decidim/initiatives/validate_mobile_phone.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    # Command to check if mobile phone has an authorization and
+    # deliver sms code
+    class ValidateMobilePhone < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # form - A MobilePhoneForm.
+      # user - The user which mobile phone must be validated.
+      def initialize(form, user)
+        @form = form
+        @user = user
+      end
+
+      # Executes the command. Broadcasts these events:
+      #
+      # - :ok when everything is valid. Returns the verification metadata of
+      #       the form.
+      # - :invalid if the user doesn't have an authorization for sms in ok
+      #            status or the phone number associated with its
+      #            authorization doesn't match the form number.
+      def call
+        return broadcast(:invalid) unless authorized? && phone_match?
+
+        generate_code
+
+        broadcast(:ok, @verification_metadata)
+      end
+
+      private
+
+      def generate_code
+        @verification_metadata = @form.verification_metadata
+      end
+
+      def authorizer
+        return unless authorization
+
+        Decidim::Verifications::Adapter.from_element(authorization_name).authorize(authorization, {}, nil, nil)
+      end
+
+      def authorization
+        @authorization ||= Verifications::Authorizations.new(organization: @user.organization, user: @user, name: authorization_name).first
+      end
+
+      def authorization_name
+        "sms"
+      end
+
+      def authorized?
+        authorizer&.first == :ok
+      end
+
+      def phone_match?
+        authorization.unique_id == @form.unique_id
+      end
+    end
+  end
+end

data/app/commands/decidim/initiatives/validate_sms_code.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    # Command to check if sms code provided by user is valid
+    class ValidateSmsCode < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # form - form containing confirmation_code.
+      # verification_metadata - metadata containing the required code.
+      def initialize(form, verification_metadata)
+        @form = form
+        @verification_metadata = verification_metadata
+      end
+
+      # Executes the command. Broadcasts these events:
+      #
+      # - :ok when everithing is valid.
+      # - :invalid if verification_metadata is not present or the form code is
+      #            invalid.
+      #
+      # Returns nothing.
+      def call
+        return broadcast(:invalid) unless verification_metadata_valid? && valid_code?
+
+        broadcast(:ok)
+      end
+
+      private
+
+      def verification_metadata_valid?
+        @verification_metadata && @verification_metadata["verification_code"].present?
+      end
+
+      def valid_code?
+        @verification_metadata["verification_code"] == @form.verification_code
+      end
+    end
+  end
+end

data/app/commands/decidim/initiatives/vote_initiative.rb

@@ -6,13 +6,12 @@ module Decidim
     class VoteInitiative < Rectify::Command
       # Public: Initializes the command.
       #
-      # initiative   - A Decidim::Initiative object.
+      # form - A form object with the params.
       # current_user - The current user.
-      # group_id     - Decidim user group id
-      def initialize(initiative, current_user, group_id)
-        @initiative = initiative
+      def initialize(form, current_user)
+        @form = form
+        @initiative = form.initiative
         @current_user = current_user
-        @decidim_user_group_id = group_id
       end
 
       # Executes the command. Broadcasts these events:
@@ -22,8 +21,9 @@ module Decidim
       #
       # Returns nothing.
       def call
+        return broadcast(:invalid) if form.invalid?
         build_initiative_vote
-        return broadcast(:invalid) unless vote.valid?
+        set_vote_timestamp
 
         percentage_before = @initiative.percentage
         vote.save!
@@ -39,13 +39,29 @@ module Decidim
 
       private
 
+      attr_reader :form, :current_user
+
       def build_initiative_vote
         @vote = @initiative.votes.build(
           author: @current_user,
-          decidim_user_group_id: @decidim_user_group_id
+          decidim_user_group_id: form.group_id,
+          encrypted_metadata: form.encrypted_metadata,
+          hash_id: form.hash_id
         )
       end
 
+      def set_vote_timestamp
+        return unless timestamp_service
+
+        @vote.assign_attributes(
+          timestamp: timestamp_service.new(document: vote.encrypted_metadata).timestamp
+        )
+      end
+
+      def timestamp_service
+        @timestamp_service ||= Decidim.timestamp_service.to_s.safe_constantize
+      end
+
       def send_notification
         return if vote.user_group.present?
 

data/app/controllers/concerns/decidim/initiatives/needs_initiative.rb

@@ -13,7 +13,7 @@ module Decidim
         include NeedsOrganization
         include InitiativeSlug
 
-        helper_method :current_initiative
+        helper_method :current_initiative, :current_participatory_space, :signature_has_steps?
 
         # Public: Finds the current Initiative given this controller's
         # context.
@@ -25,6 +25,17 @@ module Decidim
 
         alias_method :current_participatory_space, :current_initiative
 
+        # Public: Wether the current initiative belongs to an initiative type
+        # which requires one or more step before creating a signature
+        #
+        # Returns nil if there is no current_initiative, true or false
+        def signature_has_steps?
+          return unless current_initiative
+
+          initiative_type = current_initiative.scoped_type.type
+          initiative_type.collect_user_extra_fields? || initiative_type.validate_sms_code_on_votes?
+        end
+
         private
 
         def detect_initiative

data/app/controllers/decidim/initiatives/admin/answers_controller.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    module Admin
+      # Controller used to manage the initiatives answers
+      class AnswersController < Decidim::Initiatives::Admin::ApplicationController
+        include Decidim::Initiatives::NeedsInitiative
+
+        helper Decidim::Initiatives::InitiativeHelper
+        layout "decidim/admin/initiatives"
+
+        # GET /admin/initiatives/:id/answer/edit
+        def edit
+          enforce_permission_to :answer, :initiative, initiative: current_initiative
+          @form = form(Decidim::Initiatives::Admin::InitiativeAnswerForm)
+                  .from_model(
+                    current_initiative,
+                    initiative: current_initiative
+                  )
+        end
+
+        # PUT /admin/initiatives/:id/answer
+        def update
+          enforce_permission_to :answer, :initiative, initiative: current_initiative
+
+          params[:id] = params[:slug]
+          @form = form(Decidim::Initiatives::Admin::InitiativeAnswerForm)
+                  .from_params(params, initiative: current_initiative)
+
+          UpdateInitiativeAnswer.call(current_initiative, @form, current_user) do
+            on(:ok) do
+              flash[:notice] = I18n.t("initiatives.update.success", scope: "decidim.initiatives.admin")
+              redirect_to initiatives_path
+            end
+
+            on(:invalid) do
+              flash.now[:alert] = I18n.t("initiatives.update.error", scope: "decidim.initiatives.admin")
+              render :edit
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/decidim/initiatives/admin/initiatives_controller.rb

@@ -74,7 +74,7 @@ module Decidim
 
           PublishInitiative.call(current_initiative, current_user) do
             on(:ok) do
-              redirect_to decidim_admin_initiatives.initiatives_path
+              redirect_to decidim_admin_initiatives.edit_initiative_path(current_initiative)
             end
           end
         end
@@ -85,7 +85,7 @@ module Decidim
 
           UnpublishInitiative.call(current_initiative, current_user) do
             on(:ok) do
-              redirect_to decidim_admin_initiatives.initiatives_path
+              redirect_to decidim_admin_initiatives.edit_initiative_path(current_initiative)
             end
           end
         end
@@ -94,21 +94,21 @@ module Decidim
         def discard
           enforce_permission_to :discard, :initiative, initiative: current_initiative
           current_initiative.discarded!
-          redirect_to decidim_admin_initiatives.initiatives_path
+          redirect_to decidim_admin_initiatives.edit_initiative_path(current_initiative)
         end
 
         # POST /admin/initiatives/:id/accept
         def accept
           enforce_permission_to :accept, :initiative, initiative: current_initiative
           current_initiative.accepted!
-          redirect_to decidim_admin_initiatives.initiatives_path
+          redirect_to decidim_admin_initiatives.edit_initiative_path(current_initiative)
         end
 
         # DELETE /admin/initiatives/:id/reject
         def reject
           enforce_permission_to :reject, :initiative, initiative: current_initiative
           current_initiative.rejected!
-          redirect_to decidim_admin_initiatives.initiatives_path
+          redirect_to decidim_admin_initiatives.edit_initiative_path(current_initiative)
         end
 
         # GET /admin/initiatives/:id/send_to_technical_validation
@@ -142,6 +142,32 @@ module Decidim
             format.csv { send_data csv_data, file_name: "votes.csv" }
           end
         end
+
+        # GET /admin/initiatives/:id/export_pdf_signatures.pdf
+        def export_pdf_signatures
+          enforce_permission_to :export_pdf_signatures, :initiative, initiative: current_initiative
+
+          @votes = current_initiative.votes.votes
+
+          output = render_to_string(
+            pdf: "votes_#{current_initiative.id}",
+            layout: "decidim/admin/initiatives_votes",
+            template: "decidim/initiatives/admin/initiatives/export_pdf_signatures.pdf.erb"
+          )
+          output = pdf_signature_service.new(pdf: output).signed_pdf if pdf_signature_service
+
+          respond_to do |format|
+            format.pdf do
+              send_data(output, filename: "votes_#{current_initiative.id}.pdf", type: "application/pdf")
+            end
+          end
+        end
+
+        private
+
+        def pdf_signature_service
+          @pdf_signature_service ||= Decidim.pdf_signature_service.to_s.safe_constantize
+        end
       end
     end
   end

data/app/controllers/decidim/initiatives/admin/initiatives_types_controller.rb

@@ -8,6 +8,7 @@ module Decidim
       # Controller used to manage the available initiative types for the current
       # organization.
       class InitiativesTypesController < Decidim::Initiatives::Admin::ApplicationController
+        helper ::Decidim::Admin::ResourcePermissionsHelper
         helper_method :current_initiative_type
 
         # GET /admin/initiatives_types

data/app/controllers/decidim/initiatives/admin/initiatives_types_permissions_controller.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    module Admin
+      # Controller that allows managing initiatives types
+      # permissions in the admin panel.
+      class InitiativesTypesPermissionsController < Decidim::Admin::ResourcePermissionsController
+        layout "decidim/admin/initiatives"
+
+        def permission_class_chain
+          [
+            Decidim::Initiatives::Permissions,
+            Decidim::Admin::Permissions
+          ]
+        end
+      end
+    end
+  end
+end

data/app/controllers/decidim/initiatives/admin/moderations_controller.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    module Admin
+      # This controller allows admins to manage moderations in an conference.
+      class ModerationsController < Decidim::Admin::ModerationsController
+        include InitiativeAdmin
+
+        def permissions_context
+          super.merge(current_participatory_space: current_participatory_space)
+        end
+      end
+    end
+  end
+end

data/app/controllers/decidim/initiatives/application_controller.rb

@@ -4,8 +4,6 @@ module Decidim
   module Initiatives
     # The main admin application controller for initiatives
     class ApplicationController < Decidim::ApplicationController
-      layout "decidim/admin/initiatives"
-
       include NeedsPermission
 
       def permissions_context

data/app/controllers/decidim/initiatives/authorization_sign_modals_controller.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Initiatives
+    class AuthorizationSignModalsController < Decidim::Initiatives::ApplicationController
+      include Decidim::Initiatives::NeedsInitiative
+
+      helper_method :authorizations, :authorize_action_path
+      layout false
+
+      def show
+        render template: "decidim/authorization_modals/show"
+      end
+
+      private
+
+      def authorize_action_path(handler_name)
+        authorizations.status_for(handler_name).current_path(redirect_url: URI(request.referer).path)
+      end
+
+      def authorizations
+        @authorizations ||= action_authorized_to("vote", resource: current_initiative, permissions_holder: current_initiative.type)
+      end
+    end
+  end
+end

data/app/controllers/decidim/initiatives/committee_requests_controller.rb

@@ -20,7 +20,10 @@ module Decidim
       def spawn
         enforce_permission_to :request_membership, :initiative, initiative: current_initiative
 
-        SpawnCommitteeRequest.call(current_initiative, current_user) do
+        form = Decidim::Initiatives::CommitteeMemberForm
+               .from_params(initiative_id: current_initiative.id, user_id: current_user.id, state: "requested")
+
+        SpawnCommitteeRequest.call(form, current_user) do
           on(:ok) do
             redirect_to initiatives_path, flash: {
               notice: I18n.t(

data/app/controllers/decidim/initiatives/create_initiative_controller.rb

@@ -29,7 +29,7 @@ module Decidim
 
       def show
         enforce_permission_to :create, :initiative
-        send("#{step}_step", initiative: session[:initiative])
+        send("#{step}_step", initiative: session_initiative)
       end
 
       def update
@@ -71,7 +71,9 @@ module Decidim
       end
 
       def promotal_committee_step(parameters)
-        if session[:initiative].has_key?(:id)
+        skip_step unless promotal_committee_required?
+
+        if session_initiative.has_key?(:id)
           render_wizard
           return
         end
@@ -108,7 +110,7 @@ module Decidim
       def build_form(klass, parameters)
         @form = form(klass).from_params(parameters)
         attributes = @form.attributes_with_values
-        session[:initiative] = session[:initiative].merge(attributes)
+        session[:initiative] = session_initiative.merge(attributes)
         @form.valid? if params[:validate_form]
 
         @form
@@ -119,13 +121,22 @@ module Decidim
       end
 
       def current_initiative
-        initiative = session[:initiative].with_indifferent_access
-        Initiative.find(initiative[:id]) if initiative.has_key?(:id)
+        Initiative.find(session_initiative[:id]) if session_initiative.has_key?(:id)
       end
 
       def initiative_type
         @initiative_type ||= InitiativesType.find(@form&.type_id)
       end
+
+      def session_initiative
+        session[:initiative]&.with_indifferent_access
+      end
+
+      def promotal_committee_required?
+        minimum_committee_members = InitiativesType.find(session_initiative[:type_id]).minimum_committee_members ||
+                                    Decidim::Initiatives.minimum_committee_members
+        minimum_committee_members.present? && minimum_committee_members.positive?
+      end
     end
   end
 end