decidim-core 0.30.1 → 0.31.0.rc1

data/app/commands/decidim/like_resource.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module Decidim
+  # A command with all the business logic related with a user liking a resource.
+  # This is a user creates and like.
+  class LikeResource < Decidim::Command
+    # Public: Initializes the command.
+    #
+    # resource     - An instance of Decidim::Likeable.
+    # current_user - The current user.
+    def initialize(resource, current_user)
+      @resource = resource
+      @current_user = current_user
+    end
+
+    # Executes the command. Broadcasts these events:
+    #
+    # - :ok when everything is valid, together with the resource vote.
+    # - :invalid if the form was not valid and we could not proceed.
+    #
+    # Returns nothing.
+    def call
+      like = build_resource_like
+      if like.save
+        notify_liker_followers
+        broadcast(:ok, like)
+      else
+        broadcast(:invalid)
+      end
+    rescue ActiveRecord::RecordNotUnique
+      broadcast(:invalid)
+    end
+
+    private
+
+    def build_resource_like
+      @resource.likes.build(author: @current_user)
+    end
+
+    def notify_liker_followers
+      Decidim::EventsManager.publish(
+        event: "decidim.events.resource_liked",
+        event_class: Decidim::ResourceLikedEvent,
+        resource: @resource,
+        followers: @current_user.followers,
+        extra: {
+          liker_id: @current_user.id
+        }
+      )
+    end
+  end
+end

data/app/commands/decidim/messaging/reply_to_conversation.rb

@@ -27,7 +27,6 @@ module Decidim
 
         if message.save
           notify_interlocutors
-          notify_comanagers if sender.is_a?(UserGroup)
 
           broadcast(:ok, message)
         else
@@ -49,28 +48,10 @@ module Decidim
         @already_notified = [form.context.current_user]
 
         conversation.interlocutors(sender).each do |recipient|
-          if recipient.is_a?(UserGroup)
-            recipient.managers.each do |manager|
-              notify(manager) do
-                ConversationMailer.new_group_message(sender, manager, conversation, message, recipient).deliver_later
-              end
-              Decidim::PushNotificationMessageSender.new.new_group_message(sender, manager, conversation, message, recipient).deliver
-            end
-          else
-            notify(recipient) do
-              ConversationMailer.new_message(sender, recipient, conversation, message).deliver_later
-            end
-            Decidim::PushNotificationMessageSender.new.new_message(sender, recipient, conversation, message).deliver
-          end
-        end
-      end
-
-      def notify_comanagers
-        sender.managers.each do |recipient|
           notify(recipient) do
-            ConversationMailer.comanagers_new_message(sender, recipient, conversation, message, form.context.current_user).deliver_later
+            ConversationMailer.new_message(sender, recipient, conversation, message).deliver_later
           end
-          Decidim::PushNotificationMessageSender.new.comanagers_new_message(sender, recipient, conversation, message, form.context.current_user).deliver
+          Decidim::PushNotificationMessageSender.new.new_message(sender, recipient, conversation, message).deliver
         end
       end
 

data/app/commands/decidim/messaging/start_conversation.rb

@@ -22,7 +22,6 @@ module Decidim
 
         if conversation.save
           notify_interlocutors
-          notify_comanagers if originator.is_a?(UserGroup)
 
           broadcast(:ok, conversation)
         else
@@ -49,28 +48,10 @@ module Decidim
         @already_notified = [form.context.current_user]
 
         conversation.interlocutors(originator).each do |recipient|
-          if recipient.is_a?(UserGroup)
-            recipient.managers.each do |manager|
-              notify(manager) do
-                ConversationMailer.new_group_conversation(originator, manager, conversation, recipient).deliver_later
-              end
-              Decidim::PushNotificationMessageSender.new.new_group_conversation(originator, manager, conversation, recipient).deliver
-            end
-          else
-            notify(recipient) do
-              ConversationMailer.new_conversation(originator, recipient, conversation).deliver_later
-            end
-            Decidim::PushNotificationMessageSender.new.new_conversation(originator, recipient, conversation).deliver
-          end
-        end
-      end
-
-      def notify_comanagers
-        originator.managers.each do |recipient|
           notify(recipient) do
-            ConversationMailer.comanagers_new_conversation(originator, recipient, conversation, form.context.current_user).deliver_later
+            ConversationMailer.new_conversation(originator, recipient, conversation).deliver_later
           end
-          Decidim::PushNotificationMessageSender.new.comanagers_new_conversation(originator, recipient, conversation, form.context.current_user).deliver
+          Decidim::PushNotificationMessageSender.new.new_conversation(originator, recipient, conversation).deliver
         end
       end
 

data/app/commands/decidim/unlike_resource.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module Decidim
+  # A command with all the business logic to unlike a resource.
+  class UnlikeResource < Decidim::Command
+    # Public: Initializes the command.
+    #
+    # resource     - A Decidim::Likeable object.
+    # current_user - The current user.
+    def initialize(resource, current_user)
+      @resource = resource
+      @current_user = current_user
+    end
+
+    # Executes the command. Broadcasts these events:
+    #
+    # - :ok when everything is valid, together with the resource.
+    # - :invalid if the form was not valid and we could not proceed.
+    #
+    # Returns nothing.
+    def call
+      destroy_resource_like
+      broadcast(:ok, @resource)
+    end
+
+    private
+
+    def destroy_resource_like
+      query = @resource.likes.where(author: @current_user)
+
+      query.destroy_all
+    end
+  end
+end

data/app/commands/decidim/update_account.rb

@@ -56,7 +56,7 @@ module Decidim
 
     def update_avatar
       if @form.avatar.present?
-        current_user.avatar.attach(@form.avatar)
+        current_user.avatar.attach(@form.avatar.signed_id)
       elsif @form.remove_avatar
         current_user.avatar = nil
       end

data/app/controllers/concerns/decidim/ephemeral_session_checker.rb

@@ -30,7 +30,7 @@ module Decidim
       if onboarding_manager.valid?
         authorizations = action_authorized_to(onboarding_manager.action, **onboarding_manager.action_authorized_resources)
 
-        return redirect_to decidim_verifications.onboarding_pending_authorizations_path unless authorizations_permitted_paths?(authorizations, onboarding_manager)
+        return redirect_to pending_authorizations_path unless authorizations_permitted_paths?(authorizations, onboarding_manager)
 
         if authorizations.global_code == :unauthorized
           flash[:alert] = t("unauthorized", scope: "decidim.core.actions")
@@ -77,11 +77,15 @@ module Decidim
                      []
                    end
       paths_list.prepend(
-        decidim_verifications.onboarding_pending_authorizations_path,
+        pending_authorizations_path,
         decidim.page_path(terms_of_service_page)
       )
 
       paths_list.find { |el| /\A#{URI.parse(el).path}/.match?(request.path) }
     end
+
+    def pending_authorizations_path
+      onboarding_manager.authorization_path || decidim_verifications.onboarding_pending_authorizations_path
+    end
   end
 end

data/app/controllers/concerns/decidim/user_profile.rb

@@ -10,7 +10,6 @@ module Decidim
   module UserProfile
     extend ActiveSupport::Concern
     include FormFactory
-    include UserGroups
     include HasAccountBreadcrumb
 
     included do

data/app/controllers/decidim/account_controller.rb

@@ -31,7 +31,7 @@ module Decidim
         on(:invalid) do |password|
           fetch_entered_password(password)
           flash[:alert] = t("account.update.error", scope: "decidim")
-          render action: :show
+          render action: :show, status: :unprocessable_entity
         end
       end
     end

data/app/controllers/decidim/amendments_controller.rb

@@ -6,7 +6,6 @@ module Decidim
     include FormFactory
     include HasSpecificBreadcrumb
     helper Decidim::ResourceReferenceHelper
-    helper UserGroupHelper
 
     before_action :authenticate_user!
     helper_method :amendment, :amendable, :emendation
@@ -39,7 +38,7 @@ module Decidim
 
         on(:invalid) do
           flash.now[:alert] = t("created.error", scope: "decidim.amendments")
-          render :new
+          render :new, status: :unprocessable_entity
         end
       end
     end
@@ -63,7 +62,7 @@ module Decidim
 
         on(:invalid) do
           flash.now[:alert] = t("error", scope: "decidim.amendments.update_draft")
-          render :edit_draft
+          render :edit_draft, status: :unprocessable_entity
         end
       end
     end
@@ -101,13 +100,13 @@ module Decidim
 
         on(:invalid) do
           flash.now[:alert] = t("error", scope: "decidim.amendments.publish_draft")
-          render :edit_draft
+          render :edit_draft, status: :unprocessable_entity
         end
       end
     end
 
     def reject
-      enforce_permission_to :reject, :amendment, current_component: amendable.component
+      enforce_permission_to :reject, :amendment, amendable:, current_component: amendable.component
 
       @form = form(Decidim::Amendable::RejectForm).from_model(amendment)
 
@@ -143,13 +142,13 @@ module Decidim
     end
 
     def review
-      enforce_permission_to :accept, :amendment, current_component: amendable.component
+      enforce_permission_to :accept, :amendment, amendable:, current_component: amendable.component
 
       @form = form(Decidim::Amendable::ReviewForm).from_params(params)
     end
 
     def accept
-      enforce_permission_to :accept, :amendment, current_component: amendable.component
+      enforce_permission_to :accept, :amendment, amendable:, current_component: amendable.component
 
       @form = form(Decidim::Amendable::ReviewForm).from_params(params)
 
@@ -161,7 +160,7 @@ module Decidim
 
         on(:invalid) do
           flash.now[:alert] = t("accepted.error", scope: "decidim.amendments")
-          render :review
+          render :review, status: :unprocessable_entity
         end
       end
     end

data/app/controllers/decidim/application_controller.rb

@@ -41,7 +41,6 @@ module Decidim
     helper Decidim::ViewHooksHelper
     helper Decidim::CardHelper
     helper Decidim::SanitizeHelper
-    helper Decidim::TwitterSearchHelper
     helper Decidim::SocialShareButtonHelper
     helper Decidim::FiltersHelper
     helper Decidim::OnboardingActionHelper
@@ -68,6 +67,8 @@ module Decidim
 
     private
 
+    def allow_browser(**); end
+
     # This overrides Devise's method for extracting the path from the URL. We
     # want to ensure the path to be stored in the cookie is not too long in
     # order to avoid ActionDispatch::Cookies::CookieOverflow exception. If the

data/app/controllers/decidim/devise/confirmations_controller.rb

@@ -7,8 +7,6 @@ module Decidim
       include Decidim::DeviseControllers
       include Decidim::OnboardingActionMethods
 
-      helper_method :new_user_group_session_path
-
       def create
         super do |resource|
           resource.errors.delete(:decidim_organization_id) if resource.errors.any?
@@ -28,10 +26,7 @@ module Decidim
         super.merge(decidim_organization_id: current_organization.id)
       end
 
-      # Overwrites the default method to handle user groups confirmations.
       def after_confirmation_path_for(resource_name, resource)
-        return profile_path(resource.nickname) if resource_name == :user_group
-
         sign_in(resource)
 
         store_onboarding_cookie_data!(resource)

data/app/controllers/decidim/devise/omniauth_registrations_controller.rb

@@ -34,7 +34,7 @@ module Decidim
 
           on(:invalid) do
             set_flash_message :notice, :success, kind: @form.provider.capitalize
-            render :new
+            render :new, status: :unprocessable_entity
           end
 
           on(:add_tos_errors) do

data/app/controllers/decidim/devise/passwords_controller.rb

@@ -36,7 +36,7 @@ module Decidim
           on(:invalid) do
             flash.now[:alert] = t("passwords.update.error", scope: "decidim")
             resource.errors.errors.concat(@form.errors.errors)
-            render action: "edit"
+            render action: "edit", status: :unprocessable_entity
           end
         end
       end

data/app/controllers/decidim/devise/registrations_controller.rb

@@ -40,7 +40,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = t("error", scope: "decidim.devise.registrations.create")
-            render :new
+            render :new, status: :unprocessable_entity
           end
         end
       end

data/app/controllers/decidim/doorkeeper/authorizations_controller.rb

@@ -6,7 +6,18 @@ module Decidim
     class AuthorizationsController < ::Doorkeeper::AuthorizationsController
       include HasSpecificBreadcrumb
 
-      helper_method :oauth_application
+      helper_method :oauth_application, :all_abilities?
+
+      def new
+        @scopes =
+          if pre_auth.authorizable?
+            pre_auth.scopes
+          else
+            []
+          end
+
+        super
+      end
 
       def oauth_application
         @oauth_application ||= Decidim::OAuthApplication.find_by(uid: params[:client_id])
@@ -18,6 +29,13 @@ module Decidim
           active: true
         }
       end
+
+      private
+
+      def all_abilities?
+        %w(api:read api:write).all? { |scope| @scopes.include?(scope) } &&
+          %w(profile user).any? { |scope| @scopes.include?(scope) }
+      end
     end
   end
 end

data/app/controllers/decidim/download_your_data_controller.rb

@@ -10,7 +10,6 @@ module Decidim
 
     helper_method :help_definitions
 
-    # i18n-tasks-use t('decidim.download_your_data.show.answers')
     # i18n-tasks-use t('decidim.download_your_data.show.assemblies')
     # i18n-tasks-use t('decidim.download_your_data.show.debate_comments')
     # i18n-tasks-use t('decidim.download_your_data.show.debates')
@@ -21,9 +20,10 @@ module Decidim
     # i18n-tasks-use t('decidim.download_your_data.show.projects')
     # i18n-tasks-use t('decidim.download_your_data.show.proposal_comments')
     # i18n-tasks-use t('decidim.download_your_data.show.proposals')
+    # i18n-tasks-use t('decidim.download_your_data.show.responses')
     # i18n-tasks-use t('decidim.download_your_data.show.result_comments')
     # i18n-tasks-use t('decidim.download_your_data.show.results')
-    # i18n-tasks-use t('decidim.download_your_data.show.survey_user_answers')
+    # i18n-tasks-use t('decidim.download_your_data.show.survey_user_responses')
     def show
       enforce_permission_to(:show, :user, current_user:)
 

data/app/controllers/decidim/likes_controller.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module Decidim
+  # Exposes the `Likes` so that users can like resources.
+  class LikesController < Decidim::Components::BaseController
+    # we need to +include+ to be able to call :like_button from the view
+    include Decidim::LikeableHelper
+    helper_method :like_button
+    # we need to declare with +helper+ to be able to call :render_like_identity from the views
+    helper Decidim::LikeableHelper
+    helper_method :resource
+
+    before_action :authenticate_user!
+
+    def create
+      enforce_permission_to(:create, :like, resource:)
+
+      LikeResource.call(resource, current_user) do
+        on(:ok) do
+          resource.reload
+          render :update_buttons_and_counters
+        end
+
+        on(:invalid) do
+          render json: { error: I18n.t("resource_likes.create.error", scope: "decidim") }, status: :unprocessable_entity
+        end
+      end
+    end
+
+    def destroy
+      enforce_permission_to(:withdraw, :like, resource:)
+
+      UnlikeResource.call(resource, current_user) do
+        on(:ok) do
+          resource.reload
+          render :update_buttons_and_counters
+        end
+      end
+    end
+
+    # should be pubic in order to be visible in NeedsPermission#permissions_context
+    def current_component
+      resource.component
+    end
+
+    private
+
+    def resource
+      gid_param = params[:id] || params[:resource_id]
+      @resource ||= GlobalID::Locator.locate(GlobalID.parse(gid_param))
+    end
+
+    def current_participatory_space
+      current_component.participatory_space
+    end
+  end
+end

data/app/controllers/decidim/links_controller.rb

@@ -10,6 +10,7 @@ module Decidim
     helper_method :external_url
 
     before_action :parse_url
+
     rescue_from Decidim::InvalidUrlError, with: :modal
     rescue_from URI::InvalidURIError, with: :modal
 

data/app/controllers/decidim/messaging/conversations_controller.rb

@@ -14,7 +14,7 @@ module Decidim
 
       before_action :authenticate_user!
 
-      helper_method :conversation, :user_grouped_messages, :sender_is_user?, :user_groups, :validation_messages
+      helper_method :conversation, :user_grouped_messages, :sender_is_user?, :validation_messages
 
       # Shows the form to initiate a conversation with an user (the recipient)
       # recipient is passed via GET parameter:
@@ -102,13 +102,6 @@ module Decidim
 
       private
 
-      # deprecated
-      def user_groups
-        return [] unless current_organization.user_groups_enabled?
-
-        current_user.manageable_user_groups
-      end
-
       def validation_messages
         @validation_messages ||= []
       end

data/app/controllers/decidim/newsletters_controller.rb

@@ -34,7 +34,7 @@ module Decidim
 
           on(:invalid) do
             flash.now[:alert] = t("newsletters.unsubscribe.error", scope: "decidim")
-            render action: :unsubscribe
+            render action: :unsubscribe, status: :unprocessable_entity
           end
         end
       else

data/app/controllers/decidim/notifications_settings_controller.rb

@@ -17,14 +17,14 @@ module Decidim
       UpdateNotificationsSettings.call(@notifications_settings) do
         on(:ok) do
           flash.now[:notice] = t("notifications_settings.update.success", scope: "decidim")
+          render action: :show
         end
 
         on(:invalid) do
           flash.now[:alert] = t("notifications_settings.update.error", scope: "decidim")
+          render action: :show, status: :unprocessable_entity
         end
       end
-
-      render action: :show
     end
   end
 end

data/app/controllers/decidim/pages_controller.rb

@@ -6,7 +6,6 @@ module Decidim
     layout "layouts/decidim/application"
 
     helper_method :page, :pages, :page_content_blocks
-    helper CtaButtonHelper
     helper Decidim::SanitizeHelper
 
     before_action :legacy_redirect, :set_default_request_format

data/app/controllers/decidim/profiles_controller.rb

@@ -4,11 +4,7 @@ module Decidim
   # The controller to handle the user's public profile page.
   #
   # i18n-tasks-use t('decidim.profiles.show.badges')
-  # i18n-tasks-use t('decidim.profiles.show.groups')
-  # i18n-tasks-use t('decidim.profiles.show.group_admins')
-  # i18n-tasks-use t('decidim.profiles.show.group_members')
   class ProfilesController < Decidim::ApplicationController
-    include UserGroups
     include Flaggable
     include HasProfileBreadcrumb
 
@@ -17,20 +13,13 @@ module Decidim
     helper_method :profile_holder, :active_content, :context_menu
 
     before_action :ensure_profile_holder
-    before_action :ensure_profile_holder_is_a_group, only: [:members]
-    before_action :ensure_profile_holder_is_a_user, only: [:groups, :following]
+    before_action :ensure_profile_holder_is_a_user, only: :following
     before_action :ensure_user_not_blocked
 
     def show
-      return redirect_to profile_members_path if profile_holder.is_a?(Decidim::UserGroup)
-
       redirect_to profile_activity_path(nickname: params[:nickname].downcase)
     end
 
-    def tooltip
-      render json: { data: cell("decidim/author", profile_holder.presenter).profile_minicard }
-    end
-
     def following
       @content_cell = "decidim/following"
       @title_key = "following"
@@ -49,46 +38,6 @@ module Decidim
       render :show
     end
 
-    def groups
-      enforce_user_groups_enabled
-
-      @content_cell = "decidim/groups"
-      @title_key = "groups"
-      render :show
-    end
-
-    def members
-      enforce_user_groups_enabled
-
-      @content_cell = "decidim/members"
-      @title_key = "members"
-      render :show
-    end
-
-    def group_admins
-      enforce_permission_to :manage, :user_group, user_group: profile_holder
-
-      @content_cell = "decidim/group_admins"
-      @title_key = "group_admins"
-      render :show
-    end
-
-    def group_members
-      enforce_permission_to :manage, :user_group, user_group: profile_holder
-
-      @content_cell = "decidim/group_members"
-      @title_key = "group_members"
-      render :show
-    end
-
-    def group_invites
-      enforce_permission_to :manage, :user_group, user_group: profile_holder
-
-      @content_cell = "decidim/group_invites"
-      @title_key = "group_invites"
-      render :show
-    end
-
     def activity
       @content_cell = "decidim/user_activity"
       @title_key = "activity"
@@ -101,16 +50,12 @@ module Decidim
       raise ActionController::RoutingError, "Blocked User" if profile_holder&.blocked? && !current_user&.admin?
     end
 
-    def ensure_profile_holder_is_a_group
-      raise ActionController::RoutingError, "No user group with the given nickname" unless profile_holder.is_a?(Decidim::UserGroup)
-    end
-
     def ensure_profile_holder_is_a_user
       raise ActionController::RoutingError, "No user with the given nickname" unless profile_holder.is_a?(Decidim::User)
     end
 
     def ensure_profile_holder
-      raise ActionController::RoutingError, "No user or user group with the given nickname" if !profile_holder || profile_holder.nickname.blank?
+      raise ActionController::RoutingError, "No user with the given nickname" if !profile_holder || profile_holder.nickname.blank?
     end
 
     def profile_holder