decidim-admin 0.21.0 → 0.23.2

data/app/controllers/decidim/admin/newsletters_controller.rb

@@ -7,7 +7,7 @@ module Decidim
       include Decidim::NewslettersHelper
       include Decidim::Admin::NewslettersHelper
       include Paginable
-      helper_method :newsletter, :recipients_count_query
+      helper_method :newsletter, :recipients_count_query, :content_block
 
       def index
         enforce_permission_to :index, :newsletter
@@ -17,7 +17,7 @@ module Decidim
 
       def new
         enforce_permission_to :create, :newsletter
-        @form = form(NewsletterForm).instance
+        @form = form(NewsletterForm).from_model(content_block)
       end
 
       def show
@@ -36,8 +36,9 @@ module Decidim
       def create
         enforce_permission_to :create, :newsletter
         @form = form(NewsletterForm).from_params(params)
+        @form.images = images_block_context unless has_images_block_context?
 
-        CreateNewsletter.call(@form, current_user) do
+        CreateNewsletter.call(@form, content_block, current_user) do
           on(:ok) do |newsletter|
             flash.now[:notice] = I18n.t("newsletters.create.success", scope: "decidim.admin")
             redirect_to action: :show, id: newsletter.id
@@ -53,12 +54,13 @@ module Decidim
 
       def edit
         enforce_permission_to :update, :newsletter, newsletter: newsletter
-        @form = form(NewsletterForm).from_model(newsletter)
+        @form = form(NewsletterForm).from_model(content_block)
       end
 
       def update
         enforce_permission_to :update, :newsletter, newsletter: newsletter
         @form = form(NewsletterForm).from_params(params)
+        @form.images = images_block_context unless has_images_block_context?
 
         UpdateNewsletter.call(newsletter, @form, current_user) do
           on(:ok) do |newsletter|
@@ -138,6 +140,32 @@ module Decidim
         @form ||= form(SelectiveNewsletterForm).instance
         NewsletterRecipients.for(@form).size
       end
+
+      def content_block
+        @content_block ||= content_block_for_newsletter || content_block_from_manifest
+      end
+
+      def content_block_from_manifest
+        Decidim::ContentBlock.new(
+          organization: current_organization,
+          scope_name: :newsletter_template,
+          manifest_name: params[:newsletter_template_id]
+        )
+      end
+
+      def content_block_for_newsletter
+        return nil unless @newsletter
+
+        @content_block_for_newsletter ||= @newsletter.template
+      end
+
+      def images_block_context
+        form(NewsletterForm).from_model(content_block).images
+      end
+
+      def has_images_block_context?
+        @form.images && @form.valid?
+      end
     end
   end
 end

data/app/controllers/decidim/admin/officializations_controller.rb

@@ -49,6 +49,14 @@ module Decidim
         end
       end
 
+      def show_email
+        enforce_permission_to :show_email, :user, user: user
+
+        Decidim.traceability.perform_action! :show_email, user, current_user
+
+        render :show_email, layout: false
+      end
+
       private
 
       def collection

data/app/controllers/decidim/admin/organization_appearance_controller.rb

@@ -5,6 +5,7 @@ module Decidim
     # Controller that allows managing the appearance of the organization.
     class OrganizationAppearanceController < Decidim::Admin::ApplicationController
       layout "decidim/admin/settings"
+      helper Decidim::Admin::UploaderImageDimensionsHelper
 
       def edit
         enforce_permission_to :update, :organization, organization: current_organization

data/app/controllers/decidim/admin/organization_controller.rb

@@ -37,10 +37,11 @@ module Decidim
               query = if term.start_with?("@")
                         query.where("nickname ILIKE ?", "#{term.delete("@")}%")
                       else
-                        query.where("name ILIKE ?", "%#{term}%")
+                        query.where("name ILIKE ?", "%#{term}%").or(
+                          query.where("email ILIKE ?", "%#{term}%")
+                        )
                       end
-
-              render json: query.all.collect { |u| { value: u.id, label: "#{u.name} (@#{u.nickname})" } }
+              render json: query.all.collect { |u| { value: u.id, label: "#{u.name} (@#{u.nickname}) #{u.email}" } }
             else
               render json: []
             end

data/app/controllers/decidim/admin/organization_homepage_content_blocks_controller.rb

@@ -22,6 +22,7 @@ module Decidim
             redirect_to edit_organization_homepage_path
           end
           on(:invalid) do
+            edit # Sets the model to the view so that it can render the form
             render :edit
           end
         end
@@ -55,7 +56,7 @@ module Decidim
       def content_block_from_manifest
         Decidim::ContentBlock.create!(
           organization: current_organization,
-          scope: :homepage,
+          scope_name: :homepage,
           manifest_name: params[:id]
         )
       end

data/app/controllers/decidim/admin/share_tokens_controller.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    class ShareTokensController < Decidim::Admin::ApplicationController
+      def destroy
+        enforce_permission_to :destroy, :share_token, share_token: share_token
+
+        DestroyShareToken.call(share_token, current_user) do
+          on(:ok) do
+            flash[:notice] = I18n.t("share_tokens.destroy.success", scope: "decidim.admin")
+          end
+          on(:invalid) do
+            flash[:error] = I18n.t("share_tokens.destroy.error", scope: "decidim.admin")
+          end
+        end
+
+        redirect_back(fallback_location: root_path)
+      end
+
+      private
+
+      def share_token
+        @share_token ||= Decidim::ShareToken.where(
+          organization: current_organization
+        ).find(params[:id])
+      end
+    end
+  end
+end

data/app/forms/decidim/admin/attachment_form.rb

@@ -16,12 +16,15 @@ module Decidim
       mimic :attachment
 
       validates :file, presence: true, unless: :persisted?
+      validates :file, passthru: { to: Decidim::Attachment }
       validates :title, :description, translatable_presence: true
       validates :attachment_collection, presence: true, if: ->(form) { form.attachment_collection_id.present? }
       validates :attachment_collection_id, inclusion: { in: :attachment_collection_ids }, allow_blank: true
 
       delegate :attached_to, to: :context, prefix: false
 
+      alias organization current_organization
+
       def attachment_collections
         @attachment_collections ||= attached_to.attachment_collections
       end

data/app/forms/decidim/admin/component_form.rb

@@ -23,8 +23,7 @@ module Decidim
       attribute :default_step_settings, Object
       attribute :step_settings, Hash[String => Object]
 
-      validate :must_be_able_to_change_participatory_texts_setting
-      validate :amendments_visibility_options_must_be_valid
+      attribute :share_tokens, Array[ShareToken]
 
       def settings?
         settings.manifest.attributes.any?
@@ -34,6 +33,10 @@ module Decidim
         default_step_settings.manifest.attributes.any?
       end
 
+      def map_model(model)
+        self.share_tokens = model.share_tokens
+      end
+
       private
 
       # Overwrites Rectify::Form#form_attributes_valid? to validate nested `step_settings` attributes.
@@ -54,26 +57,6 @@ module Decidim
                        end
         validations.all?
       end
-
-      # Validates setting `participatory_texts_enabled` is not changed when there are proposals for the component.
-      def must_be_able_to_change_participatory_texts_setting
-        return unless manifest&.name == :proposals && (component = Component.find_by(id: id))
-        return unless settings.participatory_texts_enabled != component.settings.participatory_texts_enabled
-
-        settings.errors.add(:participatory_texts_enabled) if Decidim::Proposals::Proposal.where(component: component).any?
-      end
-
-      # Validates setting `amendments_visibility` is included in Decidim::Amendment::VisibilityStepSetting.options.
-      def amendments_visibility_options_must_be_valid
-        return unless manifest&.name == :proposals && settings.amendments_enabled
-
-        visibility_options = Decidim::Amendment::VisibilityStepSetting.options.map(&:last)
-        step_settings.each do |step, settings|
-          next unless visibility_options.exclude? settings[:amendments_visibility]
-
-          step_settings[step].errors.add(:amendments_visibility, :inclusion)
-        end
-      end
     end
   end
 end

data/app/forms/decidim/admin/newsletter_form.rb

@@ -3,14 +3,26 @@
 module Decidim
   module Admin
     # The form that validates the data to construct a valid Newsletter.
-    class NewsletterForm < Decidim::Form
+    class NewsletterForm < ContentBlockForm
       mimic :newsletter
 
       include TranslatableAttributes
 
       translatable_attribute :subject, String
-      translatable_attribute :body, String
-      validates :subject, :body, translatable_presence: true
+      validates :subject, translatable_presence: true
+
+      def map_model(content_block)
+        super(content_block)
+        self.subject = newsletter_for(content_block).try(:subject)
+      end
+
+      private
+
+      def newsletter_for(content_block)
+        Decidim::Newsletter
+          .where(organization: content_block.organization)
+          .find_by(id: content_block.scoped_resource_id)
+      end
     end
   end
 end

data/app/forms/decidim/admin/organization_appearance_form.rb

@@ -7,6 +7,7 @@ module Decidim
     #
     class OrganizationAppearanceForm < Form
       include TranslatableAttributes
+      include Decidim::HasUploadValidations
 
       mimic :organization
 
@@ -34,6 +35,8 @@ module Decidim
       attribute :success_color, String, default: "#57d685"
       attribute :warning_color, String, default: "#ffae00"
       attribute :alert_color, String, default: "#ec5840"
+      attribute :highlight_color, String, default: "#be6400"
+      attribute :highlight_alternative_color, String, default: "#ff5731"
 
       translatable_attribute :cta_button_text, String
       translatable_attribute :description, String
@@ -48,14 +51,12 @@ module Decidim
       validates :official_img_header,
                 :official_img_footer,
                 :logo,
-                file_size: { less_than_or_equal_to: ->(_record) { Decidim.maximum_attachment_size } },
-                file_content_type: { allow: ["image/jpeg", "image/png"] }
+                passthru: { to: Decidim::Organization }
 
       validates :highlighted_content_banner_action_url, presence: true, if: :highlighted_content_banner_enabled?
       validates :highlighted_content_banner_image,
                 presence: true,
-                file_size: { less_than_or_equal_to: ->(_record) { Decidim.maximum_attachment_size } },
-                file_content_type: { allow: ["image/jpeg", "image/png"] },
+                passthru: { to: Decidim::Organization },
                 if: :highlighted_content_banner_image_is_changed?
 
       validates :highlighted_content_banner_title,
@@ -74,6 +75,8 @@ module Decidim
       validates :omnipresent_banner_title, translatable_presence: true, if: :enable_omnipresent_banner?
       validates :omnipresent_banner_short_description, translatable_presence: true, if: :enable_omnipresent_banner?
 
+      alias organization current_organization
+
       private
 
       def highlighted_content_banner_enabled?

data/app/forms/decidim/admin/organization_form.rb

@@ -21,7 +21,10 @@ module Decidim
       attribute :default_locale, String
       attribute :badges_enabled, Boolean
       attribute :user_groups_enabled, Boolean
+      attribute :comments_max_length, Integer
       attribute :rich_text_editor_in_public_views, Boolean
+      attribute :enable_machine_translations, Boolean
+      attribute :machine_translation_display_priority, String
 
       attribute :send_welcome_notification, Boolean
       attribute :customize_welcome_notification, Boolean
@@ -39,12 +42,29 @@ module Decidim
       validates :default_locale, :reference_prefix, presence: true
       validates :default_locale, inclusion: { in: :available_locales }
       validates :admin_terms_of_use_body, translatable_presence: true
+      validates :comments_max_length, numericality: { greater_than: 0 }, if: ->(form) { form.comments_max_length.present? }
+      validates :machine_translation_display_priority,
+                inclusion: { in: Decidim::Organization::AVAILABLE_MACHINE_TRANSLATION_DISPLAY_PRIORITIES },
+                if: :machine_translation_enabled?
+
+      def machine_translation_priorities
+        Decidim::Organization::AVAILABLE_MACHINE_TRANSLATION_DISPLAY_PRIORITIES.map do |priority|
+          [
+            priority,
+            I18n.t("activemodel.attributes.organization.machine_translation_display_priority_#{priority}")
+          ]
+        end
+      end
 
       private
 
       def available_locales
         current_organization.available_locales
       end
+
+      def machine_translation_enabled?
+        Decidim.config.enable_machine_translations
+      end
     end
   end
 end

data/app/forms/decidim/admin/participatory_space_private_user_csv_import_form.rb

@@ -1,13 +1,26 @@
 # frozen_string_literal: true
 
+require "csv"
+
 module Decidim
   module Admin
     # A form object used to upload CSV to batch participatory space private users.
     #
     class ParticipatorySpacePrivateUserCsvImportForm < Form
       attribute :file
+      attribute :user_name, String
+      attribute :email, String
 
       validates :file, presence: true
+      validate :validate_csv
+
+      def validate_csv
+        return if file.blank?
+
+        CSV.foreach(file.path) do |_email, user_name|
+          errors.add(:user_name, :invalid) unless user_name.match?(UserBaseEntity::REGEXP_NAME)
+        end
+      end
     end
   end
 end

data/app/forms/decidim/admin/participatory_space_private_user_form.rb

@@ -11,8 +11,9 @@ module Decidim
       attribute :name, String
       attribute :email, String
 
-      validates :email, presence: true
-      validates :name, presence: true
+      validates :name, :email, presence: true
+
+      validates :name, format: { with: UserBaseEntity::REGEXP_NAME }
     end
   end
 end

data/app/forms/decidim/admin/selective_newsletter_form.rb

@@ -24,6 +24,12 @@ module Decidim
         end
       end
 
+      # Make sure the empty scope is not passed because then some logic could
+      # assume erroneously that some scope is selected.
+      def scope_ids
+        super.select(&:presence)
+      end
+
       private
 
       def at_least_one_participatory_space_selected

data/app/frontend/components/autocomplete.component.test.tsx

@@ -11,9 +11,10 @@ describe("<Autocomplete />", () => {
   const noResultsText = "No results found";
   const searchPromptText = "Type to search";
   const searchURL = "/some/url";
+  const changeURL = "/some/other/url";
 
   it("renders a div of Select", () => {
-    const wrapper = shallow(<Autocomplete name={name} selected={selected} options={options} noResultsText={noResultsText} placeholder={placeholder} searchPromptText={searchPromptText} searchURL={searchURL} />);
+    const wrapper = shallow(<Autocomplete name={name} selected={selected} options={options} noResultsText={noResultsText} placeholder={placeholder} searchPromptText={searchPromptText} searchURL={searchURL} changeURL={changeURL} />);
     expect(wrapper.find(".autocomplete-field").exists()).toBeTruthy();
   });
 });

data/app/frontend/components/autocomplete.component.tsx

@@ -43,6 +43,10 @@ export interface AutocompleteProps {
    * The URL where fetch content
    */
   searchURL: string;
+  /**
+   * The URL to call when selected option changes
+   */
+  changeURL: string;
 }
 
 interface AutocompleteState {
@@ -112,6 +116,31 @@ export class Autocomplete extends React.Component<AutocompleteProps, Autocomplet
 
   private handleChange = (selectedOption: any) => {
     this.setState({ selectedOption });
+
+    if (this.props.changeURL) {
+      axios.get(this.props.changeURL, {
+        headers: {
+          Accept: "text/javascript"
+        },
+        withCredentials: true,
+        params: {
+          id: selectedOption.value
+        }
+      })
+      .then((response) => {
+        const script = document.createElement("script");
+        script.type = "text/javascript";
+        script.innerHTML = response.data;
+        document.getElementsByTagName("head")[0].appendChild(script);
+      })
+      .catch((error: any) => {
+        if (axios.isCancel(error)) {
+          // console.log("Request canceled", error.message);
+        } else {
+          //
+        }
+      });
+    }
   }
 
   private filterOptions = (options: any, filter: any, excludeOptions: any) => {