decidim-admin 0.21.0 → 0.23.2

data/app/commands/decidim/admin/destroy_share_token.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A command with all the business logic to destroy a share token.
+    class DestroyShareToken < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # share_token - The share_token to destroy
+      # current_user - the user performing the action
+      def initialize(share_token, current_user)
+        @share_token = share_token
+        @current_user = current_user
+      end
+
+      # Executes the command. Broadcasts these events:
+      #
+      # - :ok when everything is valid.
+      # - :invalid if the form wasn't valid and we couldn't proceed.
+      #
+      # Returns nothing.
+      def call
+        begin
+          destroy_share_token
+        rescue StandardError
+          broadcast(:invalid)
+        end
+        broadcast(:ok)
+      end
+
+      private
+
+      attr_reader :current_user
+
+      def destroy_share_token
+        Decidim.traceability.perform_action!(
+          "delete",
+          @share_token,
+          current_user
+        ) do
+          @share_token.destroy!
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/reorder_content_blocks.rb

@@ -77,7 +77,7 @@ module Decidim
       def create_content_block(manifest_name, weight)
         Decidim::ContentBlock.create!(
           organization: organization,
-          scope: scope,
+          scope_name: scope,
           weight: weight,
           manifest_name: manifest_name
         )

data/app/commands/decidim/admin/update_component.rb

@@ -33,13 +33,15 @@ module Decidim
       private
 
       def update_component
-        @previous_settings = @component.attributes["settings"].dup
-
+        @previous_settings = @component.attributes["settings"].with_indifferent_access
         @component.name = form.name
+        @component.weight = form.weight
+
+        restore_readonly_settings!
+
         @component.settings = form.settings
         @component.default_step_settings = form.default_step_settings
         @component.step_settings = form.step_settings
-        @component.weight = form.weight
 
         @settings_changed = @component.settings_changed?
 
@@ -57,6 +59,28 @@ module Decidim
       def current_settings
         @component.attributes["settings"]
       end
+
+      # Keep previous values for readonly settings
+      def restore_readonly_settings!
+        browse_readonly_settings("global") do |attribute|
+          form.settings[attribute] = @previous_settings.dig("global", attribute)
+        end
+
+        browse_readonly_settings("step") do |attribute|
+          form.default_step_settings[attribute] = @previous_settings.dig("default_step", attribute) if form.default_step_settings.present?
+          if form.step_settings.present?
+            form.step_settings.each do |step_name, step|
+              step[attribute] = @previous_settings.dig("steps", step_name, attribute)
+            end
+          end
+        end
+      end
+
+      def browse_readonly_settings(settings_name)
+        @component.manifest.settings(settings_name).attributes
+                  .select { |_attribute, obj| obj.readonly?(component: @component) }
+                  .each { |attribute, _obj| yield(attribute) }
+      end
     end
   end
 end

data/app/commands/decidim/admin/update_content_block.rb

@@ -24,13 +24,37 @@ module Decidim
       def call
         return broadcast(:invalid) if form.invalid?
 
+        images_valid = true
+
         transaction do
           update_content_block_settings
+          content_block.save!
+
+          # Saving the images will cause the image file validations to run
+          # according to their uploader settings and the organization settings.
+          # The content block validation will fail in case there are processing
+          # errors on the image files.
+          #
+          # NOTE:
+          # The images can be only stored correctly if the content block is
+          # already persisted. This is not the case e.g. when creating a new
+          # newsletter which uses the content blocks through newsletter
+          # templates. This is why this needs to happen after the initial
+          # `content_block.save!` call.
           update_content_block_images
+          unless content_block.valid?
+            images_valid = false
+            raise ActiveRecord::Rollback
+          end
+
+          # The save method needs to be called another time in order to store
+          # the image information.
           content_block.save!
         end
 
-        broadcast(:ok)
+        return broadcast(:invalid) unless images_valid
+
+        broadcast(:ok, content_block)
       end
 
       private

data/app/commands/decidim/admin/update_newsletter.rb

@@ -11,25 +11,47 @@ module Decidim
       # user       - The user that updates the newsletter.
       def initialize(newsletter, form, user)
         @newsletter = newsletter
+        @content_block = newsletter.template
         @form = form
         @user = user
         @organization = user.organization
       end
 
       def call
-        return broadcast(:invalid) unless @form.valid?
-        return broadcast(:invalid) if @newsletter.sent?
-        return broadcast(:invalid) unless @organization == @newsletter.organization
+        return broadcast(:invalid) unless form.valid?
+        return broadcast(:invalid) if newsletter.sent?
+        return broadcast(:invalid) unless organization == newsletter.organization
 
+        transaction do
+          update_newsletter
+          update_content_block
+        end
+
+        broadcast(:ok, newsletter)
+      end
+
+      private
+
+      attr_reader :user, :newsletter, :content_block, :organization, :form
+
+      def update_newsletter
         @newsletter = Decidim.traceability.update!(
-          @newsletter,
-          @user,
-          subject: @form.subject,
-          body: @form.body,
-          author: @user
+          newsletter,
+          user,
+          subject: form.subject,
+          author: user
         )
+      end
 
-        broadcast(:ok, @newsletter)
+      def update_content_block
+        UpdateContentBlock.call(form, content_block, user) do
+          on(:ok) do |content_block|
+            @content_block = content_block
+          end
+          on(:invalid) do
+            raise "There was a problem persisting the changes to the content block"
+          end
+        end
       end
     end
   end

data/app/commands/decidim/admin/update_organization.rb

@@ -53,9 +53,12 @@ module Decidim
           github_handler: form.github_handler,
           badges_enabled: form.badges_enabled,
           user_groups_enabled: form.user_groups_enabled,
+          comments_max_length: form.comments_max_length,
+          enable_machine_translations: form.enable_machine_translations,
           admin_terms_of_use_body: form.admin_terms_of_use_body,
           rich_text_editor_in_public_views: form.rich_text_editor_in_public_views
         }.merge(welcome_notification_attributes)
+          .merge(machine_translation_attributes || {})
       end
 
       def welcome_notification_attributes
@@ -65,6 +68,14 @@ module Decidim
           welcome_notification_body: form.customize_welcome_notification ? form.welcome_notification_body : nil
         }
       end
+
+      def machine_translation_attributes
+        return unless Decidim.config.enable_machine_translations
+
+        {
+          machine_translation_display_priority: form.machine_translation_display_priority
+        }
+      end
     end
   end
 end

data/app/commands/decidim/admin/update_organization_appearance.rb

@@ -102,7 +102,9 @@ module Decidim
             secondary: form.secondary_color,
             success: form.success_color,
             warning: form.warning_color,
-            alert: form.alert_color
+            alert: form.alert_color,
+            highlight: form.highlight_color,
+            "highlight-alternative": form.highlight_alternative_color
           }
         }
       end

data/app/controllers/concerns/decidim/admin/participatory_space_export.rb

@@ -11,19 +11,25 @@ module Decidim
         def create
           enforce_permission_to :create, :export_space, participatory_space: exportable_space
 
-          ExportParticipatorySpaceJob.perform_later(current_user, exportable_space, "participatory_processes", default_format)
+          ExportParticipatorySpaceJob.perform_later(current_user, exportable_space, manifest_name, default_format)
 
           flash[:notice] = t("decidim.admin.exports.notice")
 
           redirect_back(fallback_location: after_export_path)
         end
 
-        # Public: The only method to be implemented at the controller. You need to
+        # Public: To be implemented at the controller. You need to
         # return the space that will be exported.
         def exportable_space
           raise NotImplementedError
         end
 
+        # Public: To be implemented at the controller. You need to
+        # return the plural of the name of the space that will be exported.
+        def manifest_name
+          raise NotImplementedError
+        end
+
         # Public: Returns a String or Object that will be passed to `redirect_to` after
         # exporing a space. By default it redirects to the root_path.
         #

data/app/controllers/decidim/admin/application_controller.rb

@@ -6,6 +6,7 @@ module Decidim
     class ApplicationController < ::DecidimController
       include NeedsOrganization
       include NeedsPermission
+      include NeedsSnippets
       include FormFactory
       include LocaleSwitcher
       include UseOrganizationTimeZone

data/app/controllers/decidim/admin/authorization_workflows_controller.rb

@@ -9,6 +9,12 @@ module Decidim
         enforce_permission_to :index, :authorization_workflow
 
         @workflows = Decidim::Verifications.admin_workflows
+
+        # Decidim::Verifications::Authorizations Query
+        @authorizations = Decidim::Verifications::Authorizations.new(
+          organization: current_organization,
+          granted: true
+        ).query
       end
     end
   end

data/app/controllers/decidim/admin/components_controller.rb

@@ -20,14 +20,17 @@ module Decidim
         @component = Component.new(
           name: default_name(manifest),
           manifest_name: params[:type],
-          participatory_space: current_participatory_space
+          participatory_space: current_participatory_space,
+          settings: {
+            scope_id: current_participatory_space.scope.try(:id)
+          }
         )
 
-        @form = form(ComponentForm).from_model(@component)
+        @form = form(@component.form_class).from_model(@component)
       end
 
       def create
-        @form = form(ComponentForm).from_params(component_params)
+        @form = form(manifest.component_form_class).from_params(component_params)
         enforce_permission_to :create, :component
 
         CreateComponent.call(@form) do
@@ -47,12 +50,12 @@ module Decidim
         @component = query_scope.find(params[:id])
         enforce_permission_to :update, :component, component: @component
 
-        @form = form(ComponentForm).from_model(@component)
+        @form = form(@component.form_class).from_model(@component)
       end
 
       def update
         @component = query_scope.find(params[:id])
-        @form = form(ComponentForm).from_params(component_params)
+        @form = form(@component.form_class).from_params(component_params)
         enforce_permission_to :update, :component, component: @component
 
         UpdateComponent.call(@form, @component) do
@@ -111,9 +114,16 @@ module Decidim
         end
       end
 
+      def share
+        @component = query_scope.find(params[:id])
+        share_token = @component.share_tokens.create!(user: current_user, organization: current_organization)
+
+        redirect_to share_token.url
+      end
+
       private
 
-      # Processes the component params so Decidim::Admin::ComponentForm
+      # Processes the component params so the form object defined in the manifest (component_form_class_name)
       # can assign and validate the attributes when using #from_params.
       def component_params
         new_settings = proc { |name, data| Component.build_settings(manifest, name, data, current_organization) }
@@ -126,6 +136,7 @@ module Decidim
           if hsh[:default_step_settings]
             hsh[:default_step_settings] = new_settings.call(:step, hsh[:default_step_settings])
           else
+            hsh[:step_settings] ||= {}
             hsh[:step_settings].each do |key, value|
               hsh[:step_settings][key] = new_settings.call(:step, value)
             end

data/app/controllers/decidim/admin/dashboard_controller.rb

@@ -6,6 +6,8 @@ module Decidim
     #
     class DashboardController < Decidim::Admin::ApplicationController
       helper_method :latest_action_logs
+      helper_method :users_counter
+      helper_method :metrics_presenter
 
       def show
         enforce_permission_to :read, :admin_dashboard
@@ -19,7 +21,37 @@ module Decidim
                                 .includes(:participatory_space, :user, :resource, :component, :version)
                                 .for_admin
                                 .order(created_at: :desc)
-                                .first(20)
+                                .first(5)
+      end
+
+      def metrics_presenter
+        @metrics_presenter ||= Decidim::Admin::DashboardMetricChartsPresenter.new(
+          summary: true,
+          organization: current_organization
+        )
+      end
+
+      def users_counter
+        last_day = Time.zone.yesterday
+        last_week = Time.zone.today.prev_week
+        last_month = Time.zone.today.prev_month
+
+        {
+          total_admins_last_24: users_count(last_day, true),
+          total_admins_last_week: users_count(last_week, true),
+          total_admins_last_month: users_count(last_month, true),
+          total_participants_last_24: users_count(last_day, false),
+          total_participants_last_week: users_count(last_week, false),
+          total_participants_last_month: users_count(last_month, false)
+        }
+      end
+
+      def users_count(date, admin)
+        @users_count = Decidim::Admin::ActiveUsersCounter.new(
+          organization: current_organization,
+          date: date,
+          admin: admin
+        ).query.count
       end
     end
   end

data/app/controllers/decidim/admin/metrics_controller.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    class MetricsController < Decidim::Admin::ApplicationController
+      helper_method :metrics_presenter
+
+      def index
+        enforce_permission_to :read, :metrics
+      end
+
+      private
+
+      def metrics_presenter
+        @metrics_presenter ||= Decidim::Admin::DashboardMetricChartsPresenter.new(
+          summary: false,
+          organization: current_organization
+        )
+      end
+    end
+  end
+end

data/app/controllers/decidim/admin/newsletter_templates_controller.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # Controller that allows managing newsletters.
+    class NewsletterTemplatesController < Decidim::Admin::ApplicationController
+      helper_method :templates, :template_manifest
+
+      layout "decidim/admin/newsletters"
+
+      def index
+        enforce_permission_to :index, :newsletter
+      end
+
+      def show; end
+
+      def preview
+        email = NewsletterMailer.newsletter(current_user, fake_newsletter)
+        Premailer::Rails::Hook.perform(email)
+        render html: email.html_part.body.decoded.html_safe
+      end
+
+      private
+
+      def templates
+        @templates ||= Decidim.content_blocks.for(:newsletter_template)
+      end
+
+      def template_manifest
+        @template_manifest ||= Decidim
+                               .content_blocks
+                               .for(:newsletter_template)
+                               .find { |manifest| manifest.name.to_s == params[:id] }
+      end
+
+      def fake_newsletter
+        @fake_newsletter ||= Decidim::Admin::FakeNewsletter.new(current_organization, template_manifest)
+      end
+    end
+  end
+end