cosmos 4.1.1-java → 4.2.0-java

data/lib/cosmos/version.rb

@@ -1,12 +1,12 @@
 # encoding: ascii-8bit
 
-COSMOS_VERSION = '4.1.1'
+COSMOS_VERSION = '4.2.0'
 module Cosmos
   module Version
     MAJOR = '4'
-    MINOR = '1'
-    PATCH = '1'
-    BUILD = '4d061cac0c17e02bfbb77c8506ee17354ef8b8f1'
+    MINOR = '2'
+    PATCH = '0'
+    BUILD = 'a20c2452747369e5340a437a5652474bae0299e4'
   end
-  VERSION = '4.1.1'
+  VERSION = '4.2.0'
 end

data/lib/cosmos/win32/win32.rb

@@ -12,11 +12,7 @@ require 'cosmos/win32/win32_main'
 require 'cosmos/packets/structure'
 
 module Cosmos
-
-  # Win32 class
-  #
-  # This class implements the Win32
-  #
+  # Uses the Win32API to implement methods useful on Windows.
   class Win32
     # Create a file
     def self.create_file(filename, desired_access, share_mode, security_attributes, creation_disposition, flags_and_attributes, template_file = NULL)
@@ -132,10 +128,8 @@ module Cosmos
       comm_timeouts.write('WriteTotalTimeoutConstant', write_total_timeout_constant)
       comm_timeouts
     end
-
-  end # class Win32
-
-end # module Cosmos
+  end
+end
 
 module QDA
   module Filters
@@ -313,7 +307,7 @@ module QDA
       end
 
       class Win32popenIO
-        def initialize (hRead, hWrite, hError)
+        def initialize(hRead, hWrite, hError)
           @hRead  = hRead
           @hWrite = hWrite
           @hError = hError

data/run_gui_tests.bat

@@ -4,6 +4,7 @@ call bundle exec ruby autohotkey\tools\CmdSequenceAHK -w 650 -t 650
 call bundle exec ruby autohotkey\tools\CmdSequenceAHK2 -w 650 -t 650 -r run_sequence.txt -o procedures
 call bundle exec ruby autohotkey\tools\CmdTlmServerAHK -x 50 -y 50 -w 900 -t 1000
 call bundle exec ruby autohotkey\tools\CmdTlmServerAHK2 -w 900 -t 1000 -p -n -c cmd_tlm_server.txt
+call bundle exec ruby autohotkey\tools\ConfigEditorAHK -w 1200 -t 800
 call bundle exec ruby autohotkey\tools\DataViewerAHK -w 600 -t 800
 call bundle exec ruby autohotkey\tools\HandbookCreatorAHK
 call bundle exec ruby autohotkey\tools\LauncherAHK
@@ -11,7 +12,7 @@ call bundle exec ruby autohotkey\tools\LimitsMonitorAHK
 call bundle exec ruby autohotkey\tools\OpenGLBuilderAHK -w 600 -t 600
 call bundle exec ruby autohotkey\tools\PacketViewerAHK -w 600 -t 800
 call bundle exec ruby autohotkey\tools\PacketViewerAHK2 --defaultsize -p "INST ADCS"
-call bundle exec ruby autohotkey\tools\ReplayAHK -w 800
+call bundle exec ruby autohotkey\tools\ReplayAHK -w 800 -t 800
 call bundle exec ruby autohotkey\tools\ScriptRunnerAHK -w 600 -t 800
 call bundle exec ruby autohotkey\tools\ScriptRunnerAHK2 -w 600 -t 800
 call bundle exec ruby autohotkey\tools\TableManagerAHK -w 800 -t 800

data/spec/config/config_parser_spec.rb

@@ -364,7 +364,7 @@ module Cosmos
           expect(ConfigParser.handle_defined_constants("MIN", :UINT, val)).to eql 0
           expect(ConfigParser.handle_defined_constants("MAX", :UINT, val)).to eql (2**val - 1)
           # Signed
-          expect(ConfigParser.handle_defined_constants("MIN", :INT, val)).to eql -((2**val) / 2)
+          expect(ConfigParser.handle_defined_constants("MIN", :INT, val)).to eql (-(2**val) / 2)
           expect(ConfigParser.handle_defined_constants("MAX", :INT, val)).to eql ((2**val) / 2 - 1)
         end
         [8,16,32,64].each do |val|
@@ -372,16 +372,16 @@ module Cosmos
           expect(ConfigParser.handle_defined_constants("MIN_UINT#{val}")).to eql 0
           expect(ConfigParser.handle_defined_constants("MAX_UINT#{val}")).to eql (2**val - 1)
           # Signed
-          expect(ConfigParser.handle_defined_constants("MIN_INT#{val}")).to eql -((2**val) / 2)
+          expect(ConfigParser.handle_defined_constants("MIN_INT#{val}")).to eql (-(2**val) / 2)
           expect(ConfigParser.handle_defined_constants("MAX_INT#{val}")).to eql ((2**val) / 2 - 1)
         end
         # Float
         expect(ConfigParser.handle_defined_constants("MIN_FLOAT32")).to be <= -3.4 * 10**38
         expect(ConfigParser.handle_defined_constants("MAX_FLOAT32")).to be >= 3.4 * 10**38
-        expect(ConfigParser.handle_defined_constants("MIN_FLOAT64")).to eql -Float::MAX
+        expect(ConfigParser.handle_defined_constants("MIN_FLOAT64")).to eql (-Float::MAX)
         expect(ConfigParser.handle_defined_constants("MAX_FLOAT64")).to eql Float::MAX
         expect(ConfigParser.handle_defined_constants("POS_INFINITY")).to eql Float::INFINITY
-        expect(ConfigParser.handle_defined_constants("NEG_INFINITY")).to eql -Float::INFINITY
+        expect(ConfigParser.handle_defined_constants("NEG_INFINITY")).to eql (-Float::INFINITY)
       end
 
       it "complains about undefined strings" do

data/spec/core_ext/array_spec.rb

@@ -16,7 +16,7 @@ describe Array do
   describe "inspect" do
     it "limits the number of items to 10" do
       expect(Array.new([1,2,3,4,5,6,7,8,9,10]).inspect).to eql "[1, 2, 3, 4, 5, 6, 7, 8, 9, 10]"
-      expect(Array.new([1,2,3,4,5,6,7,8,9,10,11]).inspect).to match /#<Array:\d+>/
+      expect(Array.new([1,2,3,4,5,6,7,8,9,10,11]).inspect).to match(/#<Array:\d+>/)
     end
   end
 

data/spec/core_ext/exception_spec.rb

@@ -18,8 +18,8 @@ describe Exception do
       begin
         raise "My message"
       rescue => err
-        expect(err.formatted).to match /RuntimeError : My message/
-        expect(err.formatted).to match /#{File.expand_path(__FILE__)}/
+        expect(err.formatted).to match(/RuntimeError : My message/)
+        expect(err.formatted).to match(/#{File.expand_path(__FILE__)}/)
       end
     end
 
@@ -27,18 +27,18 @@ describe Exception do
       begin
         raise "My message"
       rescue => err
-        expect(err.formatted(true)).not_to match /RuntimeError/
-        expect(err.formatted(true)).to match /My message/
-        expect(err.formatted(true)).to match /#{File.expand_path(__FILE__)}/
+        expect(err.formatted(true)).not_to match(/RuntimeError/)
+        expect(err.formatted(true)).to match(/My message/)
+        expect(err.formatted(true)).to match(/#{File.expand_path(__FILE__)}/)
       end
 
       # If it's not a RuntimeError then we should still see the class
       begin
         raise ArgumentError.new("My message")
       rescue => err
-        expect(err.formatted(true)).to match /ArgumentError/
-        expect(err.formatted(true)).to match /My message/
-        expect(err.formatted(true)).to match /#{File.expand_path(__FILE__)}/
+        expect(err.formatted(true)).to match(/ArgumentError/)
+        expect(err.formatted(true)).to match(/My message/)
+        expect(err.formatted(true)).to match(/#{File.expand_path(__FILE__)}/)
       end
     end
 
@@ -46,15 +46,15 @@ describe Exception do
       begin
         raise "My message"
       rescue => err
-        expect(err.formatted(false, false)).to match /RuntimeError : My message/
-        expect(err.formatted(false, false)).not_to match /#{File.expand_path(__FILE__)}/
+        expect(err.formatted(false, false)).to match(/RuntimeError : My message/)
+        expect(err.formatted(false, false)).not_to match(/#{File.expand_path(__FILE__)}/)
       end
 
       begin
         raise "My message"
       rescue => err
-        expect(err.formatted(true, false)).to match /My message/
-        expect(err.formatted(true, false)).not_to match /#{File.expand_path(__FILE__)}/
+        expect(err.formatted(true, false)).to match(/My message/)
+        expect(err.formatted(true, false)).not_to match(/#{File.expand_path(__FILE__)}/)
       end
     end
   end

data/spec/core_ext/file_spec.rb

@@ -40,29 +40,29 @@ describe File do
     it "formats the time" do
       time = Time.now
       timestamp = sprintf("%04u_%02u_%02u_%02u_%02u_%02u", time.year, time.month, time.mday, time.hour, time.min, time.sec)
-      expect(File.build_timestamped_filename(nil,".txt",time)).to match timestamp
+      expect(File.build_timestamped_filename(nil,".txt",time)).to match(timestamp)
     end
 
     it "allows empty tags" do
-      expect(File.build_timestamped_filename([])).to match /\d\d\.txt/
+      expect(File.build_timestamped_filename([])).to match(/\d\d\.txt/)
     end
 
     it "allows nil tags" do
-      expect(File.build_timestamped_filename(nil)).to match /\d\d\.txt/
+      expect(File.build_timestamped_filename(nil)).to match(/\d\d\.txt/)
     end
 
     it "includes the tags" do
-      expect(File.build_timestamped_filename(['this','is','a','test'])).to match 'this_is_a_test'
+      expect(File.build_timestamped_filename(['this','is','a','test'])).to match('this_is_a_test')
     end
 
     it "changes the extension" do
-      expect(File.build_timestamped_filename(nil,".bin")).to match ".bin"
+      expect(File.build_timestamped_filename(nil,".bin")).to match(".bin")
     end
   end
 
   describe "find_in_search_path" do
     it "returns the path to the file" do
-      expect(File.find_in_search_path("cosmos.rb")).to match "lib/cosmos.rb"
+      expect(File.find_in_search_path("cosmos.rb")).to match("lib/cosmos.rb")
     end
 
     it "returns nil if the file can't be found" do

data/spec/core_ext/hash_spec.rb

@@ -18,7 +18,7 @@ describe Hash do
       hash = {'1'=>1,'2'=>2,'3'=>3,'4'=>4,'5'=>5,'6'=>6,'7'=>7,'8'=>8,'9'=>9,'10'=>10}
       expect(hash.inspect).to eql '{"1"=>1, "2"=>2, "3"=>3, "4"=>4, "5"=>5, "6"=>6, "7"=>7, "8"=>8, "9"=>9, "10"=>10}'
       hash['11'] = 11
-      expect(hash.inspect).to match /#<Hash:\d+>/
+      expect(hash.inspect).to match(/#<Hash:\d+>/)
     end
   end
 end

data/spec/core_ext/socket_spec.rb

@@ -16,7 +16,7 @@ describe Socket do
     it "returns the ip address of the current machine" do
       begin
         Socket.get_own_ip_address
-        expect(Socket.get_own_ip_address).to match /\b(?:\d{1,3}\.){3}\d{1,3}\b/
+        expect(Socket.get_own_ip_address).to match(/\b(?:\d{1,3}\.){3}\d{1,3}\b/)
       rescue Resolv::ResolvError
         # Oh well
       end
@@ -27,7 +27,7 @@ describe Socket do
     it "returns the hostname for the ip address" do
       if !ENV['APPVEYOR']
         ipaddr = Resolv.getaddress "localhost"
-        expect(Socket.lookup_hostname_from_ip(ipaddr)).to match "localhost"
+        expect(Socket.lookup_hostname_from_ip(ipaddr)).to match("localhost")
       end
     end
   end

data/spec/core_ext/string_spec.rb

@@ -26,39 +26,39 @@ describe String do
     end
 
     it "uses 2 byte words" do
-      expect(@data.formatted(2, 8)).to match "00000000: 1A1B 1C1D 1E1F" # ...
-      expect(@data.formatted(2, 8)).to match "00000010: 2A2B 2C2D 2E2F"
+      expect(@data.formatted(2, 8)).to match("00000000: 1A1B 1C1D 1E1F") # ...
+      expect(@data.formatted(2, 8)).to match("00000010: 2A2B 2C2D 2E2F")
     end
 
     it "changes the word separator" do
-      expect(@data.formatted(2, 4, '_')).to match "00000000: 1A1B_1C1D_1E1F_2021"
-      expect(@data.formatted(2, 4, '_')).to match "00000008: 2223_2425_2627_2829"
-      expect(@data.formatted(2, 4, '_')).to match "00000010: 2A2B_2C2D_2E2F"
+      expect(@data.formatted(2, 4, '_')).to match("00000000: 1A1B_1C1D_1E1F_2021")
+      expect(@data.formatted(2, 4, '_')).to match("00000008: 2223_2425_2627_2829")
+      expect(@data.formatted(2, 4, '_')).to match("00000010: 2A2B_2C2D_2E2F")
     end
 
     it "indents the lines" do
-      expect(@data.formatted(1, 16, ' ', 4)).to match "    00000000: 1A 1B 1C 1D"
+      expect(@data.formatted(1, 16, ' ', 4)).to match("    00000000: 1A 1B 1C 1D")
     end
 
     it "does not show the address" do
-      expect(@data.formatted(1, 16, ' ', 0, false)).to match "1A 1B 1C 1D"
+      expect(@data.formatted(1, 16, ' ', 0, false)).to match("1A 1B 1C 1D")
     end
 
     it "changes the address separator" do
-      expect(@data.formatted(1, 16, ' ', 0, true, '= ')).to match "00000000= 1A 1B 1C 1D"
+      expect(@data.formatted(1, 16, ' ', 0, true, '= ')).to match("00000000= 1A 1B 1C 1D")
     end
 
     it "does not show the ASCII" do
-      expect(@data.formatted(1,16,'',0,true,'',true)).to match '29         !"#\$%&\'()'
-      expect(@data.formatted(1,16,'',0,true,'',false)).not_to match '29         !"#\$%&\'()'
+      expect(@data.formatted(1,16,'',0,true,'',true)).to match('29         !"#\$%&\'()')
+      expect(@data.formatted(1,16,'',0,true,'',false)).not_to match('29         !"#\$%&\'()')
     end
 
     it "changes the ASCII separator" do
-      expect(@data.formatted(1,16,'',0,true,'',true,'__')).to match '29__       !"#\$%&\'()'
+      expect(@data.formatted(1,16,'',0,true,'',true,'__')).to match('29__       !"#\$%&\'()')
     end
 
     it "changes the ASCII unprintable character" do
-      expect(@data.formatted(1,16,'',0,true,'',true,'__','x')).to match '29__xxxxxx !"#\$%&\'()'
+      expect(@data.formatted(1,16,'',0,true,'',true,'__','x')).to match('29__xxxxxx !"#\$%&\'()')
     end
 
     it "changes the line separator" do
@@ -199,7 +199,7 @@ describe String do
       expect("[.a,2,3]".convert_to_value).to eql "[.a,2,3]"
     end
 
-    it "doesn't match multiline strings" do
+    it "doesn't match(multiline strings" do
       expect("12345\n12345".convert_to_value).to eql "12345\n12345"
       expect("5.123\n5.123".convert_to_value).to eql "5.123\n5.123"
       expect("[0,1,2,3]\n[0,1,2,3]".convert_to_value).to eql "[0,1,2,3]\n[0,1,2,3]"

data/spec/core_ext/time_spec.rb

@@ -164,7 +164,6 @@ describe Time do
   describe "Time.ccsds2julian and Time.julian2ccsds" do
     it "converts CCSDS to and from Julian" do
       expect(Time.ccsds2julian(0, 1000, 2)).to be_within(0.00001).of(2436204.500012)
-      time = Time.now
       ccsds_day, ccsds_ms, ccsds_us = Time.mdy2ccsds(2015,1,2,3,4,5,100)
       julian = Time.ccsds2julian(ccsds_day, ccsds_ms, ccsds_us)
       parts = Time.julian2ccsds(julian)
@@ -177,7 +176,6 @@ describe Time do
   describe "Time.ccsds2sec and Time.sec2ccsds" do
     it "converts seconds to and from CCSDS" do
       expect(Time.ccsds2sec(0, 1000, 2)).to be_within(0.00001).of(1)
-      time = Time.now
       ccsds_day, ccsds_ms, ccsds_us = Time.mdy2ccsds(2015,1,2,3,4,5,100)
       seconds = Time.ccsds2sec(ccsds_day, ccsds_ms, ccsds_us)
       parts = Time.sec2ccsds(seconds)

data/spec/gui/utilities/script_module_gui_spec.rb

@@ -63,7 +63,7 @@ if RUBY_ENGINE == 'ruby'
           end
 
           buttons = %w(THIS IS A TEST)
-          answer = combo_box("HI", *buttons)
+          combo_box("HI", *buttons)
           expect(buttons).to eq %w(THIS IS A TEST)
         end
       end
@@ -79,7 +79,7 @@ if RUBY_ENGINE == 'ruby'
           end
 
           buttons = %w(THIS IS A TEST)
-          answer = message_box("HI", *buttons)
+          message_box("HI", *buttons)
           expect(buttons).to eq %w(THIS IS A TEST)
         end
       end
@@ -93,7 +93,7 @@ if RUBY_ENGINE == 'ruby'
           end
 
           buttons = %w(THIS IS A TEST)
-          answer = vertical_message_box("HI", *buttons)
+          vertical_message_box("HI", *buttons)
           expect(buttons).to eq %w(THIS IS A TEST)
         end
       end

data/spec/install/config/targets/INST/cmd_tlm/inst_tlm.txt

@@ -70,17 +70,17 @@ TELEMETRY INST HEALTH_STATUS BIG_ENDIAN "Health and status from the instrument"
   ITEM TIMEFORMATTED 0 0 DERIVED "Derived time since epoch as formatted string"
     READ_CONVERSION unix_time_formatted_conversion.rb TIMESEC TIMEUS
   ITEM TEMP1HIGH 0 0 DERIVED "High-water mark for TEMP1"
-    READ_CONVERSION processor_conversion.rb TEMP1WATER HIGH_WATER
+    READ_CONVERSION processor_conversion.rb TEMP1WATER HIGH_WATER # Deliberately leave off type and bit size
   ITEM TEMP1LOW 0 0 DERIVED "Low-water mark for TEMP1"
-    READ_CONVERSION processor_conversion.rb TEMP1WATER LOW_WATER
+    READ_CONVERSION processor_conversion.rb TEMP1WATER LOW_WATER # Deliberately leave off type and bit size
   ITEM TEMP1MAX 0 0 DERIVED "Maximum of most recent 100 samples for TEMP1"
-    READ_CONVERSION processor_conversion.rb TEMP1STAT MAX
+    READ_CONVERSION processor_conversion.rb TEMP1STAT MAX FLOAT 64
   ITEM TEMP1MIN 0 0 DERIVED "Minimum of most recent 100 samples for TEMP1"
-    READ_CONVERSION processor_conversion.rb TEMP1STAT MIN
+    READ_CONVERSION processor_conversion.rb TEMP1STAT MIN FLOAT 64
   ITEM TEMP1MEAN 0 0 DERIVED "Mean of most recent 100 samples for TEMP1"
-    READ_CONVERSION processor_conversion.rb TEMP1STAT MEAN
+    READ_CONVERSION processor_conversion.rb TEMP1STAT MEAN FLOAT 64
   ITEM TEMP1STDDEV 0 0 DERIVED "Stddev of most recent 100 samples for TEMP1"
-    READ_CONVERSION processor_conversion.rb TEMP1STAT STDDEV
+    READ_CONVERSION processor_conversion.rb TEMP1STAT STDDEV FLOAT 64
   PROCESSOR TEMP1STAT statistics_processor.rb TEMP1 100
   PROCESSOR TEMP1WATER watermark_processor.rb TEMP1
 

data/spec/install/config/tools/cmd_tlm_server/cmd_tlm_server.txt

@@ -0,0 +1,4 @@
+INTERFACE SYSTEM_INT cmd_tlm_server_interface.rb
+  TARGET SYSTEM
+INTERFACE INST_INT interface.rb
+  TARGET INST

data/spec/interfaces/cmd_tlm_server_interface_spec.rb

@@ -15,7 +15,9 @@ module Cosmos
 
   describe CmdTlmServerInterface do
     before(:all) do
+      # Save cmd_tlm_server.txt
       cts = File.join(Cosmos::USERPATH,'config','tools','cmd_tlm_server','cmd_tlm_server.txt')
+      FileUtils.mv cts, Cosmos::USERPATH
       FileUtils.mkdir_p(File.dirname(cts))
       File.open(cts,'w') do |file|
         file.puts 'INTERFACE INT interface.rb'
@@ -24,8 +26,10 @@ module Cosmos
     end
 
     after(:all) do
-      clean_config()
-      FileUtils.rm_rf File.join(Cosmos::USERPATH,'config','tools')
+      # Restore cmd_tlm_server.txt
+      FileUtils.mv File.join(Cosmos::USERPATH, 'cmd_tlm_server.txt'),
+      File.join(Cosmos::USERPATH,'config','tools','cmd_tlm_server')
+      System.class_eval('@@instance = nil')
     end
 
     before(:each) do

data/spec/interfaces/interface_spec.rb

@@ -14,7 +14,6 @@ require 'cosmos/interfaces/protocols/protocol'
 
 module Cosmos
   class InterfaceTestProtocol < Protocol
-
     def initialize(added_data, stop_count = 0, packet_added_data = nil, packet_stop_count = 0)
       @added_data = added_data
       @packet_added_data = packet_added_data

data/spec/interfaces/linc_interface_spec.rb

@@ -19,11 +19,6 @@ module Cosmos
       def write(data); end
     end
 
-    before(:all) do
-      clean_config()
-      System.class_eval('@@instance = nil')
-    end
-
     describe "connect" do
       it "passes a new TcpipClientStream to the stream protocol" do
         i = LincInterface.new('localhost','8888')

data/spec/interfaces/protocols/crc_protocol_spec.rb

@@ -35,111 +35,226 @@ module Cosmos
 
     describe "initialize" do
       it "complains if strip crc is not boolean" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          '', # strip crc
-          'ERROR', # bad strategy
-          -16, # bit offset
-           16], # bit size
-          :READ_WRITE) }.to raise_error(/Invalid strip CRC/)
+        ['ERROR', 0, nil].each do |strip_crc|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            strip_crc, # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16], # bit size
+            :READ_WRITE) }.to raise_error(/Invalid strip CRC/)
+        end
       end
 
       it "complains if bad strategy is not ERROR or DISCONNECT" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'TRUE', # strip crc
-          '', # bad strategy
-          -16, # bit offset
-           16], # bit size
-          :READ_WRITE) }.to raise_error(/Invalid bad CRC strategy/)
+        ['BAD', 0, nil].each do |strategy|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'TRUE', # strip crc
+            strategy, # bad strategy
+            -16, # bit offset
+            16], # bit size
+            :READ_WRITE) }.to raise_error(/Invalid bad CRC strategy/)
+        end
       end
 
       it "complains if bit size is not 16, 32, or 64" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'TRUE', # strip crc
-          'ERROR', # bad strategy
-          128, # bit offset
-          8], # bit size
-          :READ_WRITE) }.to raise_error( /Invalid bit size/)
+        ['0', 0, nil].each do |bit_size|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'TRUE', # strip crc
+            'ERROR', # bad strategy
+            128, # bit offset
+            bit_size], # bit size
+            :READ_WRITE) }.to raise_error( /Invalid bit size/)
+        end
+      end
+
+      it "accepts a string bit size of 16, 32, or 64" do
+        %w(16 32 64).each do |bit_size|
+          @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'TRUE', # strip crc
+            'ERROR', # bad strategy
+            -32, # bit offset
+            bit_size], # bit size
+            :READ_WRITE)
+          expect(@interface.read_protocols[-1].instance_variable_get(:@bit_size)).to eq Integer(bit_size)
+        end
       end
 
       it "complains if bit offset is not byte divisible" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'TRUE', # strip crc
-          'ERROR', # bad strategy
-          100, # bit offset
-          16], # bit size
-          :READ_WRITE) }.to raise_error(/Invalid bit offset/)
+        [nil, 100, '100'].each do |offset|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'TRUE', # strip crc
+            'ERROR', # bad strategy
+            offset, # bit offset
+            16], # bit size
+            :READ_WRITE) }.to raise_error(/Invalid bit offset/)
+        end
       end
 
-      it "complains if the endianness is not a BIG_ENDIAN or LITTLE_ENDIAN" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'FALSE', # strip crc
-          'ERROR', # bad strategy
-          -16, # bit offset
-          16, # bit size
-          'TRUE', # endianness
-          0xDEAD, # poly
-          0x0, # seed
-          'TRUE', # xor
-          'TRUE', # reflect
-          ],
-          :READ_WRITE) }.to raise_error(/Invalid endianness/)
+      it "accepts a string for bit offset" do
+        %w(0 32 -32).each do |offset|
+          @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'TRUE', # strip crc
+            'ERROR', # bad strategy
+            offset, # bit offset
+            16], # bit size
+            :READ_WRITE)
+          expect(@interface.read_protocols[-1].instance_variable_get(:@bit_offset)).to eq Integer(offset)
+        end
+      end
+
+      it "complains if the endianness is not BIG_ENDIAN or LITTLE_ENDIAN" do
+        ['ENDIAN', 0, nil].each do |endianness|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            endianness, # endianness
+            0xDEAD, # poly
+            0x0, # seed
+            'TRUE', # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to raise_error(/Invalid endianness/)
+        end
       end
 
       it "complains if the poly is not a number" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'FALSE', # strip crc
-          'ERROR', # bad strategy
-          -16, # bit offset
-          16, # bit size
-          'BIG_ENDIAN', # endianness
-          'TRUE', # poly
-          0x0, # seed
-          'TRUE', # xor
-          'TRUE', # reflect
-          ],
-          :READ_WRITE) }.to raise_error(/invalid value/)
+        ['TRUE', '123abc'].each do |poly|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'BIG_ENDIAN', # endianness
+            poly, # poly
+            0x0, # seed
+            'TRUE', # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to raise_error(/Invalid poly/)
+        end
+      end
+
+      it "accepts nil and numeric polynomials" do
+        ['0xABCD', 0xABCD, nil, '', 'NIL', 'NULL'].each do |poly|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'BIG_ENDIAN', # endianness
+            poly, # poly
+            0x0, # seed
+            'TRUE', # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to_not raise_error
+        end
       end
 
       it "complains if the seed is not a number" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'FALSE', # strip crc
-          'ERROR', # bad strategy
-          -16, # bit offset
-          16, # bit size
-          'LITTLE_ENDIAN', # endianness
-          0xABCD, # poly
-          'TRUE', # seed
-          'TRUE', # xor
-          'TRUE', # reflect
-          ],
-          :READ_WRITE) }.to raise_error(/invalid value/)
+        ['TRUE', '123abc'].each do |seed|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'LITTLE_ENDIAN', # endianness
+            0xABCD, # poly
+            seed, # seed
+            'TRUE', # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to raise_error(/Invalid seed/)
+        end
+      end
+
+      it "accepts nil and numeric seeds" do
+        ['0xABCD', 0xABCD, nil, '', 'NIL', 'NULL'].each do |seed|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'BIG_ENDIAN', # endianness
+            nil, # poly
+            seed, # seed
+            'TRUE', # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to_not raise_error
+        end
+      end
+
+      it "accepts nil TRUE FALSE for xor" do
+        [nil, '', 'NIL', 'NULL', 'TRUE', 'FALSE'].each do |xor|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'BIG_ENDIAN', # endianness
+            0xABCD, # poly
+            0, # seed
+            xor, # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to_not raise_error
+        end
       end
 
       it "complains if the xor is not boolean" do
-        expect { @interface.add_protocol(CrcProtocol, [
-          nil, # item name
-          'FALSE', # strip crc
-          'ERROR', # bad strategy
-          -16, # bit offset
-          16, # bit size
-          'BIG_ENDIAN', # endianness
-          0xABCD, # poly
-          0, # seed
-          0, # xor
-          'TRUE', # reflect
-          ],
-          :READ_WRITE) }.to raise_error(/Invalid XOR value/)
+        ['ERROR', 0].each do |xor|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'BIG_ENDIAN', # endianness
+            0xABCD, # poly
+            0, # seed
+            xor, # xor
+            'TRUE', # reflect
+            ],
+            :READ_WRITE) }.to raise_error(/Invalid XOR value/)
+        end
+      end
+
+      it "accepts nil TRUE FALSE for reflect" do
+        [nil, '', 'NIL', 'NULL', 'TRUE', 'FALSE'].each do |reflect|
+          expect { @interface.add_protocol(CrcProtocol, [
+            nil, # item name
+            'FALSE', # strip crc
+            'ERROR', # bad strategy
+            -16, # bit offset
+            16, # bit size
+            'BIG_ENDIAN', # endianness
+            0xABCD, # poly
+            0, # seed
+            'TRUE', # xor
+            reflect, # reflect
+            ],
+            :READ_WRITE) }.to_not raise_error
+        end
       end
 
       it "complains if the reflect is not boolean" do
-        expect { @interface.add_protocol(CrcProtocol, [
+        ['ERROR', 0].each do |reflect|
+          expect { @interface.add_protocol(CrcProtocol, [
           nil, # item name
           'FALSE', # strip crc
           'ERROR', # bad strategy
@@ -149,9 +264,10 @@ module Cosmos
           0xABCD, # poly
           0, # seed
           'TRUE', # xor
-          0, # reflect
+          reflect, # reflect
           ],
           :READ_WRITE) }.to raise_error(/Invalid reflect value/)
+        end
       end
     end
 
@@ -378,7 +494,7 @@ module Cosmos
         $buffer[0] = "\x01"
 
         expect(Logger).to receive(:error) do |msg|
-          expect(msg).to match "Invalid CRC detected!"
+          expect(msg).to match("Invalid CRC detected!")
         end
         packet = @interface.read
         expect(packet.buffer.length).to eql 8
@@ -406,7 +522,7 @@ module Cosmos
         $buffer[0] = "\x01"
 
         expect(Logger).to receive(:error) do |msg|
-          expect(msg).to match "Invalid CRC detected!"
+          expect(msg).to match("Invalid CRC detected!")
         end
         packet = @interface.read
         expect(packet).to be_nil # thread disconnects when packet is nil