cosmos 4.1.1-java → 4.2.0-java

data/lib/cosmos/packets/structure.rb

@@ -263,7 +263,11 @@ module Cosmos
     # @return (see #define_item)
     def append_item(name, bit_size, data_type, array_size = nil, endianness = @default_endianness, overflow = :ERROR)
       raise ArgumentError, "Can't append an item after a variably sized item" if !@fixed_size
-      return define_item(name, @defined_length_bits, bit_size, data_type, array_size, endianness, overflow)
+      if data_type == :DERIVED
+        return define_item(name, 0, bit_size, data_type, array_size, endianness, overflow)
+      else
+        return define_item(name, @defined_length_bits, bit_size, data_type, array_size, endianness, overflow)
+      end
     end
 
     # Adds an item at the end of the structure. It adds the item to the items
@@ -273,7 +277,11 @@ module Cosmos
     # @return (see #define)
     def append(item)
       raise ArgumentError, "Can't append an item after a variably sized item" if !@fixed_size
-      item.bit_offset = @defined_length_bits
+      if item.data_type == :DERIVED
+        item.bit_offset = 0
+      else
+        item.bit_offset = @defined_length_bits
+      end
       return define(item)
     end
 

data/lib/cosmos/packets/structure_item.rb

@@ -287,6 +287,16 @@ module Cosmos
       hash
     end
 
+    def little_endian_bit_field?
+      return false unless @endianness == :LITTLE_ENDIAN
+      return false unless (@data_type == :INT || @data_type == :UINT)
+      # If we're not byte aligned we're a bit field
+      return true unless (@bit_offset % 8) == 0
+      # If we don't have an even number of bytes we're a bit field
+      return true unless even_byte_multiple()
+      false
+    end
+
     protected
 
     # Verifies overall integrity of the StructureItem by checking for correct
@@ -302,11 +312,8 @@ module Cosmos
           raise ArgumentError, "#{@name}: Can't define an item with bit_size #{@bit_size} greater than negative bit_offset #{@bit_offset}"
         end
       else
-        # Check for byte alignment and byte multiple
-        byte_aligned = ((@bit_offset % 8) == 0)
-
-        # Verify little-endian bit fields
-        if @endianness == :LITTLE_ENDIAN and (@data_type == :INT or @data_type == :UINT) and !(byte_aligned and (@bit_size == 8 or @bit_size == 16 or @bit_size == 32 or @bit_size == 64))
+        # Verify bounds on little-endian bit fields
+        if little_endian_bit_field?()
           # Bitoffset always refers to the most significant bit of a bitfield
           num_bytes = (((@bit_offset % 8) + @bit_size - 1) / 8) + 1
           upper_bound = @bit_offset / 8
@@ -319,6 +326,13 @@ module Cosmos
       end
     end
 
-  end # class StructureItem
-
-end # module Cosmos
+    def even_byte_multiple
+      case @bit_size
+      when 8, 16, 32, 64
+        true
+      else
+        false
+      end
+    end
+  end
+end

data/lib/cosmos/processors/statistics_processor.rb

@@ -32,6 +32,8 @@ module Cosmos
     # See Processor#call
     def call(packet, buffer)
       value = packet.read(@item_name, @value_type, buffer)
+      # Don't process NaN or Infinite values
+      return if value.to_f.nan? || value.to_f.infinite?
       @samples << value
       @samples = @samples[-@samples_to_average..-1] if @samples.length > @samples_to_average
       mean, stddev = Math.stddev_sample(@samples)

data/lib/cosmos/script/api_shared.rb

@@ -114,7 +114,7 @@ module Cosmos
         if all_checks_ok
           Logger.info message
         else
-          if $cmd_tlm_disconnect
+          if $disconnected_targets && $disconnected_targets.include?(target_name)
             Logger.error message
           else
             raise CheckError, message
@@ -128,7 +128,7 @@ module Cosmos
           Logger.info "#{check_str} was within #{range_str}"
         else
           message = "#{check_str} failed to be within #{range_str}"
-          if $cmd_tlm_disconnect
+          if $disconnected_targets && $disconnected_targets.include?(target_name)
             Logger.error message
           else
             raise CheckError, message
@@ -167,7 +167,7 @@ module Cosmos
         Logger.info "CHECK: #{exp_to_eval} is TRUE"
       else
         message = "CHECK: #{exp_to_eval} is FALSE"
-        if $cmd_tlm_disconnect
+        if $disconnected_targets
           Logger.error message
         else
           raise CheckError, message
@@ -279,7 +279,7 @@ module Cosmos
         Logger.info "#{check_str} success #{with_value_str}"
       else
         message = "#{check_str} failed #{with_value_str}"
-        if $cmd_tlm_disconnect
+        if $disconnected_targets && $disconnected_targets.include?(target_name)
           Logger.error message
         else
           raise CheckError, message
@@ -336,7 +336,7 @@ module Cosmos
         if success
           Logger.info message
         else
-          if $cmd_tlm_disconnect
+          if $disconnected_targets && $disconnected_targets.include?(target_name)
             Logger.error message
           else
             raise CheckError, message
@@ -352,7 +352,7 @@ module Cosmos
           Logger.info "#{check_str} was within #{range_str}"
         else
           message = "#{check_str} failed to be within #{range_str}"
-          if $cmd_tlm_disconnect
+          if $disconnected_targets && $disconnected_targets.include?(target_name)
             Logger.error message
           else
             raise CheckError, message
@@ -386,7 +386,7 @@ module Cosmos
         Logger.info "CHECK: #{exp_to_eval} is TRUE after waiting #{time} seconds"
       else
         message = "CHECK: #{exp_to_eval} is FALSE after waiting #{time} seconds"
-        if $cmd_tlm_disconnect
+        if $disconnected_targets
           Logger.error message
         else
           raise CheckError, message
@@ -419,7 +419,7 @@ module Cosmos
       else
         message = "#{type}: #{target_name.upcase} #{packet_name.upcase} expected to be received #{num_packets} times but only received #{value - initial_count} times after waiting #{time} seconds"
         if check
-          if $cmd_tlm_disconnect
+          if $disconnected_targets && $disconnected_targets.include?(target_name)
             Logger.error message
           else
             raise CheckError, message
@@ -505,7 +505,8 @@ module Cosmos
         begin
           file_text = File.read(path)
         rescue Exception => error
-          raise "Error reading procedure file : #{path}"
+          msg = "Error reading procedure file '#{path}' due to #{error.message}."
+          raise $!, msg, $!.backtrace
         end
 
         if use_file_cache and File.exist?(cache_filename)
@@ -786,7 +787,7 @@ module Cosmos
 
     # sleep in a script - returns true if canceled mid sleep
     def cosmos_script_sleep(sleep_time = nil)
-      return false if $cmd_tlm_disconnect
+      return false if $disconnected_targets
       if defined? ScriptRunnerFrame and ScriptRunnerFrame.instance
         sleep_time = 30000000 unless sleep_time # Handle infinite wait
         if sleep_time > 0.0
@@ -822,7 +823,7 @@ module Cosmos
         if eval(exp_to_eval)
           return true, value
         end
-        break if Time.now.sys >= end_time || $cmd_tlm_disconnect
+        break if Time.now.sys >= end_time || ($disconnected_targets && $disconnected_targets.include?(target_name))
 
         delta = Time.now.sys - work_start
         sleep_time = polling_rate - delta
@@ -905,7 +906,7 @@ module Cosmos
         Logger.info "#{check_str} success #{value_str}"
       else
         message = "#{check_str} failed #{value_str}"
-        if $cmd_tlm_disconnect
+        if $disconnected_targets && $disconnected_targets.include?(target_name)
           Logger.error message
         else
           raise CheckError, message

data/lib/cosmos/script/cmd_tlm_server.rb

@@ -208,5 +208,9 @@ module Cosmos
     def get_output_logs_filenames(filter = '*tlm.bin')
       return $cmd_tlm_server.get_output_logs_filenames(filter)
     end    
+
+    def get_saved_config(configuration_name = nil)
+      return $cmd_tlm_server.get_saved_config(configuration_name)
+    end
   end
 end

data/lib/cosmos/script/commands.rb

@@ -9,7 +9,6 @@
 # attribution addendums as found in the LICENSE.txt
 
 module Cosmos
-
   module Script
     private
 
@@ -33,25 +32,14 @@ module Cosmos
       no_hazardous = cmd.include?('no_hazardous') || cmd.include?('no_checks')
 
       begin
-        if $cmd_tlm_disconnect
-          # In disconnect mode we call API methods directly on the server
-          target_name, cmd_name, cmd_params = $cmd_tlm_server.send(cmd, *args)
-        else
-          # In connected mode we forward method calls through the JsonDrb object
-          # so we must call method_missing
-          target_name, cmd_name, cmd_params = $cmd_tlm_server.method_missing(cmd, *args)
-        end
+        target_name, cmd_name, cmd_params = $cmd_tlm_server.method_missing(cmd, *args)
         _log_cmd(target_name, cmd_name, cmd_params, raw, no_range, no_hazardous)
       rescue HazardousError => e
         ok_to_proceed = prompt_for_hazardous(e.target_name,
                                              e.cmd_name,
                                              e.hazardous_description)
         if ok_to_proceed
-          if $cmd_tlm_disconnect
-            target_name, cmd_name, cmd_params = $cmd_tlm_server.send(cmd_no_hazardous, *args)
-          else
-            target_name, cmd_name, cmd_params = $cmd_tlm_server.method_missing(cmd_no_hazardous, *args)
-          end
+          target_name, cmd_name, cmd_params = $cmd_tlm_server.method_missing(cmd_no_hazardous, *args)
           _log_cmd(target_name, cmd_name, cmd_params, raw, no_range, no_hazardous)
         else
           retry unless prompt_for_script_abort()
@@ -181,7 +169,7 @@ module Cosmos
     # Returns the buffer from the most recent specified command
     def get_cmd_buffer(target_name, command_name)
       return $cmd_tlm_server.get_cmd_buffer(target_name, command_name)
-    end    
+    end
 
   end # module Script
 

data/lib/cosmos/script/script.rb

@@ -20,14 +20,68 @@ require 'cosmos/script/scripting'
 require 'cosmos/script/tools'
 
 $cmd_tlm_server = nil
-$cmd_tlm_disconnect = false
+$disconnected_targets = nil
 $cmd_tlm_replay_mode = false
 
 module Cosmos
+  # Error raised by the API when a check fails
   class CheckError < RuntimeError; end
+  # Error raised when a Script should be stopped
   class StopScript < StandardError; end
+  # Error raised when a TestCase should be skipped by TestRunner
   class SkipTestCase < StandardError; end
 
+  # Provides a proxy to both a disconnected CmdTlmServer instance and the real
+  # JsonDRbObject which communicates with the real CmdTlmServer. If targets
+  # are disconnected their method calls are forwarded to the disconnected
+  # CmdTlmServer while all other calls are forwarded through to the real
+  # server by the JsonDRbObject.
+  class ServerProxy
+    # Creates a disconnected CmdTlmServer object if there are any
+    # $disconnected_targets defined. Also creates a JsonDRbObject
+    # connected to Replay (if $cmd_tlm_replay_mode) or to the
+    # Command and Telemetry Server.
+    def initialize(config_file)
+      if $disconnected_targets
+        # Start up a standalone CTS in disconnected mode
+        @disconnected = CmdTlmServer.new(config_file, false, true)
+      end
+      # Start a Json connect to the real server
+      if $cmd_tlm_replay_mode
+        @cmd_tlm_server = JsonDRbObject.new(System.connect_hosts['REPLAY_API'], System.ports['REPLAY_API'])
+      else
+        @cmd_tlm_server = JsonDRbObject.new(System.connect_hosts['CTS_API'], System.ports['CTS_API'])
+      end
+    end
+
+    # Ruby method which captures any method calls on this object. This allows
+    # us to proxy the methods to either the disconnected CmdTlmServer object
+    # or to the real server through the JsonDRbObject.
+    def method_missing(method_name, *method_params)
+      if $disconnected_targets && method_params[0].is_a?(String)
+        if method_params.length == 1
+          target = method_params[0].split(" ")[0]
+        else
+          target = method_params[0]
+        end
+        if $disconnected_targets.include?(target)
+          return @disconnected.send(method_name, *method_params)
+        end
+      end
+      # Must call shutdown and disconnect on the JsonDrbObject itself
+      # to avoid it being sent to the CmdTlmServer
+      case method_name
+      when :shutdown
+        @cmd_tlm_server.shutdown
+        @disconnected.stop if @disconnected
+      when :disconnect
+        @cmd_tlm_server.disconnect
+      else
+        @cmd_tlm_server.method_missing(method_name, *method_params)
+      end
+    end
+  end
+
   module Script
     # All methods are private so they can only be called by themselves and not
     # on another object. This is important for the JsonDrbObject class which we
@@ -40,43 +94,36 @@ module Cosmos
 
     # Called when this module is mixed in using "include Cosmos::Script"
     def self.included(base)
-      $cmd_tlm_disconnect = false
+      $disconnected_targets = nil
       $cmd_tlm_replay_mode = false
       $cmd_tlm_server = nil
       initialize_script_module()
     end
 
     def initialize_script_module(config_file = CmdTlmServer::DEFAULT_CONFIG_FILE)
-      if $cmd_tlm_disconnect
-        # Start up a standalone CTS in disconnected mode
-        $cmd_tlm_server = CmdTlmServer.new(config_file, false, true)
-      else
-        # Start a Json connect to the real server
-        if $cmd_tlm_replay_mode
-          $cmd_tlm_server = JsonDRbObject.new(System.connect_hosts['REPLAY_API'], System.ports['REPLAY_API'])
-        else
-          $cmd_tlm_server = JsonDRbObject.new(System.connect_hosts['CTS_API'], System.ports['CTS_API'])
-        end
-      end
+      shutdown_cmd_tlm()
+      $cmd_tlm_server = ServerProxy.new(config_file)
     end
 
     def shutdown_cmd_tlm
-      $cmd_tlm_server.shutdown if $cmd_tlm_server && !$cmd_tlm_disconnect
+      $cmd_tlm_server.shutdown if $cmd_tlm_server
     end
 
-    def set_cmd_tlm_disconnect(disconnect = false, config_file = CmdTlmServer::DEFAULT_CONFIG_FILE)
-      if disconnect != $cmd_tlm_disconnect
-        $cmd_tlm_disconnect = disconnect
-        initialize_script_module(config_file)
-      end
+    def set_disconnected_targets(targets, config_file = CmdTlmServer::DEFAULT_CONFIG_FILE)
+      $disconnected_targets = targets
+      initialize_script_module(config_file)
     end
 
-    def get_cmd_tlm_disconnect
-      return $cmd_tlm_disconnect
+    def get_disconnected_targets
+      return $disconnected_targets
+    end
+
+    def clear_disconnected_targets
+      $disconnected_targets = nil
     end
 
     def script_disconnect
-      $cmd_tlm_server.disconnect if $cmd_tlm_server && !$cmd_tlm_disconnect
+      $cmd_tlm_server.disconnect if $cmd_tlm_server
     end
 
     def set_replay_mode(replay_mode)
@@ -89,6 +136,5 @@ module Cosmos
     def get_replay_mode
       $cmd_tlm_replay_mode
     end
-
   end
 end

data/lib/cosmos/streams/tcpip_client_stream.rb

@@ -38,8 +38,8 @@ module Cosmos
       @read_port  = ConfigParser.handle_nil(read_port)
       @read_port  = Integer(read_port) if @read_port
 
-      write_addr = nil
-      read_addr = nil
+      @write_addr = nil
+      @read_addr = nil
       begin
         @write_addr = Socket.pack_sockaddr_in(@write_port, @hostname) if @write_port
         @read_addr = Socket.pack_sockaddr_in(@read_port, @hostname) if @read_port

data/lib/cosmos/system/system.rb

@@ -73,11 +73,11 @@ module Cosmos
     instance_attr_reader :additional_md5_files
 
     # Known COSMOS ports
-    KNOWN_PORTS = ['CTS_API', 'TLMVIEWER_API', 'CTS_PREIDENTIFIED', 'CTS_CMD_ROUTER', 'REPLAY_API', 'REPLAY_PREIDENTIFIED', 'REPLAY_CMD_ROUTER']
+    KNOWN_PORTS = ['CTS_API', 'TLMVIEWER_API', 'CTS_PREIDENTIFIED', 'CTS_CMD_ROUTER', 'REPLAY_API', 'REPLAY_PREIDENTIFIED', 'REPLAY_CMD_ROUTER', 'DART_STREAM', 'DART_DECOM']
     # Known COSMOS hosts
-    KNOWN_HOSTS = ['CTS_API', 'TLMVIEWER_API', 'CTS_PREIDENTIFIED', 'CTS_CMD_ROUTER', 'REPLAY_API', 'REPLAY_PREIDENTIFIED', 'REPLAY_CMD_ROUTER']
+    KNOWN_HOSTS = ['CTS_API', 'TLMVIEWER_API', 'CTS_PREIDENTIFIED', 'CTS_CMD_ROUTER', 'REPLAY_API', 'REPLAY_PREIDENTIFIED', 'REPLAY_CMD_ROUTER', 'DART_STREAM', 'DART_DECOM']
     # Known COSMOS paths
-    KNOWN_PATHS = ['LOGS', 'TMP', 'SAVED_CONFIG', 'TABLES', 'HANDBOOKS', 'PROCEDURES', 'SEQUENCES']
+    KNOWN_PATHS = ['LOGS', 'TMP', 'SAVED_CONFIG', 'TABLES', 'HANDBOOKS', 'PROCEDURES', 'SEQUENCES', 'DART_DATA', 'DART_LOGS']
 
     @@instance = nil
     @@instance_mutex = Mutex.new
@@ -252,13 +252,17 @@ module Cosmos
           when 'DEFAULT_PACKET_LOG_WRITER'
             usage = "#{keyword} <FILENAME> <Specific Parameters>"
             parser.verify_num_parameters(1, nil, usage)
-            @default_packet_log_writer = Cosmos.require_class(parameters[0])
+            Cosmos.disable_warnings do
+              @default_packet_log_writer = Cosmos.require_class(parameters[0])
+            end
             @default_packet_log_writer_params = parameters[1..-1] if parameters.size > 1
 
           when 'DEFAULT_PACKET_LOG_READER'
             usage = "#{keyword} <FILENAME> <Specific Parameters>"
             parser.verify_num_parameters(1, nil, usage)
-            @default_packet_log_reader = Cosmos.require_class(parameters[0])
+            Cosmos.disable_warnings do
+              @default_packet_log_reader = Cosmos.require_class(parameters[0])
+            end
             @default_packet_log_reader_params = parameters[1..-1] if parameters.size > 1
 
           when 'ENABLE_SOUND'
@@ -429,8 +433,6 @@ module Cosmos
       end # parser.parse_file
     end
 
-
-
     # Load the specified configuration by iterating through the SAVED_CONFIG
     # directory looking for a matching MD5 sum. Updates the internal state so
     # subsequent commands and telemetry methods return the new configuration.
@@ -439,6 +441,11 @@ module Cosmos
     #   configuration. Pass nil to load the default configuration.
     # @return [String, Exception/nil] The actual configuration loaded
     def load_configuration(name = nil)
+      unless @config
+        # Ensure packets have been lazy loaded
+        System.commands
+      end
+
       if name && @config
         # Make sure they're requesting something other than the current
         # configuration.
@@ -473,8 +480,6 @@ module Cosmos
           end
         end
       else
-        # Ensure packets have been lazy loaded
-        System.commands
         update_config(@initial_config)
       end
       return @config.name, nil
@@ -487,7 +492,7 @@ module Cosmos
 
     # Resets the System's internal state to defaults.
     #
-    # @params [String] Path to system.txt config file to process. Defaults to config/system/system.txt
+    # @param filename [String] Path to system.txt config file to process. Defaults to config/system/system.txt
     def reset_variables(filename = nil)
       @targets = {}
       @targets['UNKNOWN'] = Target.new('UNKNOWN')
@@ -516,6 +521,8 @@ module Cosmos
       @ports['REPLAY_API'] = 7877
       @ports['REPLAY_PREIDENTIFIED'] = 7879
       @ports['REPLAY_CMD_ROUTER'] = 7880
+      @ports['DART_DECOM'] = 8777
+      @ports['DART_STREAM'] = 8779
 
       @listen_hosts = {}
       @listen_hosts['CTS_API'] = '127.0.0.1'
@@ -527,6 +534,8 @@ module Cosmos
       # Localhost would be more secure but historically these are open to allow for chaining servers by default
       @listen_hosts['REPLAY_PREIDENTIFIED'] = '0.0.0.0'
       @listen_hosts['REPLAY_CMD_ROUTER'] = '0.0.0.0'
+      @listen_hosts['DART_STREAM'] = '0.0.0.0'
+      @listen_hosts['DART_DECOM'] = '0.0.0.0'
 
       @connect_hosts = {}
       @connect_hosts['CTS_API'] = '127.0.0.1'
@@ -536,6 +545,8 @@ module Cosmos
       @connect_hosts['REPLAY_API'] = '127.0.0.1'
       @connect_hosts['REPLAY_PREIDENTIFIED'] = '127.0.0.1'
       @connect_hosts['REPLAY_CMD_ROUTER'] = '127.0.0.1'
+      @connect_hosts['DART_STREAM'] = '127.0.0.1'
+      @connect_hosts['DART_DECOM'] = '127.0.0.1'
 
       @paths = {}
       @paths['LOGS'] = File.join(USERPATH, 'outputs', 'logs')
@@ -545,6 +556,8 @@ module Cosmos
       @paths['HANDBOOKS'] = File.join(USERPATH, 'outputs', 'handbooks')
       @paths['PROCEDURES'] = [File.join(USERPATH, 'procedures')]
       @paths['SEQUENCES'] = File.join(USERPATH, 'outputs', 'sequences')
+      @paths['DART_DATA'] = File.join(USERPATH, 'outputs', 'dart', 'data')
+      @paths['DART_LOGS'] = File.join(USERPATH, 'outputs', 'dart', 'logs')
 
       unless filename
         system_arg = false
@@ -575,15 +588,27 @@ module Cosmos
       self.instance.reset
     end
 
+    def find_configuration(name)
+      Cosmos.set_working_dir do
+        Dir.foreach(@paths['SAVED_CONFIG']) do |filename|
+          full_path = File.join(@paths['SAVED_CONFIG'], filename)
+          if File.exist?(full_path) && File.basename(filename, ".*")[-32..-1] == name
+            return full_path
+          end
+        end
+      end
+      nil
+    end
+
     protected
 
-    def unzip(zip_file)
-      zip_dir = File.join(@paths['TMP'], File.basename(zip_file, ".*"))
+    def unzip(zip_file_name)
+      zip_dir = File.join(@paths['TMP'], File.basename(zip_file_name, ".*"))
       # Only unzip if we have to. We assume the unzipped directory structure is
       # intact. If not they'll get a popop with the errors encountered when
       # loading the configuration.
       unless File.exist? zip_dir
-        Zip::File.open(zip_file) do |zip_file|
+        Zip::File.open(zip_file_name) do |zip_file|
           zip_file.each do |entry|
             path = File.join(@paths['TMP'], entry.name)
             FileUtils.mkdir_p(File.dirname(path))
@@ -656,18 +681,6 @@ module Cosmos
       @telemetry.reset if current_config != config
     end
 
-    def find_configuration(name)
-      Cosmos.set_working_dir do
-        Dir.foreach(@paths['SAVED_CONFIG']) do |filename|
-          full_path = File.join(@paths['SAVED_CONFIG'], filename)
-          if File.exist?(full_path) && File.basename(filename, ".*")[-32..-1] == name
-            return full_path
-          end
-        end
-      end
-      nil
-    end
-
     def save_configuration
       Cosmos.set_working_dir do
         configuration = find_configuration(@config.name)
@@ -707,6 +720,7 @@ module Cosmos
                 end
               end
             end
+            File.chmod(0444, configuration) # Mark readonly
           rescue Exception => error
             Logger.error "Problem saving configuration to #{configuration}: #{error.class}:#{error.message}\n#{error.backtrace.join("\n")}\n"
           end
@@ -831,6 +845,8 @@ module Cosmos
       tlm_meta.write('RUBY_VERSION', "#{RUBY_VERSION}p#{RUBY_PATCHLEVEL}")
 
       cmd_meta.buffer = tlm_meta.buffer
+      cmd_meta.received_time = Time.now.sys
+      tlm_meta.received_time = Time.now.sys
     end
 
     def build_cmd_system_meta
@@ -848,6 +864,7 @@ module Cosmos
 
     def build_tlm_system_meta
       tlm_meta = Packet.new('SYSTEM', 'META', :BIG_ENDIAN)
+      tlm_meta.define_reserved_items()
       item = tlm_meta.append_item('PKTID', 8, :UINT, nil, :BIG_ENDIAN, :ERROR, nil, nil, nil, 1)
       item.description = 'Packet Id'
       item.meta["READ_ONLY"] = []