codeclimate-services 1.6.1 → 1.7.0

data/spec/cc/service/stash_pull_requests_spec.rb

@@ -0,0 +1,132 @@
+describe CC::Service::StashPullRequests, type: :service do
+  it "receive test" do
+    http_stubs.get "/rest/api/1.0/users" do
+      [200, {}, "{ 'values': [] }"]
+    end
+
+    response = receive_test
+
+    expect({ ok: true, message: "Test succeeded" }).to eq(response)
+  end
+
+  it "failed receive test" do
+    http_stubs.get "/rest/api/1.0/users" do
+      [401, {}, ""]
+    end
+
+    response = receive_test
+
+    expect({ ok: false, message: "API request unsuccessful (401)" }).to eq(response)
+  end
+
+  it "pull request status pending" do
+    expect_status_update("abc123", "state" => "INPROGRESS",
+                                   "description" => /is analyzing/)
+
+    receive_pull_request(
+      commit_sha: "abc123",
+      state: "pending",
+    )
+  end
+
+  it "pull request status success detailed" do
+    expect_status_update("abc123", "state" => "SUCCESSFUL",
+      "description" => "Code Climate found 2 new issues and 1 fixed issue.")
+
+    receive_pull_request(
+      commit_sha: "abc123",
+      state: "success",
+    )
+  end
+
+  it "pull request status failure" do
+    expect_status_update("abc123", "state" => "FAILED",
+      "description" => "Code Climate found 2 new issues and 1 fixed issue.")
+
+    receive_pull_request(
+      commit_sha: "abc123",
+      state: "failure",
+    )
+  end
+
+  it "pull request status error" do
+    expect_status_update("abc123", "state" => "FAILED",
+      "description" => "Code Climate encountered an error attempting to analyze this pull request.")
+
+    receive_pull_request(
+      commit_sha: "abc123",
+      state: "error",
+    )
+  end
+
+  it "pull request status error message provided" do
+    message = "Everything broke."
+
+    expect_status_update("abc123", "state" => "FAILED",
+      "description" => message)
+
+    receive_pull_request(
+      commit_sha: "abc123",
+      message: message,
+      state: "error",
+    )
+  end
+
+  it "pull request status skipped" do
+    expect_status_update("abc123", "state" => "SUCCESSFUL",
+      "description" => "Code Climate has skipped analysis of this commit.")
+
+    receive_pull_request(
+      commit_sha: "abc123",
+      state: "skipped",
+    )
+  end
+
+  it "failed receive pull request" do
+    commit_sha = "abc123"
+
+    http_stubs.post("/rest/build-status/1.0/commits/#{commit_sha}") do
+      [401, {}, ""]
+    end
+
+
+    expect do
+      receive_pull_request(
+        commit_sha: "abc123",
+        state: "success",
+      )
+    end.to raise_error(CC::Service::HTTPError)
+  end
+
+  private
+
+  def expect_status_update(commit_sha, params)
+    http_stubs.post("/rest/build-status/1.0/commits/#{commit_sha}") do |env|
+      body = JSON.parse(env[:body])
+
+      params.each do |k, v|
+        expect(v).to match(body[k])
+      end
+    end
+  end
+
+  def default_config
+    { domain: "example.com", username: "zaphod", password: "g4rgl3bl4st3r" }
+  end
+
+  def receive_pull_request(event_data, config = {})
+    service_receive(
+      CC::Service::StashPullRequests,
+      default_config.merge(config),
+      { name: "pull_request", issue_comparison_counts: { "fixed" => 1, "new" => 2 } }.merge(event_data),
+    )
+  end
+
+  def receive_test(config = {}, event_data = {})
+    service_receive(
+      CC::Service::StashPullRequests,
+      default_config.merge(config),
+      { name: "test" }.merge(event_data),
+    )
+  end
+end

data/spec/cc/service_spec.rb

@@ -0,0 +1,78 @@
+describe CC::Service, type: :service do
+  it "validates events" do
+    expect { CC::Service.new(:foo, {}, {}, {}) }.to raise_error(ArgumentError)
+  end
+
+  it "default path to ca file" do
+    s = CC::Service.new({}, name: "test")
+    expect(File.expand_path("../../../config/cacert.pem", __FILE__)).to eq(s.ca_file)
+    expect(File.exist?(s.ca_file)).to eq(true)
+  end
+
+  it "custom path to ca file" do
+    begin
+      ENV["CODECLIMATE_CA_FILE"] = "/tmp/cacert.pem"
+      s = CC::Service.new({}, name: "test")
+      expect("/tmp/cacert.pem").to eq(s.ca_file)
+    ensure
+      ENV.delete("CODECLIMATE_CA_FILE")
+    end
+  end
+
+  it "nothing has a handler" do
+    service = CC::Service.new({}, name: "test")
+
+    result = service.receive
+
+    expect(result[:ok]).to eq(false)
+    expect(result[:ignored]).to eq(true)
+    expect(result[:message]).to eq("No service handler found")
+  end
+
+  it "post success" do
+    stub_http("/my/test/url", [200, {}, '{"ok": true, "thing": "123"}'])
+
+    response = service_post("/my/test/url", { token: "1234" }.to_json, {}) do |inner_response|
+      body = JSON.parse(inner_response.body)
+      { thing: body["thing"] }
+    end
+
+    expect(response[:ok]).to eq(true)
+    expect(response[:params]).to eq('{"token":"1234"}')
+    expect(response[:endpoint_url]).to eq("/my/test/url")
+    expect(response[:status]).to eq(200)
+  end
+
+  it "post redirect success" do
+    stub_http("/my/test/url", [307, { "Location" => "/my/redirect/url" }, '{"ok": false, "redirect": true}'])
+    stub_http("/my/redirect/url", [200, {}, '{"ok": true, "thing": "123"}'])
+
+    response = service_post_with_redirects("/my/test/url", { token: "1234" }.to_json, {}) do |inner_response|
+      body = JSON.parse(inner_response.body)
+      { thing: body["thing"] }
+    end
+
+    expect(response[:ok]).to eq(true)
+    expect(response[:params]).to eq('{"token":"1234"}')
+    expect(response[:endpoint_url]).to eq("/my/test/url")
+    expect(response[:status]).to eq(200)
+  end
+
+  it "post http failure" do
+    stub_http("/my/wrong/url", [404, {}, ""])
+
+    expect { service_post("/my/wrong/url", { token: "1234" }.to_json, {}) }.to raise_error(CC::Service::HTTPError)
+  end
+
+  it "post some other failure" do
+    stub_http("/my/wrong/url") { raise ArgumentError, "lol" }
+
+    expect { service_post("/my/wrong/url", { token: "1234" }.to_json, {}) }.to raise_error(ArgumentError)
+  end
+
+  it "services" do
+    services = CC::Service.services
+
+    expect(services.include?(CC::PullRequests)).not_to eq(true)
+  end
+end

data/{test → spec}/fixtures.rb

@@ -7,7 +7,7 @@ class EventFixtures
     "C" => 15,
     "D" => 20,
     "F" => 25,
-  }
+  }.freeze
 
   def initialize(options)
     @options = {
@@ -27,7 +27,7 @@ class EventFixtures
       name: "coverage",
       covered_percent: to,
       previous_covered_percent: from,
-      covered_percent_delta: delta
+      covered_percent_delta: delta,
     )
   end
 
@@ -42,7 +42,7 @@ class EventFixtures
       rating: to,
       previous_rating: from,
       remediation_cost: REMEDIATIONS[to],
-      previous_remediation_cost: REMEDIATIONS[from]
+      previous_remediation_cost: REMEDIATIONS[from],
     )
   end
 
@@ -54,7 +54,6 @@ class EventFixtures
   def issue
     options.merge(name: "issue")
   end
-
 end
 
 def event(name, options = {})

data/spec/spec_helper.rb

@@ -0,0 +1,37 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
+cwd = File.expand_path(File.dirname(__FILE__))
+require "#{cwd}/../config/load"
+require "#{cwd}/fixtures"
+Dir["#{cwd}/support/*.rb"].sort.each do |helper|
+  require helper
+end
+CC::Service.load_services
+
+require "#{cwd}/support/service_context"
+
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+end

data/spec/support/service_context.rb

@@ -0,0 +1,42 @@
+RSpec.shared_examples "Service Context", type: :service do
+  let!(:http_stubs) { Faraday::Adapter::Test::Stubs.new }
+
+  before do
+    I18n.enforce_available_locales = true
+  end
+
+  after do
+    http_stubs.verify_stubbed_calls
+  end
+
+  def service(klass, data, payload)
+    service = klass.new(data, payload)
+    service.http adapter: [:test, http_stubs]
+    service
+  end
+
+  def service_receive(*args)
+    service(*args).receive
+  end
+
+  def service_post(*args)
+    service(
+      CC::Service,
+      { data: "my data" },
+      event(:quality, to: "D", from: "C"),
+    ).service_post(*args)
+  end
+
+  def service_post_with_redirects(*args)
+    service(
+      CC::Service,
+      { data: "my data" },
+      event(:quality, to: "D", from: "C"),
+    ).service_post_with_redirects(*args)
+  end
+
+  def stub_http(url, response = nil, &block)
+    block ||= ->(*_args) { response }
+    http_stubs.post(url, &block)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-services
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.7.0
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-31 00:00:00.000000000 Z
+date: 2016-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.6.2
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: test-unit
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -144,11 +144,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
 - ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- base_rubocop.yml
 - bin/bundler
 - bin/coderay
 - bin/nokogiri
@@ -196,29 +199,30 @@ files:
 - lib/cc/services/version.rb
 - pull_request_test.rb
 - service_test.rb
-- test/asana_test.rb
-- test/axiom/types/password_test.rb
-- test/campfire_test.rb
-- test/fixtures.rb
-- test/flowdock_test.rb
-- test/formatters/snapshot_formatter_test.rb
-- test/github_issues_test.rb
-- test/github_pull_requests_test.rb
-- test/gitlab_merge_requests_test.rb
-- test/helper.rb
-- test/hipchat_test.rb
-- test/invocation_error_handling_test.rb
-- test/invocation_return_values_test.rb
-- test/invocation_test.rb
-- test/jira_test.rb
-- test/lighthouse_test.rb
-- test/pivotal_tracker_test.rb
-- test/presenters/pull_requests_presenter_test.rb
-- test/service_test.rb
-- test/slack_test.rb
-- test/stash_pull_requests_test.rb
-- test/support/fake_logger.rb
-- test/with_metrics_test.rb
+- spec/axiom/types/password_spec.rb
+- spec/cc/formatters/snapshot_formatter_spec.rb
+- spec/cc/presenters/pull_requests_presenter_spec.rb
+- spec/cc/service/asana_spec.rb
+- spec/cc/service/campfire_spec.rb
+- spec/cc/service/flowdock_spec.rb
+- spec/cc/service/github_issues_spec.rb
+- spec/cc/service/github_pull_requests_spec.rb
+- spec/cc/service/gitlab_merge_requests_spec.rb
+- spec/cc/service/hipchat_spec.rb
+- spec/cc/service/invocation/error_handling_spec.rb
+- spec/cc/service/invocation/return_values_spec.rb
+- spec/cc/service/invocation/with_metrics_spec.rb
+- spec/cc/service/invocation_spec.rb
+- spec/cc/service/jira_spec.rb
+- spec/cc/service/lighthouse_spec.rb
+- spec/cc/service/pivotal_tracker_spec.rb
+- spec/cc/service/slack_spec.rb
+- spec/cc/service/stash_pull_requests_spec.rb
+- spec/cc/service_spec.rb
+- spec/fixtures.rb
+- spec/spec_helper.rb
+- spec/support/fake_logger.rb
+- spec/support/service_context.rb
 homepage: ''
 licenses:
 - MIT
@@ -239,31 +243,32 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Service classes for Code Climate
 test_files:
-- test/asana_test.rb
-- test/axiom/types/password_test.rb
-- test/campfire_test.rb
-- test/fixtures.rb
-- test/flowdock_test.rb
-- test/formatters/snapshot_formatter_test.rb
-- test/github_issues_test.rb
-- test/github_pull_requests_test.rb
-- test/gitlab_merge_requests_test.rb
-- test/helper.rb
-- test/hipchat_test.rb
-- test/invocation_error_handling_test.rb
-- test/invocation_return_values_test.rb
-- test/invocation_test.rb
-- test/jira_test.rb
-- test/lighthouse_test.rb
-- test/pivotal_tracker_test.rb
-- test/presenters/pull_requests_presenter_test.rb
-- test/service_test.rb
-- test/slack_test.rb
-- test/stash_pull_requests_test.rb
-- test/support/fake_logger.rb
-- test/with_metrics_test.rb
+- spec/axiom/types/password_spec.rb
+- spec/cc/formatters/snapshot_formatter_spec.rb
+- spec/cc/presenters/pull_requests_presenter_spec.rb
+- spec/cc/service/asana_spec.rb
+- spec/cc/service/campfire_spec.rb
+- spec/cc/service/flowdock_spec.rb
+- spec/cc/service/github_issues_spec.rb
+- spec/cc/service/github_pull_requests_spec.rb
+- spec/cc/service/gitlab_merge_requests_spec.rb
+- spec/cc/service/hipchat_spec.rb
+- spec/cc/service/invocation/error_handling_spec.rb
+- spec/cc/service/invocation/return_values_spec.rb
+- spec/cc/service/invocation/with_metrics_spec.rb
+- spec/cc/service/invocation_spec.rb
+- spec/cc/service/jira_spec.rb
+- spec/cc/service/lighthouse_spec.rb
+- spec/cc/service/pivotal_tracker_spec.rb
+- spec/cc/service/slack_spec.rb
+- spec/cc/service/stash_pull_requests_spec.rb
+- spec/cc/service_spec.rb
+- spec/fixtures.rb
+- spec/spec_helper.rb
+- spec/support/fake_logger.rb
+- spec/support/service_context.rb