codeclimate-services 1.6.1 → 1.7.0

data/pull_request_test.rb

@@ -15,7 +15,7 @@
 #         Generate new token
 #
 ###
-require 'cc/services'
+require "cc/services"
 CC::Service.load_services
 
 class WithResponseLogging
@@ -28,17 +28,18 @@ class WithResponseLogging
   end
 end
 
-service = CC::Service::GitHubPullRequests.new({
-  oauth_token:   ENV.fetch("OAUTH_TOKEN"),
-}, {
-  name:        "pull_request",
+service = CC::Service::GitHubPullRequests.new(
+  {
+    oauth_token: ENV.fetch("OAUTH_TOKEN"),
+  },
+  name: "pull_request",
   # https://github.com/codeclimate/nillson/pull/33
-  state:       "success",
+  state: "success",
   github_slug: "codeclimate/nillson",
-  issue_comparison_counts: {"new" => 0, "fixed" => 0},
-  number:      33,
-  commit_sha:  "986ec903b8420f4e8c8d696d8950f7bd0667ff0c"
-})
+  issue_comparison_counts: { "new" => 0, "fixed" => 0 },
+  number: 33,
+  commit_sha: "986ec903b8420f4e8c8d696d8950f7bd0667ff0c",
+)
 
 CC::Service::Invocation.new(service) do |i|
   i.wrap(WithResponseLogging)

data/service_test.rb

@@ -18,7 +18,7 @@
 #   REPO_NAME  Defaults to "App"
 #
 ###
-require 'cc/services'
+require "cc/services"
 CC::Service.load_services
 
 class WithResponseLogging
@@ -40,7 +40,7 @@ class ServiceTest
   def test(payload = {})
     config = {}
 
-    puts "-"*80
+    puts "-" * 80
     puts @klass
 
     @params.each do |param|
@@ -59,7 +59,7 @@ class ServiceTest
     test_service(@klass, config, payload)
   end
 
-private
+  private
 
   def to_env_var(param)
     "#{@klass.to_s.split("::").last}_#{param}".upcase
@@ -70,7 +70,7 @@ private
 
     service = klass.new(
       config,
-      { name: :test, repo_name: repo_name }.merge(payload)
+      { name: :test, repo_name: repo_name }.merge(payload),
     )
 
     CC::Service::Invocation.new(service) do |i|
@@ -83,4 +83,4 @@ ServiceTest.new(CC::Service::Slack, :webhook_url).test
 ServiceTest.new(CC::Service::Flowdock, :api_token).test
 ServiceTest.new(CC::Service::Jira, :username, :password, :domain, :project_id).test
 ServiceTest.new(CC::Service::Asana, :api_key, :workspace_id, :project_id).test
-ServiceTest.new(CC::Service::GitHubPullRequests, :oauth_token).test({ github_slug: "codeclimate/codeclimate" })
+ServiceTest.new(CC::Service::GitHubPullRequests, :oauth_token).test(github_slug: "codeclimate/codeclimate")

data/spec/axiom/types/password_spec.rb

@@ -0,0 +1,14 @@
+describe Axiom::Types::Password do
+  class TestConfiguration < CC::Service::Config
+    attribute :password_attribute, Password
+    attribute :string_attribute, String
+  end
+
+  it "password type inference" do
+    expect(Axiom::Types::Password).to eq(TestConfiguration.attribute_set[:password_attribute].type)
+  end
+
+  it "string type inference" do
+    expect(Axiom::Types::String).to eq(TestConfiguration.attribute_set[:string_attribute].type)
+  end
+end

data/spec/cc/formatters/snapshot_formatter_spec.rb

@@ -0,0 +1,44 @@
+describe CC::Formatters::SnapshotFormatter do
+  def described_class
+    CC::Formatters::SnapshotFormatter::Base
+  end
+
+  it "quality alert with new constants" do
+    f = described_class.new("new_constants" => [{ "to" => { "rating" => "D" } }], "changed_constants" => [])
+    expect(f.alert_constants_payload).not_to be_nil
+  end
+
+  it "quality alert with decreased constants" do
+    f = described_class.new("new_constants" => [],
+                            "changed_constants" => [{ "to" => { "rating" => "D" }, "from" => { "rating" => "A" } }])
+    expect(f.alert_constants_payload).not_to be_nil
+  end
+
+  it "quality improvements with better ratings" do
+    f = described_class.new("new_constants" => [],
+                            "changed_constants" => [{ "to" => { "rating" => "A" }, "from" => { "rating" => "D" } }])
+    expect(f.improved_constants_payload).not_to be_nil
+  end
+
+  it "nothing set without changes" do
+    f = described_class.new("new_constants" => [], "changed_constants" => [])
+    expect(f.alert_constants_payload).to be_nil
+    expect(f.improved_constants_payload).to be_nil
+  end
+
+  it "snapshot formatter test with relaxed constraints" do
+    f = CC::Formatters::SnapshotFormatter::Sample.new(
+      "new_constants" => [{ "name" => "foo", "to" => { "rating" => "A" } }, { "name" => "bar", "to" => { "rating" => "A" } }],
+      "changed_constants" => [
+        { "from" => { "rating" => "B" }, "to" => { "rating" => "C" } },
+        { "from" => { "rating" => "D" }, "to" => { "rating" => "D" } },
+        { "from" => { "rating" => "D" }, "to" => { "rating" => "D" } },
+        { "from" => { "rating" => "A" }, "to" => { "rating" => "B" } },
+        { "from" => { "rating" => "C" }, "to" => { "rating" => "B" } },
+      ],
+    )
+
+    expect(f.alert_constants_payload).not_to be_nil
+    expect(f.improved_constants_payload).not_to be_nil
+  end
+end

data/spec/cc/presenters/pull_requests_presenter_spec.rb

@@ -0,0 +1,45 @@
+require "cc/presenters/pull_requests_presenter"
+
+describe CC::Service::PullRequestsPresenter, type: :service do
+  it "message singular" do
+    expect("Code Climate found 1 new issue and 1 fixed issue.").to eq(build_presenter("fixed" => 1, "new" => 1).success_message)
+  end
+
+  it "message plural" do
+    expect("Code Climate found 2 new issues and 1 fixed issue.").to eq(build_presenter("fixed" => 1, "new" => 2).success_message)
+  end
+
+  it "message only fixed" do
+    expect("Code Climate found 1 fixed issue.").to eq(build_presenter("fixed" => 1, "new" => 0).success_message)
+  end
+
+  it "message only new" do
+    expect("Code Climate found 3 new issues.").to eq(build_presenter("fixed" => 0, "new" => 3).success_message)
+  end
+
+  it "message no new or fixed" do
+    expect("Code Climate didn't find any new or fixed issues.").to eq(build_presenter("fixed" => 0, "new" => 0).success_message)
+  end
+
+  it "message coverage same" do
+    expect("85% test coverage").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message)
+  end
+
+  it "message coverage up" do
+    expect("85.5% test coverage (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message)
+  end
+
+  it "message coverage down" do
+    expect("85.35% test coverage (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
+  end
+
+  private
+
+  def build_payload(issue_counts)
+    { "issue_comparison_counts" => issue_counts }
+  end
+
+  def build_presenter(issue_counts, payload = {})
+    CC::Service::PullRequestsPresenter.new(build_payload(issue_counts).merge(payload))
+  end
+end

data/{test/asana_test.rb → spec/cc/service/asana_spec.rb}

@@ -1,73 +1,71 @@
-require File.expand_path('../helper', __FILE__)
-
-class TestAsana < CC::Service::TestCase
-  def test_quality
+describe CC::Service::Asana, type: :service do
+  it "quality" do
     assert_asana_receives(
       event(:quality, to: "D", from: "C"),
-      "Refactor User from a D on Code Climate - https://codeclimate.com/repos/1/feed"
+      "Refactor User from a D on Code Climate - https://codeclimate.com/repos/1/feed",
     )
   end
 
-  def test_vulnerability
+  it "vulnerability" do
     assert_asana_receives(
       event(:vulnerability, vulnerabilities: [{
-        "warning_type" => "critical",
-        "location" => "app/user.rb line 120"
-      }]),
-      "New critical issue found in app/user.rb line 120 - https://codeclimate.com/repos/1/feed"
+              "warning_type" => "critical",
+              "location" => "app/user.rb line 120",
+            }]),
+      "New critical issue found in app/user.rb line 120 - https://codeclimate.com/repos/1/feed",
     )
   end
 
-  def test_issue
+  it "issue" do
     payload = {
       issue: {
         "check_name" => "Style/LongLine",
-        "description" => "Line is too long [1000/80]"
+        "description" => "Line is too long [1000/80]",
       },
       constant_name: "foo.rb",
-      details_url: "http://example.com/repos/id/foo.rb#issue_123"
+      details_url: "http://example.com/repos/id/foo.rb#issue_123",
     }
 
     assert_asana_receives(
       event(:issue, payload),
       "Fix \"Style/LongLine\" issue in foo.rb",
-      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123"
+      "Line is too long [1000/80]\n\nhttp://example.com/repos/id/foo.rb#issue_123",
     )
   end
 
-  def test_successful_post
-    @stubs.post '/api/1.0/tasks' do |env|
+  it "successful post" do
+    http_stubs.post "/api/1.0/tasks" do |_env|
       [200, {}, '{"data":{"id":"2"}}']
     end
 
     response = receive_event
 
-    assert_equal "2", response[:id]
-    assert_equal "https://app.asana.com/0/1/2", response[:url]
+    expect(response[:id]).to eq("2")
+    expect(response[:url]).to eq("https://app.asana.com/0/1/2")
   end
 
-  def test_receive_test
-    @stubs.post '/api/1.0/tasks' do |env|
+  it "receive test" do
+    http_stubs.post "/api/1.0/tasks" do |_env|
       [200, {}, '{"data":{"id":"4"}}']
     end
 
     response = receive_event(name: "test")
 
-    assert_equal "Ticket <a href='https://app.asana.com/0/1/4'>4</a> created.", response[:message]
+    expect(response[:message]).to eq("Ticket <a href='https://app.asana.com/0/1/4'>4</a> created.")
   end
 
   private
 
   def assert_asana_receives(event_data, name, notes = "")
-    @stubs.post '/api/1.0/tasks' do |env|
+    http_stubs.post "/api/1.0/tasks" do |env|
       body = JSON.parse(env[:body])
       data = body["data"]
 
-      assert_equal "1",             data["workspace"]
-      assert_equal "2",             data["projects"].first
-      assert_equal "jim@asana.com", data["assignee"]
-      assert_equal name,            data["name"]
-      assert_equal notes,           data["notes"]
+      expect(data["workspace"]).to eq("1")
+      expect(data["projects"].first).to eq("2")
+      expect(data["assignee"]).to eq("jim@asana.com")
+      expect(data["name"]).to eq(name)
+      expect(data["notes"]).to eq(notes)
 
       [200, {}, '{"data":{"id":4}}']
     end
@@ -76,10 +74,10 @@ class TestAsana < CC::Service::TestCase
   end
 
   def receive_event(event_data = nil)
-    receive(
+    service_receive(
       CC::Service::Asana,
       { api_key: "abc123", workspace_id: "1", project_id: "2", assignee: "jim@asana.com" },
-      event_data || event(:quality, to: "D", from: "C")
+      event_data || event(:quality, to: "D", from: "C"),
     )
   end
 end

data/{test/campfire_test.rb → spec/cc/service/campfire_spec.rb}

@@ -1,109 +1,105 @@
-require File.expand_path('../helper', __FILE__)
-
-class TestCampfire < CC::Service::TestCase
-  def test_config
-    assert_raises CC::Service::ConfigurationError do
-      service(CC::Service::Campfire, {}, {name: "test"})
-    end
+describe CC::Service::Campfire, type: :service do
+  it "config" do
+    expect { service(CC::Service::Campfire, {}, name: "test") }.to raise_error(CC::Service::ConfigurationError)
   end
 
-  def test_test_hook
+  it "test hook" do
     assert_campfire_receives(
       { name: "test", repo_name: "Rails" },
-      "[Code Climate][Rails] This is a test of the Campfire service hook"
+      "[Code Climate][Rails] This is a test of the Campfire service hook",
     )
   end
 
-  def test_coverage_improved
+  it "coverage improved" do
     e = event(:coverage, to: 90.2, from: 80)
 
     assert_campfire_receives(e, [
       "[Code Climate][Example] :sunny:",
       "Test coverage has improved to 90.2% (+10.2%).",
-      "(https://codeclimate.com/repos/1/feed)"
+      "(https://codeclimate.com/repos/1/feed)",
     ].join(" "))
   end
 
-  def test_coverage_declined
+  it "coverage declined" do
     e = event(:coverage, to: 88.6, from: 94.6)
 
     assert_campfire_receives(e, [
       "[Code Climate][Example] :umbrella:",
       "Test coverage has declined to 88.6% (-6.0%).",
-      "(https://codeclimate.com/repos/1/feed)"
+      "(https://codeclimate.com/repos/1/feed)",
     ].join(" "))
   end
 
-  def test_quality_improved
+  it "quality improved" do
     e = event(:quality, to: "A", from: "B")
 
     assert_campfire_receives(e, [
       "[Code Climate][Example] :sunny:",
       "User has improved from a B to an A.",
-      "(https://codeclimate.com/repos/1/feed)"
+      "(https://codeclimate.com/repos/1/feed)",
     ].join(" "))
   end
 
-  def test_quality_declined
+  it "quality declined" do
     e = event(:quality, to: "D", from: "C")
 
     assert_campfire_receives(e, [
       "[Code Climate][Example] :umbrella:",
       "User has declined from a C to a D.",
-      "(https://codeclimate.com/repos/1/feed)"
+      "(https://codeclimate.com/repos/1/feed)",
     ].join(" "))
   end
 
-  def test_single_vulnerability
+  it "single vulnerability" do
     e = event(:vulnerability, vulnerabilities: [
-      { "warning_type" => "critical" }
-    ])
+                { "warning_type" => "critical" },
+              ])
 
     assert_campfire_receives(e, [
       "[Code Climate][Example]",
       "New critical issue found.",
-      "Details: https://codeclimate.com/repos/1/feed"
+      "Details: https://codeclimate.com/repos/1/feed",
     ].join(" "))
   end
 
-  def test_single_vulnerability_with_location
+  it "single vulnerability with location" do
     e = event(:vulnerability, vulnerabilities: [{
-      "warning_type" => "critical",
-      "location" => "app/user.rb line 120"
-    }])
+                "warning_type" => "critical",
+                "location" => "app/user.rb line 120",
+              }])
 
     assert_campfire_receives(e, [
       "[Code Climate][Example]",
       "New critical issue found",
       "in app/user.rb line 120.",
-      "Details: https://codeclimate.com/repos/1/feed"
+      "Details: https://codeclimate.com/repos/1/feed",
     ].join(" "))
   end
 
-  def test_multiple_vulnerabilities
+  it "multiple vulnerabilities" do
     e = event(:vulnerability, warning_type: "critical", vulnerabilities: [{
-      "warning_type" => "unused",
-      "location" => "unused"
-    }, {
-      "warning_type" => "unused",
-      "location" => "unused"
-    }])
+                "warning_type" => "unused",
+                "location" => "unused",
+              }, {
+                "warning_type" => "unused",
+                "location" => "unused",
+              }])
 
     assert_campfire_receives(e, [
       "[Code Climate][Example]",
       "2 new critical issues found.",
-      "Details: https://codeclimate.com/repos/1/feed"
+      "Details: https://codeclimate.com/repos/1/feed",
     ].join(" "))
   end
 
-  def test_receive_test
-    @stubs.post request_url do |env|
-      [200, {}, '']
+  it "receive test" do
+    http_stubs.post request_url do |_env|
+      [200, {}, ""]
     end
 
     response = receive_event(name: "test")
 
-    assert_equal "Test message sent", response[:message]
+    expect(response[:message]).to eq("Test message sent")
   end
 
   private
@@ -125,20 +121,20 @@ class TestCampfire < CC::Service::TestCase
   end
 
   def assert_campfire_receives(event_data, expected_body)
-    @stubs.post request_url do |env|
+    http_stubs.post request_url do |env|
       body = JSON.parse(env[:body])
-      assert_equal expected_body, body["message"]["body"]
-      [200, {}, '']
+      expect(body["message"]["body"]).to eq(expected_body)
+      [200, {}, ""]
     end
 
     receive_event(event_data)
   end
 
   def receive_event(event_data = nil)
-    receive(
+    service_receive(
       CC::Service::Campfire,
-      { token: "token", subdomain: subdomain, room_id: room},
-      event_data || event(:quality, to: "D", from: "C")
+      { token: "token", subdomain: subdomain, room_id: room },
+      event_data || event(:quality, to: "D", from: "C"),
     )
   end
 end